Change in vdsm[master]: storage: outOfProcess: remove useless warning

2016-09-16 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: storage: outOfProcess: remove useless warning
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/63702
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I479ab4952d85abcde18f6472b8ca0e019c59bdb8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: outOfProcess: remove useless warning

2016-09-16 Thread danken 
Dan Kenigsberg has submitted this change and it was merged.

Change subject: storage: outOfProcess: remove useless warning
..


storage: outOfProcess: remove useless warning

This usage of warnings module add no value, so we drop it

Change-Id: I479ab4952d85abcde18f6472b8ca0e019c59bdb8
Signed-off-by: Francesco Romani 
Reviewed-on: https://gerrit.ovirt.org/63702
Continuous-Integration: Jenkins CI
Reviewed-by: Nir Soffer 
---
M vdsm/storage/outOfProcess.py
1 file changed, 0 insertions(+), 4 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Francesco Romani: Verified



-- 
To view, visit https://gerrit.ovirt.org/63702
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I479ab4952d85abcde18f6472b8ca0e019c59bdb8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: outOfProcess: remove useless warning

2016-09-13 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: storage: outOfProcess: remove useless warning
..


Patch Set 1: Verified+1

trivial patch, verified running the tests.

-- 
To view, visit https://gerrit.ovirt.org/63702
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I479ab4952d85abcde18f6472b8ca0e019c59bdb8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: outOfProcess: remove useless warning

2016-09-12 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: storage: outOfProcess: remove useless warning
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/63702
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I479ab4952d85abcde18f6472b8ca0e019c59bdb8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: outOfProcess: remove useless warning

2016-09-12 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: storage: outOfProcess: remove useless warning
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63702
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I479ab4952d85abcde18f6472b8ca0e019c59bdb8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: outOfProcess: remove useless warning

2016-09-12 Thread fromani 
Francesco Romani has uploaded a new change for review.

Change subject: storage: outOfProcess: remove useless warning
..

storage: outOfProcess: remove useless warning

This usage of warnings module add no value, so we drop it

Change-Id: I479ab4952d85abcde18f6472b8ca0e019c59bdb8
Signed-off-by: Francesco Romani 
---
M vdsm/storage/outOfProcess.py
1 file changed, 0 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/02/63702/1

diff --git a/vdsm/storage/outOfProcess.py b/vdsm/storage/outOfProcess.py
index c6b2cee..4d431f5 100644
--- a/vdsm/storage/outOfProcess.py
+++ b/vdsm/storage/outOfProcess.py
@@ -28,7 +28,6 @@
 import weakref
 
 from functools import partial
-from warnings import warn
 
 from ioprocess import IOProcess
 
@@ -237,9 +236,6 @@
 except OSError as e:
 if e.errno != errno.ENOTEMPTY:
 raise
-
-warn("Renaming a non-empty directory is not an atomic operation",
- DeprecationWarning)
 
 _IOProcessFileUtils(self._iop).cleanupdir(newpath, False)
 self.mkdir(newpath)


-- 
To view, visit https://gerrit.ovirt.org/63702
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I479ab4952d85abcde18f6472b8ca0e019c59bdb8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org