Giuseppe Vallarelli has posted comments on this change.
Change subject: tests: setupNetworks with invalid params.
..
Patch Set 7:
(1 comment)
File
Giuseppe Vallarelli has posted comments on this change.
Change subject: tests: setupNetworks with invalid params.
..
Patch Set 8: Verified+1
--
To view, visit http://gerrit.ovirt.org/17435
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: setupNetworks with invalid params.
..
Patch Set 8:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4177/ : SUCCESS
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: setupNetworks with invalid params.
..
tests: setupNetworks with invalid params.
Added three tests:
* testIsNicValid
*
Dan Kenigsberg has posted comments on this change.
Change subject: tests: setupNetworks with invalid params.
..
Patch Set 7:
(1 comment)
File
Dan Kenigsberg has posted comments on this change.
Change subject: tests: setupNetworks with invalid params.
..
Patch Set 8: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/17435
To unsubscribe, visit
Giuseppe Vallarelli has posted comments on this change.
Change subject: tests: setupNetworks with invalid params.
..
Patch Set 7:
cherrypicked on top of master
--
To view, visit http://gerrit.ovirt.org/17435
To unsubscribe,
Giuseppe Vallarelli has posted comments on this change.
Change subject: tests: setupNetworks with invalid params.
..
Patch Set 7: Verified+1
I believe we can merge this small patchset :)
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: setupNetworks with invalid params.
..
Patch Set 7:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4168/ : SUCCESS
Dan Kenigsberg has posted comments on this change.
Change subject: tests: setupNetworks with invalid params.
..
Patch Set 7: Code-Review-1
(2 comments)
File
Giuseppe Vallarelli has posted comments on this change.
Change subject: tests: setupNetworks with invalid params.
..
Patch Set 6: Verified+1
Cherrypicked on top of the updated dependency.
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: setupNetworks with invalid params.
..
Patch Set 6:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3845/ : SUCCESS
Antoni Segura Puimedon has posted comments on this change.
Change subject: tests: setupNetworks with invalid params.
..
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/17435
To unsubscribe, visit
Giuseppe Vallarelli has posted comments on this change.
Change subject: tests: setupNetworks with invalid params.
..
Patch Set 5: Verified+1
Updated old commit msg.
--
To view, visit http://gerrit.ovirt.org/17435
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: setupNetworks with invalid params.
..
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3729/ : SUCCESS
Antoni Segura Puimedon has posted comments on this change.
Change subject: tests: setupNetworks with invalid params.
..
Patch Set 3: (1 inline comment)
File
Giuseppe Vallarelli has posted comments on this change.
Change subject: tests: setupNetworks with invalid params.
..
Patch Set 4: Verified+1
Cherrypicked on top of the updated dependency patch.
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: setupNetworks with invalid params.
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3697/ : SUCCESS
Giuseppe Vallarelli has posted comments on this change.
Change subject: tests: setupNetworks with invalid params.
..
Patch Set 1:
This means that I need to rewrite a new patch - redo the work.
--
To view, visit
Antoni Segura Puimedon has posted comments on this change.
Change subject: tests: setupNetworks with invalid params.
..
Patch Set 1: (3 inline comments)
Dropping the two things that are already tested (for good or for a future
Giuseppe Vallarelli has posted comments on this change.
Change subject: tests: setupNetworks with invalid params.
..
Patch Set 1: No score
(4 inline comments)
File
Giuseppe Vallarelli has posted comments on this change.
Change subject: tests: setupNetworks with invalid params.
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/17435
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: setupNetworks with invalid params.
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3679/ : SUCCESS
Giuseppe Vallarelli has posted comments on this change.
Change subject: tests: setupNetworks with invalid params.
..
Patch Set 3: Verified
Cherrypicked on top of the updated patch.
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: setupNetworks with invalid params.
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3687/ : SUCCESS
Antoni Segura Puimedon has posted comments on this change.
Change subject: tests: setupNetworks with invalid params.
..
Patch Set 1: I would prefer that you didn't submit this
I feel like all these 4 tests can be done with
Giuseppe Vallarelli has uploaded a new change for review.
Change subject: tests: setupNetworks with invalid params.
..
tests: setupNetworks with invalid params.
Added four functional tests:
* testSetupNetworksAddBadBondingName
Giuseppe Vallarelli has posted comments on this change.
Change subject: tests: setupNetworks with invalid params.
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/17435
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: setupNetworks with invalid params.
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2733/ : SUCCESS
29 matches
Mail list logo
