From Dan Kenigsberg :
Dan Kenigsberg has submitted this change and it was merged.
Change subject: utils: Wait for terminated process
..
utils: Wait for terminated process
utils.terminating was not waiting
From Dan Kenigsberg :
Dan Kenigsberg has posted comments on this change.
Change subject: utils: Wait for terminated process
..
Patch Set 5: Code-Review+2
Given Yaniv report, I suggest that we introduce a
Yaniv Bronhaim has posted comments on this change.
Change subject: utils: Wait for terminated process
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/65324/5/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 737:
Yaniv Bronhaim has posted comments on this change.
Change subject: utils: Wait for terminated process
..
Patch Set 5:
we don't use terminating context anywhere yet anyway, only in execmd itself
when calling communicate which
Dan Kenigsberg has posted comments on this change.
Change subject: utils: Wait for terminated process
..
Patch Set 5: Code-Review+1
what you say here is very clear; but since https://gerrit.ovirt.org/#/c/51407/
was very
gerrit-hooks has posted comments on this change.
Change subject: utils: Wait for terminated process
..
Patch Set 5:
* Update Tracker::IGNORE, not relevant for branch: master
* Check Bug-Url::IGNORE, not relevant for branch:
Piotr Kliczewski has posted comments on this change.
Change subject: utils: Wait for terminated process
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/65324
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: utils: Wait for terminated process
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Francesco Romani has posted comments on this change.
Change subject: utils: Wait for terminated process
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/65324
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: utils: Wait for terminated process
..
Patch Set 3: Continuous-Integration+1
Verfied on travis:
https://travis-ci.org/nirs/vdsm/builds/166549485
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: utils: Wait for terminated process
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: utils: Wait for terminated process
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Nir Soffer has posted comments on this change.
Change subject: utils: Wait for terminated process
..
Patch Set 1: Verified+1
Verified by the tests.
--
To view, visit https://gerrit.ovirt.org/65324
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: utils: Wait for terminated process
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Nir Soffer has uploaded a new change for review.
Change subject: utils: Wait for terminated process
..
utils: Wait for terminated process
utils.terminating was not waiting for a terminated process, passing the
process to
15 matches
Mail list logo