Dan Kenigsberg has submitted this change and it was merged.
Change subject: vdsm: move balloon logic out of buildConfDevices
..
vdsm: move balloon logic out of buildConfDevices
Encapsulates empty balloon creation logic outside
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: move balloon logic out of buildConfDevices
..
Patch Set 4: Code-Review+2
I join the "I agree with Ayal, but.." sentiment.
--
To view, visit http://gerri
Antoni Segura Puimedon has posted comments on this change.
Change subject: vdsm: move balloon logic out of buildConfDevices
..
Patch Set 4: Code-Review+1
I agree with Michal's last comment. We can take this now, but I really wa
Federico Simoncelli has posted comments on this change.
Change subject: vdsm: move balloon logic out of buildConfDevices
..
Patch Set 4: Code-Review+1
Looks fine. It's ok for me if we'll address the parameters-passing in anothe
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: move balloon logic out of buildConfDevices
..
Patch Set 4:
(1 comment)
File vdsm/vm.py
Line 1936:
Martin Polednik has posted comments on this change.
Change subject: vdsm: move balloon logic out of buildConfDevices
..
Patch Set 4:
(2 comments)
File vdsm/vm.py
Line 1873:
Ayal Baron has posted comments on this change.
Change subject: vdsm: move balloon logic out of buildConfDevices
..
Patch Set 4:
(3 comments)
File vdsm/vm.py
Line 1873:
Martin Polednik has posted comments on this change.
Change subject: vdsm: move balloon logic out of buildConfDevices
..
Patch Set 4: Verified+1
--
To view, visit http://gerrit.ovirt.org/19321
To unsubscribe, visit http://gerri
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: move balloon logic out of buildConfDevices
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4781/ : SUCCESS
http
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: move balloon logic out of buildConfDevices
..
Patch Set 3: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4757/ : SUCCES
Antoni Segura Puimedon has posted comments on this change.
Change subject: vdsm: move balloon logic out of buildConfDevices
..
Patch Set 2:
(1 comment)
File vdsm/vm.py
Line
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: move balloon logic out of buildConfDevices
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4517/ : SUCCESS
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: move balloon logic out of buildConfDevices
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/19321
To unsubscribe, visit http://g
Martin Polednik has posted comments on this change.
Change subject: vdsm: move balloon logic out of buildConfDevices
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/19321
To unsubscribe, visit http://gerri
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: move balloon logic out of buildConfDevices
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4492/ : SUCCESS
Martin Polednik has uploaded a new change for review.
Change subject: vdsm: move balloon logic out of buildConfDevices
..
vdsm: move balloon logic out of buildConfDevices
Encapsulates empty balloon creation logic outside of
buil
16 matches
Mail list logo
