Tomas Golembiovsky has posted comments on this change.
Change subject: v2v: add test for Xen block device
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/63022
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: log: Nicer logging format
..
Patch Set 1:
I for myself support this direction. This format is much much nicer and easier
to work with.
The idea to have a
Tomas Golembiovsky has posted comments on this change.
Change subject: alignmentScan: Use proper environment
..
Patch Set 1:
(1 comment)
Just a typo in commit message. Other than that LGTM.
Petr Horáček has posted comments on this change.
Change subject: net: Remove OVS bond implementation.
..
Patch Set 9: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/63850
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: vm: Remove useless volume size monitoring
..
Patch Set 5: Verified-1
This does not work yet - we must replace the usage of Drive.apparentsize and
Drive.truesize
Nir Soffer has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 13:
(1 comment)
https://gerrit.ovirt.org/#/c/57347/13/lib/vdsm/virtsparsify.py
File
Francesco Romani has posted comments on this change.
Change subject: virt: utils: add is_kvm helper
..
Patch Set 33: Verified+1
trivial patch, covered by tests.
--
To view, visit https://gerrit.ovirt.org/55647
To
Tal Nisan has posted comments on this change.
Change subject: alignmentScan: Use proper environment
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64123
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: alignmentScan: Use proper environment
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/64123/1//COMMIT_MSG
Commit Message:
Line 6:
Line 7:
gerrit-hooks has posted comments on this change.
Change subject: net: Use Linux bonds with OVS networks
..
Patch Set 30:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: net: Remove OVS bond implementation.
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: net: Split OVS setup transaction to adjust for bond setup
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Edward Haas has uploaded a new change for review.
Change subject: net: Relocate sysfs_bond_permission to nettestlib
..
net: Relocate sysfs_bond_permission to nettestlib
CI does not always allow access to sysfs and will fail the
gerrit-hooks has posted comments on this change.
Change subject: net: Relocate sysfs_bond_permission to nettestlib
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Petr Horáček has posted comments on this change.
Change subject: net: Relocate sysfs_bond_permission to nettestlib
..
Patch Set 1: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/64131/1//COMMIT_MSG
Commit Message:
Nir Soffer has posted comments on this change.
Change subject: lib: move exception.py under common
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/63952
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: v2v: add test for Xen block device
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/63022
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: alignmentScan: Use proper environment
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Nir Soffer has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 13:
(1 comment)
https://gerrit.ovirt.org/#/c/57347/13/lib/vdsm/virtsparsify.py
File
Nir Soffer has uploaded a new change for review.
Change subject: alignmentScan: Use proper environment
..
alignmentScan: Use proper environment
In commit f9d12864a404 (v2v: Running virt-v2v with some sane
environment) we leaned
Tomas Golembiovsky has posted comments on this change.
Change subject: vdsm: Rely on system for logrotation
..
Patch Set 3: Code-Review-1
Thanks Dan. Somehow I have missed this change when browsing through related
history.
Nir Soffer has posted comments on this change.
Change subject: vdsm: Rely on system for logrotation
..
Patch Set 3:
Please send another patch documenting why we are not using logrotate in the
standard way, with url to the
Petr Horáček has posted comments on this change.
Change subject: net: edit bond detached from bridge but still attached to a vlan
..
Patch Set 6: Verified+1
The added test fails without ifcfg changes, passes with them.
--
To
gerrit-hooks has posted comments on this change.
Change subject: net: edit bond detached from bridge but still attached to a vlan
..
Patch Set 6:
* #1372798::Update tracker: OK
* Check Bug-Url::OK
* Check Public
Edward Haas has posted comments on this change.
Change subject: net: Remove OVS bond implementation.
..
Patch Set 9: Verified+1
--
To view, visit https://gerrit.ovirt.org/63850
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: vdsm: Do not modify warnings filter in a library
..
Patch Set 2:
Yaniv, you are trying to force your warnings on other developers.
We are trying to help
Nir Soffer has posted comments on this change.
Change subject: log: Nicer logging format
..
Patch Set 1:
Maybe we need to have a library for parsing vdsm logs. We already have this
code in some tools (e.g contrib/db). This
gerrit-hooks has posted comments on this change.
Change subject: **WIP** tool: reconfigure containers networks
..
Patch Set 15:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: tests: containers: add testsuite
..
Patch Set 19:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: network: filter out 'veth' devices
..
Patch Set 16:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Jenkins CI has posted comments on this change.
Change subject: alignmentScan: Use proper environment
..
Patch Set 2: Continuous-Integration+1
Propagate review hook: Continuous Integration value inherited from patch 1
--
To
gerrit-hooks has posted comments on this change.
Change subject: alignmentScan: Use proper environment
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Tomas Golembiovsky has posted comments on this change.
Change subject: alignmentScan: Use proper environment
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64123
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: lib: move the response.py under common
..
Patch Set 3:
Junkins failure is unrelated:
DEBUG package_manager.py:96: ['/usr/bin/yum-deprecated',
Edward Haas has posted comments on this change.
Change subject: net: Relocate sysfs_bond_permission to nettestlib
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/64131/1//COMMIT_MSG
Commit Message:
PS1, Line 14:
Freddy Rolland has posted comments on this change.
Change subject: vm: Remove unneeded fallback to blockRebase
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64111
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: vdsm: Do not modify warnings filter in a library
..
Patch Set 2:
I'm ok with this approach, better than my https://gerrit.ovirt.org/#/c/64117/
--
To view,
Francesco Romani has abandoned this change.
Change subject: vdscli: do not use the warnings module
..
Abandoned
replaced by https://gerrit.ovirt.org/#/c/64100/2
--
To view, visit https://gerrit.ovirt.org/64117
To
gerrit-hooks has posted comments on this change.
Change subject: vdscli: do not use the warnings module
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/64117
To
Francesco Romani has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 13: Code-Review+1
(1 comment)
Just one possible caveat - please check inline comments.
Looks good to
Francesco Romani has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 13: Code-Review-1
since there are pending comments, -1 for visibility is actually better :\
--
To
gerrit-hooks has posted comments on this change.
Change subject: supervdsm: expose systemd utilities
..
Patch Set 29:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: cmdutils: enhance systemd_run
..
Patch Set 29:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: core: containers: add the container support module
..
Patch Set 31:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Francesco Romani has posted comments on this change.
Change subject: cmdutils: enhance systemd_run
..
Patch Set 29: Verified+1
verified running patched Vdsm, and using the tests.
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: tests: containers: add testsuite
..
Patch Set 18:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: network: supervdsm: configure container networks
..
Patch Set 42:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: vdsm: virt: add optional container support
..
Patch Set 49:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: **WIP** tool: reconfigure containers networks
..
Patch Set 14:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: virt: utils: add is_kvm helper
..
Patch Set 33:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: network: filter out 'veth' devices
..
Patch Set 15:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: vmxml: export container metadata
..
Patch Set 21:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Francesco Romani has posted comments on this change.
Change subject: tests: containers: add testsuite
..
Patch Set 18:
code coverage is pretty good:
00:08:20.964
Francesco Romani has posted comments on this change.
Change subject: tests: containers: add testsuite
..
Patch Set 18: Verified+1
this patch adds only tests, so as long as juenkins is happy, so we are.
--
To view, visit
Shmuel Leib Melamud has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 13:
(1 comment)
https://gerrit.ovirt.org/#/c/57347/13/vdsm/storage/sdm/api/sparsify_volume.py
Francesco Romani has posted comments on this change.
Change subject: log: Nicer logging format
..
Patch Set 1: Code-Review+1
I like this. We tried to change our log format in the past, without much luck.
Let's try again.
Francesco Romani has posted comments on this change.
Change subject: virt: Introduce the thinp module
..
Patch Set 1: Code-Review+1
I like this direction, but I want too see how this evolves. Provisional +1
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: logging: add and use new devel logger
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/62209/5/lib/vdsm/vdscli.py
File lib/vdsm/vdscli.py:
Line
gerrit-hooks has posted comments on this change.
Change subject: Live Merge: Refresh base volume before live merge
..
Patch Set 3:
* #1375076::Update tracker: OK
* Set MODIFIED::bug 1375076#1375076OK
--
To view,
Yaniv Kaul has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 13:
And the initial discussion -
https://www.redhat.com/archives/libguestfs/2015-November/msg00031.html
Francesco Romani has posted comments on this change.
Change subject: vm: Remove unneeded fallback to blockRebase
..
Patch Set 2: Code-Review+2
looks good to me.
--
To view, visit https://gerrit.ovirt.org/64111
To
Francesco Romani has posted comments on this change.
Change subject: Live Merge: Refresh base volume before live merge
..
Patch Set 2: Code-Review+1
Looks ok, let me try to make jenkins happy.
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: Live Merge: Refresh base volume before live merge
..
Patch Set 2:
Rerun-Hooks: all
--
To view, visit https://gerrit.ovirt.org/63634
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: Live Merge: Refresh base volume before live merge
..
Patch Set 2: -Verified
* #1375076::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1375076::OK,
Francesco Romani has posted comments on this change.
Change subject: Live Merge: Refresh base volume before live merge
..
Patch Set 2: Code-Review+2 Continuous-Integration+1
This failure is irrilevant:
00:06:31.819
Francesco Romani has submitted this change and it was merged.
Change subject: Live Merge: Refresh base volume before live merge
..
Live Merge: Refresh base volume before live merge
When live merging raw base volume, engine
Martin Sivák has posted comments on this change.
Change subject: logging: add and use new devel logger
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/62209/5/lib/vdsm/vdscli.py
File lib/vdsm/vdscli.py:
PS5, Line
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: Rely on system for logrotation
..
Patch Set 3:
I am not 100% that this still applies, but please discuss
Yaniv Kaul has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 13:
I'm quite sure this is not the case. If it is only sparsifying the top layer,
it is not very efficient
Yaniv Bronhaim has posted comments on this change.
Change subject: build: Disable tests during build
..
Patch Set 3:
most developers run "make rpm" directly instead of "make check", as this is
what we advice to do in [1].
Yaniv Bronhaim has posted comments on this change.
Change subject: vdsm: Do not modify warnings filter in a library
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/64100/2/lib/vdsm/vdscli.py
File lib/vdsm/vdscli.py:
Petr Horáček has posted comments on this change.
Change subject: net: edit bond detached from bridge but still attached to a vlan
..
Patch Set 8: Verified+1
Passed network/*_test.py and functional/networkTests.py OK.
Without
Petr Horáček has posted comments on this change.
Change subject: net: Remove OVS bond implementation.
..
Patch Set 8: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/63850
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: mount: Wait for systemd temporary mount unit
..
Patch Set 7: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56544
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: vm: Remove useless volume size monitoring
..
Patch Set 5: Code-Review+1
Not 100% sure we can merge this, but I'd love to have this patch in.
--
To view,
Petr Horáček has posted comments on this change.
Change subject: net: remove default route before adding a new one
..
Patch Set 4:
With this path it is possible to overwrite existing default route.
network/*_test.py passed
Petr Horáček has posted comments on this change.
Change subject: net: remove default route before adding a new one
..
Patch Set 4: -Code-Review Verified+1
--
To view, visit https://gerrit.ovirt.org/63220
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: vdsm: Do not modify warnings filter in a library
..
Patch Set 2:
I wonder if we don't want both the warning and a log print
--
To view, visit
Petr Horáček has posted comments on this change.
Change subject: net: remove default route before adding a new one
..
Patch Set 4: Code-Review+1
With this path it is possible to overwrite existing default route.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: mount: Wait for systemd temporary mount unit
..
mount: Wait for systemd temporary mount unit
Systemd is monitoring mountpoints created during runtime
gerrit-hooks has posted comments on this change.
Change subject: mount: Wait for systemd temporary mount unit
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
gerrit-hooks has posted comments on this change.
Change subject: net: Split OVS setup transaction to adjust for bond setup
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
gerrit-hooks has posted comments on this change.
Change subject: net: Use Linux bonds with OVS networks
..
Patch Set 31:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: net: Relocate sysfs_bond_permission to nettestlib
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: draft: Hook nic_libvirt_migration_destination, proposal 2
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: lib: api.py: preserve signature in decorator
..
Patch Set 13: Verified+1
schemaValidation passes with this patch.
--
To view, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: Remove python-argparse requirement
..
Patch Set 1:
cstratak reached me in irc as python maintainer and asked to remove this
requirement from our spec now when
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Remove python-argparse requirement
..
Remove python-argparse requirement
This package has been obsoleted in Fedora because it got in to stdlib.
Change-Id:
gerrit-hooks has posted comments on this change.
Change subject: Remove python-argparse requirement
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Francesco Romani has posted comments on this change.
Change subject: lib: response: helper to detect valid responses
..
Patch Set 11:
(1 comment)
https://gerrit.ovirt.org/#/c/63760/11/lib/vdsm/common/response.py
File
Marcin Mirecki has abandoned this change.
Change subject: draft: Hook nic_libvirt_migration_destination, proposal 2
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/63686
To unsubscribe, visit
Marcin Mirecki has abandoned this change.
Change subject: draft: Hook before_nic_libvirt_migration_destination, proposal 1
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/63684
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: draft: Hook before_nic_libvirt_migration_destination, proposal 1
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: lib: api: allow to return prebuilt responses
..
Patch Set 12:
(1 comment)
https://gerrit.ovirt.org/#/c/61474/12/lib/vdsm/common/api.py
File
Simone Tiraboschi has posted comments on this change.
Change subject: vdsm: Do not modify warnings filter in a library
..
Patch Set 2: Code-Review+1
+1 for me, I agree to take the python way for it.
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: virt: Start all VM related stuff after switching to post-copy
migration
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug
gerrit-hooks has posted comments on this change.
Change subject: virt: Typo fix in Vm._acquireCpuLockWithTimeout error message
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Petr Horáček has posted comments on this change.
Change subject: net: Relocate sysfs_bond_permission to nettestlib
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64131
To unsubscribe, visit
Petr Horáček has posted comments on this change.
Change subject: net: Split OVS setup transaction to adjust for bond setup
..
Patch Set 3: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/64118/3//COMMIT_MSG
Commit
Francesco Romani has posted comments on this change.
Change subject: tests: containers: add testsuite
..
Patch Set 19: Verified+1
--
To view, visit https://gerrit.ovirt.org/60678
To unsubscribe, visit
1 - 100 of 182 matches
Mail list logo
