Change in vdsm[master]: tests: Remove cPopenTests.py

2016-10-12 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: tests: Remove cPopenTests.py .. tests: Remove cPopenTests.py We kept an old and broken version of cpopen tests in vdsm when cpopen was separated into a standalone

Change in vdsm[master]: tests: Remove cPopenTests.py

2016-10-12 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Remove cPopenTests.py .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: build: Ensure nose 1.3.7 is used for tests

2016-10-12 Thread automation
gerrit-hooks has posted comments on this change. Change subject: build: Ensure nose 1.3.7 is used for tests .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: build: Ensure nose 1.3.7 is used for tests

2016-10-12 Thread automation
gerrit-hooks has posted comments on this change. Change subject: build: Ensure nose 1.3.7 is used for tests .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: build: Ensure nose 1.3.7 is used for tests

2016-10-12 Thread automation
gerrit-hooks has posted comments on this change. Change subject: build: Ensure nose 1.3.7 is used for tests .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: build: Ensure nose 1.3.7 is used for tests

2016-10-12 Thread automation
gerrit-hooks has posted comments on this change. Change subject: build: Ensure nose 1.3.7 is used for tests .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: build: Ensure nose 1.3.7 is used for tests

2016-10-12 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: build: Ensure nose 1.3.7 is used for tests .. Patch Set 6: Verified+1 Verified locally and on travis: https://travis-ci.org/nirs/vdsm/builds/167181752 -- To

Change in vdsm[master]: tests: Remove cPopenTests.py

2016-10-12 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: Remove cPopenTests.py .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/65407 To unsubscribe, visit https://gerrit.ovirt.org/settings

Change in vdsm[master]: jobs: Fix abort semantics

2016-10-12 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: jobs: Fix abort semantics .. Patch Set 5: Code-Review+1 (1 comment) Francesco, would take another look? https://gerrit.ovirt.org/#/c/65102/5/lib/vdsm/jobs.py

Change in vdsm[master]: qemuimg: Explicit run semantics for QemuImgOperation

2016-10-12 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: qemuimg: Explicit run semantics for QemuImgOperation .. Patch Set 5: Code-Review-1 (10 comments) https://gerrit.ovirt.org/#/c/65148/5/lib/vdsm/qemuimg.py File

Change in vdsm[ovirt-4.0]: Fix return value names for VM.ioTune calls

2016-10-12 Thread fromani
Francesco Romani has posted comments on this change. Change subject: Fix return value names for VM.ioTune calls .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/63478 To unsubscribe, visit

Change in vdsm[ovirt-4.0]: Add all MOM calls to jsonrpc client

2016-10-12 Thread fromani
Francesco Romani has posted comments on this change. Change subject: Add all MOM calls to jsonrpc client .. Patch Set 3: please backport again to the ovirt-4.0.5 branch if you want this in 4.0.5 - otherwise will be in 4.0.6

Change in vdsm[ovirt-4.0]: Add all MOM calls to jsonrpc client

2016-10-12 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Add all MOM calls to jsonrpc client .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::bug 1373832#1373832::SKIPPED, The branch

Change in vdsm[ovirt-4.0]: Fix return value names for VM.ioTune calls

2016-10-12 Thread fromani
Francesco Romani has submitted this change and it was merged. Change subject: Fix return value names for VM.ioTune calls .. Fix return value names for VM.ioTune calls Bug-Url:

Change in vdsm[ovirt-4.0]: Add all MOM calls to jsonrpc client

2016-10-12 Thread fromani
Francesco Romani has posted comments on this change. Change subject: Add all MOM calls to jsonrpc client .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/63479 To unsubscribe, visit

Change in vdsm[ovirt-4.0]: Fix return value names for VM.ioTune calls

2016-10-12 Thread fromani
Francesco Romani has posted comments on this change. Change subject: Fix return value names for VM.ioTune calls .. Patch Set 3: please backport again to the ovirt-4.0.5 branch if you want this in 4.0.5 - otherwise will be in

Change in vdsm[ovirt-4.0]: Add all MOM calls to jsonrpc client

2016-10-12 Thread fromani
Francesco Romani has submitted this change and it was merged. Change subject: Add all MOM calls to jsonrpc client .. Add all MOM calls to jsonrpc client Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1373832 Change-Id:

Change in vdsm[ovirt-4.0]: Fix return value names for VM.ioTune calls

2016-10-12 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Fix return value names for VM.ioTune calls .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::bug 1373832#1373832IGNORE, not all

Change in vdsm[master]: virt: Try to detect non guest iniated shutdowns

2016-10-12 Thread automation
gerrit-hooks has posted comments on this change. Change subject: virt: Try to detect non guest iniated shutdowns .. Patch Set 7: * #1341106::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1341106::OK, public bug *

Change in vdsm[ovirt-4.0.5]: Fix return value names for VM.ioTune calls

2016-10-12 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Fix return value names for VM.ioTune calls .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::bug 1373832#1373832OK -- To view,

Change in vdsm[ovirt-4.0.5]: Fix return value names for VM.ioTune calls

2016-10-12 Thread fromani
Francesco Romani has posted comments on this change. Change subject: Fix return value names for VM.ioTune calls .. Patch Set 1: Run 'make check' manually. Unrelated, known test failures. -- To view, visit

Change in vdsm[master]: osinfo: un-nest kernel version gathering function

2016-10-12 Thread mpolednik
Martin Polednik has posted comments on this change. Change subject: osinfo: un-nest kernel version gathering function .. Patch Set 1: Verified+1 network test failures... -- To view, visit https://gerrit.ovirt.org/65379 To

Change in vdsm[ovirt-4.0.5]: Add all MOM calls to jsonrpc client

2016-10-12 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Add all MOM calls to jsonrpc client .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::bug 1373832#1373832OK, already on MODIFIED

Change in vdsm[ovirt-4.0.5]: Add all MOM calls to jsonrpc client

2016-10-12 Thread fromani
Francesco Romani has posted comments on this change. Change subject: Add all MOM calls to jsonrpc client .. Patch Set 1: run 'make check' locally and manually with no issues. -- To view, visit https://gerrit.ovirt.org/65378

Change in vdsm[ovirt-4.0.5]: Add all MOM calls to jsonrpc client

2016-10-12 Thread fromani
Francesco Romani has submitted this change and it was merged. Change subject: Add all MOM calls to jsonrpc client .. Add all MOM calls to jsonrpc client Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1373832 Change-Id:

Change in vdsm[ovirt-4.0.5]: Add all MOM calls to jsonrpc client

2016-10-12 Thread fromani
Francesco Romani has posted comments on this change. Change subject: Add all MOM calls to jsonrpc client .. Patch Set 1: Continuous-Integration+1 -- To view, visit https://gerrit.ovirt.org/65378 To unsubscribe, visit

Change in vdsm[master]: osinfo: drop package buildtime

2016-10-12 Thread mpolednik
Martin Polednik has posted comments on this change. Change subject: osinfo: drop package buildtime .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/65059 To unsubscribe, visit

Change in vdsm[ovirt-4.0]: Fix API schema to align with runtime schema

2016-10-12 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Fix API schema to align with runtime schema .. Patch Set 2: * #1348255::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1348255::OK, public bug *

Change in vdsm[master]: vmxml: export container metadata

2016-10-12 Thread mpolednik
Martin Polednik has posted comments on this change. Change subject: vmxml: export container metadata .. Patch Set 23: Code-Review-1 (6 comments) https://gerrit.ovirt.org/#/c/60481/23/vdsm/virt/vmxml.py File

Change in vdsm[master]: config: add tunables for container support

2016-10-12 Thread mpolednik
Martin Polednik has posted comments on this change. Change subject: config: add tunables for container support .. Patch Set 2: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/64243/2//COMMIT_MSG Commit Message: Line

Change in vdsm[ovirt-4.0.5]: Fix return value names for VM.ioTune calls

2016-10-12 Thread fromani
Francesco Romani has posted comments on this change. Change subject: Fix return value names for VM.ioTune calls .. Patch Set 1: Continuous-Integration+1 -- To view, visit https://gerrit.ovirt.org/65377 To unsubscribe, visit

Change in vdsm[ovirt-4.0.5]: Fix return value names for VM.ioTune calls

2016-10-12 Thread fromani
Francesco Romani has submitted this change and it was merged. Change subject: Fix return value names for VM.ioTune calls .. Fix return value names for VM.ioTune calls Bug-Url:

Change in vdsm[master]: vdsm: virt: add optional container support

2016-10-12 Thread mpolednik
Martin Polednik has posted comments on this change. Change subject: vdsm: virt: add optional container support .. Patch Set 51: Code-Review-1 (9 comments) https://gerrit.ovirt.org/#/c/53820/51/lib/vdsm/containersconnection.py

Change in vdsm[master]: osinfo: drop package buildtime

2016-10-12 Thread michal . skrivanek
Michal Skrivanek has posted comments on this change. Change subject: osinfo: drop package buildtime .. Patch Set 3: Code-Review+1 I casually checked engine 3.0 and it's not used there either -- To view, visit

Change in vdsm[master]: core: containers: add the container support module

2016-10-12 Thread mpolednik
Martin Polednik has posted comments on this change. Change subject: core: containers: add the container support module .. Patch Set 33: (11 comments) https://gerrit.ovirt.org/#/c/59824/33/lib/vdsm/virt/containers/command.py

Change in vdsm[master]: supervdsm: expose systemd utilities

2016-10-12 Thread mpolednik
Martin Polednik has posted comments on this change. Change subject: supervdsm: expose systemd utilities .. Patch Set 31: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56491 To unsubscribe, visit

Change in vdsm[ovirt-4.0.5]: Add all MOM calls to jsonrpc client

2016-10-12 Thread fromani
Francesco Romani has posted comments on this change. Change subject: Add all MOM calls to jsonrpc client .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/65378 To unsubscribe, visit

Change in vdsm[ovirt-4.0.5]: Fix return value names for VM.ioTune calls

2016-10-12 Thread fromani
Francesco Romani has posted comments on this change. Change subject: Fix return value names for VM.ioTune calls .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/65377 To unsubscribe, visit

Change in vdsm[master]: network: supervdsm: configure container networks

2016-10-12 Thread mpolednik
Martin Polednik has posted comments on this change. Change subject: network: supervdsm: configure container networks .. Patch Set 44: The code is somewhat fine considering the TODOs, but question remains: if I install

Change in vdsm[master]: static: move man under static

2016-10-12 Thread fromani
Francesco Romani has posted comments on this change. Change subject: static: move man under static .. Patch Set 5: Code-Review+1 (3 comments) https://gerrit.ovirt.org/#/c/62549/5/static/Makefile.am File static/Makefile.am:

Change in vdsm[master]: osinfo: drop package buildtime

2016-10-12 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: osinfo: drop package buildtime .. Patch Set 3: Updating yml spec file should be enough. Before we will merge I will make sure that it was really not used on

Change in vdsm[master]: virt: Make DomainDescriptor use XML helpers

2016-10-12 Thread mzamazal
Milan Zamazal has uploaded a new change for review. Change subject: virt: Make DomainDescriptor use XML helpers .. virt: Make DomainDescriptor use XML helpers We are going to stop using xml.dom.minidom and to use xml.etree

Change in vdsm[master]: static: move vdsm bonding defaults under static

2016-10-12 Thread fromani
Francesco Romani has posted comments on this change. Change subject: static: move vdsm bonding defaults under static .. Patch Set 6: Code-Review+1 (1 comment) Moving to static/ -> +2 hardcoding paths? not really sure. So just

Change in vdsm[master]: osinfo: drop package buildtime

2016-10-12 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: osinfo: drop package buildtime .. Patch Set 3: Code-Review-1 please drop buildtime from lib/api/vdsm-api.yml as well. (ask piotr how to do that properly) --

Change in vdsm[master]: py3: make gluster_cli_tests pass

2016-10-12 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: py3: make gluster_cli_tests pass .. Patch Set 4: Code-Review+1 (3 comments) Minor date in copyrights update but the patch looks good.

Change in vdsm[master]: [WIP] use libvirt domain xml prepared in advance

2016-10-12 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: [WIP] use libvirt domain xml prepared in advance .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/65182/2/vdsm/virt/vmxml.py File vdsm/virt/vmxml.py:

Change in vdsm[master]: osinfo: un-nest kernel version gathering function

2016-10-12 Thread fromani
Francesco Romani has posted comments on this change. Change subject: osinfo: un-nest kernel version gathering function .. Patch Set 1: Code-Review+2 (2 comments) worth switching now to logging.exception()? no big deal, your

Change in vdsm[master]: virt: Make DomainDescriptor use XML helpers

2016-10-12 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: virt: Make DomainDescriptor use XML helpers .. Patch Set 9: (10 comments) I tried to address all the suggestions for improvements, so hopefully we can move

Change in vdsm[master]: osinfo: drop package buildtime

2016-10-12 Thread fromani
Francesco Romani has posted comments on this change. Change subject: osinfo: drop package buildtime .. Patch Set 3: Code-Review+2 farewell to this unused bit. -- To view, visit https://gerrit.ovirt.org/65059 To unsubscribe,

Change in vdsm[master]: osinfo: drop package buildtime

2016-10-12 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: osinfo: drop package buildtime .. Patch Set 3: I checked and it was not used on master, 3.6 and 4.0 engine. What you need to do is to remove following

Change in vdsm[ovirt-4.0]: Fix API schema to align with runtime schema

2016-10-12 Thread akrejcir
Andrej Krejcir has posted comments on this change. Change subject: Fix API schema to align with runtime schema .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/65288 To unsubscribe, visit

Change in vdsm[master]: v2v: support for block devices

2016-10-12 Thread Tomas Golembiovsky
Tomas Golembiovsky has posted comments on this change. Change subject: v2v: support for block devices .. Patch Set 4: (1 comment) I investigated this a little and we can get the device size with libvirt call

Change in vdsm[ovirt-4.0.5]: Add all MOM calls to jsonrpc client

2016-10-12 Thread akrejcir
Hello Piotr Kliczewski, Francesco Romani, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/65378 to review the following change. Change subject: Add all MOM calls to jsonrpc client .. Add all MOM

Change in vdsm[ovirt-4.0.5]: Fix return value names for VM.ioTune calls

2016-10-12 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Fix return value names for VM.ioTune calls .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::OK * Check Public Bug::#1373832::OK,

Change in vdsm[ovirt-4.0.5]: Add all MOM calls to jsonrpc client

2016-10-12 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Add all MOM calls to jsonrpc client .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::OK * Check Public Bug::#1373832::OK, public bug *

Change in vdsm[ovirt-4.0.5]: Fix return value names for VM.ioTune calls

2016-10-12 Thread akrejcir
Hello Piotr Kliczewski, Francesco Romani, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/65377 to review the following change. Change subject: Fix return value names for VM.ioTune calls .. Fix

Change in vdsm[ovirt-4.0.5]: Fix return value names for VM.ioTune calls

2016-10-12 Thread akrejcir
Andrej Krejcir has posted comments on this change. Change subject: Fix return value names for VM.ioTune calls .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/65377 To unsubscribe, visit

Change in vdsm[ovirt-4.0.5]: Add all MOM calls to jsonrpc client

2016-10-12 Thread akrejcir
Andrej Krejcir has posted comments on this change. Change subject: Add all MOM calls to jsonrpc client .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/65378 To unsubscribe, visit

Change in vdsm[master]: osinfo: un-nest kernel version gathering function

2016-10-12 Thread mpolednik
Martin Polednik has uploaded a new change for review. Change subject: osinfo: un-nest kernel version gathering function .. osinfo: un-nest kernel version gathering function Previous function, kernelDict, had unclear naming and

Change in vdsm[master]: osinfo: un-nest kernel version gathering function

2016-10-12 Thread automation
gerrit-hooks has posted comments on this change. Change subject: osinfo: un-nest kernel version gathering function .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: osinfo: drop package buildtime

2016-10-12 Thread automation
gerrit-hooks has posted comments on this change. Change subject: osinfo: drop package buildtime .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: static: move man under static

2016-10-12 Thread automation
gerrit-hooks has posted comments on this change. Change subject: static: move man under static .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: static: move vdsm bonding defaults under static

2016-10-12 Thread automation
gerrit-hooks has posted comments on this change. Change subject: static: move vdsm bonding defaults under static .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: automation: Create coverage report sooner

2016-10-12 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: automation: Create coverage report sooner .. automation: Create coverage report sooner For some reason a build artifacts step was inserted before creating the

Change in vdsm[master]: build: Run the tests with tox

2016-10-12 Thread automation
gerrit-hooks has posted comments on this change. Change subject: build: Run the tests with tox .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: tests: Add tests for waiting on a zombie process

2016-10-12 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: Add tests for waiting on a zombie process .. Patch Set 5: Verified+1 This version simplifies the helpers for detecting a zombie. -- To view, visit

Change in vdsm[master]: tests: Wait for child process in tearDown

2016-10-12 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Wait for child process in tearDown .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: utils: Raise detectable error if termination fail

2016-10-12 Thread automation
gerrit-hooks has posted comments on this change. Change subject: utils: Raise detectable error if termination fail .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: utils: Add missing Popen methods

2016-10-12 Thread automation
gerrit-hooks has posted comments on this change. Change subject: utils: Add missing Popen methods .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: storage: Fix abort race in SDM.copy_data

2016-10-12 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: storage: Fix abort race in SDM.copy_data .. Patch Set 5: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/65150/5/tests/storage_sdm_copy_data_test.py File

Change in vdsm[master]: pep8: Fix long line in vdsm sos plugin

2016-10-12 Thread automation
gerrit-hooks has posted comments on this change. Change subject: pep8: Fix long line in vdsm sos plugin .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: build: Run the tests with tox

2016-10-12 Thread automation
gerrit-hooks has posted comments on this change. Change subject: build: Run the tests with tox .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: automation: Create coverage report sooner

2016-10-12 Thread automation
gerrit-hooks has posted comments on this change. Change subject: automation: Create coverage report sooner .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: build: Replace pep8 and pyflakes with flake8

2016-10-12 Thread automation
gerrit-hooks has posted comments on this change. Change subject: build: Replace pep8 and pyflakes with flake8 .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: tests: Remove cPopenTests.py

2016-10-12 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Remove cPopenTests.py .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: build: Run the tests with tox

2016-10-12 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: build: Run the tests with tox .. Patch Set 7: Verified+1 -- To view, visit https://gerrit.ovirt.org/65404 To unsubscribe, visit https://gerrit.ovirt.org/settings

Change in vdsm[master]: build: Run the tests with tox

2016-10-12 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: build: Run the tests with tox .. Patch Set 8: Verified+1 -- To view, visit https://gerrit.ovirt.org/65404 To unsubscribe, visit https://gerrit.ovirt.org/settings

Change in vdsm[master]: tests: Add test for terminating a terminated process

2016-10-12 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Add test for terminating a terminated process .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: tests: Add tests for waiting on a zombie process

2016-10-12 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Add tests for waiting on a zombie process .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: tests: Add tests for poll and wait failures

2016-10-12 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Add tests for poll and wait failures .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: automation: Create coverage report sooner

2016-10-12 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: automation: Create coverage report sooner .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/65414 To unsubscribe, visit

Change in vdsm[master]: protocoldetector: Fix random double close

2016-10-12 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: protocoldetector: Fix random double close .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/65187/1/lib/vdsm/protocoldetector.py File

Change in vdsm[master]: tests: Add test for terminating a terminated process

2016-10-12 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Add test for terminating a terminated process .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: tests: Use Popen.poll() for running state

2016-10-12 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Use Popen.poll() for running state .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: tests: Add tests for poll and wait failures

2016-10-12 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Add tests for poll and wait failures .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: tests: Refine TerminationTests names

2016-10-12 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Refine TerminationTests names .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: tests: Add tests for waiting on a zombie process

2016-10-12 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Add tests for waiting on a zombie process .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: utils: Wait for terminated process

2016-10-12 Thread automation
gerrit-hooks has posted comments on this change. Change subject: utils: Wait for terminated process .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: tests: Add tests for waiting on a zombie process

2016-10-12 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: Add tests for waiting on a zombie process .. Patch Set 6: This version removes the now unneeded re module. -- To view, visit

Change in vdsm[master]: tests: Add tests for waiting on a zombie process

2016-10-12 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: Add tests for waiting on a zombie process .. Patch Set 6: Verified+1 -- To view, visit https://gerrit.ovirt.org/65327 To unsubscribe, visit

Change in vdsm[master]: WIP: docs: add tutorial

2016-10-12 Thread fromani
Francesco Romani has uploaded a new change for review. Change subject: WIP: docs: add tutorial .. WIP: docs: add tutorial Probably not worth merging Change-Id: I3a9e947c30f2978fd9670fd64d99bf380181aa9c Signed-off-by: Francesco

Change in vdsm[master]: supervdsm: expose systemd utilities

2016-10-12 Thread automation
gerrit-hooks has posted comments on this change. Change subject: supervdsm: expose systemd utilities .. Patch Set 32: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: vmxml: export container metadata

2016-10-12 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vmxml: export container metadata .. Patch Set 24: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: network: filter out 'veth' devices

2016-10-12 Thread automation
gerrit-hooks has posted comments on this change. Change subject: network: filter out 'veth' devices .. Patch Set 19: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: pep8: Fix long line in sos plugin

2016-10-12 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: pep8: Fix long line in sos plugin .. pep8: Fix long line in sos plugin Change-Id: I81c2f558f7e34505b9873a8b379f88339859f589 Signed-off-by: Nir Soffer

Change in vdsm[master]: build: Replace pep8 and pyflakes with flake8

2016-10-12 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: build: Replace pep8 and pyflakes with flake8 .. build: Replace pep8 and pyflakes with flake8 flake8 is an extensible and configurable tool combining pep8,

Change in vdsm[master]: pep8: Fix long line in sos plugin

2016-10-12 Thread automation
gerrit-hooks has posted comments on this change. Change subject: pep8: Fix long line in sos plugin .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: build: Replace pep8 and pyflakes with flake8

2016-10-12 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: build: Replace pep8 and pyflakes with flake8 .. Patch Set 1: Verified+1 Tested locally. -- To view, visit https://gerrit.ovirt.org/65403 To unsubscribe, visit

Change in vdsm[master]: py3: make gluster_cli_tests pass

2016-10-12 Thread automation
gerrit-hooks has posted comments on this change. Change subject: py3: make gluster_cli_tests pass .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: build: Ensure nose 1.3.7 is used for tests

2016-10-12 Thread Jenkins CI
Jenkins CI has posted comments on this change. Change subject: build: Ensure nose 1.3.7 is used for tests .. Patch Set 2: Continuous-Integration-1 Propagate review hook: Continuous Integration value inherited from patch 1 --

  1   2   >