Change in vdsm[master]: config: add tunables for container support

2016-10-13 Thread mpolednik
Martin Polednik has posted comments on this change. Change subject: config: add tunables for container support .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/64243 To unsubscribe, visit

Change in vdsm[master]: automation: Create coverage report sooner

2016-10-13 Thread fromani
Francesco Romani has posted comments on this change. Change subject: automation: Create coverage report sooner .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65414 To unsubscribe, visit

Change in vdsm[master]: build: Replace pep8 and pyflakes with flake8

2016-10-13 Thread fromani
Francesco Romani has posted comments on this change. Change subject: build: Replace pep8 and pyflakes with flake8 .. Patch Set 2: Code-Review+1 good idea, I like this. -- To view, visit https://gerrit.ovirt.org/65403 To

Change in vdsm[master]: tests: Remove cPopenTests.py

2016-10-13 Thread fromani
Francesco Romani has posted comments on this change. Change subject: tests: Remove cPopenTests.py .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65407 To unsubscribe, visit

Change in vdsm[master]: vdsm: virt: add optional container support

2016-10-13 Thread mpolednik
Martin Polednik has posted comments on this change. Change subject: vdsm: virt: add optional container support .. Patch Set 51: (1 comment) https://gerrit.ovirt.org/#/c/53820/51/lib/vdsm/containerslib.py File

Change in vdsm[master]: tests: Refine TerminationTests names

2016-10-13 Thread fromani
Francesco Romani has posted comments on this change. Change subject: tests: Refine TerminationTests names .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65326 To unsubscribe, visit

Change in vdsm[master]: utils: Raise detectable error if termination fail

2016-10-13 Thread fromani
Francesco Romani has posted comments on this change. Change subject: utils: Raise detectable error if termination fail .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65325 To unsubscribe, visit

Change in vdsm[master]: virt: Try to detect non guest iniated shutdowns

2016-10-13 Thread vfeenstr
Vinzenz Feenstra has posted comments on this change. Change subject: virt: Try to detect non guest iniated shutdowns .. Patch Set 7: Verified+1 -- To view, visit https://gerrit.ovirt.org/64991 To unsubscribe, visit

Change in vdsm[master]: vdsm: virt: add optional container support

2016-10-13 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vdsm: virt: add optional container support .. Patch Set 51: (1 comment) https://gerrit.ovirt.org/#/c/53820/51/lib/vdsm/containerslib.py File

Change in vdsm[master]: virt: Try to detect non guest iniated shutdowns

2016-10-13 Thread vfeenstr
Vinzenz Feenstra has posted comments on this change. Change subject: virt: Try to detect non guest iniated shutdowns .. Patch Set 7: Verification: EL7 guest with guest agent supporting the messages: When VM gets killed on

Change in vdsm[master]: build: Run the tests with tox

2016-10-13 Thread fromani
Francesco Romani has posted comments on this change. Change subject: build: Run the tests with tox .. Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65404 To unsubscribe, visit

Change in vdsm[master]: qemuimg: Expose API for qemuimg map

2016-10-13 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: qemuimg: Expose API for qemuimg map .. Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/65112 To unsubscribe, visit

Change in vdsm[master]: qemuimg: Expose API for qemuimg map

2016-10-13 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: qemuimg: Expose API for qemuimg map .. Patch Set 6: Verified+1 Tests pass, so this must verified. -- To view, visit https://gerrit.ovirt.org/65112 To

Change in vdsm[master]: qemuimg: Expose API for qemuimg map

2016-10-13 Thread nsoffer
Nir Soffer has submitted this change and it was merged. Change subject: qemuimg: Expose API for qemuimg map .. qemuimg: Expose API for qemuimg map Change-Id: I54d6c936239d3dcc7a3d236dbaab0a93501ada8c Signed-off-by: Nir Soffer

Change in vdsm[master]: qemuimg: Expose API for qemuimg map

2016-10-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: qemuimg: Expose API for qemuimg map .. Patch Set 7: * Update Tracker::IGNORE, no bug url/s found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit

Change in vdsm[master]: tests: Remove cPopenTests.py

2016-10-13 Thread igoihman
Irit Goihman has posted comments on this change. Change subject: tests: Remove cPopenTests.py .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65407 To unsubscribe, visit

Change in vdsm[master]: build: Run the tests with tox

2016-10-13 Thread igoihman
Irit Goihman has posted comments on this change. Change subject: build: Run the tests with tox .. Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65404 To unsubscribe, visit

Change in vdsm[master]: virt: Make DomainDescriptor use XML helpers

2016-10-13 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: virt: Make DomainDescriptor use XML helpers .. Patch Set 9: (1 comment) Very partial review, will look at it again next week.

Change in vdsm[master]: [WIP] use libvirt domain xml prepared in advance

2016-10-13 Thread ahadas
Arik Hadas has posted comments on this change. Change subject: [WIP] use libvirt domain xml prepared in advance .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/65182/2/vdsm/virt/vmxml.py File vdsm/virt/vmxml.py:

Change in vdsm[master]: jobs: Fix abort semantics

2016-10-13 Thread alitke
Adam Litke has posted comments on this change. Change subject: jobs: Fix abort semantics .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/65102/5/lib/vdsm/jobs.py File lib/vdsm/jobs.py: Line 237: """ Line

Change in vdsm[master]: jobs: Fix abort semantics

2016-10-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: jobs: Fix abort semantics .. Patch Set 6: * Update Tracker::IGNORE, no bug url/s found * Check Bug-Url::IGNORE, not relevant for branch: master * Check Public

Change in vdsm[master]: jobs: Fix abort semantics

2016-10-13 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: jobs: Fix abort semantics .. Patch Set 6: Code-Review+2 Lets make some progress. -- To view, visit https://gerrit.ovirt.org/65102 To unsubscribe, visit

Change in vdsm[master]: jobs: Fix abort semantics

2016-10-13 Thread alitke
Adam Litke has posted comments on this change. Change subject: jobs: Fix abort semantics .. Patch Set 6: Verified+1 Verified with unit tests. -- To view, visit https://gerrit.ovirt.org/65102 To unsubscribe, visit

Change in vdsm[master]: storage: Fix abort race in SDM.copy_data

2016-10-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: storage: Fix abort race in SDM.copy_data .. Patch Set 6: * Update Tracker::IGNORE, no bug url/s found * Check Bug-Url::IGNORE, not relevant for branch: master *

Change in vdsm[master]: qemuimg: Explicit run semantics for QemuImgOperation

2016-10-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: qemuimg: Explicit run semantics for QemuImgOperation .. Patch Set 6: * Update Tracker::IGNORE, no bug url/s found * Check Bug-Url::IGNORE, not relevant for

Change in vdsm[master]: osinfo: drop package buildtime

2016-10-13 Thread mpolednik
Martin Polednik has posted comments on this change. Change subject: osinfo: drop package buildtime .. Patch Set 4: Verified+1 -- To view, visit https://gerrit.ovirt.org/65059 To unsubscribe, visit

Change in vdsm[master]: osinfo: drop package buildtime

2016-10-13 Thread michal . skrivanek
Michal Skrivanek has posted comments on this change. Change subject: osinfo: drop package buildtime .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65059 To unsubscribe, visit

Change in vdsm[master]: tests: Use Popen.poll() for running state

2016-10-13 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: tests: Use Popen.poll() for running state .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/65323/4//COMMIT_MSG Commit Message: PS4, Line 9: exists

Change in vdsm[master]: volume_artifacts: Add qcow2_compat on create.

2016-10-13 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: volume_artifacts: Add qcow2_compat on create. .. Patch Set 24: Verified+1 -- To view, visit https://gerrit.ovirt.org/64372 To unsubscribe, visit

Change in vdsm[master]: copy_data: Add qcow2_compat on convert.

2016-10-13 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: copy_data: Add qcow2_compat on convert. .. Patch Set 24: Verified+1 -- To view, visit https://gerrit.ovirt.org/64373 To unsubscribe, visit

Change in vdsm[master]: tests: Refine TerminationTests names

2016-10-13 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: tests: Refine TerminationTests names .. Patch Set 5: (3 comments) https://gerrit.ovirt.org/#/c/65326/5//COMMIT_MSG Commit Message: PS5, Line 9: Al For all

Change in vdsm[master]: tests: Add tests for poll and wait failures

2016-10-13 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: tests: Add tests for poll and wait failures .. Patch Set 8: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/65294/8/tests/utilsTests.py File

Change in vdsm[master]: logging: Improve log level alignment

2016-10-13 Thread edwardh
Edward Haas has posted comments on this change. Change subject: logging: Improve log level alignment .. Patch Set 3: IMO the two char saving is not worth the small hack (https://gerrit.ovirt.org/#/c/64217/3/vdsm/vdsm), it is

Change in vdsm[master]: copy_data: Add qcow2_compat on convert.

2016-10-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: copy_data: Add qcow2_compat on convert. .. Patch Set 24: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: volume_artifacts: Add qcow2_compat on create.

2016-10-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: volume_artifacts: Add qcow2_compat on create. .. Patch Set 24: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: tests: Add test for terminating a terminated process

2016-10-13 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: tests: Add test for terminating a terminated process .. Patch Set 6: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/65328/6/tests/utilsTests.py File

Change in vdsm[master]: tests: Add tests for waiting on a zombie process

2016-10-13 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: tests: Add tests for waiting on a zombie process .. Patch Set 6: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/65327/6/tests/utilsTests.py File

Change in vdsm[master]: tests: Add test for terminating a terminated process

2016-10-13 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: Add test for terminating a terminated process .. Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/65328/6/tests/utilsTests.py File

Change in vdsm[master]: build: Replace pep8 and pyflakes with flake8

2016-10-13 Thread edwardh
Edward Haas has posted comments on this change. Change subject: build: Replace pep8 and pyflakes with flake8 .. Patch Set 2: -Code-Review Will this work with py3? -- To view, visit https://gerrit.ovirt.org/65403 To

Change in vdsm[master]: pep8: Fix long line in vdsm sos plugin

2016-10-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: pep8: Fix long line in vdsm sos plugin .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit

Change in vdsm[master]: utils: Wait for terminated process

2016-10-13 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: utils: Wait for terminated process .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65324 To unsubscribe, visit

Change in vdsm[master]: tests: Add tests for waiting on a zombie process

2016-10-13 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: Add tests for waiting on a zombie process .. Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/65327/6/tests/utilsTests.py File tests/utilsTests.py:

Change in vdsm[master]: tests: Add tests for poll and wait failures

2016-10-13 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: Add tests for poll and wait failures .. Patch Set 8: (2 comments) https://gerrit.ovirt.org/#/c/65294/8/tests/utilsTests.py File tests/utilsTests.py: Line

Change in vdsm[master]: pep8: Fix long line in vdsm sos plugin

2016-10-13 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: pep8: Fix long line in vdsm sos plugin .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/65402 To unsubscribe, visit

Change in vdsm[master]: pep8: Fix long line in vdsm sos plugin

2016-10-13 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: pep8: Fix long line in vdsm sos plugin .. pep8: Fix long line in vdsm sos plugin Change-Id: I81c2f558f7e34505b9873a8b379f88339859f589 Signed-off-by:

Change in vdsm[master]: osinfo: drop package buildtime

2016-10-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: osinfo: drop package buildtime .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: static: move vdsm bonding defaults under static

2016-10-13 Thread mpolednik
Martin Polednik has posted comments on this change. Change subject: static: move vdsm bonding defaults under static .. Patch Set 6: (1 comment) No path was hardcoded during the creation of this patch. :)

Change in vdsm[master]: static: move man under static

2016-10-13 Thread mpolednik
Martin Polednik has posted comments on this change. Change subject: static: move man under static .. Patch Set 5: (3 comments) https://gerrit.ovirt.org/#/c/62549/5/static/Makefile.am File static/Makefile.am: PS5, Line 24:

Change in vdsm[master]: tests: use assertXMLEqual in vmTests

2016-10-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: use assertXMLEqual in vmTests .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: tests: use assertXMLEqual in vmTests

2016-10-13 Thread fromani
Francesco Romani has uploaded a new change for review. Change subject: tests: use assertXMLEqual in vmTests .. tests: use assertXMLEqual in vmTests switch to assertXMLEqual to have better error messages. Change-Id:

Change in vdsm[master]: utils: Add missing Popen methods

2016-10-13 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: utils: Add missing Popen methods .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65321 To unsubscribe, visit

Change in vdsm[master]: osinfo: un-nest kernel version gathering function

2016-10-13 Thread mpolednik
Martin Polednik has posted comments on this change. Change subject: osinfo: un-nest kernel version gathering function .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/65379/1/lib/vdsm/osinfo.py File

Change in vdsm[master]: osinfo: un-nest kernel version gathering function

2016-10-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: osinfo: un-nest kernel version gathering function .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: tests: Wait for child process in tearDown

2016-10-13 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: tests: Wait for child process in tearDown .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65322 To unsubscribe, visit

Change in vdsm[master]: utils: Raise detectable error if termination fail

2016-10-13 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: utils: Raise detectable error if termination fail .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/65325/5//COMMIT_MSG Commit Message: PS5, Line

Change in vdsm[master]: osinfo: drop package buildtime

2016-10-13 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: osinfo: drop package buildtime .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65059 To unsubscribe, visit

Change in vdsm[master]: tests: Use Popen.poll() for running state

2016-10-13 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: Use Popen.poll() for running state .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/65323/4//COMMIT_MSG Commit Message: Line 5: CommitDate:

Change in vdsm[master]: qemuimg: Expose API for qemuimg map

2016-10-13 Thread ahino
Ala Hino has posted comments on this change. Change subject: qemuimg: Expose API for qemuimg map .. Patch Set 4: (4 comments) https://gerrit.ovirt.org/#/c/65112/4/tests/qemuimg_test.py File tests/qemuimg_test.py: Line 497:

Change in vdsm[master]: qemuimg: Expose API for qemuimg map

2016-10-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: qemuimg: Expose API for qemuimg map .. Patch Set 5: * Update Tracker::IGNORE, not relevant for branch: master * Check Bug-Url::IGNORE, not relevant for branch:

Change in vdsm[master]: utils: Raise detectable error if termination fail

2016-10-13 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: utils: Raise detectable error if termination fail .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/65325/5//COMMIT_MSG Commit Message: Line 14: job

Change in vdsm[master]: config: add tunables for container support

2016-10-13 Thread fromani
Francesco Romani has posted comments on this change. Change subject: config: add tunables for container support .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/64243/2//COMMIT_MSG Commit Message: Line 5: CommitDate:

Change in vdsm[master]: tests: Use Popen.poll() for running state

2016-10-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Use Popen.poll() for running state .. Patch Set 5: * Update Tracker::IGNORE, not relevant for branch: master * Check Bug-Url::IGNORE, not relevant for

Change in vdsm[master]: tests: Add test for terminating a terminated process

2016-10-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Add test for terminating a terminated process .. Patch Set 7: * Update Tracker::IGNORE, not relevant for branch: master * Check Bug-Url::IGNORE, not

Change in vdsm[master]: tests: Wait for child process in tearDown

2016-10-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Wait for child process in tearDown .. Patch Set 5: * Update Tracker::IGNORE, not relevant for branch: master * Check Bug-Url::IGNORE, not relevant for

Change in vdsm[master]: tests: Refine TerminationTests names

2016-10-13 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: Refine TerminationTests names .. Patch Set 5: (3 comments) https://gerrit.ovirt.org/#/c/65326/5//COMMIT_MSG Commit Message: Line 5: CommitDate: 2016-10-13

Change in vdsm[master]: utils: Raise detectable error if termination fail

2016-10-13 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: utils: Raise detectable error if termination fail .. Patch Set 6: Verified+1 -- To view, visit https://gerrit.ovirt.org/65325 To unsubscribe, visit

Change in vdsm[master]: vmxml: export container metadata

2016-10-13 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vmxml: export container metadata .. Patch Set 23: (6 comments) https://gerrit.ovirt.org/#/c/60481/23/vdsm/virt/vmxml.py File vdsm/virt/vmxml.py: PS23, Line

Change in vdsm[master]: utils: Raise detectable error if termination fail

2016-10-13 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: utils: Raise detectable error if termination fail .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/65325/5//COMMIT_MSG Commit Message: Line 14: job

Change in vdsm[master]: utils: Wait for terminated process

2016-10-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: utils: Wait for terminated process .. Patch Set 5: * Update Tracker::IGNORE, not relevant for branch: master * Check Bug-Url::IGNORE, not relevant for branch:

Change in vdsm[master]: utils: Add missing Popen methods

2016-10-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: utils: Add missing Popen methods .. Patch Set 5: * Update Tracker::IGNORE, not relevant for branch: master * Check Bug-Url::IGNORE, not relevant for branch:

Change in vdsm[master]: tests: Add tests for waiting on a zombie process

2016-10-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Add tests for waiting on a zombie process .. Patch Set 7: * Update Tracker::IGNORE, not relevant for branch: master * Check Bug-Url::IGNORE, not relevant

Change in vdsm[master]: utils: Raise detectable error if termination fail

2016-10-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: utils: Raise detectable error if termination fail .. Patch Set 6: * Update Tracker::IGNORE, not relevant for branch: master * Check Bug-Url::IGNORE, not relevant

Change in vdsm[master]: tests: Refine TerminationTests names

2016-10-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Refine TerminationTests names .. Patch Set 6: * Update Tracker::IGNORE, not relevant for branch: master * Check Bug-Url::IGNORE, not relevant for branch:

Change in vdsm[master]: tests: Refine TerminationTests names

2016-10-13 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: Refine TerminationTests names .. Patch Set 6: Verified+1 -- To view, visit https://gerrit.ovirt.org/65326 To unsubscribe, visit

Change in vdsm[master]: tests: Add tests for poll and wait failures

2016-10-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Add tests for poll and wait failures .. Patch Set 9: * Update Tracker::IGNORE, not relevant for branch: master * Check Bug-Url::IGNORE, not relevant for

Change in vdsm[master]: build: Replace pep8 and pyflakes with flake8

2016-10-13 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: build: Replace pep8 and pyflakes with flake8 .. Patch Set 2: Edward, flake8 works on both python 2 and 3, but this is not relevant to our tests. -- To view,

Change in vdsm[master]: py3: make gluster_cli_tests pass

2016-10-13 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: py3: make gluster_cli_tests pass .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65008 To unsubscribe, visit

Change in vdsm[master]: virt: Make DomainDescriptor use XML helpers

2016-10-13 Thread fromani
Francesco Romani has posted comments on this change. Change subject: virt: Make DomainDescriptor use XML helpers .. Patch Set 9: Code-Review+2 *Really* nice improvements. I like this. -- To view, visit

Change in vdsm[master]: tests: containers: add testsuite

2016-10-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: containers: add testsuite .. Patch Set 23: * Update Tracker::IGNORE, no bug url/s found * Check Bug-Url::IGNORE, not relevant for branch: master * Check

Change in vdsm[master]: vmxml: export container metadata

2016-10-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vmxml: export container metadata .. Patch Set 25: * Update Tracker::IGNORE, no bug url/s found * Check Bug-Url::IGNORE, not relevant for branch: master * Check

Change in vdsm[master]: **WIP** tool: reconfigure containers networks

2016-10-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: **WIP** tool: reconfigure containers networks .. Patch Set 19: * Update Tracker::IGNORE, no bug url/s found * Check Bug-Url::IGNORE, not relevant for branch:

Change in vdsm[master]: WIP: docs: add tutorial

2016-10-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: WIP: docs: add tutorial .. Patch Set 2: * Update Tracker::IGNORE, no bug url/s found * Check Bug-Url::IGNORE, not relevant for branch: master * Check Public

Change in vdsm[master]: supervdsm: expose systemd utilities

2016-10-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: supervdsm: expose systemd utilities .. Patch Set 33: * Update Tracker::IGNORE, no bug url/s found * Check Bug-Url::IGNORE, not relevant for branch: master *

Change in vdsm[master]: network: supervdsm: configure container networks

2016-10-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: network: supervdsm: configure container networks .. Patch Set 46: * Update Tracker::IGNORE, no bug url/s found * Check Bug-Url::IGNORE, not relevant for branch:

Change in vdsm[master]: config: add tunables for container support

2016-10-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: config: add tunables for container support .. Patch Set 4: * Update Tracker::IGNORE, no bug url/s found * Check Bug-Url::IGNORE, not relevant for branch: master

Change in vdsm[master]: network: filter out 'veth' devices

2016-10-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: network: filter out 'veth' devices .. Patch Set 20: * Update Tracker::IGNORE, no bug url/s found * Check Bug-Url::IGNORE, not relevant for branch: master * Check

Change in vdsm[master]: core: containers: add the container support module

2016-10-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: core: containers: add the container support module .. Patch Set 35: * Update Tracker::IGNORE, no bug url/s found * Check Bug-Url::IGNORE, not relevant for

Change in vdsm[master]: vdsm: virt: add optional container support

2016-10-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vdsm: virt: add optional container support .. Patch Set 53: * Update Tracker::IGNORE, no bug url/s found * Check Bug-Url::IGNORE, not relevant for branch: master

Change in vdsm[master]: static: move vdsm bonding defaults under static

2016-10-13 Thread fromani
Francesco Romani has posted comments on this change. Change subject: static: move vdsm bonding defaults under static .. Patch Set 6: Code-Review+2 (1 comment) https://gerrit.ovirt.org/#/c/62537/6/static/Makefile.am File

Change in vdsm[master]: static: move man under static

2016-10-13 Thread fromani
Francesco Romani has posted comments on this change. Change subject: static: move man under static .. Patch Set 5: Code-Review+2 same answer as per parent patch, no reason to hold +2 -- To view, visit

Change in vdsm[master]: tests: use assertXMLEqual in vmTests

2016-10-13 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: use assertXMLEqual in vmTests .. Patch Set 1: Looks good, need to make pep8 happy. ./tests/vmTests.py:636:80: E501 line too long (81 > 79 characters)

Change in vdsm[master]: osinfo: drop package buildtime

2016-10-13 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: osinfo: drop package buildtime .. osinfo: drop package buildtime Buildtime of host packages was never used and only causes us problems w/ parsing

Change in vdsm[master]: osinfo: drop package buildtime

2016-10-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: osinfo: drop package buildtime .. Patch Set 5: * Update Tracker::IGNORE, no bug url/s found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit

Change in vdsm[master]: osinfo: drop package buildtime

2016-10-13 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: osinfo: drop package buildtime .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/65059 To unsubscribe, visit

Change in vdsm[master]: tests: Add tests for waiting on a zombie process

2016-10-13 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: tests: Add tests for waiting on a zombie process .. Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/65327/6/tests/utilsTests.py File

Change in vdsm[master]: virt: Try to detect non guest iniated shutdowns

2016-10-13 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: virt: Try to detect non guest iniated shutdowns .. Patch Set 7: Code-Review+1 Maybe _shutdownLock is no longer necessary? -- To view, visit

Change in vdsm[master]: net test: fix ovs_test:test_dry_run

2016-10-13 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net test: fix ovs_test:test_dry_run .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65058 To unsubscribe, visit

Change in vdsm[master]: storagetestlib: Add sdVersion param to the test API.

2016-10-13 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: storagetestlib: Add sdVersion param to the test API. .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/65308/3/tests/storagetestlib_test.py File

Change in vdsm[master]: utils: Raise detectable error if termination fail

2016-10-13 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: utils: Raise detectable error if termination fail .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/65325/5//COMMIT_MSG Commit Message: Line 14: job

Change in vdsm[master]: tests: Add tests for poll and wait failures

2016-10-13 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: Add tests for poll and wait failures .. Patch Set 8: (1 comment) https://gerrit.ovirt.org/#/c/65294/8/tests/utilsTests.py File tests/utilsTests.py: Line

  1   2   >