Change in vdsm[master]: vm: create a vnic with vhostuser backend

2017-06-06 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: vm: create a vnic with vhostuser backend .. Patch Set 29: Code-Review-1 (1 comment)

Change in vdsm[master]: net tests: Introduce requires_systemdrun and use it in cmd_test

2017-06-06 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net tests: Introduce requires_systemdrun and use it in cmd_test .. Patch Set 2: Code-Review+2 I don't understand why

Change in vdsm[master]: net tests: Introduce requires_systemdrun and use it in cmd_test

2017-06-06 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: net tests: Introduce requires_systemdrun and use it in cmd_test .. net tests: Introduce requires_systemdrun

Change in vdsm[master]: virt: add method to build device map from XML

2017-06-06 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: virt: add method to build device map from XML .. Patch Set 2: (1 comment)

Change in vdsm[master]: Removing syslog print from vdsm-tool when module load fails

2017-06-06 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: Removing syslog print from vdsm-tool when module load fails .. Patch Set 1: yes we can ... I can add new log if you

Change in vdsm[master]: Remove upgrade hacks for vdsm version <=4.16

2017-06-06 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: Remove upgrade hacks for vdsm version <=4.16 .. Patch Set 2: Verified+1 -- To view, visit

Change in vdsm[master]: net tests: Introduce requires_systemdrun and use it in cmd_test

2017-06-06 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net tests: Introduce requires_systemdrun and use it in cmd_test .. Patch Set 1: (1 comment)

Change in vdsm[master]: ssl: enable tlsv1.2 support

2017-06-06 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: ssl: enable tlsv1.2 support .. Patch Set 27: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/72284 To

Change in vdsm[master]: rpc: propagate executor issue to the engine

2017-06-06 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: rpc: propagate executor issue to the engine .. Patch Set 23: Code-Review-1 (1 comment)

Change in vdsm[master]: network: isolate libnl bindings, link functions

2017-06-06 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: network: isolate libnl bindings, link functions .. network: isolate libnl bindings, link functions

Change in vdsm[master]: network: isolate libnl constants, callback actions

2017-06-06 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: network: isolate libnl constants, callback actions .. network: isolate libnl constants, callback actions

Change in vdsm[master]: network: isolate libnl bindings, cache functions

2017-06-06 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: network: isolate libnl bindings, cache functions .. network: isolate libnl bindings, cache functions

Change in vdsm[master]: network: isolate libnl constants, object type names

2017-06-06 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: network: isolate libnl constants, object type names .. network: isolate libnl constants, object type names

Change in vdsm[master]: network: isolate libnl constants, interface state

2017-06-06 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: network: isolate libnl constants, interface state .. network: isolate libnl constants, interface state

Change in vdsm[master]: network: isolate libnl bindings, address functions

2017-06-06 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: network: isolate libnl bindings, address functions .. network: isolate libnl bindings, address functions

Change in vdsm[master]: network: isolate libnl constants, EVENTS

2017-06-06 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: network: isolate libnl constants, EVENTS .. network: isolate libnl constants, EVENTS Change-Id:

Change in vdsm[master]: network: isolate libnl constants, callback kinds

2017-06-06 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: network: isolate libnl constants, callback kinds .. network: isolate libnl constants, callback kinds

Change in vdsm[master]: network: isolate libnl constants, NETLINK_ROUTE

2017-06-06 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: network: isolate libnl constants, NETLINK_ROUTE .. network: isolate libnl constants, NETLINK_ROUTE

Change in vdsm[master]: network: isolate libnl bindings, socket functions

2017-06-06 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: network: isolate libnl bindings, socket functions .. network: isolate libnl bindings, socket functions

Change in vdsm[master]: network: isolate libnl bindings, object and message functions

2017-06-06 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: network: isolate libnl bindings, object and message functions .. network: isolate libnl bindings, object and

Change in vdsm[master]: network: remove unused netlink constant _NLE_NODEV

2017-06-06 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: network: remove unused netlink constant _NLE_NODEV .. network: remove unused netlink constant _NLE_NODEV

Change in vdsm[master]: network: isolate libnl constants, routing tables

2017-06-06 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: network: isolate libnl constants, routing tables .. network: isolate libnl constants, routing tables

Change in vdsm[master]: network: isolate libnl bindings, route functions

2017-06-06 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: network: isolate libnl bindings, route functions .. network: isolate libnl bindings, route functions

Change in vdsm[master]: net nm: nmdbus connections settings report race fix

2017-06-06 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net nm: nmdbus connections settings report race fix .. Patch Set 3: Code-Review+2 raising score -- To view, visit

Change in vdsm[master]: net nm: nmdbus connections settings report race fix

2017-06-06 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: net nm: nmdbus connections settings report race fix .. net nm: nmdbus connections settings report race fix

Change in vdsm[master]: network: remove blacklisted tests fixed by netlink refactoring

2017-06-06 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: network: remove blacklisted tests fixed by netlink refactoring .. network: remove blacklisted tests fixed by

Change in vdsm[master]: network: remove blacklisted tests fixed by netlink refactoring

2017-06-06 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: network: remove blacklisted tests fixed by netlink refactoring .. Patch Set 25: Verified+1 passing CI is good enough

Change in vdsm[master]: ssl: enable tlsv1.2 support

2017-06-06 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: ssl: enable tlsv1.2 support .. Patch Set 26: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/72284 To

Change in vdsm[master]: virt: move device mapping inside vmdevices

2017-06-06 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: virt: move device mapping inside vmdevices .. Patch Set 34: Code-Review+2 -- To view, visit

Change in vdsm[master]: spec: Use systemctl directly instead of vdsm-tool where poss...

2017-06-06 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: spec: Use systemctl directly instead of vdsm-tool where possible .. Patch Set 1: Code-Review+1 I prefer that, and

Change in vdsm[master]: WIP: extract Vm.process_devices()

2017-06-06 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: WIP: extract Vm.process_devices() .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/77815/2/vdsm/virt/vm.py

Change in vdsm[master]: cmdutils: Relocate *_log_line funcs to common.cmdutils

2017-06-06 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: cmdutils: Relocate *_log_line funcs to common.cmdutils .. Patch Set 8: Code-Review+2 -- To view, visit

Change in vdsm[master]: constants: Move EXT_SYSTEMD_RUN from constants to cmdutils

2017-06-06 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: constants: Move EXT_SYSTEMD_RUN from constants to cmdutils .. Patch Set 8: Code-Review+2 -- To view, visit

Change in vdsm[master]: constants: Move EXT_SYSTEMD_RUN from constants to cmdutils

2017-06-06 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: constants: Move EXT_SYSTEMD_RUN from constants to cmdutils .. constants: Move EXT_SYSTEMD_RUN from constants

Change in vdsm[master]: compat: Move compat module to common

2017-06-06 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: compat: Move compat module to common .. Patch Set 11: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/77510

Change in vdsm[master]: cmdutils: Relocate systemd_run to common.cmdutils

2017-06-06 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: cmdutils: Relocate systemd_run to common.cmdutils .. Patch Set 8: Code-Review+2 -- To view, visit

Change in vdsm[master]: cmdutils: Relocate *_log_line funcs to common.cmdutils

2017-06-06 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: cmdutils: Relocate *_log_line funcs to common.cmdutils .. cmdutils: Relocate *_log_line funcs to

Change in vdsm[master]: cmdutils: Relocate systemd_run to common.cmdutils

2017-06-06 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: cmdutils: Relocate systemd_run to common.cmdutils .. cmdutils: Relocate systemd_run to common.cmdutils

Change in vdsm[master]: compat: Move compat module to common

2017-06-06 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: compat: Move compat module to common .. compat: Move compat module to common compat fits vdsm.common as it