Change in vdsm[master]: janitorial: drop once-used P_VDSM_KEYS

2017-07-24 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: janitorial: drop once-used P_VDSM_KEYS .. Patch Set 4: Verified+1 OST passes http://jenkins.ovirt.org/view/oVirt%20system%20tests/job/ov

Change in vdsm[master]: move constants.SUPPORTED_BLOCKSIZE to its sole user

2017-07-24 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: move constants.SUPPORTED_BLOCKSIZE to its sole user .. Patch Set 1: Verified+1 OST passes http://jenkins.ovirt.org/view/oVirt%20system%2

Change in vdsm[master]: move constants.SUPPORTED_DOMAIN_VERSIONS to storage.constants

2017-07-24 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: move constants.SUPPORTED_DOMAIN_VERSIONS to storage.constants .. Patch Set 1: Verified+1 OST passes http://jenkins.ovirt.org/view/oVirt%

Change in vdsm[master]: move vdsm.constants.UUID_GLOB_PATTERN to storage.constants

2017-07-24 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79714 ) Change subject: move vdsm.constants.UUID_GLOB_PATTERN to storage.constants .. move vdsm.constants.UUID_GLOB_P

Change in vdsm[master]: hook: checkimages: define GiB properly

2017-07-24 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: hook: checkimages: define GiB properly .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/79730 To unsubscribe, vi

Change in vdsm[master]: move constants.P_VDSM_NODE_ID to its sole user

2017-07-24 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79715 ) Change subject: move constants.P_VDSM_NODE_ID to its sole user .. move constants.P_VDSM_NODE_ID to its sole u

Change in vdsm[master]: janitorial: drop once-used P_VDSM_KEYS

2017-07-24 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/77468 ) Change subject: janitorial: drop once-used P_VDSM_KEYS .. janitorial: drop once-used P_VDSM_KEYS PKI_DIR lea

Change in vdsm[master]: move constants.EXT_BRCTL to its sole current user

2017-07-24 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79717 ) Change subject: move constants.EXT_BRCTL to its sole current user .. move constants.EXT_BRCTL to its sole cur

Change in vdsm[master]: hook: checkimages: define GiB properly

2017-07-24 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79730 ) Change subject: hook: checkimages: define GiB properly .. hook: checkimages: define GiB properly The constan

Change in vdsm[master]: move constants.P_VDSM_STORAGE to storage.constants

2017-07-24 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has uploaded a new change for review. Change subject: move constants.P_VDSM_STORAGE to storage.constants .. move constants.P_VDSM_STORAGE to storage.constants Change-Id: I4bf8cbe4a8c435d93e7

Change in vdsm[master]: move constants.P_VDSM_CONF to vdsm.config

2017-07-24 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has uploaded a new change for review. Change subject: move constants.P_VDSM_CONF to vdsm.config .. move constants.P_VDSM_CONF to vdsm.config Change-Id: Ic0ba7de6aae8331a3587d82eadf16346437ca

Change in vdsm[master]: ssl: handle handshake errors

2017-07-24 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: ssl: handle handshake errors .. Patch Set 4: (2 comments) https://gerrit.ovirt.org/#/c/79668/4//COMMIT_MSG Commit Message: Line 5: Comm

Change in vdsm[ovirt-4.1]: m2c: uses different protocol constant names

2017-07-24 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: m2c: uses different protocol constant names .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/79664/2//COMMIT_MSG Commit Message:

Change in vdsm[master]: Makefile: replace astrisks with equal signs

2017-07-24 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has uploaded a new change for review. Change subject: Makefile: replace astrisks with equal signs .. Makefile: replace astrisks with equal signs Tripple astrisks are used to mark failures in

Change in vdsm[master]: sslutils: add info to SSLHandshake errors

2017-07-24 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: sslutils: add info to SSLHandshake errors .. Patch Set 2: thanks Piotr, that was very kind of you. -- To view, visit https://gerrit.ovi

Change in vdsm[master]: sslutils: add info to SSLHandshake errors

2017-07-24 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/76221 ) Change subject: sslutils: add info to SSLHandshake errors .. sslutils: add info to SSLHandshake errors Inclu

Change in vdsm[master]: Makefile: replace astrisks with equal signs

2017-07-24 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: Makefile: replace astrisks with equal signs .. Patch Set 3: ci please build -- To view, visit https://gerrit.ovirt.org/79750 To unsubsc

Change in vdsm[master]: Makefile: replace astrisks with equal signs

2017-07-24 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: Makefile: replace astrisks with equal signs .. Patch Set 3: http://jenkins.ovirt.org/view/oVirt%20system%20tests/job/ovirt-system-tests_m

Change in vdsm[master]: RPC: Fix error messages in JsonRpcResponse

2017-07-24 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79665 ) Change subject: RPC: Fix error messages in JsonRpcResponse .. RPC: Fix error messages in JsonRpcResponse Jso

Change in vdsm[master]: RPC: Refactor JSON RPC exceptions

2017-07-24 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/78660 ) Change subject: RPC: Refactor JSON RPC exceptions .. RPC: Refactor JSON RPC exceptions JsonRpcError class is

Change in vdsm[master]: network: add IPAddressApi and its iproute implementation

2017-07-24 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/76153 ) Change subject: network: add IPAddressApi and its iproute implementation .. network: add IPAddressApi and its

Change in vdsm[master]: move constants.P_VDSM_STORAGE to storage.constants

2017-07-24 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: move constants.P_VDSM_STORAGE to storage.constants .. Patch Set 4: ci please build -- To view, visit https://gerrit.ovirt.org/79741 To

Change in vdsm[master]: move constants.P_VDSM_CONF to vdsm.config

2017-07-24 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: move constants.P_VDSM_CONF to vdsm.config .. Patch Set 6: Code-Review-1 -- To view, visit https://gerrit.ovirt.org/79742 To unsubscribe,

Change in vdsm[master]: move constants.P_VDSM_CONF to vdsm.config

2017-07-24 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: move constants.P_VDSM_CONF to vdsm.config .. Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/79742/6/lib/vdsm/vdsmd.py File lib/vd

Change in vdsm[master]: move constants.SUPPORTED_BLOCKSIZE to storage.constants

2017-07-24 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: move constants.SUPPORTED_BLOCKSIZE to storage.constants .. Patch Set 3: Verified+1 OST is happy http://jenkins.ovirt.org/view/oVirt syste

Change in vdsm[master]: move constants.SUPPORTED_DOMAIN_VERSIONS to storage.constants

2017-07-24 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: move constants.SUPPORTED_DOMAIN_VERSIONS to storage.constants .. Patch Set 3: Verified+1 OST is happy http://jenkins.ovirt.org/view/oVirt

Change in vdsm[master]: drop constants.EXT_PYTHON

2017-07-24 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: drop constants.EXT_PYTHON .. Patch Set 5: Verified+1 OST is happy http://jenkins.ovirt.org/view/oVirt system tests/job/ovirt-system-test

Change in vdsm[master]: move constants.P_VDSM_STORAGE to storage.constants

2017-07-24 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: move constants.P_VDSM_STORAGE to storage.constants .. Patch Set 4: Verified+1 OST is happy http://jenkins.ovirt.org/view/oVirt system te

Change in vdsm[master]: Makefile: replace astrisks with equal signs

2017-07-24 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: Makefile: replace astrisks with equal signs .. Patch Set 3: Verified+1 passes CI -- To view, visit https://gerrit.ovirt.org/79750 To un

Change in vdsm[master]: Makefile: replace astrisks with equal signs

2017-07-24 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79750 ) Change subject: Makefile: replace astrisks with equal signs .. Makefile: replace astrisks with equal signs T

Change in vdsm[master]: move constants.SUPPORTED_DOMAIN_VERSIONS to storage.constants

2017-07-24 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79732 ) Change subject: move constants.SUPPORTED_DOMAIN_VERSIONS to storage.constants .. move constants.SUPPORTED_DOM

Change in vdsm[master]: drop constants.EXT_PYTHON

2017-07-24 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79733 ) Change subject: drop constants.EXT_PYTHON .. drop constants.EXT_PYTHON commands_test and gluster.gfapi's ugl

Change in vdsm[master]: move constants.SUPPORTED_BLOCKSIZE to storage.constants

2017-07-24 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79731 ) Change subject: move constants.SUPPORTED_BLOCKSIZE to storage.constants .. move constants.SUPPORTED_BLOCKSIZE

Change in vdsm[master]: move constants.P_VDSM_STORAGE to storage.constants

2017-07-24 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79741 ) Change subject: move constants.P_VDSM_STORAGE to storage.constants .. move constants.P_VDSM_STORAGE to storag