Change in vdsm[master]: Restore previous MTU on bond when VLAN with bigger MTU remov...

2012-08-20 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Restore previous MTU on bond when VLAN with bigger MTU removed .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7323 To

Change in vdsm[master]: BZ#848299 - Fix delete VLANed network with custom MTU

2012-08-20 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: BZ#848299 - Fix delete VLANed network with custom MTU .. Patch Set 5: Verified just verified that you can now remove a network defined with an MTU. -- To

Change in vdsm[master]: BZ#848299 - Fix delete VLANed network with custom MTU

2012-08-20 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: BZ#848299 - Fix delete VLANed network with custom MTU .. BZ#848299 - Fix delete VLANed network with custom MTU Change-Id:

Change in vdsm[master]: vdsm: libvirt service was restarted everytime vdsm was resta...

2012-08-20 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vdsm: libvirt service was restarted everytime vdsm was restarted (#734847) .. Patch Set 4: (6 inline comments) partial review. Please break to smaller

Change in vdsm[master]: vdsm: libvirt service was restarted everytime vdsm was resta...

2012-08-20 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vdsm: libvirt service was restarted everytime vdsm was restarted (#734847) .. Patch Set 4: I would prefer that you didn't submit this -- To view, visit

Change in vdsm[master]: vdsm: generating uuid for libvirt configuration (#842115)

2012-08-20 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vdsm: generating uuid for libvirt configuration (#842115) .. Patch Set 1: I would prefer that you didn't submit this (4 inline comments) minor comments. I

Change in vdsm[master]: Ship the version file with the tarballs

2012-08-20 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Ship the version file with the tarballs .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7295 To unsubscribe, visit

Change in vdsm[master]: Use quiesce only if qgaEnable is enabled

2012-08-20 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Use quiesce only if qgaEnable is enabled .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7143 To

Change in vdsm[master]: vdsm-upgrade: use python scripts from ovirtnode

2012-08-20 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vdsm-upgrade: use python scripts from ovirtnode .. Patch Set 3: I would prefer that you didn't submit this (2 inline comments)

Change in vdsm[master]: Add eclipse and PyDev project files to .gitignore

2012-08-20 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Add eclipse and PyDev project files to .gitignore .. Patch Set 1: Verified; Looks good to me, approved works for me. -- To view, visit

Change in vdsm[master]: Add eclipse and PyDev project files to .gitignore

2012-08-20 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: Add eclipse and PyDev project files to .gitignore .. Add eclipse and PyDev project files to .gitignore PyDev as eclipse plugin is commonly used for

Change in vdsm[master]: BZ829710 Get VMList with oop if necessary

2012-08-20 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: BZ829710 Get VMList with oop if necessary .. Patch Set 4: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6867 To unsubscribe, visit

Change in vdsm[master]: Fix vdsm-faqemu VM launch failure on hosts with newer libvir...

2012-08-20 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Fix vdsm-faqemu VM launch failure on hosts with newer libvirt .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit

Change in vdsm[master]: BZ#846004 - IP on nic/bond should be preserved when VLAN add...

2012-08-20 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: BZ#846004 - IP on nic/bond should be preserved when VLAN added .. Patch Set 6: Looks good to me, but someone else must approve -- To view, visit

Change in vdsm[master]: configNetwork: use MTU as int in setNewMtu

2012-08-20 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: configNetwork: use MTU as int in setNewMtu .. Patch Set 2: Looks good to me, approved goodness gracious. this has never ever worked. thanks for fixing this

Change in vdsm[master]: BZ#811807 Enable network filtering

2012-08-20 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: BZ#811807 Enable network filtering .. Patch Set 2: I would prefer that you didn't submit this (1 inline comment)

Change in vdsm[master]: Remove 'skipLibvirt' from NetworkOptions

2012-08-20 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: Remove 'skipLibvirt' from NetworkOptions .. Remove 'skipLibvirt' from NetworkOptions The option 'skipLibvirt' was removed in commit ccb07ae. So it

Change in vdsm[master]: BZ#811807 Define network filter on libvirt

2012-08-20 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: BZ#811807 Define network filter on libvirt .. Patch Set 2: I would prefer that you didn't submit this (9 inline comments)

Change in vdsm[master]: BZ#811807 Libvirt service engagement workaround

2012-08-20 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: BZ#811807 Libvirt service engagement workaround .. Patch Set 1: (3 inline comments) arghh, that's ugly - but not your fault, and I have no better idea.

Change in vdsm[master]: BZ#842115 - Generating uuid for libvirt configuration

2012-08-21 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: BZ#842115 - Generating uuid for libvirt configuration .. Patch Set 3: Looks good to me, approved Please have someone verify this patch: see that on

Change in vdsm[master]: test: Add tests for _validateInterNetworkCompatibility()

2012-08-21 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: test: Add tests for _validateInterNetworkCompatibility() .. Patch Set 1: I would prefer that you didn't submit this (3 inline comments) Thanks for extending

Change in vdsm[master]: BZ#833425 Change cpu topology source to /sys.

2012-08-21 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: BZ#833425 Change cpu topology source to /sys. .. Patch Set 12: I would prefer that you didn't submit this (5 inline comments)

Change in vdsm[master]: BZ#841555 A migration failure with an AttributeError excep...

2012-08-21 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: BZ#841555 A migration failure with an AttributeError exception. .. Patch Set 1: (1 inline comment) File

Change in vdsm[master]: Fix vdsm-faqemu VM launch failure on hosts with newer libvir...

2012-08-21 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Fix vdsm-faqemu VM launch failure on hosts with newer libvirt .. Patch Set 1: Looks good to me, approved If Mark is happy with this, so am I ;-) Thanks, Ryan.

Change in vdsm[master]: Fix vdsm-faqemu VM launch failure on hosts with newer libvir...

2012-08-21 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: Fix vdsm-faqemu VM launch failure on hosts with newer libvirt .. Fix vdsm-faqemu VM launch failure on hosts with newer libvirt Since January 2012,

Change in vdsm[master]: Use setattr instead of __dict__

2012-08-21 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: Use setattr instead of __dict__ .. Use setattr instead of __dict__ It is bad to access the __dict__ directly Change-Id:

Change in vdsm[master]: Check if libvirtd.upstart is present before copying

2012-08-21 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Check if libvirtd.upstart is present before copying .. Patch Set 1: was there any functional side effect to this, beyond ugly errors on vdsmd restart? -- To

Change in vdsm[master]: Check if libvirtd.upstart is present before copying

2012-08-21 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Check if libvirtd.upstart is present before copying .. Patch Set 1: I would prefer that you didn't submit this -1 for visibility only -- To view, visit

Change in vdsm[master]: BZ#849542 bootstrap: set system time as soon as possible

2012-08-21 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: BZ#849542 bootstrap: set system time as soon as possible .. Patch Set 1: Looks good to me, approved makes a lot of sense. thanks. -- To view, visit

Change in vdsm[master]: BZ#849542 bootstrap: set system time as soon as possible

2012-08-21 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: BZ#849542 bootstrap: set system time as soon as possible .. BZ#849542 bootstrap: set system time as soon as possible CURRENT BEHAVIOR Set system time

Change in vdsm[master]: Check if libvirtd.upstart is present before copying

2012-08-21 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Check if libvirtd.upstart is present before copying .. Patch Set 1: oh, I now see that there *is* a big issue.

Change in vdsm[master]: vdsm.spec: Adding hostname as Require

2012-08-21 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vdsm.spec: Adding hostname as Require .. Patch Set 1: I would prefer that you didn't submit this I assume that you're trying to pull hostname into ovirt-node

Change in vdsm[master]: Ship the version file with the tarballs

2012-08-21 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Ship the version file with the tarballs .. Patch Set 3: Looks good to me, but someone else must approve (1 inline comment)

Change in vdsm[master]: BZ#811807 Enable network filtering

2012-08-21 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: BZ#811807 Enable network filtering .. Patch Set 3: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7353 To unsubscribe, visit

Change in vdsm[master]: BZ#811807 Libvirt service engagement workaround

2012-08-21 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: BZ#811807 Libvirt service engagement workaround .. Patch Set 2: Looks good to me, but someone else must approve (1 inline comment)

Change in vdsm[master]: BZ#811807 Define network filter on libvirt

2012-08-21 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: BZ#811807 Define network filter on libvirt .. Patch Set 3: I would prefer that you didn't submit this (6 inline comments) I think we have more simplifications

Change in vdsm[master]: netConfig: translate to new option names from cmdline, too

2012-08-22 Thread danken
Dan Kenigsberg has uploaded a new change for review. Change subject: netConfig: translate to new option names from cmdline, too .. netConfig: translate to new option names from cmdline, too At some point in prehistoric past a

Change in vdsm[master]: configNetwork: use MTU as int in setNewMtu

2012-08-22 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: configNetwork: use MTU as int in setNewMtu .. Patch Set 3: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7360 To unsubscribe, visit

Change in vdsm[master]: confNet: ifcfg's VLAN should be set only on vlan cfg

2012-08-22 Thread danken
Dan Kenigsberg has uploaded a new change for review. Change subject: confNet: ifcfg's VLAN should be set only on vlan cfg .. confNet: ifcfg's VLAN should be set only on vlan cfg If a misguided script calls addNetwork with

Change in vdsm[master]: BZ#848843 Check if libvirtd.upstart is present before copyin...

2012-08-22 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: BZ#848843 Check if libvirtd.upstart is present before copying .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7375 To

Change in vdsm[master]: configNetwork: Fix a race between dhcp thread and connectivi...

2012-08-22 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: configNetwork: Fix a race between dhcp thread and connectivity check .. Patch Set 2: I did not read your code yet, but I wanted to note that we intentionally

Change in vdsm[master]: Introduce a new verb setBalloonTarget

2012-08-22 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Introduce a new verb setBalloonTarget .. Patch Set 8: (2 inline comments) File

Change in vdsm[master]: BZ#811807 Enable network filtering

2012-08-22 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: BZ#811807 Enable network filtering .. BZ#811807 Enable network filtering The VM network interface might receive a rule/filter to control the VM

Change in vdsm[master]: Added xml option in gluster command execution.

2012-08-22 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Added xml option in gluster command execution. .. Patch Set 2: I would prefer that you didn't submit this -- To view, visit http://gerrit.ovirt.org/6999 To

Change in vdsm[master]: Added xml option in gluster command execution.

2012-08-22 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Added xml option in gluster command execution. .. Patch Set 1: (2 inline comments) File

Change in vdsm[master]: test: Add tests for _validateInterNetworkCompatibility()

2012-08-22 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: test: Add tests for _validateInterNetworkCompatibility() .. test: Add tests for _validateInterNetworkCompatibility() Signed-off-by: Mark Wu

Change in vdsm[master]: test: Add tests for _validateInterNetworkCompatibility()

2012-08-22 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: test: Add tests for _validateInterNetworkCompatibility() .. Patch Set 3: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7241 To

Change in vdsm[master]: infra: adding debug log to vdsm daemon init script

2012-08-22 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: infra: adding debug log to vdsm daemon init script .. Patch Set 6: I would prefer that you didn't submit this (1 inline comment) I think it would be nice if

Change in vdsm[master]: vdsm-upgrade: use python scripts from ovirtnode

2012-08-22 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vdsm-upgrade: use python scripts from ovirtnode .. Patch Set 4: Looks good to me, but someone else must approve (1 inline comment)

Change in vdsm[master]: API: Provide a working getAllTasks API

2012-08-22 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: API: Provide a working getAllTasks API .. Patch Set 4: Have I really suggested this? Would it be possible to add server-side filtering semantics to this verb,

Change in vdsm[master]: BZ#833084 Set StoragePool.id to SPM_ID_FREE by default

2012-08-22 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: BZ#833084 Set StoragePool.id to SPM_ID_FREE by default .. BZ#833084 Set StoragePool.id to SPM_ID_FREE by default Setting the storage pool id to

Change in vdsm[master]: infra: adding debug log to vdsm daemon init script

2012-08-22 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: infra: adding debug log to vdsm daemon init script .. Patch Set 6: hmm, maybe I should have asked if using bash's -x and -v options is not helpful even more

Change in vdsm[master]: Move fencing logic out of API.py

2012-08-22 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Move fencing logic out of API.py .. Patch Set 2: (1 inline comment) File vdsm/API.py Line 994:

Change in vdsm[master]: Move fencing logic out of API.py

2012-08-22 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Move fencing logic out of API.py .. Patch Set 4: I would prefer that you didn't submit this (1 inline comment)

Change in vdsm[master]: vdsm: improve message when trying to attach import domain wi...

2012-08-23 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vdsm: improve message when trying to attach import domain with wrong permissions (#842146) .. Patch Set 5: (1 inline comment)

Change in vdsm[master]: BZ#846004 - IP on nic/bond should be preserved when VLAN add...

2012-08-23 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: BZ#846004 - IP on nic/bond should be preserved when VLAN added .. BZ#846004 - IP on nic/bond should be preserved when VLAN added Change-Id:

Change in vdsm[master]: BZ#846004 - IP on nic/bond should be preserved when VLAN add...

2012-08-23 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: BZ#846004 - IP on nic/bond should be preserved when VLAN added .. Patch Set 7: Verified; Looks good to me, approved -- To view, visit

Change in vdsm[master]: Restore previous MTU on bond when VLAN with bigger MTU remov...

2012-08-23 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Restore previous MTU on bond when VLAN with bigger MTU removed .. Patch Set 4: Verified; Looks good to me, approved -- To view, visit

Change in vdsm[master]: Restore previous MTU on bond when VLAN with bigger MTU remov...

2012-08-23 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: Restore previous MTU on bond when VLAN with bigger MTU removed .. Restore previous MTU on bond when VLAN with bigger MTU removed Change-Id:

Change in vdsm[master]: configNetwork: use MTU as int in setNewMtu

2012-08-23 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: configNetwork: use MTU as int in setNewMtu .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/7360 To unsubscribe, visit

Change in vdsm[master]: libvirtvm: unsetPortMirroring just before hotunplug

2012-08-23 Thread danken
Dan Kenigsberg has uploaded a new change for review. Change subject: libvirtvm: unsetPortMirroring just before hotunplug .. libvirtvm: unsetPortMirroring just before hotunplug Change-Id:

Change in vdsm[master]: tc: add to PEP8_WHITELIST

2012-08-23 Thread danken
Dan Kenigsberg has uploaded a new change for review. Change subject: tc: add to PEP8_WHITELIST .. tc: add to PEP8_WHITELIST Change-Id: I1b3b1d8de08ea8fac5cd3debb53f22d7a7a8ad87 Signed-off-by: Dan Kenigsberg dan...@redhat.com

Change in vdsm[master]: Use quiesce only if qgaEnable is enabled

2012-08-23 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: Use quiesce only if qgaEnable is enabled .. Use quiesce only if qgaEnable is enabled Do not attempt to use the quiesce live snapshot flag if the guest

Change in vdsm[master]: tc: make TCException more accessible programmatically

2012-08-23 Thread danken
Dan Kenigsberg has uploaded a new change for review. Change subject: tc: make TCException more accessible programmatically .. tc: make TCException more accessible programmatically Change-Id:

Change in vdsm[master]: tc: silently ignore ingress qdisc re-creation

2012-08-23 Thread danken
Dan Kenigsberg has uploaded a new change for review. Change subject: tc: silently ignore ingress qdisc re-creation .. tc: silently ignore ingress qdisc re-creation We should allow starting up two VMs monitorring a single

Change in vdsm[master]: vdsm-upgrade: use python scripts from ovirtnode

2012-08-23 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vdsm-upgrade: use python scripts from ovirtnode .. Patch Set 4: Looks good to me, approved Thanks, Joey Douglas. -- To view, visit

Change in vdsm[master]: vdsm-upgrade: use python scripts from ovirtnode

2012-08-23 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: vdsm-upgrade: use python scripts from ovirtnode .. vdsm-upgrade: use python scripts from ovirtnode Replace /usr/libexec/ovirt-config-boot call from

Change in vdsm[master]: tc: make TCException more accessible programmatically

2012-08-23 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: tc: make TCException more accessible programmatically .. tc: make TCException more accessible programmatically Change-Id:

Change in vdsm[master]: Added xml option in gluster command execution.

2012-08-23 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Added xml option in gluster command execution. .. Patch Set 3: I would prefer that you didn't submit this -- To view, visit http://gerrit.ovirt.org/6999 To

Change in vdsm[master]: tc: Fix make rpm for filter tests.

2012-08-23 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: tc: Fix make rpm for filter tests. .. Patch Set 2: (1 inline comment) File tests/Makefile.am Line 50:

Change in vdsm[master]: infra: adding debug log to vdsm daemon init script

2012-08-23 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: infra: adding debug log to vdsm daemon init script .. Patch Set 7: I would prefer that you didn't submit this I think it would be nice if you not only define

Change in vdsm[master]: infra: adding debug log to vdsm daemon init script

2012-08-23 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: infra: adding debug log to vdsm daemon init script .. Patch Set 7: but really. please explain the motivation of this. why running the script with -xv is not

Change in vdsm[master]: tc: Fix make rpm for filter tests.

2012-08-23 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: tc: Fix make rpm for filter tests. .. Patch Set 3: Looks good to me, approved Thanks! -- To view, visit http://gerrit.ovirt.org/7442 To unsubscribe, visit

Change in vdsm[master]: tc: Fix make rpm for filter tests.

2012-08-23 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: tc: Fix make rpm for filter tests. .. tc: Fix make rpm for filter tests. Change-Id: Idb3cee09f16202f4e69728b5aaf36e54f39e8d82 Signed-off-by: Antoni S.

Change in vdsm[master]: tc: silently ignore ingress qdisc re-creation

2012-08-23 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: tc: silently ignore ingress qdisc re-creation .. Patch Set 2: Verified; Looks good to me, approved After that it is approved. -- To view, visit

Change in vdsm[master]: tc: silently ignore ingress qdisc re-creation

2012-08-23 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: tc: silently ignore ingress qdisc re-creation .. tc: silently ignore ingress qdisc re-creation We should allow starting up two VMs monitoring a single

Change in vdsm[master]: tc: rename qdisc_replace_prio()

2012-08-23 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: tc: rename qdisc_replace_prio() .. Patch Set 5: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7300 To unsubscribe, visit

Change in vdsm[master]: tc: rename qdisc_replace_prio()

2012-08-23 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: tc: rename qdisc_replace_prio() .. tc: rename qdisc_replace_prio() This funciton replaces a PRIO qdisc. Let us call it accordingly Change-Id:

Change in vdsm[master]: tc: add to PEP8_WHITELIST

2012-08-23 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: tc: add to PEP8_WHITELIST .. Patch Set 1: I would prefer that you didn't submit this yes... I'm afraid that something fishy is going on with this topic branch

Change in vdsm[master]: Sort the pep8 whitelist list

2012-08-23 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: Sort the pep8 whitelist list .. Sort the pep8 whitelist list Change-Id: I86982eb9eb0ce2ae6a671af0be209f021e72 Signed-off-by: Saggi Mizrahi

Change in vdsm[master]: Sort the pep8 whitelist list

2012-08-23 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Sort the pep8 whitelist list .. Patch Set 13: Looks good to me, approved The commit message is now wrong, but this little patch annoyed us enough. -- To view,

Change in vdsm[master]: Ship the version file with the tarballs

2012-08-24 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Ship the version file with the tarballs .. Patch Set 3: Verified; Looks good to me, approved Thanks, Federico! -- To view, visit http://gerrit.ovirt.org/7295

Change in vdsm[master]: API: Provide a working getAllTasks API

2012-08-24 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: API: Provide a working getAllTasks API .. API: Provide a working getAllTasks API Changes since last iteration: - Dropped 'tags' filtering from the

Change in vdsm[master]: API: Provide a working getAllTasks API

2012-08-24 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: API: Provide a working getAllTasks API .. Patch Set 4: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3613 To unsubscribe, visit

Change in vdsm[master]: add server_once for CrabRPCServer

2012-08-24 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: add server_once for CrabRPCServer .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7452 To

Change in vdsm[master]: tcTests: test port-mirroring while another device is watchin...

2012-08-24 Thread danken
Dan Kenigsberg has uploaded a new change for review. Change subject: tcTests: test port-mirroring while another device is watching .. tcTests: test port-mirroring while another device is watching Change-Id:

Change in vdsm[master]: configNet: introduce ConfigWriter.restorePersistentBackup()

2012-08-26 Thread danken
Dan Kenigsberg has uploaded a new change for review. Change subject: configNet: introduce ConfigWriter.restorePersistentBackup() .. configNet: introduce ConfigWriter.restorePersistentBackup() restorePersistentBackup is to be

Change in vdsm[master]: configNet: introduce ConfigWriter.restorePersistentBackup()

2012-08-26 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: configNet: introduce ConfigWriter.restorePersistentBackup() .. Patch Set 2: Verified I've verified that it has no functional side effects on Vdsm, and makes

Change in vdsm[master]: configNet: introduce ConfigWriter.restorePersistentBackup()

2012-08-26 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: configNet: introduce ConfigWriter.restorePersistentBackup() .. configNet: introduce ConfigWriter.restorePersistentBackup() restorePersistentBackup is

Change in vdsm[master]: BZ#846312 - Keep MTU on ehtX after bond editing, when ethX p...

2012-08-26 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: BZ#846312 - Keep MTU on ehtX after bond editing, when ethX part of this bond .. Patch Set 2: Looks good to me, approved -- To view, visit

Change in vdsm[master]: configNet: grant proper selinux context to ifcfg-*

2012-08-26 Thread danken
Dan Kenigsberg has uploaded a new change for review. Change subject: configNet: grant proper selinux context to ifcfg-* .. configNet: grant proper selinux context to ifcfg-* Bug-Id: BZ#838347 Change-Id:

Change in vdsm[master]: BZ#846312 - Keep MTU on ehtX after bond editing, when ethX p...

2012-08-26 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: BZ#846312 - Keep MTU on ehtX after bond editing, when ethX part of this bond .. BZ#846312 - Keep MTU on ehtX after bond editing, when ethX part of

Change in vdsm[master]: BZ#846312 - Keep max MTU when adding non-VLANed bridgeless n...

2012-08-26 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: BZ#846312 - Keep max MTU when adding non-VLANed bridgeless network .. Patch Set 1: Looks good to me, approved hmm, was the original and vlan a premature

Change in vdsm[master]: configNet: grant proper selinux context to ifcfg-*

2012-08-27 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: configNet: grant proper selinux context to ifcfg-* .. Patch Set 1: (2 inline comments) File

Change in vdsm[master]: BZ#846312 - Keep max MTU when adding non-VLANed bridgeless n...

2012-08-27 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: BZ#846312 - Keep max MTU when adding non-VLANed bridgeless network .. BZ#846312 - Keep max MTU when adding non-VLANed bridgeless network Change-Id:

Change in vdsm[master]: add server_once for CrabRPCServer

2012-08-27 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: add server_once for CrabRPCServer .. Patch Set 1: Looks good to me, approved Change seems simple enough. I suppose it is fine if I take it with only my own

Change in vdsm[master]: add server_once for CrabRPCServer

2012-08-27 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: add server_once for CrabRPCServer .. add server_once for CrabRPCServer server_once is convenient for integrating CrabRPCServer into the event loop of

Change in vdsm[master]: Define network filter on libvirt

2012-08-27 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Define network filter on libvirt .. Patch Set 4: I would prefer that you didn't submit this (2 inline comments) only the tuple thingy is a must-fix.

Change in vdsm[master]: improve message when trying to attach import domain with wro...

2012-08-27 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: improve message when trying to attach import domain with wrong permissions .. improve message when trying to attach import domain with wrong

Change in vdsm[master]: Libvirt service engagement workaround

2012-08-27 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Libvirt service engagement workaround .. Patch Set 3: No score (1 inline comment) File vdsm/vdsmd.init.in

  1   2   3   4   5   6   7   8   9   10   >