Liron Aravot has posted comments on this change.
Change subject: VDSM: Fix VDSM error message.
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9355
To unsubscribe,
Liron Ar has posted comments on this change.
Change subject: Adding [start|stop]MonitoringDomain().
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/19762
To unsubscribe, visit
Liron Ar has posted comments on this change.
Change subject: vm: pre-validate disks for snapshot
..
Patch Set 4:
(2 comments)
File vdsm/vm.py
Line 3704:
Liron Ar has posted comments on this change.
Change subject: vm: pre-validate disks for snapshot
..
Patch Set 5:
(1 comment)
File vdsm/vm.py
Line 3712: for
Liron Ar has posted comments on this change.
Change subject: domainMonitor: Separate change detection from lastCheck value
..
Patch Set 3:
(1 comment)
File
Liron Ar has posted comments on this change.
Change subject: domainMonitor: Rename confusing lastCheck variable
..
Patch Set 1: Code-Review+1
perhaps change to checkTime
--
To view, visit http://gerrit.ovirt.org/21879
To
Liron Ar has posted comments on this change.
Change subject: domainMonitor: Separate change detection from lastCheck value
..
Patch Set 3:
(1 comment)
File
Liron Ar has posted comments on this change.
Change subject: domainMonitor: Rename confusing lastCheck variable
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21879
To unsubscribe, visit
Liron Ar has posted comments on this change.
Change subject: domainMonitor: Separate change detection from lastCheck value
..
Patch Set 4: Code-Review-1
marking -1 just so that my comment on the previous patchset will be seen.
Liron Ar has posted comments on this change.
Change subject: domainMonitor: Separate change detection from lastCheck value
..
Patch Set 4:
Let's wait for other opinions with it.
The -1 isn't for blocking the change, but to
Liron Ar has posted comments on this change.
Change subject: domainMonitor: Separate change detection from lastCheck value
..
Patch Set 4:
just to clarify - my -1 is just so a maintainer will see my comment in
Liron Ar has posted comments on this change.
Change subject: domainMonitor: Separate change detection from lastCheck value
..
Patch Set 5:
(1 comment)
File
Liron Ar has posted comments on this change.
Change subject: domainMonitor: Separate change detection from lastCheck value
..
Patch Set 5: Code-Review+1
(1 comment)
File
Liron Ar has posted comments on this change.
Change subject: vdsm: Add an exception for wrong master version.
..
Patch Set 3:
(1 comment)
File
Liron Ar has posted comments on this change.
Change subject: vdsm: Add an exception for wrong master version.
..
Patch Set 3: Code-Review-1
--
To view, visit http://gerrit.ovirt.org/21175
To unsubscribe, visit
Liron Ar has posted comments on this change.
Change subject: vdsm: Add an exception for wrong master version.
..
Patch Set 3:
(1 comment)
File
Liron Ar has uploaded a new change for review.
Change subject: deactivateSD - perform nothing if the domain is already
deactivated
..
deactivateSD - perform nothing if the domain is already deactivated
When calling
Liron Ar has abandoned this change.
Change subject: deactivateSD - perform nothing if the domain is already
deactivated
..
Abandoned
making related change/checks. will restore later.
--
To view, visit
Liron Ar has uploaded a new change for review.
Change subject: downloadstream
..
downloadstream
Change-Id: I85bc63365273adf306c73ef1de7fea578ec42662
Signed-off-by: Liron Aravot lara...@redhat.com
---
M vdsm/API.py
M
Liron Ar has uploaded a new change for review.
Change subject: utils
..
utils
Change-Id: Icbd049360a02ae98fa21756dc734c1da8ac3d11a
Signed-off-by: Liron Aravot lara...@redhat.com
---
M lib/vdsm/utils.py
1 file changed, 26
Liron Ar has abandoned this change.
Change subject: introducing downloadImageFromStream
..
Abandoned
--
To view, visit http://gerrit.ovirt.org/23281
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType:
Liron Ar has uploaded a new change for review.
Change subject: introducing downloadImageFromStream
..
introducing downloadImageFromStream
This patch introduces the downloadImageFromStream verb in vdsm which
allows to upload
Liron Ar has restored this change.
Change subject: introducing downloadImageFromStream
..
Restored
--
To view, visit http://gerrit.ovirt.org/23281
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType:
Liron Ar has abandoned this change.
Change subject: introducing downloadImageFromStream
..
Abandoned
making related changes, will return.
--
To view, visit http://gerrit.ovirt.org/23281
To unsubscribe, visit
Liron Ar has posted comments on this change.
Change subject: introducing downloadImageFromStream
..
Patch Set 1:
(36 comments)
http://gerrit.ovirt.org/#/c/23281/1//COMMIT_MSG
Commit Message:
Line 10: allows to upload using
Liron Ar has restored this change.
Change subject: introducing downloadImageFromStream
..
Restored
--
To view, visit http://gerrit.ovirt.org/23281
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType:
Liron Ar has posted comments on this change.
Change subject: introducing downloadFromStream verb
..
Patch Set 4:
(15 comments)
http://gerrit.ovirt.org/#/c/23281/4//COMMIT_MSG
Commit Message:
Line 6:
Line 7: introducing
Liron Ar has posted comments on this change.
Change subject: introducing downloadFromStream verb
..
Patch Set 5:
(6 comments)
http://gerrit.ovirt.org/#/c/23281/5//COMMIT_MSG
Commit Message:
Line 11: XML-RPC spec doesn't
Liron Ar has posted comments on this change.
Change subject: introducing downloadFromStream verb
..
Patch Set 4:
(3 comments)
http://gerrit.ovirt.org/#/c/23281/4//COMMIT_MSG
Commit Message:
Line 7: introducing
Liron Aravot has posted comments on this change.
Change subject: Handle and store serial to guest device names mapping
..
Patch Set 2:
(2 comments)
http://gerrit.ovirt.org/#/c/31497/2/vdsm/virt/guestagent.py
File
Liron Aravot has posted comments on this change.
Change subject: Handle and store serial to guest device names mapping
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/31497/3/vdsm/virt/guestagent.py
File
Liron Aravot has uploaded a new change for review.
Change subject: vm: return diskMapping on status()
..
vm: return diskMapping on status()
status() is used by API.Global.getVMList and should return also the disk
mapping
Liron Aravot has uploaded a new change for review.
Change subject: vm, guestagent: return hash should include also the disk mapping
..
vm, guestagent: return hash should include also the disk mapping
Change-Id:
Liron Aravot has posted comments on this change.
Change subject: vm: return diskMapping on status()
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/31700/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 2435:
Liron Aravot has posted comments on this change.
Change subject: Handle and store serial to guest device names mapping
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/31497
To unsubscribe, visit
Liron Aravot has posted comments on this change.
Change subject: vm, guestagent: hash to include also the disk mapping
..
Patch Set 3:
(3 comments)
http://gerrit.ovirt.org/#/c/31701/3/vdsm/virt/guestagent.py
File
Liron Aravot has posted comments on this change.
Change subject: vm, guestagent: hash to include also the disk mapping
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/31701/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Liron Aravot has posted comments on this change.
Change subject: vm, guestagent: hash to include also the disk mapping
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/31701/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Liron Aravot has posted comments on this change.
Change subject: vm, guestagent: hash to include also the disk mapping
..
Patch Set 3:
(2 comments)
http://gerrit.ovirt.org/#/c/31701/3/vdsm/virt/guestagent.py
File
Liron Aravot has posted comments on this change.
Change subject: vm, guestagent: hash to include also the disk mapping
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/31701/3/vdsm/virt/guestagent.py
File
Liron Aravot has posted comments on this change.
Change subject: vm: return diskMapping on status()
..
Patch Set 2:
Francesco, changed to guestDiskMapping. I've also added that to the schema.
thanks.
--
To view, visit
Liron Aravot has posted comments on this change.
Change subject: vm: return diskMapping on status()
..
Patch Set 2:
(3 comments)
http://gerrit.ovirt.org/#/c/31700/2/vdsm/rpc/vdsmapi-schema.json
File
Liron Aravot has posted comments on this change.
Change subject: vm, guestagent: return hash should include also the disk mapping
..
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/31701/4/vdsm/virt/guestagent.py
File
Liron Aravot has posted comments on this change.
Change subject: vm, guestagent: return hash should include also the disk mapping
..
Patch Set 5:
Done
--
To view, visit http://gerrit.ovirt.org/31701
To unsubscribe, visit
Liron Aravot has posted comments on this change.
Change subject: vm, guestagent: return hash should include also the disk mapping
..
Patch Set 9: Verified+1
--
To view, visit http://gerrit.ovirt.org/31701
To unsubscribe,
Liron Aravot has posted comments on this change.
Change subject: vm: return diskMapping on status()
..
Patch Set 5: Verified+1
--
To view, visit http://gerrit.ovirt.org/31700
To unsubscribe, visit
Liron Aravot has posted comments on this change.
Change subject: vm: return diskMapping on status()
..
Patch Set 5:
(1 comment)
@Nir - see the comment to Dan here.
http://gerrit.ovirt.org/#/c/31700/5//COMMIT_MSG .
Liron Aravot has posted comments on this change.
Change subject: vm: return diskMapping on status()
..
Patch Set 5:
(1 comment)
Michal, I'm favouring the approach of keeping it as simple as we can.
The devices are returned
Liron Aravot has posted comments on this change.
Change subject: vm: return diskMapping on status()
..
Patch Set 6: Verified+1
On the last patch only vdsmapi-schema.json was updated, therefore marking as
verified.
--
To
Liron Aravot has posted comments on this change.
Change subject: vm: return diskMapping on status()
..
Patch Set 6:
(4 comments)
http://gerrit.ovirt.org/#/c/31700/6/vdsm/rpc/vdsmapi-schema.json
File
Liron Aravot has posted comments on this change.
Change subject: vm: return diskMapping on status()
..
Patch Set 9: Verified+1
--
To view, visit http://gerrit.ovirt.org/31700
To unsubscribe, visit
Liron Aravot has uploaded a new change for review.
Change subject: vm: return diskMapping on status()
..
vm: return diskMapping on status()
status() is used by API.Global.getVMList and should return also the disk
mapping
Liron Aravot has uploaded a new change for review.
Change subject: vm, guestagent: return hash should include also the disk mapping
..
vm, guestagent: return hash should include also the disk mapping
Change-Id:
Liron Aravot has posted comments on this change.
Change subject: vm: return diskMapping on status()
..
Patch Set 10: Verified+1
--
To view, visit http://gerrit.ovirt.org/31700
To unsubscribe, visit
Liron Aravot has posted comments on this change.
Change subject: vm, guestagent: return hash should include also the disk mapping
..
Patch Set 14: Verified+1
--
To view, visit http://gerrit.ovirt.org/31701
To unsubscribe,
Liron Aravot has posted comments on this change.
Change subject: vm: return diskMapping on status()
..
Patch Set 6: Verified+1
--
To view, visit http://gerrit.ovirt.org/33197
To unsubscribe, visit
Liron Aravot has posted comments on this change.
Change subject: vm, guestagent: return hash should include also the disk mapping
..
Patch Set 7: Verified+1
--
To view, visit http://gerrit.ovirt.org/33198
To unsubscribe,
Liron Aravot has posted comments on this change.
Change subject: vm, guestagent: return hash should include also the disk mapping
..
Patch Set 8: Verified+1
--
To view, visit http://gerrit.ovirt.org/33198
To unsubscribe,
Liron Aravot has posted comments on this change.
Change subject: vm: return diskMapping on status()
..
Patch Set 7: Verified+1
--
To view, visit http://gerrit.ovirt.org/33197
To unsubscribe, visit
Liron Aravot has posted comments on this change.
Change subject: tests: assertIsNone is not available on Python 2.6
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/34497
To unsubscribe, visit
Liron Aravot has uploaded a new change for review.
Change subject: schema: fix guest disk mapping versioning
..
schema: fix guest disk mapping versioning
The guest disk mapping report feature is being merged to the ovirt-3.5
Liron Aravot has posted comments on this change.
Change subject: vm: return diskMapping on status()
..
Patch Set 8: Verified+1
--
To view, visit http://gerrit.ovirt.org/33197
To unsubscribe, visit
Liron Aravot has posted comments on this change.
Change subject: schema: fix guest disk mapping versioning
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/34636
To unsubscribe, visit
Liron Ar has posted comments on this change.
Change subject: vm: add the transient disk support
..
Patch Set 8:
(1 comment)
File lib/vdsm/tool/transient.py
Line 63:
Liron Ar has posted comments on this change.
Change subject: introducing downloadFromStream verb
..
Patch Set 7:
(6 comments)
http://gerrit.ovirt.org/#/c/23281/7/vdsm/BindingXMLRPC.py
File vdsm/BindingXMLRPC.py:
Line 28:
Liron Ar has posted comments on this change.
Change subject: introducing downloadFromStream verb
..
Patch Set 7:
(6 comments)
http://gerrit.ovirt.org/#/c/23281/7/vdsm/BindingXMLRPC.py
File vdsm/BindingXMLRPC.py:
Line 144:
Liron Ar has abandoned this change.
Change subject: introducing downloadFromStream verb
..
Abandoned
I've thought about problematic scenario,
abandoning and will re-upload it.
--
To view, visit http://gerrit.ovirt.org/23281
Liron Ar has restored this change.
Change subject: introducing downloadFromStream verb
..
Restored
--
To view, visit http://gerrit.ovirt.org/23281
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType:
Liron Ar has posted comments on this change.
Change subject: introducing downloadFromStream verb
..
Patch Set 8:
(6 comments)
http://gerrit.ovirt.org/#/c/23281/8//COMMIT_MSG
Commit Message:
Line 3: AuthorDate: 2014-01-12
Liron Ar has posted comments on this change.
Change subject: xmlrpc: Use correct base class for parsing request
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/24289
To unsubscribe, visit
Liron Ar has posted comments on this change.
Change subject: introducing capabillity to stream data to image
..
Patch Set 9:
(5 comments)
http://gerrit.ovirt.org/#/c/23281/9//COMMIT_MSG
Commit Message:
Line 30: today for
Liron Ar has posted comments on this change.
Change subject: introducing capability to stream data to image
..
Patch Set 10:
(2 comments)
http://gerrit.ovirt.org/#/c/23281/10/vdsm/storage/imageSharing.py
File
Liron Ar has posted comments on this change.
Change subject: introducing capability to stream data to image
..
Patch Set 11:
(1 comment)
http://gerrit.ovirt.org/#/c/23281/11/vdsm/BindingXMLRPC.py
File vdsm/BindingXMLRPC.py:
Liron Ar has posted comments on this change.
Change subject: introducing capability to stream data to image
..
Patch Set 12:
@Nir, the failure doesn't seem related to this patch - take a look here.
we should look at this
Liron Ar has posted comments on this change.
Change subject: introducing capability to stream data to image
..
Patch Set 12:
(1 comment)
http://gerrit.ovirt.org/#/c/23281/12/vdsm/storage/imageSharing.py
File
Liron Ar has posted comments on this change.
Change subject: introducing capability to stream data to image
..
Patch Set 13: Verified+1
verified - tested upload of 1000 ovfs, both ISCSI and NFS. vdsm - rhel 6.5,
engine - rhel
Hello Nir Soffer, Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/24597
to review the following change.
Change subject: introducing capability to stream data to image
..
introducing
Liron Ar has posted comments on this change.
Change subject: introducing capability to stream data to image
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/24597
To unsubscribe, visit
Liron Ar has posted comments on this change.
Change subject: vm: snapshot transient disk check should be per disk
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/24867/2/vdsm/vm.py
File vdsm/vm.py:
Line 3955:
Liron Ar has posted comments on this change.
Change subject: vm: snapshot transient disk check should be per disk
..
Patch Set 2: Code-Review-1
--
To view, visit http://gerrit.ovirt.org/24867
To unsubscribe, visit
Liron Ar has posted comments on this change.
Change subject: vm: snapshot transient disk check should be per disk
..
Patch Set 2: -Code-Review
--
To view, visit http://gerrit.ovirt.org/24867
To unsubscribe, visit
Liron Ar has posted comments on this change.
Change subject: resourceManager: Keep resource state if registerResource fails
..
Patch Set 1:
(4 comments)
http://gerrit.ovirt.org/#/c/25284/1/tests/resourceManagerTests.py
File
Liron Ar has posted comments on this change.
Change subject: resourceManager: Keep resource state if registerResource fails
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/25284/1/vdsm/storage/resourceManager.py
File
Liron Ar has posted comments on this change.
Change subject: resourceManager: Keep resource state if registerResource fails
..
Patch Set 2:
(6 comments)
http://gerrit.ovirt.org/#/c/25284/2/tests/resourceManagerTests.py
File
Liron Ar has posted comments on this change.
Change subject: resourceManager: Keep resource state if registerResource fails
..
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/25284/4/tests/resourceManagerTests.py
File
Liron Ar has uploaded a new change for review.
Change subject: sp: fix spm start when failing to produce domain
..
sp: fix spm start when failing to produce domain
During spmStart we attept to go over all the domains and set
Liron Ar has posted comments on this change.
Change subject: resourceManager: Keep resource state if registerResource fails
..
Patch Set 4: Code-Review+1
(1 comment)
Liron Ar has posted comments on this change.
Change subject: sp: fix spm start when failing to produce domain
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/25424/2/vdsm/storage/sp.py
File vdsm/storage/sp.py:
Line
Liron Ar has posted comments on this change.
Change subject: sp: fix spm start when failing to produce domain
..
Patch Set 2:
(2 comments)
http://gerrit.ovirt.org/#/c/25424/2/vdsm/storage/sp.py
File vdsm/storage/sp.py:
Line
Liron Ar has posted comments on this change.
Change subject: sp: fix spm start when failing to produce domain
..
Patch Set 2:
(3 comments)
http://gerrit.ovirt.org/#/c/25424/2/vdsm/storage/sp.py
File vdsm/storage/sp.py:
Line
Liron Ar has posted comments on this change.
Change subject: sp: fix spm start when failing to produce domain
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/25424/2/vdsm/storage/sp.py
File vdsm/storage/sp.py:
Line
Liron Ar has uploaded a new change for review.
Change subject: core: fixing attribute error on fenceSpmStorage
..
core: fixing attribute error on fenceSpmStorage
In change I75493d1db60e51cccd5231b516f963c970d24c99 the pool
Liron Ar has abandoned this change.
Change subject: core: fixing attribute error on fenceSpmStorage
..
Abandoned
--
To view, visit http://gerrit.ovirt.org/26357
To unsubscribe, visit http://gerrit.ovirt.org/settings
Liron Ar has uploaded a new change for review.
Change subject: core: fixing attribute error on fenceSpmStorage
..
core: fixing attribute error on fenceSpmStorage
In change I75493d1db60e51cccd5231b516f963c970d24c99 the pool
Liron Ar has posted comments on this change.
Change subject: core: fixing attribute error on fenceSpmStorage
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/26358/1/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:
Line
Liron Ar has uploaded a new change for review.
Change subject: core: introducing retrieveImage
..
core: introducing retrieveImage
Adding retrieveImage verb which allows to upload image data from vdsm
to the requester over HTTP.
Liron Ar has uploaded a new change for review.
Change subject: imageSharing - exporting logic to external methods
..
imageSharing - exporting logic to external methods
In the following patch logic is being exported
Liron Ar has uploaded a new change for review.
Change subject: core: refactor in BindingXMLRPC
..
core: refactor in BindingXMLRPC
moved logic from do_PUT to methods.
Change-Id: I64bb1b0a4cb85ce822929f1907847dd63eb69fc2
Liron Ar has uploaded a new change for review.
Change subject: core: renaming streamDownloadImage methods to generic names
..
core: renaming streamDownloadImage methods to generic names
renaming streamDownloadImage to
Liron Ar has uploaded a new change for review.
Change subject: core: removal of unneeded callback passing
..
core: removal of unneeded callback passing
The callback can be executed from sp.py after completing the operation,
1 - 100 of 392 matches
Mail list logo
