Michal Skrivanek has posted comments on this change.
Change subject: add simple VM creation functional test
..
Patch Set 1: Looks good to me, but someone else must approve
(3 inline comments
Michal Skrivanek has posted comments on this change.
Change subject: add simple VM creation functional test
..
Patch Set 1: No score
(1 inline comment)
File tests
Michal Skrivanek has posted comments on this change.
Change subject: BZ#734847- vdsmd always restarts libvirtd upon start-up
..
Patch Set 9: (2 inline comments)
File vdsm
Michal Skrivanek has posted comments on this change.
Change subject: Change waitForMigrationDestinationPrepare function waiting.
..
Patch Set 1: (1 inline comment)
File vdsm
Michal Skrivanek has posted comments on this change.
Change subject: BZ#734847- vdsmd always restarts libvirtd upon start-up
..
Patch Set 10: Looks good to me, but someone else must approve
--
To view, visit http
Michal Skrivanek has posted comments on this change.
Change subject: BZ#734847- vdsmd always restarts libvirtd upon start-up
..
Patch Set 12: Looks good to me, but someone else must approve
--
To view, visit http
Michal Skrivanek has posted comments on this change.
Change subject: Change waitForMigrationDestinationPrepare function waiting.
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http
Michal Skrivanek has uploaded a new change for review.
Change subject: converting some more RH strings to oVirt
..
converting some more RH strings to oVirt
Change-Id: I2fe916e591e2d998f30c997e0af907db776dad62
Signed-off
Michal Skrivanek has abandoned this change.
Change subject: converting some more RH strings to oVirt
..
Patch Set 1: Abandoned
--
To view, visit http://gerrit.ovirt.org/7920
To unsubscribe, visit http://gerrit.ovirt.org
Michal Skrivanek has posted comments on this change.
Change subject: converting some more RH strings to oVirt
..
Patch Set 1: (2 inline comments)
File vdsm/libvirtvm.py
Line
Michal Skrivanek has posted comments on this change.
Change subject: Factor betterThreading out of Vdsm
..
Patch Set 1: Looks good to me, but someone else must approve
does it perhaps deserve a comment
Michal Skrivanek has posted comments on this change.
Change subject: converting some more RH strings to oVirt
..
Patch Set 6: (1 inline comment)
File vdsm/constants.py.in
Michal Skrivanek has posted comments on this change.
Change subject: fix dataProgress of migration
..
Patch Set 3: (1 inline comment)
one minor comment to fix, please
File
Michal Skrivanek has posted comments on this change.
Change subject: fix dataProgress of migration
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7914
To unsubscribe
Michal Skrivanek has posted comments on this change.
Change subject: BZ#781975 VM creation concurrency limit
..
Patch Set 1: (1 inline comment)
File vdsm/vm.py
Line 259
Michal Skrivanek has posted comments on this change.
Change subject: BZ#781975 VM creation concurrency limit
..
Patch Set 1: I would prefer that you didn't submit this
commit msg: multy-threaded - !
--
To view, visit http
Michal Skrivanek has uploaded a new change for review.
Change subject: Bug 852956 - 3.1 - prepareForShutdown is not called when
connection to libvirt is broken with event: libvirtError: internal error client
socket is closed add few more error codes from libvirt's virsh code
Michal Skrivanek has posted comments on this change.
Change subject: BZ#781975 VM creation concurrency limit
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8295
Michal Skrivanek has posted comments on this change.
Change subject: libvirtconnection: retry opening a libvirt connection
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http
Michal Skrivanek has posted comments on this change.
Change subject: Fix a bug in the naming convertion of cpu feature 'sse4_x'
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http
Michal Skrivanek has posted comments on this change.
Change subject: BZ#867439 VM unexpectedly was shutdown after migration.
..
Patch Set 1: (1 inline comment)
Commit
Michal Skrivanek has posted comments on this change.
Change subject: BZ#867439 VM unexpectedly was shutdown after migration.
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment
Michal Skrivanek has posted comments on this change.
Change subject: BZ#867439 VM unexpectedly was shutdown after migration.
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http
Michal Skrivanek has posted comments on this change.
Change subject: Added a support for a guest hibernate command.
..
Patch Set 8: I would prefer that you didn't submit this
please make the old behavior(migrate to file) still
Michal Skrivanek has posted comments on this change.
Change subject: Add an option to create a watchdog device.
..
Patch Set 12:
Are you following up with engine-side patch to get a proper support? Then the
hook can
Michal Skrivanek has posted comments on this change.
Change subject: Add an option to create a watchdog device.
..
Patch Set 13: Looks good to me, but someone else must approve
My only concern/question is about not filling
Michal Skrivanek has posted comments on this change.
Change subject: add createVm support of cputune
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8445
To unsubscribe
Michal Skrivanek has posted comments on this change.
Change subject: Added a support for a guest hibernate command.
..
Patch Set 9: (1 inline comment)
File vdsm/vm.py
Line
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: Attaching a console should be controllable
..
Patch Set 3:
true, but now that it becomes an engine managed device, question is if it
shouldn't
Michal Skrivanek has posted comments on this change.
Change subject: Integrate Smartcard support
..
Patch Set 17: Looks good to me, but someone else must approve
(3 inline comments
Michal Skrivanek has posted comments on this change.
Change subject: fix prepareVolumePath: BZ#843387, BZ#872961
..
Patch Set 8: Verified
Verified by Adolfo Gómez dkmas...@dkmon.com
--
To view, visit http://gerrit.ovirt.org
Michal Skrivanek has posted comments on this change.
Change subject: Integrate Smartcard support
..
Patch Set 21: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8450
To unsubscribe
Michal Skrivanek has posted comments on this change.
Change subject: vm.Vm._getUnderlyingDriveInfo: extract path of gluster disks
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/19950
To unsubscribe
Michal Skrivanek has posted comments on this change.
Change subject: vm.Vm._getUnderlyingDriveInfo: extract path of gluster disks
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/19949
To unsubscribe
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: Accents in the vm name break the migration
..
Patch Set 1:
(1 comment)
File vdsm/vm.py
Line 4876
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: pre-defined range for spice/vnc ports
..
Patch Set 2: Code-Review-1
see additional comments in the bug
--
To view, visit http://gerrit.ovirt.org
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: move balloon logic out of buildConfDevices
..
Patch Set 4:
(1 comment)
File vdsm/vm.py
Line 1936
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: support VIR_MIGRATE_ABORT_ON_ERROR
..
Patch Set 1:
then it would be the engine's problem. from vdsm point of view the code is
backward compatible
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: fix RTC offset
..
Patch Set 2:
(1 comment)
File vdsm/vm.py
Line 2264:
Line 2265: def
Michal Skrivanek has posted comments on this change.
Change subject: Migration cancellation replies wrong message format
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21250
To unsubscribe, visit http
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: Reduce the migration progress timeout
..
Patch Set 4:
(1 comment)
File vdsm/vm.py
Line 747
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: Reduce the migration progress timeout
..
Patch Set 4:
(1 comment)
File vdsm/vm.py
Line 747
Michal Skrivanek has posted comments on this change.
Change subject: Revert xmlrpc: Parsing error logging enhancement - vdsClient
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21489
To unsubscribe
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: handle migration abort before semaphore acquiration
..
Patch Set 1:
(1 comment)
File vdsm/vm.py
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: Accents in the vm name break the migration
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/19684
To unsubscribe, visit http
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: handle migration abort before semaphore acquiration
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21445
To unsubscribe
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 33:
(1 comment)
File vdsm/vm.py
Line 1780: while
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: pre-defined range for spice/vnc ports
..
Patch Set 4: Code-Review+1
(1 comment)
File lib/vdsm
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: pre-defined range for spice/vnc ports
..
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/17058
To unsubscribe, visit http
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: pre-defined range for spice/vnc ports
..
Patch Set 5: Verified+1
Verified by: Vinzenz Feenstra. just commit message changed
--
To view, visit http
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: support VIR_MIGRATE_ABORT_ON_ERROR
..
Patch Set 1: Verified-1 Code-Review-1
Yes, this should be abandoned, I wonder who can do that….
--
To view
Michal Skrivanek has posted comments on this change.
Change subject: [WIP]add simple balloon functional testcase
..
Patch Set 2:
(1 comment)
File tests/functional
Michal Skrivanek has posted comments on this change.
Change subject: [WIP]add simple balloon functional testcase
..
Patch Set 2: Code-Review-1
this needs to be changed to conform with the changes in functional unit tests
Michal Skrivanek has posted comments on this change.
Change subject: add rollback to _runVMKernelBootTemplate
..
Patch Set 2: Code-Review-1
this needs to be changed according to functional tests refactoring done in
change-id
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 34:
(1 comment)
File vdsm/vm.py
Line 1747:
Line 1748
Michal Skrivanek has posted comments on this change.
Change subject: Introduce a maximum time limit a migration may take
..
Patch Set 1:
(3 comments)
I think we need more feedback to the questions I posted
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 35:
(1 comment)
File vdsm/vm.py
Line 1790
Michal Skrivanek has posted comments on this change.
Change subject: Get rid of legacy status 'Running'
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21766
To unsubscribe, visit http
Michal Skrivanek has posted comments on this change.
Change subject: Get rid of legacy status 'Running'
..
Patch Set 1:
I also think this should be removed immediately. It was not documented and in
any case you would have
Michal Skrivanek has posted comments on this change.
Change subject: Get rid of legacy status 'Running'
..
Patch Set 1:
(1 comment)
Commit Message
Line 6:
Line 7: Get rid
Michal Skrivanek has posted comments on this change.
Change subject: clientIF: Fix use of getConfDevices
..
Patch Set 2: Code-Review+1
ugh.
Yes, the tests should cover recovery. Well, The recovery should actually be
fixed
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: prepareVolumePath correct path handling for cdrom
..
Patch Set 6: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/20074
To unsubscribe, visit
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 35:
(1 comment)
File client/vdsClient.py
Line 1922
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 35:
(1 comment)
File vdsm/vm.py
Line 1725
Michal Skrivanek has posted comments on this change.
Change subject: vm: Fix exception when shutdown() called on vm in 'Down' state
..
Patch Set 1:
(1 comment)
File vdsm
Michal Skrivanek has posted comments on this change.
Change subject: vm: Fix exception when shutdown() called on vm in 'Down' state
..
Patch Set 1: Code-Review-1
(1 comment
Michal Skrivanek has posted comments on this change.
Change subject: Teardown only VDSM images when power-off VM
..
Patch Set 2: Code-Review-1
(2 comments)
Commit Message
Michal Skrivanek has posted comments on this change.
Change subject: Teardown only VDSM images when power-off VM
..
Patch Set 2:
(1 comment)
File vdsm/vm.py
Line 2537
Michal Skrivanek has posted comments on this change.
Change subject: Avoid going into 'Paused' status during long during migrations
..
Patch Set 1:
(1 comment)
File vdsm
Michal Skrivanek has posted comments on this change.
Change subject: vm: Fix exception when shutdown() called on vm in 'Down' state
..
Patch Set 1: Code-Review+1
(1 comment)
note this patch is going to be obsoleted by http
Michal Skrivanek has posted comments on this change.
Change subject: Avoid going into 'Paused' status during long during migrations
..
Patch Set 3:
(1 comment)
Commit
Michal Skrivanek has posted comments on this change.
Change subject: clientIF: Teardown volume path only for VDSM images
..
Patch Set 5:
I'd be for splitting as well. I think it needs to be carefully verified the
==disk check
Michal Skrivanek has posted comments on this change.
Change subject: tests: validate cdrom path sent to/received from vdsm
..
Patch Set 1:
(2 comments)
File tests
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: prepareVolumePath correct path handling for cdrom
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/22324
To unsubscribe, visit
Michal Skrivanek has posted comments on this change.
Change subject: clientIF: Teardown volume path only for VDSM images
..
Patch Set 5:
(1 comment)
File vdsm/clientIF.py
Michal Skrivanek has posted comments on this change.
Change subject: clientIF: Teardown volume path only for VDSM images
..
Patch Set 5:
(1 comment)
File vdsm/clientIF.py
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: add support for S3/S4 suspend calls
..
Patch Set 5: Code-Review-1
I think we have to run through the suspend hooks as well
--
To view, visit http
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: Reduce the migration progress timeout
..
Patch Set 4:
(1 comment)
File lib/vdsm/config.py.in
Line
Michal Skrivanek has posted comments on this change.
Change subject: Introduce a maximum time limit a migration may take
..
Patch Set 5:
(1 comment)
File lib/vdsm
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: Add support for Guest Reboot
..
Patch Set 1: Code-Review+1
ACPI can trigger a reboot too, but we can keep that for later…no need to change
now
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: Add support for Guest Reboot
..
Patch Set 1:
(1 comment)
File vdsm/guestIF.py
Line 302: def
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: Add support for Guest Reboot
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/22440
To unsubscribe, visit http
Michal Skrivanek has posted comments on this change.
Change subject: tests: janitorial: cleanup temporary directories.
..
Patch Set 2: Code-Review+1
Dan,
any comment to your -1?
--
To view, visit http://gerrit.ovirt.org
Michal Skrivanek has posted comments on this change.
Change subject: Introduce a maximum time limit a migration may take
..
Patch Set 7:
(1 comment)
File vdsm/vm.py
Line
Michal Skrivanek has posted comments on this change.
Change subject: tests: validate cdrom path sent to/received from vdsm
..
Patch Set 1:
(2 comments)
I'd like to see a follow-up test about vmPayload as well
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: Create VMs for the POWER architecture
..
Patch Set 9:
(2 comments)
File vdsm/vm.py
Line 1794
Michal Skrivanek has posted comments on this change.
Change subject: clientIF: Remove unnecessary device is disk check in
prepareVolumePath
..
Patch Set 2:
(1 comment
Michal Skrivanek has posted comments on this change.
Change subject: vm: Unify checks for vdsm image
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/22370
To unsubscribe, visit http://gerrit.ovirt.org
Michal Skrivanek has posted comments on this change.
Change subject: clientIF: Remove unnecessary device is disk check in
prepareVolumePath
..
Patch Set 2:
(1 comment
Michal Skrivanek has posted comments on this change.
Change subject: clientIF: Remove unnecessary device is disk check in
prepareVolumePath
..
Patch Set 2:
(1 comment
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: Create VMs for the POWER architecture
..
Patch Set 10: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/18718
To unsubscribe, visit http
Michal Skrivanek has posted comments on this change.
Change subject: [RFE] set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 15:
(1 comment)
File vdsm/vm.py
Line
Michal Skrivanek has posted comments on this change.
Change subject: [WIP]add simple balloon functional testcase
..
Patch Set 2:
(1 comment)
File tests/functional
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: Adding guest agent API versioning support
..
Patch Set 2:
(3 comments)
File vdsm/guestIF.py
Line
Michal Skrivanek has posted comments on this change.
Change subject: Rename migration_timeout to migration_downtime_delay
..
Patch Set 12:
(1 comment)
File vdsm/vm.py
Line
Michal Skrivanek has posted comments on this change.
Change subject: Rename migration_timeout to migration_downtime_delay
..
Patch Set 13: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/22421
To unsubscribe, visit
Michal Skrivanek has posted comments on this change.
Change subject: [RFE] set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 18:
(1 comment)
File vdsm/hooks.py
Michal Skrivanek has posted comments on this change.
Change subject: utils.py: Add hostUUID retrieval support for KVM on PPC64
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/8637
To unsubscribe, visit
Michal Skrivanek has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 19:
(1 comment)
File vdsm/vm.py
Line 895
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: fix RTC offset
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/14750
To unsubscribe, visit http://gerrit.ovirt.org/settings
1 - 100 of 799 matches
Mail list logo
