Nir Soffer has posted comments on this change.
Change subject: oop: improve safety for truncateFile
..
Patch Set 1: Code-Review+1
(7 comments)
The change is good and important, and having a test for this is even more
Nir Soffer has uploaded a new change for review.
Change subject: tests: refactor remoteFileHandler truncateFile tests
..
tests: refactor remoteFileHandler truncateFile tests
Old test was too big, causing one test to fail if the
Nir Soffer has posted comments on this change.
Change subject: tests: refactor remoteFileHandler truncateFile tests
..
Patch Set 3:
Remove nice empty line at end of file to make pep8 happy and unneeded print.
--
To view,
Nir Soffer has posted comments on this change.
Change subject: tests: refactor remoteFileHandler truncateFile tests
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/20084
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: tests: refactor remoteFileHandler truncateFile tests
..
Patch Set 4:
Address Allon comments
--
To view, visit http://gerrit.ovirt.org/20084
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: tests: refactor remoteFileHandler truncateFile tests
..
Patch Set 4: Verified+1
--
To view, visit http://gerrit.ovirt.org/20084
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: tests: Add Patch class for fixture monkey patching
..
Patch Set 2:
Waking up reviewers
--
To view, visit http://gerrit.ovirt.org/19881
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: tests: Add Patch class for fixture monkey patching
..
Patch Set 3: Verified+1
(1 comment)
Changes:
1. Refine commit message
2. Simplify complex test helper class
Nir Soffer has posted comments on this change.
Change subject: tests: Add Patch class for fixture monkey patching
..
Patch Set 4: Verified+1
Make pep8 happy
--
To view, visit http://gerrit.ovirt.org/19881
To unsubscribe,
Nir Soffer has uploaded a new change for review.
Change subject: logging: Add vdsm lvm log
..
logging: Add vdsm lvm log
LVM log is disabled by default, making it harder then it should to debug
lvm issues. This patch add lvm log
Nir Soffer has posted comments on this change.
Change subject: logging: Add vdsm lvm log
..
Patch Set 2:
Make pep8 happy
--
To view, visit http://gerrit.ovirt.org/20145
To unsubscribe, visit http://gerrit.ovirt.org/settings
Nir Soffer has posted comments on this change.
Change subject: logging: Add vdsm lvm log
..
Patch Set 3:
lvm log is the most useless and pathetic log I even seen. Adding command_names
= 1 may make it suck less.
--
To view,
Nir Soffer has posted comments on this change.
Change subject: logging: Add vdsm lvm log
..
Patch Set 4:
Use log level 3 (error), as level 4 (warning) is way too noisy.
--
To view, visit http://gerrit.ovirt.org/20145
To
Nir Soffer has posted comments on this change.
Change subject: Avoiding automatically restart of sanlock service when starting
vdsmd
..
Patch Set 13:
(1 comment)
Commit message title looks wrong
Nir Soffer has posted comments on this change.
Change subject: getIsoList() returns dict with files metadata
..
Patch Set 9:
(1 comment)
API version should be updated as master version was bumped to 4.13.0.
Nir Soffer has posted comments on this change.
Change subject: getIsoList() returns dict with files metadata
..
Patch Set 9:
(1 comment)
Reply
File
Nir Soffer has uploaded a new change for review.
Change subject: tests: Add monkey patching class decorator
..
tests: Add monkey patching class decorator
Using the new MonkeyClass decorator, you can do monkey patching during
Nir Soffer has posted comments on this change.
Change subject: tests: Add monkey patching class decorator
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/20175
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: Testing my sanity
..
Patch Set 1:
This was actually testing jenkins build :-)
--
To view, visit http://gerrit.ovirt.org/20176
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: tests: Add monkey patching class decorator
..
Patch Set 2:
Address Alon comments; previous patch was mixing cleanups with new feature.
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: tests: Add monkey patching class decorator
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/20175
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: tests: Add monkey patching class decorator
..
Patch Set 2:
I'll post the cleanups later
--
To view, visit http://gerrit.ovirt.org/20175
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: getIsoList() returns dict with files metadata
..
Patch Set 11: Code-Review+1
(2 comments)
Looks good except the API version that can be fixed when merging.
Nir Soffer has uploaded a new change for review.
Change subject: tests: Minor cleanup in monkeypatch module and tests
..
tests: Minor cleanup in monkeypatch module and tests
Change-Id: I7d1d10c8b1e97d7d28af31d25fb1fe0fdcd8d8d5
Nir Soffer has posted comments on this change.
Change subject: tests: Minor cleanup in monkeypatch module and tests
..
Patch Set 1:
Irrelevant tests fail with a timeout - seems that the build machine is
overloaded again.
--
Nir Soffer has posted comments on this change.
Change subject: lvm: ignore skipped clustered vgs
..
Patch Set 1: Code-Review-1
(4 comments)
This patch may be great but it does not explain why it is needed, not in the
commit
Nir Soffer has posted comments on this change.
Change subject: stats: return HA agent score when applicable
..
Patch Set 4: Code-Review-1
(6 comments)
File vdsm/API.py
Line
Nir Soffer has posted comments on this change.
Change subject: tests: Add miniaml issciadm tests
..
Patch Set 5:
Rebase and use new MonkeyClass class decorator.
--
To view, visit http://gerrit.ovirt.org/19856
To unsubscribe,
Nir Soffer has posted comments on this change.
Change subject: tests: Add miniaml issciadm tests
..
Patch Set 6:
More generic Callable, faking exceptions.
--
To view, visit http://gerrit.ovirt.org/19856
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: tests: Add miniaml issciadm tests
..
Patch Set 8: Verified+1
--
To view, visit http://gerrit.ovirt.org/19856
To unsubscribe, visit
Nir Soffer has uploaded a new change for review.
Change subject: iscsiadm: Add debug level option
..
iscsiadm: Add debug level option
VDSM uses iscdiadm to perform iSCSI operations which are often
complicated to debug. This
Nir Soffer has posted comments on this change.
Change subject: tests: prevent hook validation decorator from leaving scripts
installed
..
Patch Set 5:
(3 comments)
File
Nir Soffer has posted comments on this change.
Change subject: tests: Add miniaml issciadm tests
..
Patch Set 9: Verified+1
Address Allon comments
--
To view, visit http://gerrit.ovirt.org/19856
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: iscsiadm: Add debug level option
..
Patch Set 1:
(1 comment)
File lib/vdsm/config.py.in
Line 288:
Nir Soffer has posted comments on this change.
Change subject: iscsiadm: Add debug level option
..
Patch Set 1:
(1 comment)
File vdsm/storage/iscsiadm.py
Line 80:
Nir Soffer has posted comments on this change.
Change subject: iscsiadm: Add debug level option
..
Patch Set 2:
Rebase, dependent patch changed.
--
To view, visit http://gerrit.ovirt.org/20338
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: Ensure active LVs are refreshed before use.
..
Patch Set 4:
(1 comment)
Change looks good, documentation missing.
Nir Soffer has posted comments on this change.
Change subject: Ensure active LVs are refreshed before use.
..
Patch Set 4:
(1 comment)
Commit message can be even better.
Nir Soffer has posted comments on this change.
Change subject: Ensure active LVs are refreshed before use.
..
Patch Set 4:
Can we trust the availability status of the lvs, or we need to refresh first?
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: getIsoList() returns dict with files metadata
..
Patch Set 11:
Wake up maintainer - its time to merge :-)
--
To view, visit http://gerrit.ovirt.org/19544
To
Nir Soffer has posted comments on this change.
Change subject: lvm: Ensure active LVs are refreshed before use.
..
Patch Set 5: Code-Review-1
(1 comment)
After talking with Eduardo, I think this patch is wrong.
First,
Nir Soffer has posted comments on this change.
Change subject: tests: Add miniaml issciadm tests
..
Patch Set 10: Verified+1
Fix missing fake module when running the test during make rpm. Turns out that
successful make check
Nir Soffer has posted comments on this change.
Change subject: iscsiadm: Add debug level option
..
Patch Set 3:
Rebase over new version of http://gerrit.ovirt.org/#/c/19856
--
To view, visit http://gerrit.ovirt.org/20338
To
Nir Soffer has posted comments on this change.
Change subject: tests: Add miniaml issciadm tests
..
Patch Set 10:
(3 comments)
Address Dan comments.
Commit Message
Line 3:
Nir Soffer has posted comments on this change.
Change subject: getFileList() filters files in case incensitive manner
..
Patch Set 1:
(2 comments)
Hopefully it will be easy to get this minimal change merged, but in this case
Nir Soffer has posted comments on this change.
Change subject: getFileList() filters files in case incensitive manner
..
Patch Set 1:
I did not check yet other vdsm apis; if options already used like this, lets be
consistent
Nir Soffer has posted comments on this change.
Change subject: getFileList() filters files in case incensitive manner
..
Patch Set 1:
About the unused options parameter - if this is the convention in other apis,
keep it.
--
Nir Soffer has posted comments on this change.
Change subject: iscsiadm: Add debug level option
..
Patch Set 3:
Please ignore jenkins build failure - the build machine is broken.
See
Nir Soffer has posted comments on this change.
Change subject: iscsiadm: Add debug level option
..
Patch Set 3: Verified+1
Verified that new debug level option works and we do get iscsiadm logs inside
vdsm log.
Note that the
Nir Soffer has posted comments on this change.
Change subject: iscsiadm: Add debug level option
..
Patch Set 3:
Having iscsiadm debug logs in vdsm log is better then having no logs when you
want to debug an issue in iscsiadm.
Nir Soffer has posted comments on this change.
Change subject: iscsiadm: Add debug level option
..
Patch Set 3:
This change does not effect the clearness of vdsm log. It adds iscsi debug log
only if you enable this feature.
Nir Soffer has posted comments on this change.
Change subject: iscsiadm: Add debug level option
..
Patch Set 3:
I am wondering why you don't want to move step by step, I mean writing this
log to another file first.
Writing
Nir Soffer has posted comments on this change.
Change subject: cleanup: Improve networking imports (PEP328)
..
Patch Set 1: Code-Review-1
(16 comments)
Important cleanup - but mixes many unrelated cleanups.
This patch does
Nir Soffer has posted comments on this change.
Change subject: lvm: Ensure active LVs are refreshed before use.
..
Patch Set 5:
(1 comment)
Must warn when finding unexpected active lvs.
Nir Soffer has posted comments on this change.
Change subject: getFileList() filters files in case incensitive manner
..
Patch Set 1:
Sergey, Dan and me discussed the wanted api, and agreed that:
- Change the name to
Nir Soffer has posted comments on this change.
Change subject: cleanup: Improve networking imports (PEP328)
..
Patch Set 1:
Please do not change import order in this patch - it is not related to absolute
imports and just make
Nir Soffer has posted comments on this change.
Change subject: cleanup: drop several unused local variables
..
Patch Set 5: Code-Review-1
(33 comments)
Most of these changes do not improve the code.
Place where unused
Nir Soffer has posted comments on this change.
Change subject: Refactor getFilelist()
..
Patch Set 4:
(12 comments)
Looks good but needs some cleanups.
Commit Message
Line
Nir Soffer has posted comments on this change.
Change subject: Add additional vgcheck to fix vgextend workflow on HSMs.
..
Patch Set 9: Code-Review-1
(1 comment)
I don't understand how this fixes the related bug. If the issue
Nir Soffer has posted comments on this change.
Change subject: tests: Add miniaml issciadm tests
..
Patch Set 10:
Waking up reviewers - this patch is verified and ready for merging.
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: Get rid of mutables(lists) as default parameters
..
Patch Set 2:
Wake up author - this is important fix that only needs minor cleanup to
complete. Why is this not
Nir Soffer has posted comments on this change.
Change subject: tests: Add miniaml issciadm tests
..
Patch Set 11: Verified+1
Fix typos in the commit message.
--
To view, visit http://gerrit.ovirt.org/19856
To unsubscribe,
Nir Soffer has posted comments on this change.
Change subject: Replace unused getFileList() with more flexible getFileStats()
..
Patch Set 5: Code-Review+1
(1 comment)
Nice - there is one possible documentation cleanup if you
Nir Soffer has posted comments on this change.
Change subject: tests: Add miniaml issciadm tests
..
Patch Set 11:
I don't want to test that I'm passing the correct arguments. This is just
not a thing you test. passing this
Nir Soffer has posted comments on this change.
Change subject: tests: Add miniaml issciadm tests
..
Patch Set 11:
(4 comments)
File tests/fake.py
Line 19: # Refer to the
Nir Soffer has posted comments on this change.
Change subject: Replace unused getFileList() with more flexible getFileStats()
..
Patch Set 5:
Are you sure patch 5 is correct? I don't see the changes in gerrit.
--
To view,
Nir Soffer has posted comments on this change.
Change subject: stats: return HA agent score when applicable
..
Patch Set 5:
(1 comment)
File vdsm/API.py
Line 51: try:
Line
Nir Soffer has posted comments on this change.
Change subject: stats: return HA agent score when applicable
..
Patch Set 6:
Looks like a tool error to me; the original code is valid.
Maybe there is an old version of pep8 on
Nir Soffer has abandoned this change.
Change subject: iscsiadm: Add debug level option
..
Abandoned
We are not going to implement this RFE, since this is not the best place to
collect iscsiadm debug logs.
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: stats: return HA agent score when applicable
..
Patch Set 7:
(1 comment)
File vdsm/API.py
Line 1220:
Nir Soffer has posted comments on this change.
Change subject: stats: return HA agent score when applicable
..
Patch Set 8: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/20126
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: Networking import reordering
..
Patch Set 1:
(3 comments)
I like it - this is mostly how I organize imports, but better :-)
Nir Soffer has uploaded a new change for review.
Change subject: fcp: Deactivate vdsm volume groups during boot
..
fcp: Deactivate vdsm volume groups during boot
When using FC storage, physical volumes are connected during
Nir Soffer has posted comments on this change.
Change subject: fcp: Deactivate vdsm volume groups during boot
..
Patch Set 1:
I will handle packaging in the next commit.
--
To view, visit http://gerrit.ovirt.org/20720
To
Nir Soffer has posted comments on this change.
Change subject: fcp: Deactivate vdsm volume groups during boot
..
Patch Set 1:
As usual, jenkins build is broken :-)
--
To view, visit http://gerrit.ovirt.org/20720
To
Nir Soffer has posted comments on this change.
Change subject: fcp: Deactivate vdsm volume groups during boot
..
Patch Set 1:
If vdsm does not support this state, why not just fix vdsm?
There is nothing to fix in vdsm - it
Nir Soffer has posted comments on this change.
Change subject: vm: Pause vm in case volume allocation is greater than lv size
..
Patch Set 7: Code-Review+1
(1 comment)
File
Nir Soffer has posted comments on this change.
Change subject: Invalidate filters on HSMs before rescanning extended VG
..
Patch Set 16: Code-Review-1
(2 comments)
Looks good, but I think it can more correct.
Nir Soffer has posted comments on this change.
Change subject: Invalidate filters on HSMs before rescanning extended VG
..
Patch Set 16:
One more thing - please document the fact that filters are invalidated by the
function
Nir Soffer has posted comments on this change.
Change subject: Invalidate filters on HSMs before rescanning extended VG
..
Patch Set 16:
(1 comment)
File
Nir Soffer has posted comments on this change.
Change subject: Invalidate filters on HSMs before rescanning extended VG
..
Patch Set 16:
(1 comment)
File
Nir Soffer has posted comments on this change.
Change subject: Replace unused getFileList() with more flexible getFileStats()
..
Patch Set 6: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/20476
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: fcp: Deactivate vdsm volume groups during boot
..
Patch Set 1:
(3 comments)
Ayal, the current implementation would not cut the storage under a running
VM, as
Nir Soffer has posted comments on this change.
Change subject: fcp: Deactivate vdsm volume groups during boot
..
Patch Set 1:
For this kind of upgrade we may either require a reboot, or detect which lvs
are used and
Nir Soffer has posted comments on this change.
Change subject: cleanup: Improve lib/vdsm imports (PEP328)
..
Patch Set 4:
(1 comment)
Commit Message
Line 29: from .
Nir Soffer has posted comments on this change.
Change subject: fcp: Deactivate vdsm volume groups during boot
..
Patch Set 1:
(2 comments)
also bare in mind that user can have vdsmd installed without running it at
all, so
Nir Soffer has posted comments on this change.
Change subject: fcp: Deactivate vdsm volume groups during boot
..
Patch Set 1:
Current plan is to have this patch only for zstream, and use lvm activation
skipping for el 6.5
Nir Soffer has uploaded a new change for review.
Change subject: lvm: Prevent auto-actviation of logical volumes
..
lvm: Prevent auto-actviation of logical volumes
When using FC storage, physical volumes are connected during
Nir Soffer has posted comments on this change.
Change subject: lvm: Prevent auto-actviation of logical volumes
..
Patch Set 1:
Missing also spec changes - depend on lvm 2.02.100.
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: lvm: Prevent auto-actviation of logical volumes
..
Patch Set 1:
(6 comments)
Commit Message
Line 16: lvm
Nir Soffer has posted comments on this change.
Change subject: lvm: Prevent auto-actviation of logical volumes
..
Patch Set 3:
Fix typo and lvm2 dependency.
--
To view, visit http://gerrit.ovirt.org/20832
To unsubscribe,
Nir Soffer has posted comments on this change.
Change subject: sampling.ImagePathStatus: drop dead thread
..
Patch Set 3:
(1 comment)
Looks good expect unused variable.
Nir Soffer has posted comments on this change.
Change subject: sampling.ImagePathStatus: drop dead thread
..
Patch Set 3:
(1 comment)
Minor title edit.
Commit Message
Line
Nir Soffer has posted comments on this change.
Change subject: cleanup: Improve lib/vdsm imports (PEP328)
..
Patch Set 1:
(2 comments)
File vdsm/configNetwork.py
Line 32:
Nir Soffer has posted comments on this change.
Change subject: lvm: Prevent auto-actviation of logical volumes
..
Patch Set 3:
(7 comments)
Commit Message
Line 8:
Line 9:
Nir Soffer has posted comments on this change.
Change subject: lvm: Prevent auto-actviation of logical volumes
..
Patch Set 3:
(1 comment)
Commit Message
Line 3:
Nir Soffer has posted comments on this change.
Change subject: lvm: Prevent auto-activation of logical volumes
..
Patch Set 4:
Changes:
- Fix typo in commit message
- Refine commit message
- Add new flags to the invariant part
Nir Soffer has posted comments on this change.
Change subject: lvm: Prevent auto-activation of logical volumes
..
Patch Set 4:
And update lvm2 version to last release version for 6.5.
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: sampling.ImagePathStatus: drop unused code
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/20812
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: tests: prevent hook validation decorator from leaving scripts
installed
..
Patch Set 6:
(1 comment)
File
1 - 100 of 11706 matches
Mail list logo
