Ramesh N has posted comments on this change.
Change subject: gluster: fix build error in F20 due to blivet version issue
..
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/38942/3/vdsm/gluster/storagedev.py
File
Ramesh N has posted comments on this change.
Change subject: gluster: storage devices list provides device size in Mib
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/38707/1/vdsm/gluster/storagedev.py
File
Ramesh N has posted comments on this change.
Change subject: gluster: storage devices list provides device size in Mib
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/38707
To unsubscribe, visit
Ramesh N has posted comments on this change.
Change subject: spec: revert build dependency on non-existing blivet
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/39132
To unsubscribe, visit
Ramesh N has posted comments on this change.
Change subject: gluster: Adds a new element 'extraFeaturesSupported' to
getVdsCaps.
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/39324/2/vdsm/caps.py
File
Ramesh N has posted comments on this change.
Change subject: gluster: Adds a new element 'additionalFeatures' to getVdsCaps.
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/39324/4/vdsm/caps.py
File vdsm/caps.py:
Ramesh N has posted comments on this change.
Change subject: gluster: Adds a new element 'additionalFeatures' to getVdsCaps.
..
Patch Set 5: Code-Review-1
Please don't merge until engine patch is getting to a conclusion.
--
Ramesh N has posted comments on this change.
Change subject: gluster: Adds a new element 'additionalFeatures' to getVdsCaps.
..
Patch Set 5: Code-Review+1
It can be merged now as the related engine patch is already in.
--
To
Ramesh N has posted comments on this change.
Change subject: gluster: refresh lvm devices after brick create
..
Patch Set 7: Verified+1
I was able to reproduce this issues without this fix. But after this fix i
could not
Ramesh N has posted comments on this change.
Change subject: gluster:fix NoneType error for some devices does not contain
sysfsPath
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/41466
To unsubscribe,
Ramesh N has posted comments on this change.
Change subject: gluster: fix AttributeError and TypeError in exception.py
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/41530/1//COMMIT_MSG
Commit Message:
Line 7:
Ramesh N has posted comments on this change.
Change subject: gluster:fix NoneType error for some devices does not contain
sysfsPath
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/41262/2/vdsm/gluster/storagedev.py
Ramesh N has posted comments on this change.
Change subject: gluster:fix NoneType error for some devices does not contain
sysfsPath
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/41262
To
Ramesh N has posted comments on this change.
Change subject: gluster: fix TypeError in exception.py
..
Patch Set 1: Code-Review+1
Tim: Confirm that the mentioned python bug is not fixed in latest 2.7
--
To view, visit
Ramesh N has posted comments on this change.
Change subject: gluster: fix AttributeError in exception.py
..
Patch Set 4: Code-Review+1
Acked.
Tim: Confirm that the python issue http://bugs.python.org/issue15440 is not
fixed
Ramesh N has posted comments on this change.
Change subject: gluster: fix xfs filesystem is created with wrong inode size
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/43847
To unsubscribe, visit
Ramesh N has posted comments on this change.
Change subject: gluster: fix AttributeError and TypeError in exception.py
..
Patch Set 3: Code-Review+1
Please don't introduce or change the error codes without adding those
Ramesh N has posted comments on this change.
Change subject: gluster: fix AttributeError and TypeError in exception.py
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/41530/2//COMMIT_MSG
Commit Message:
Line 13:
Ramesh N has posted comments on this change.
Change subject: gluster: fix AttributeError and TypeError in exception.py
..
Patch Set 2:
(4 comments)
https://gerrit.ovirt.org/#/c/41530/2/vdsm/gluster/exception.py
File
Ramesh N has posted comments on this change.
Change subject: gluster: fix mount point issue for snapshot thin lv
..
Patch Set 1: Code-Review-1
This patch is not required since the blivet bug is already fixed. This patch
can
Ramesh N has posted comments on this change.
Change subject: gluster: fix AttributeError and TypeError in exception.py
..
Patch Set 3: -Code-Review
(1 comment)
https://gerrit.ovirt.org/#/c/41530/3/vdsm/gluster/exception.py
Ramesh N has posted comments on this change.
Change subject: gluster: fix xfs filesystem is created with wrong inode size
..
Patch Set 1:
(1 comment)
May be its better to have a small write up in the program itself to explain
Ramesh N has posted comments on this change.
Change subject: gluster: fix xfs filesystem is created with wrong inode size
..
Patch Set 2:
Please add comment explaining what are things we are doing in create brick. We
have to
Ramesh N has posted comments on this change.
Change subject: gluster: Added VDSM verb to stop gluster related processes
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/48449
To unsubscribe, visit
Hello Piotr Kliczewski, Bala.FA, Dan Kenigsberg,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/48449
to review the following change.
Change subject: gluster: Added VDSM verb to stop gluster related processes
Ramesh N has posted comments on this change.
Change subject: gluster: Added VDSM verb to stop gluster related processes
..
Patch Set 4: Code-Review-1
Marking it as -1 since the dependent gluster patch is not yet merged.
--
Ramesh N has posted comments on this change.
Change subject: gluster: Added VDSM verb to stop gluster related processes
..
Patch Set 6: Verified+1
--
To view, visit https://gerrit.ovirt.org/43821
To unsubscribe, visit
Ramesh N has posted comments on this change.
Change subject: gluster: Added VDSM verb to stop gluster related processes
..
Patch Set 6:
(1 comment)
I changed the schema to follow the approach used in volumeSnapshotConfigSet.
Ramesh N has posted comments on this change.
Change subject: gluster: Added VDSM verb to stop gluster related processes
..
Patch Set 7: Verified+1
--
To view, visit https://gerrit.ovirt.org/43821
To unsubscribe, visit
Ramesh N has posted comments on this change.
Change subject: gluster: Added VDSM verb to stop gluster related processes
..
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/43821/4/vdsm/gluster/api.py
File
Ramesh N has posted comments on this change.
Change subject: gluster: Added VDSM verb to stop gluster related processes
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/43821/3/vdsm/gluster/api.py
File
Ramesh N has posted comments on this change.
Change subject: gluster: Added VDSM verb to stop gluster related processes
..
Patch Set 3:
(3 comments)
https://gerrit.ovirt.org/#/c/43821/3/vdsm/gluster/api.py
File
Ramesh N has posted comments on this change.
Change subject: gluster: fix brick devices are created with incorrect data
alignment
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/47959/2/vdsm/gluster/storagedev.py
Hello Piotr Kliczewski, Bala.FA, Dan Kenigsberg,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/50312
to review the following change.
Change subject: gluster: Added VDSM verb to stop gluster related processes
Ramesh N has posted comments on this change.
Change subject: gluster: Added VDSM verb to stop gluster related processes
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/50312
To unsubscribe, visit
Ramesh N has uploaded a new change for review.
Change subject: gluster: fix size conversion issues in brick create
..
gluster: fix size conversion issues in brick create
There is change in blivet API
Ramesh N has posted comments on this change.
Change subject: gluster: fix performance issue in brick creation
..
Patch Set 6: Verified+1
--
To view, visit https://gerrit.ovirt.org/47959
To unsubscribe, visit
Ramesh N has posted comments on this change.
Change subject: gluster: fix size conversion issues in brick create
..
Patch Set 5: Verified+1
--
To view, visit https://gerrit.ovirt.org/50705
To unsubscribe, visit
Ramesh N has posted comments on this change.
Change subject: gluster: fix performance issue in brick creation
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/47959/3/vdsm/gluster/storagedev.py
File
Ramesh N has posted comments on this change.
Change subject: gluster: fix performance issue in brick creation
..
Patch Set 3:
I have splited this patch into two patches new one at
https://gerrit.ovirt.org/50705. I have
Ramesh N has posted comments on this change.
Change subject: gluster: fix brick devices are created with incorrect data
alignment
..
Patch Set 3: Code-Review+1 Verified+1
I have manually verified this patch in Fedora 22 and
Ramesh N has posted comments on this change.
Change subject: gluster: fix size conversion issues in brick create
..
Patch Set 6:
(5 comments)
Thanks for your suggestions Nir. I will fix them in the next patch set.
Ramesh N has posted comments on this change.
Change subject: gluster: ensure LV size is multiple of VG's PE value
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/50809
To unsubscribe, visit
Ramesh N has posted comments on this change.
Change subject: gluster: fix alignment issue for brick creation on JBOD
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/50806
To unsubscribe, visit
Ramesh N has posted comments on this change.
Change subject: gluster: create bricks without MBR partitions
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/50805
To unsubscribe, visit
Ramesh N has posted comments on this change.
Change subject: gluster: fix size conversion issues in brick create
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/50808
To unsubscribe, visit
Ramesh N has posted comments on this change.
Change subject: gluster add mount options for gluster brick.
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/50807
To unsubscribe, visit
Ramesh N has posted comments on this change.
Change subject: gluster: ensure LV size is multiple of VG's PE value
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/50802
To unsubscribe, visit
Hello Nir Soffer, Sahina Bose,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/50807
to review the following change.
Change subject: gluster add mount options for gluster brick.
..
gluster add
Hello Nir Soffer, Sahina Bose,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/50809
to review the following change.
Change subject: gluster: ensure LV size is multiple of VG's PE value
..
Hello Nir Soffer, Sahina Bose,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/50806
to review the following change.
Change subject: gluster: fix alignment issue for brick creation on JBOD
..
Hello Nir Soffer, Sahina Bose,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/50808
to review the following change.
Change subject: gluster: fix size conversion issues in brick create
..
gluster:
Hello Nir Soffer, Sahina Bose,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/50805
to review the following change.
Change subject: gluster: create bricks without MBR partitions
..
gluster:
Ramesh N has posted comments on this change.
Change subject: gluster: create bricks without MBR partitions
..
Patch Set 1:
This is a special branch for gluster :-). But Yes. I have to back port the
patches to ovirt 3.6 as
Ramesh N has posted comments on this change.
Change subject: gluster: ensure LV size is multiple of VG's PE value
..
Patch Set 3:
I have verified this patch in Fedora, RHEL 6 and RHEL 7 platforms.
Also i tried creating brick
Ramesh N has posted comments on this change.
Change subject: gluster: ensure LV size is multiple of VG's PE value
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/50854
To unsubscribe, visit
Ramesh N has posted comments on this change.
Change subject: gluster: fix size conversion issues in brick create
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/50853
To unsubscribe, visit
Ramesh N has posted comments on this change.
Change subject: gluster: fix alignment issue for brick creation on JBOD
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/50851
To unsubscribe, visit
Ramesh N has posted comments on this change.
Change subject: gluster add mount options for gluster brick.
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/50852
To unsubscribe, visit
Ramesh N has posted comments on this change.
Change subject: gluster: fix xfs filesystem is created with wrong inode size
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/50849
To unsubscribe, visit
Hello Nir Soffer, Sahina Bose,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/50851
to review the following change.
Change subject: gluster: fix alignment issue for brick creation on JBOD
..
Hello Nir Soffer, Sahina Bose,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/50853
to review the following change.
Change subject: gluster: fix size conversion issues in brick create
..
gluster:
Hello Nir Soffer, Sahina Bose,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/50852
to review the following change.
Change subject: gluster add mount options for gluster brick.
..
gluster add
Hello Nir Soffer, Sahina Bose,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/50850
to review the following change.
Change subject: gluster: create bricks without MBR partitions
..
gluster:
Hello Manoj Pillai, Timothy Asir, Bala.FA, Dan Kenigsberg,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/50849
to review the following change.
Change subject: gluster: fix xfs filesystem is created with wrong inode size
Hello Nir Soffer, Sahina Bose,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/50854
to review the following change.
Change subject: gluster: ensure LV size is multiple of VG's PE value
..
Ramesh N has posted comments on this change.
Change subject: gluster: fix size conversion issues in brick create
..
Patch Set 7: Verified+1
--
To view, visit https://gerrit.ovirt.org/50705
To unsubscribe, visit
Ramesh N has posted comments on this change.
Change subject: gluster: create bricks without MBR partitions
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/50850
To unsubscribe, visit
Ramesh N has uploaded a new change for review.
Change subject: gluster: ensure LV size is multiple of VG's PE value
..
gluster: ensure LV size is multiple of VG's PE value
Size of LV should be multiple of PE value. But this
Ramesh N has uploaded a new change for review.
Change subject: gluster: create bricks without MBR partitions
..
gluster: create bricks without MBR partitions
During gluster brick creation, PVs should be
created directly on the
Ramesh N has uploaded a new change for review.
Change subject: gluster add mount options for gluster brick.
..
gluster add mount options for gluster brick.
Mount options "inode64,noatime" should be used to
mount the gluster
Ramesh N has posted comments on this change.
Change subject: gluster: fix size conversion issues in brick create
..
Patch Set 5:
(7 comments)
https://gerrit.ovirt.org/#/c/50705/5/vdsm/gluster/storagedev.py
File
Ramesh N has posted comments on this change.
Change subject: gluster: create bricks without MBR partitions
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/50769
To unsubscribe, visit
Ramesh N has posted comments on this change.
Change subject: gluster add mount options for gluster brick.
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/50770
To unsubscribe, visit
Ramesh N has posted comments on this change.
Change subject: gluster: fix alignment issue for brick creation on JBOD
..
Patch Set 7:
Splitted the original patch into 3 patches https://gerrit.ovirt.org/50769
Ramesh N has posted comments on this change.
Change subject: gluster: fix alignment issue for brick creation on JBOD
..
Patch Set 7: Verified+1
--
To view, visit https://gerrit.ovirt.org/47959
To unsubscribe, visit
Ramesh N has posted comments on this change.
Change subject: gluster: fix size conversion issues in brick create
..
Patch Set 6: Verified+1
--
To view, visit https://gerrit.ovirt.org/50705
To unsubscribe, visit
Ramesh N has posted comments on this change.
Change subject: gluster: fix performance issue in brick creation
..
Patch Set 6:
(3 comments)
https://gerrit.ovirt.org/#/c/47959/6//COMMIT_MSG
Commit Message:
Line 12: 1. PVs
Ramesh N has posted comments on this change.
Change subject: gluster: fix brick devices are created with incorrect data
alignment
..
Patch Set 2: -Code-Review
Thanks Manoj for clarifying. If the old steps are correct though
Ramesh N has posted comments on this change.
Change subject: gluster: fix brick devices are created with incorrect data
alignment
..
Patch Set 2: Code-Review-1
(4 comments)
Ramesh N has posted comments on this change.
Change subject: gluster: fix brick devices are created with incorrect data
alignment
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/47959/2/vdsm/gluster/storagedev.py
Ramesh N has uploaded a new change for review.
Change subject: gluster:enforce gluster fencing policies
..
gluster:enforce gluster fencing policies
Enforce gluster related fencing policies before fencing
the host.
1.
Ramesh N has posted comments on this change.
Change subject: gluster:enforce gluster fencing policies
..
Patch Set 2:
(6 comments)
https://gerrit.ovirt.org/#/c/59600/2/vdsm/API.py
File vdsm/API.py:
Line 54: from vdsm.define
Ramesh N has uploaded a new change for review.
Change subject: gluster: add support for arbiter volumes
..
gluster: add support for arbiter volumes
Add support for arbiter gluster volume creations. Also
include arbiter count
Ramesh N has uploaded a new change for review.
Change subject: gluster: add gluster heal info verb
..
gluster: add gluster heal info verb
Add gluster heal info to get list of unsynced entries
present in the given gluster
Ramesh N has posted comments on this change.
Change subject: Move gluster package to vdsm.gluster
..
Patch Set 2:
(1 comment)
Overall changes looks to correct. Let me verify once.
Ramesh N has posted comments on this change.
Change subject: gluster: add gluster heal info verb
..
Patch Set 7:
(4 comments)
Patch-set to follow.
https://gerrit.ovirt.org/#/c/56738/7/lib/api/vdsmapi-gluster-schema.json
File
Ramesh N has posted comments on this change.
Change subject: gluster: add gluster heal info verb
..
Patch Set 8: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56738
To unsubscribe, visit
Ramesh N has posted comments on this change.
Change subject: gluster: add gluster heal info verb
..
Patch Set 8: -Code-Review Verified+1
--
To view, visit https://gerrit.ovirt.org/56738
To unsubscribe, visit
Ramesh N has posted comments on this change.
Change subject: gluster: add gluster heal info verb
..
Patch Set 10:
(2 comments)
https://gerrit.ovirt.org/#/c/56738/10/lib/api/vdsmapi-gluster-schema.json
File
Ramesh N has posted comments on this change.
Change subject: gluster: add gluster heal info verb
..
Patch Set 11: Verified+1
--
To view, visit https://gerrit.ovirt.org/56738
To unsubscribe, visit
Ramesh N has posted comments on this change.
Change subject: gluster: add gluster heal info verb
..
Patch Set 12: Verified+1
--
To view, visit https://gerrit.ovirt.org/56738
To unsubscribe, visit
Ramesh N has posted comments on this change.
Change subject: gluster: add gluster heal info verb
..
Patch Set 9: Verified+1
--
To view, visit https://gerrit.ovirt.org/56738
To unsubscribe, visit
Ramesh N has posted comments on this change.
Change subject: gluster: add gluster heal info verb
..
Patch Set 9:
(1 comment)
https://gerrit.ovirt.org/#/c/56738/9/tests/glusterVolumeHealInfo.xml
File
Ramesh N has uploaded a new change for review.
Change subject: gluster: fix python-blivet dependency issue for python3
..
gluster: fix python-blivet dependency issue for python3
Until now blivet API had both 'python-blivet'
Ramesh N has uploaded a new change for review.
Change subject: gluster: fix for lvchange regression in rhel 6.8
..
gluster: fix for lvchange regression in rhel 6.8
There is a regression in lvchange command. Changes are not
Ramesh N has posted comments on this change.
Change subject: gluster: add gluster heal info verb
..
Patch Set 5:
(3 comments)
https://gerrit.ovirt.org/#/c/56738/5/client/vdsClientGluster.py
File client/vdsClientGluster.py:
Ramesh N has posted comments on this change.
Change subject: gluster:enforce gluster fencing policies
..
Patch Set 9:
(4 comments)
https://gerrit.ovirt.org/#/c/59600/9/lib/vdsm/gluster/fence.py
File lib/vdsm/gluster/fence.py:
Ramesh N has posted comments on this change.
Change subject: gluster:enforce gluster fencing policies
..
Patch Set 9:
(1 comment)
https://gerrit.ovirt.org/#/c/59600/9/vdsm.spec.in
File vdsm.spec.in:
Line 1648: %license
Ramesh N has posted comments on this change.
Change subject: gluster:enforce gluster fencing policies
..
Patch Set 4:
Thanks Martin for your suggestions. I will post a new patch -set with the
suggested changes.
--
To view,
1 - 100 of 143 matches
Mail list logo
