Shahar Havivi has abandoned this change.
Change subject: cancel migration: remove event sync
..
Patch Set 1: Abandoned
--
To view, visit http://gerrit.ovirt.org/2533
To unsubscribe, visit http://gerrit.ovirt.org/settings
Shahar Havivi has posted comments on this change.
Change subject: vdsm-hooks: fix malformed libvirt xml
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21913
To unsubscribe, visit
Shahar Havivi has uploaded a new change for review.
Change subject: getExternalVmList
..
getExternalVmList
Change-Id: I7dcfb860626a844d1d08590274b508519a33f4a3
Signed-off-by: Shahar Havivi shah...@redhat.com
---
M
Shahar Havivi has posted comments on this change.
Change subject: getExternalVmList
..
Patch Set 1: Verified-1
--
To view, visit http://gerrit.ovirt.org/33309
To unsubscribe, visit http://gerrit.ovirt.org/settings
Shahar Havivi has posted comments on this change.
Change subject: PATCH: external VMs integration
..
Patch Set 5:
(2 comments)
No need to -1 yet..., this is still marked as draft ;)
Shahar Havivi has posted comments on this change.
Change subject: PATCH: external VMs integration
..
Patch Set 5:
(1 comment)
http://gerrit.ovirt.org/#/c/33309/5/vdsm/v2v.py
File vdsm/v2v.py:
Line 96:
Line 97: auth =
Shahar Havivi has posted comments on this change.
Change subject: PATCH: external VMs integration
..
Patch Set 4:
(10 comments)
http://gerrit.ovirt.org/#/c/33309/4//COMMIT_MSG
Commit Message:
Line 7: PATCH: external VMs
Shahar Havivi has uploaded a new change for review.
Change subject: libvirtconnection: add credentials other then defalut
..
libvirtconnection: add credentials other then defalut
Adding username, passwd, and uri for
Shahar Havivi has uploaded a new change for review.
Change subject: Convert VM from external source to Data Domain
..
Convert VM from external source to Data Domain
new verb: convert VM from external source (non-kvm) to Data
Shahar Havivi has posted comments on this change.
Change subject: libvirtconnection: add credentials other then defalut
..
Patch Set 1:
sure
--
To view, visit http://gerrit.ovirt.org/34293
To unsubscribe, visit
Shahar Havivi has posted comments on this change.
Change subject: libvirtconnection: add credentials other then defalut
..
Patch Set 1:
(3 comments)
http://gerrit.ovirt.org/#/c/34293/1/lib/vdsm/libvirtconnection.py
File
Shahar Havivi has posted comments on this change.
Change subject: libvirtconnection: add credentials other then defalut
..
Patch Set 5:
(1 comment)
http://gerrit.ovirt.org/#/c/34293/5/lib/vdsm/libvirtconnection.py
File
Shahar Havivi has posted comments on this change.
Change subject: libvirtconnection: add credentials other then defalut
..
Patch Set 5:
(1 comment)
http://gerrit.ovirt.org/#/c/34293/5/lib/vdsm/libvirtconnection.py
File
Shahar Havivi has posted comments on this change.
Change subject: libvirtconnection: add credentials other then defalut
..
Patch Set 6:
(2 comments)
http://gerrit.ovirt.org/#/c/34293/6/lib/vdsm/libvirtconnection.py
File
Shahar Havivi has posted comments on this change.
Change subject: External hypervisor VMs integration
..
Patch Set 12:
(12 comments)
Thanks for reviewing Nir.
http://gerrit.ovirt.org/#/c/33309/12/vdsm/API.py
File
Shahar Havivi has posted comments on this change.
Change subject: libvirtconnection: add credentials other then defalut
..
Patch Set 8:
(2 comments)
http://gerrit.ovirt.org/#/c/34293/8//COMMIT_MSG
Commit Message:
Line 3:
Shahar Havivi has posted comments on this change.
Change subject: Convert VM from external source to Data Domain
..
Patch Set 11: Verified-1
Do not review
--
To view, visit http://gerrit.ovirt.org/34294
To unsubscribe, visit
Shahar Havivi has posted comments on this change.
Change subject: Convert VM from external source to Data Domain
..
Patch Set 12: Verified-1
Do not review
--
To view, visit http://gerrit.ovirt.org/34294
To unsubscribe, visit
Shahar Havivi has posted comments on this change.
Change subject: Convert VM from external source to Data Domain
..
Patch Set 13: Verified-1
Do not review
--
To view, visit http://gerrit.ovirt.org/34294
To unsubscribe, visit
Shahar Havivi has posted comments on this change.
Change subject: External hypervisor VMs integration
..
Patch Set 16:
(7 comments)
http://gerrit.ovirt.org/#/c/33309/16/tests/v2vTests.py
File tests/v2vTests.py:
Line 82:
Shahar Havivi has posted comments on this change.
Change subject: Convert VM from external source to Data Domain
..
Patch Set 14: Verified-1
do not review
--
To view, visit http://gerrit.ovirt.org/34294
To unsubscribe, visit
Shahar Havivi has posted comments on this change.
Change subject: libvirtconnection: add function to create a new connection
..
Patch Set 9:
Verified that the new open_connection is working with no parameters (the
default)
Shahar Havivi has posted comments on this change.
Change subject: External hypervisor VMs integration
..
Patch Set 18: Verified+1
--
To view, visit http://gerrit.ovirt.org/33309
To unsubscribe, visit
Shahar Havivi has posted comments on this change.
Change subject: libvirtconnection: add function to create a new connection
..
Patch Set 10: Verified+1
--
To view, visit http://gerrit.ovirt.org/34293
To unsubscribe, visit
Shahar Havivi has posted comments on this change.
Change subject: External hypervisor VMs integration
..
Patch Set 18:
(3 comments)
http://gerrit.ovirt.org/#/c/33309/18/vdsm/v2v.py
File vdsm/v2v.py:
Line 30:
Shahar Havivi has posted comments on this change.
Change subject: External hypervisor VMs integration
..
Patch Set 18:
(1 comment)
http://gerrit.ovirt.org/#/c/33309/18/vdsm/v2v.py
File vdsm/v2v.py:
Line 30:
Shahar Havivi has posted comments on this change.
Change subject: External hypervisor VMs integration
..
Patch Set 18:
(4 comments)
http://gerrit.ovirt.org/#/c/33309/18/vdsm/v2v.py
File vdsm/v2v.py:
Line 30:
Shahar Havivi has posted comments on this change.
Change subject: Convert VM from external source to Data Domain
..
Patch Set 16: Verified-1
--
To view, visit http://gerrit.ovirt.org/34294
To unsubscribe, visit
Shahar Havivi has uploaded a new change for review.
Change subject: support for multiple heas in qxl display divice
..
support for multiple heas in qxl display divice
bug-url: https://bugzilla.redhat.com/787578
Change-Id:
Shahar Havivi has posted comments on this change.
Change subject: Add hostusbdirect hook to vdsm_hooks.
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/17428
To
Shahar Havivi has posted comments on this change.
Change subject: Support for multiple heads for Qxl display device
..
Patch Set 6: (1 inline comment)
Mark,
You can test it by looking at libvirt xml and see that you have the
Shahar Havivi has posted comments on this change.
Change subject: Support for multiple heads for Qxl display device
..
Patch Set 7: (1 inline comment)
File tests/vmTests.py
Shahar Havivi has posted comments on this change.
Change subject: Support for multiple heads for Qxl display device
..
Patch Set 8:
Mark,
When you set the heads1 in a qxl video device, qemu is passing your video
devices via a
Shahar Havivi has posted comments on this change.
Change subject: Support for multiple heads for Qxl display device
..
Patch Set 8: Verified
--
To view, visit http://gerrit.ovirt.org/17067
To unsubscribe, visit
Shahar Havivi has uploaded a new change for review.
Change subject: vdsm: add support for ram/vram on QXL device
..
vdsm: add support for ram/vram on QXL device
setting support for qxl device with proper ram/vram attributes:
1
Shahar Havivi has posted comments on this change.
Change subject: vdsm: add support for ram/vram on QXL device
..
Patch Set 3:
(2 comments)
File vdsm/vm.py
Line 1206:
Shahar Havivi has uploaded a new change for review.
Change subject: BZ#753625 honor displayNetwork again
..
BZ#753625 honor displayNetwork again
added libvirt-network support for add/del network,
and on vdsm startup add
Shahar Havivi has posted comments on this change.
Change subject: BZ#753625 honor displayNetwork again
..
Patch Set 2: (5 inline comments)
File vdsm/clientIF.py
Line 114:
Shahar Havivi has posted comments on this change.
Change subject: BZ#753625 honor displayNetwork again
..
Patch Set 3: (2 inline comments)
File vdsm/configNetwork.py
Line
Shahar Havivi has posted comments on this change.
Change subject: BZ#753625 honor displayNetwork again
..
Patch Set 5: Verified
--
To view, visit http://gerrit.ovirt.org/255
To unsubscribe, visit
Shahar Havivi has posted comments on this change.
Change subject: Adding hooks to VDSM
..
Patch Set 3: (3 inline comments)
File vdsm_hooks/directlun/after_vm_destroy.py
Line
Shahar Havivi has posted comments on this change.
Change subject: Adding hooks to VDSM
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/366
To unsubscribe, visit http://gerrit.ovirt.org/settings
Shahar Havivi has posted comments on this change.
Change subject: Adding hooks to VDSM
..
Patch Set 4: (6 inline comments)
File configure.ac
Line 129:
Shahar Havivi has posted comments on this change.
Change subject: Adding hooks to VDSM
..
Patch Set 5: Verified
--
To view, visit http://gerrit.ovirt.org/366
To unsubscribe, visit http://gerrit.ovirt.org/settings
Shahar Havivi has posted comments on this change.
Change subject: Adding hooks to VDSM
..
Patch Set 6: Verified
--
To view, visit http://gerrit.ovirt.org/366
To unsubscribe, visit http://gerrit.ovirt.org/settings
Shahar Havivi has uploaded a new change for review.
Change subject: vdsm: new verb: migration cancel
..
vdsm: new verb: migration cancel
the verb migrateCancel will take vmid and try to stop migration,
if there is no migration
Shahar Havivi has posted comments on this change.
Change subject: Add Shahar to AUTHORS
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/477
To unsubscribe, visit http://gerrit.ovirt.org/settings
Shahar Havivi has posted comments on this change.
Change subject: Add Shahar to AUTHORS
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/477
To unsubscribe, visit
Shahar Havivi has posted comments on this change.
Change subject: vdsm: new verb: migration cancel
..
Patch Set 2: (3 inline comments)
Commit Message
Line 10: if there is no
Shahar Havivi has posted comments on this change.
Change subject: vdsm: new verb: migration cancel
..
Patch Set 3: (4 inline comments)
Commit Message
Line 7: vdsm: new verb:
Shahar Havivi has posted comments on this change.
Change subject: new verb: migration cancel
..
Patch Set 5: Verified
--
To view, visit http://gerrit.ovirt.org/480
To unsubscribe, visit http://gerrit.ovirt.org/settings
Shahar Havivi has posted comments on this change.
Change subject: new verb: migration cancel
..
Patch Set 6: Verified
--
To view, visit http://gerrit.ovirt.org/480
To unsubscribe, visit http://gerrit.ovirt.org/settings
Shahar Havivi has posted comments on this change.
Change subject: hooks, promisc: note added for inline mode
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/642
To unsubscribe, visit
Shahar Havivi has posted comments on this change.
Change subject: new verb: migration cancel
..
Patch Set 6: (1 inline comment)
File vdsm/libvirtvm.py
Line 442: def
Shahar Havivi has posted comments on this change.
Change subject: promisc hook: added in-line (redirect) mode
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/712
To unsubscribe, visit
Shahar Havivi has posted comments on this change.
Change subject: new verb: migration cancel
..
Patch Set 7: Verified
--
To view, visit http://gerrit.ovirt.org/480
To unsubscribe, visit http://gerrit.ovirt.org/settings
Shahar Havivi has posted comments on this change.
Change subject: new verb: migration cancel
..
Patch Set 7: (3 inline comments)
File vdsm/libvirtvm.py
Line 436:
Shahar Havivi has posted comments on this change.
Change subject: new verb: migration cancel
..
Patch Set 8: Verified
--
To view, visit http://gerrit.ovirt.org/480
To unsubscribe, visit http://gerrit.ovirt.org/settings
Shahar Havivi has posted comments on this change.
Change subject: added mtu support for network interface
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/754
To unsubscribe, visit
Shahar Havivi has posted comments on this change.
Change subject: added mtu support for network interface
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/754
To unsubscribe, visit
Shahar Havivi has posted comments on this change.
Change subject: added mtu support for network interface
..
Patch Set 2: (5 inline comments)
File vdsm/configNetwork.py
Line
Shahar Havivi has posted comments on this change.
Change subject: added mtu support for network interface
..
Patch Set 2: (2 inline comments)
File vdsm/configNetwork.py
Line
Shahar Havivi has posted comments on this change.
Change subject: added mtu support for network interface
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/754
To unsubscribe, visit
Shahar Havivi has uploaded a new change for review.
Change subject: add/del network - add bridgesless network
..
add/del network - add bridgesless network
Change-Id: Id7a3efea92312ac628e0373a5c29fbb1669058f4
---
M
Shahar Havivi has posted comments on this change.
Change subject: add/del network - add bridgesless network
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/848
To unsubscribe, visit
Shahar Havivi has uploaded a new change for review.
Change subject: added support for mirror promisc mode
..
added support for mirror promisc mode
let ability to VM to monitor (mirror) all other VMs in the same host by
specific
Shahar Havivi has posted comments on this change.
Change subject: added support for mirror promisc mode
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/956
To unsubscribe, visit
Shahar Havivi has uploaded a new change for review.
Change subject: bz772670: [rhevh] network is not set after using boot params
..
bz772670: [rhevh] network is not set after using boot params
when using vdsm-reg we are
Shahar Havivi has uploaded a new change for review.
Change subject: bz773364 cancel-migration: abort migration on dest results an
exception
..
bz773364 cancel-migration: abort migration on dest results an exception
while
Shahar Havivi has posted comments on this change.
Change subject: bz773364 cancel-migration: abort migration on dest results an
exception
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/1041
To unsubscribe,
Shahar Havivi has posted comments on this change.
Change subject: setupNetwork: release deleted network first
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/893
To
Shahar Havivi has posted comments on this change.
Change subject: [WIP] add before_vm_destroy hook
..
Patch Set 1: I would prefer that you didn't submit this
you are missing the mkdir before_vm_destory in
Shahar Havivi has posted comments on this change.
Change subject: [WIP] add before_vm_destroy hook
..
Patch Set 1: Verified
(1 inline comment)
File vdsm/libvirtvm.py
Line
Shahar Havivi has posted comments on this change.
Change subject: [WIP] add before_vm_destroy hook
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/1175
To unsubscribe, visit http://gerrit.ovirt.org/settings
Shahar Havivi has posted comments on this change.
Change subject: added mtu support for network interface
..
Patch Set 3: (4 inline comments)
File vdsm/configNetwork.py
Line
Shahar Havivi has posted comments on this change.
Change subject: added mtu support for network interface
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/754
To unsubscribe, visit
Shahar Havivi has posted comments on this change.
Change subject: added mtu support for network interface
..
--
To view, visit http://gerrit.ovirt.org/754
To unsubscribe, visit http://gerrit.ovirt.org/settings
Shahar Havivi has posted comments on this change.
Change subject: add/del network - add bridgesless network
..
Patch Set 2: (3 inline comments)
File vdsm/configNetwork.py
Shahar Havivi has posted comments on this change.
Change subject: add/del network - add bridgesless network
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/848
To unsubscribe, visit
Shahar Havivi has posted comments on this change.
Change subject: added support for mirror promisc mode
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/956
To unsubscribe, visit
Shahar Havivi has posted comments on this change.
Change subject: added mtu support for network interface
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/754
To
Shahar Havivi has posted comments on this change.
Change subject: added mtu support for network interface
..
Patch Set 5: Verified; No score
--
To view, visit http://gerrit.ovirt.org/754
To unsubscribe, visit
Shahar Havivi has posted comments on this change.
Change subject: added mtu support for network interface
..
Patch Set 5: (1 inline comment)
File vdsm/netinfo.py
Line 61:
Shahar Havivi has posted comments on this change.
Change subject: added support for mirror promisc mode
..
Patch Set 2: (1 inline comment)
File vdsm/supervdsmServer.py
Line
Shahar Havivi has posted comments on this change.
Change subject: added mtu support for network interface
..
Patch Set 6: (2 inline comments)
File vdsm/configNetwork.py
Line
Shahar Havivi has uploaded a new change for review.
Change subject: promisc hook: release monitor traffic on before_vm_destory
..
promisc hook: release monitor traffic on before_vm_destory
after_vm_destroy is too late to
Shahar Havivi has posted comments on this change.
Change subject: added support for mirror promisc mode
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/956
To unsubscribe, visit
Shahar Havivi has posted comments on this change.
Change subject: add/del network - add bridgesless network
..
Patch Set 5: Verified
--
To view, visit http://gerrit.ovirt.org/848
To unsubscribe, visit
Shahar Havivi has posted comments on this change.
Change subject: added mtu support for network interface
..
Patch Set 8: Verified
--
To view, visit http://gerrit.ovirt.org/754
To unsubscribe, visit
Shahar Havivi has posted comments on this change.
Change subject: added support for mirror promisc mode
..
Patch Set 3: (1 inline comment)
File vdsm/tc.py
Line 23: class
Shahar Havivi has posted comments on this change.
Change subject: add/del network - add bridgesless network
..
Patch Set 7: Fails
problem with bond with vlans,
will send a new patch
--
To view, visit
Shahar Havivi has posted comments on this change.
Change subject: add/del network - add bridgesless network
..
Patch Set 8: Verified
--
To view, visit http://gerrit.ovirt.org/848
To unsubscribe, visit
Shahar Havivi has posted comments on this change.
Change subject: add/del network - add bridgesless network
..
Patch Set 8: (11 inline comments)
File vdsm/API.py
Line 1086:
Shahar Havivi has uploaded a new change for review.
Change subject: addNetwork in BindingXMLRPC is not forwarding options
..
addNetwork in BindingXMLRPC is not forwarding options
Change-Id:
Shahar Havivi has posted comments on this change.
Change subject: added mtu support for network interface
..
Patch Set 9: Verified
--
To view, visit http://gerrit.ovirt.org/754
To unsubscribe, visit
Shahar Havivi has posted comments on this change.
Change subject: add/del network - add bridgesless network
..
Patch Set 9: Verified
--
To view, visit http://gerrit.ovirt.org/848
To unsubscribe, visit
Shahar Havivi has posted comments on this change.
Change subject: added support for mirror promisc mode
..
Patch Set 6: Verified
--
To view, visit http://gerrit.ovirt.org/956
To unsubscribe, visit
Shahar Havivi has posted comments on this change.
Change subject: addNetwork in BindingXMLRPC is not forwarding options
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/1832
To unsubscribe, visit
Shahar Havivi has posted comments on this change.
Change subject: add/del network - add bridgesless network
..
Patch Set 9: (6 inline comments)
File vdsm/clientIF.py
Line
Shahar Havivi has posted comments on this change.
Change subject: configNet: drop local reimpl of utils.tobool
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/1864
To
1 - 100 of 828 matches
Mail list logo
