Tal Nisan has posted comments on this change.
Change subject: vm, guestagent: return hash should include also the disk mapping
..
Patch Set 3:
Rerun-Hooks: run
--
To view, visit http://gerrit.ovirt.org/33198
To unsubscribe, v
Tal Nisan has posted comments on this change.
Change subject: vm: return diskMapping on status()
..
Patch Set 3:
Rerun-Hooks: all
--
To view, visit http://gerrit.ovirt.org/33197
To unsubscribe, visit http://gerrit.ovirt.org/s
Tal Nisan has posted comments on this change.
Change subject: vm, guestagent: return hash should include also the disk mapping
..
Patch Set 3:
Rerun-Hooks: all
--
To view, visit http://gerrit.ovirt.org/33198
To unsubscribe, v
Tal Nisan has posted comments on this change.
Change subject: spec: Require qemu-kvm-rhev in EL
..
Patch Set 3:
Any updates about this patch? Seem to be stuck from the 14th
--
To view, visit http://gerrit.ovirt.org/32239
To u
Tal Nisan has posted comments on this change.
Change subject: qemuimg: Create qcow2 compat 0.10 images
..
Patch Set 1:
Guys, can we go forward with this patch?
--
To view, visit http://gerrit.ovirt.org/33022
To unsubscribe, v
Tal Nisan has uploaded a new change for review.
Change subject: Allow getFileStats for non NFS ISO domains
..
Allow getFileStats for non NFS ISO domains
getFileStats only allowed file stats to be gathered for NFS ISO domains
we
Tal Nisan has posted comments on this change.
Change subject: Allow getFileStats for non NFS ISO domains
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/25627
To unsubscribe, visit http://gerrit.ovirt.org/
Tal Nisan has uploaded a new change for review.
Change subject: Allow moving of sparse images to a block domains
..
Allow moving of sparse images to a block domains
When attempting to move a sparse image from a file domain to a
Tal Nisan has posted comments on this change.
Change subject: Allow moving of sparse images to a block domains
..
Patch Set 2:
(2 comments)
http://gerrit.ovirt.org/#/c/25778/2//COMMIT_MSG
Commit Message:
Line 6:
Line 7: Allo
Tal Nisan has posted comments on this change.
Change subject: Allow getFileStats for non NFS ISO domains
..
Patch Set 1:
(3 comments)
http://gerrit.ovirt.org/#/c/25627/1//COMMIT_MSG
Commit Message:
Line 5: CommitDate: 2014-03
Tal Nisan has uploaded a new change for review.
Change subject: Add the host uptime in seconds to host stats
..
Add the host uptime in seconds to host stats
Change-Id: I5ebb9c27d99e50dd397db6fc97e03c4215aed456
Signed-off-by: Tal
Tal Nisan has posted comments on this change.
Change subject: Add the host uptime in seconds to host stats
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/25835/1/vdsm/API.py
File vdsm/API.py:
Line 1238: stats
Tal Nisan has abandoned this change.
Change subject: Add the host uptime in seconds to host stats
..
Abandoned
Abandoned due to a similar patch pushed
--
To view, visit http://gerrit.ovirt.org/25835
To unsubscribe, visit http
Tal Nisan has posted comments on this change.
Change subject: Allow getFileStats for non NFS ISO domains
..
Patch Set 2: Verified+1
Verified with creating an NFS ISO domain and getting the correct file stats (in
order to make
Tal Nisan has uploaded a new change for review.
Change subject: Allow getFileStats for non NFS ISO domains
..
Allow getFileStats for non NFS ISO domains
getFileStats only allowed file stats to be gathered from NFS ISO domains.
W
Tal Nisan has posted comments on this change.
Change subject: Allow getFileStats for non NFS ISO domains
..
Patch Set 1:
Yes, a bug in 3.4 which is a regression, but you could have just click on the
bug link in the message and
Tal Nisan has posted comments on this change.
Change subject: Allow getFileStats for non NFS ISO domains
..
Patch Set 2: Verified+1
Verified with creating an NFS ISO domain and getting the correct file stats (in
order to make
Tal Nisan has posted comments on this change.
Change subject: Allow moving of sparse images to a block domains
..
Patch Set 7: Verified+1
Verified moving all different options of format types and sparse/preallocated
from file
Tal Nisan has posted comments on this change.
Change subject: Allow moving of sparse images to a block domains
..
Patch Set 7:
(1 comment)
http://gerrit.ovirt.org/#/c/25778/7/vdsm/storage/image.py
File vdsm/storage/image.py:
Tal Nisan has posted comments on this change.
Change subject: Allow moving of sparse images to a block domains
..
Patch Set 8: Verified+1
Verified moving all different options of format types and sparse/preallocated
from file
Tal Nisan has uploaded a new change for review.
Change subject: Fix a reference before assignment bug in Hsm.py
..
Fix a reference before assignment bug in Hsm.py
https://bugzilla.redhat.com/show_bug.cgi?id=1080106
Signed-off-by
Tal Nisan has posted comments on this change.
Change subject: Fix a reference before assignment bug in Hsm.py
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/26109/1/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:
Line
Tal Nisan has abandoned this change.
Change subject: Fix a reference before assignment bug in Hsm.py
..
Abandoned
After a discussion in the bug itself it seems that the workaround suggested is
not correct, thus abandoning
--
Hello Federico Simoncelli, Dan Kenigsberg, Allon Mureinik,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/26469
to review the following change.
Change subject: Allow moving of sparse images to a block domains
.
Tal Nisan has posted comments on this change.
Change subject: Allow moving of sparse images to a block domains
..
Patch Set 3: Verified+1
Verified moving all different options of format types and sparse/preallocated
from file
Tal Nisan has uploaded a new change for review.
Change subject: Create destination image as preallocated only if format is RAW
..
Create destination image as preallocated only if format is RAW
Create a destination image as preal
Tal Nisan has posted comments on this change.
Change subject: Create destination image as preallocated only if format is RAW
..
Patch Set 1:
(2 comments)
http://gerrit.ovirt.org/#/c/27244/1/vdsm/storage/image.py
File vdsm/stor
Tal Nisan has posted comments on this change.
Change subject: core: return lver/spm id from pool metadata
..
Patch Set 2:
In V4 it will al go away :)
--
To view, visit http://gerrit.ovirt.org/27226
To unsubscribe, vis
Tal Nisan has posted comments on this change.
Change subject: fileUtils: Make memory filesystems support configurable
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/27236
To unsubscribe, visit http://g
Tal Nisan has posted comments on this change.
Change subject: Create destination image as preallocated only if format is RAW
..
Patch Set 3: Verified+1
Verified by ratamir and some by me by:
- Cold move in the same storage type
Tal Nisan has posted comments on this change.
Change subject: storage: fix pep issue with image.py
..
Patch Set 1: Code-Review+1
Fix seems ok but it's strange, I double checked with pep8 on image.py before
pushing the patch, h
Tal Nisan has uploaded a new change for review.
Change subject: Create destination image as preallocated only if format is RAW
..
Create destination image as preallocated only if format is RAW
Create a destination image as preal
Tal Nisan has posted comments on this change.
Change subject: storage: fix pep issue with image.py
..
Patch Set 2:
On the contrary, I totally agreed with Douglas, the Jenkins build also failed
although it was a couple of hours
Tal Nisan has posted comments on this change.
Change subject: storage: fix pep issue with image.py
..
Patch Set 2:
I meant *a couple of hours after the merge
--
To view, visit http://gerrit.ovirt.org/27273
To unsubscribe, vis
Tal Nisan has posted comments on this change.
Change subject: Create destination image as preallocated only if format is RAW
..
Patch Set 1:
Verified by:
Cold move in the same storage type (block/file)
Cold move in the differen
Tal Nisan has posted comments on this change.
Change subject: Create destination image as preallocated only if format is RAW
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/27274
To unsubscribe, visit http
Tal Nisan has posted comments on this change.
Change subject: downloadFromStream
..
Patch Set 4:
(3 comments)
File vdsm/BindingXMLRPC.py
Line 152: co
Tal Nisan has abandoned this change.
Change subject: Raise specific exception when local path not exist
..
Abandoned
Stale
--
To view, visit http://gerrit.ovirt.org/13724
To unsubscribe, visit http://gerrit.ovirt.org/settings
Tal Nisan has posted comments on this change.
Change subject: API: move diskSizeExtend logic from BindingXMLRPC
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/36590
To unsubscribe, visit http://gerrit.
Hello Nir Soffer, Daniel Erez, Dan Kenigsberg, Allon Mureinik,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/36613
to review the following change.
Change subject: API: move diskSizeExtend logic from BindingXMLRPC
Hello Nir Soffer, Daniel Erez, Dan Kenigsberg, Allon Mureinik,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/36614
to review the following change.
Change subject: API: move diskSizeExtend logic from BindingXMLRPC
Tal Nisan has abandoned this change.
Change subject: API: move diskSizeExtend logic from BindingXMLRPC
..
Abandoned
Wrong branch, this is meant to be in ovirt-3.5
--
To view, visit http://gerrit.ovirt.org/36613
To unsubscribe
Tal Nisan has posted comments on this change.
Change subject: fileUtils: Remove bogus warning from log [1/2]
..
Patch Set 5:
Federico/Dan, ping?
--
To view, visit http://gerrit.ovirt.org/36764
To unsubscribe, visit http://ger
Tal Nisan has posted comments on this change.
Change subject: fileUtils: Remove bogus warning from log [1/2]
..
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/36764
To unsubscribe, visit http://gerrit.ovi
Tal Nisan has uploaded a new change for review.
Change subject: spec: Require lvm >= 2.02.100-8
..
spec: Require lvm >= 2.02.100-8
Change-Id: Iee80ffbbee55768aa632725c9f129813a8815d4b
Signed-off-by: Tal Nisan
Bug-Url: https://b
Tal Nisan has posted comments on this change.
Change subject: spec: Require lvm >= 2.02.100-8
..
Patch Set 3: Verified-1
I agree with Nir, I'm gonna try and contact the LVM bug assignee again to know
exactly which one we shoul
Tal Nisan has posted comments on this change.
Change subject: qemu-img: Handle image end offset on different lines of output
..
Patch Set 2: Code-Review+1
(1 comment)
Minor comment in the test
https://gerrit.ovirt.org/#/c/383
Tal Nisan has posted comments on this change.
Change subject: Logging: config logging in new process of remoteFileHandler
..
Patch Set 6:
Guys, please review asap
--
To view, visit http://gerrit.ovirt.org/9182
To unsubscribe,
Tal Nisan has posted comments on this change.
Change subject: Delete useless withRelaunch argument of onReboot in vm.py
..
Patch Set 1:
Hi Jarod,
Is the patch still relevant?
--
To view, visit http://gerrit.ovirt.org/9096
To u
Tal Nisan has posted comments on this change.
Change subject: Modify vdsm/netinfo.py for PEP8 compliance
..
Patch Set 1:
Hi Eli,
Is the patch still relevant?
--
To view, visit http://gerrit.ovirt.org/4334
To unsubscribe, visit
Tal Nisan has uploaded a new change for review.
Change subject: Raise specific exception when local path not exist
..
Raise specific exception when local path not exist
When trying to connect to local storage connection, raise a
Tal Nisan has posted comments on this change.
Change subject: Raise specific exception when local path not exist
..
Patch Set 2: (1 inline comment)
File vdsm/storage/storageS
Tal Nisan has posted comments on this change.
Change subject: Raise specific exception when local path not exist
..
Patch Set 3: (1 inline comment)
File vdsm/storage/storageS
Tal Nisan has posted comments on this change.
Change subject: spec: Require newer kernel version for RHEL
..
Patch Set 8:
Guys, please review, we need this for 3.5.6
--
To view, visit https://gerrit.ovirt.org/47078
To unsubsc
Tal Nisan has posted comments on this change.
Change subject: block: add blkdiscard on zero image
..
Patch Set 3:
ping???
--
To view, visit https://gerrit.ovirt.org/35631
To unsubscribe, visit https://gerrit.ovirt.org/setting
Tal Nisan has posted comments on this change.
Change subject: build: Introduce --enable-gluster-mgmt option
..
Patch Set 5:
Barak, this is a much needed patch, if you have a better solution please share
with us otherwise pleas
Tal Nisan has posted comments on this change.
Change subject: build: Introduce --enable-gluster-mgmt option
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/46708
To unsubscribe, visit https://gerrit.ov
Tal Nisan has posted comments on this change.
Change subject: spec: Require newer libvirt version for el7
..
Patch Set 3:
Ping?
--
To view, visit https://gerrit.ovirt.org/44834
To unsubscribe, visit https://gerrit.ovirt.org/s
Tal Nisan has posted comments on this change.
Change subject: Live Merge: Restore watermark tracking
..
Patch Set 4:
Ping?
--
To view, visit https://gerrit.ovirt.org/36924
To unsubscribe, visit https://gerrit.ovirt.org/settin
Tal Nisan has uploaded a new change for review.
Change subject: spec: Require newer multipath version
..
spec: Require newer multipath version
There is a race between udev and multiapth which is solved in newer
multipath version
Tal Nisan has posted comments on this change.
Change subject: spec: Require newer multipath version
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/49113/3//COMMIT_MSG
Commit Message:
Line 7: spec: Require newer mult
Hello Dan Kenigsberg, Allon Mureinik, Freddy Rolland,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/49444
to review the following change.
Change subject: spec: Require newer libvirt version for el7
..
Tal Nisan has posted comments on this change.
Change subject: spec: Require newer libvirt version for el7
..
Patch Set 1:
The error in the check-patch job is not relevant:
Error: nothing provides ovirt-vmconsole >= 1.0.0-0 need
Tal Nisan has posted comments on this change.
Change subject: spec: Require newer multipath version
..
Patch Set 8: Verified+1
--
To view, visit https://gerrit.ovirt.org/49113
To unsubscribe, visit https://gerrit.ovirt.org/set
Tal Nisan has uploaded a new change for review.
Change subject: spec: Require newer multipath version
..
spec: Require newer multipath version
There is a race between udev and multiapth which is solved in newer
multipath version
Tal Nisan has posted comments on this change.
Change subject: spec: Require newer multipath version
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/49461
To unsubscribe, visit https://gerrit.ovirt.org/set
Tal Nisan has posted comments on this change.
Change subject: spec: Require newer libvirt version for el7
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/49444
To unsubscribe, visit https://gerrit.ovirt.o
Tal Nisan has posted comments on this change.
Change subject: multipath: Fix "COMPELNT"/"Compellent Vol" configuration
..
Patch Set 6:
How can we proceed then? What do we need to verify? I guess we don't want to
leave it hangi
Tal Nisan has posted comments on this change.
Change subject: spmprotect: Switch from fencing by pid to fencing using
systemctl
..
Patch Set 7:
Dima, there is a comment waiting for you reply here
--
To view, visit https://ge
Tal Nisan has posted comments on this change.
Change subject: Cleanup of storage domain creation in hsm.py
..
Patch Set 2: Verified+1
Verified by creating a file domain and a block domain, both worked correctly
--
To view, vi
Tal Nisan has uploaded a new change for review.
Change subject: Cleanup of storage domain creation in hsm.py
..
Cleanup of storage domain creation in hsm.py
This patch changes the specific per domain type creation handling is do
Tal Nisan has posted comments on this change.
Change subject: blockVolume: Fail if metadata overflows
..
Patch Set 3: Code-Review+1
Giving +1 from the Engine side of the patch
--
To view, visit https://gerrit.ovirt.org/45472
Tal Nisan has posted comments on this change.
Change subject: virt: Use libvirt to get drive size
..
Patch Set 1:
(3 comments)
https://gerrit.ovirt.org/#/c/55399/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 3498
Line 3499
Lin
Tal Nisan has posted comments on this change.
Change subject: storage: fix spec normalization when mounting
..
Patch Set 8:
ping?
--
To view, visit https://gerrit.ovirt.org/55182
To unsubscribe, visit https://gerrit.ovirt.org
Tal Nisan has posted comments on this change.
Change subject: qemuimg: Make QCOW2_COMPAT configurable
..
Patch Set 2:
Adam, ping?
--
To view, visit https://gerrit.ovirt.org/54759
To unsubscribe, visit https://gerrit.ovirt.org
Tal Nisan has posted comments on this change.
Change subject: spec: qemu-kvm-img to handle unaligned images
..
Patch Set 1:
Nir, ping?
--
To view, visit https://gerrit.ovirt.org/56142
To unsubscribe, visit https://gerrit.ovir
Tal Nisan has posted comments on this change.
Change subject: Don't prepare image with illegal volumes
..
Patch Set 1: Code-Review-1
Wait with the merge, we need a different Bug-Url
--
To view, visit https://gerrit.ovirt.org/
Tal Nisan has posted comments on this change.
Change subject: Don't prepare image with illegal volumes
..
Patch Set 1: -Code-Review
Please use this bug in the Bug-Url:
https://bugzilla.redhat.com/1332038
--
To view, visit ht
Tal Nisan has posted comments on this change.
Change subject: Added the option to scan alignment directly according to a
config value
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/40402/5/lib/vdsm/config.py.in
File
Tal Nisan has posted comments on this change.
Change subject: Added the option to scan alignment directly according to a
config value
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/40402/5//COMMIT_MSG
Commit Message
Tal Nisan has posted comments on this change.
Change subject: vdsClient: Fix typo parmeter->parameter
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/51300
To unsubscribe, visit https://gerrit.ovirt.or
Tal Nisan has posted comments on this change.
Change subject: nfs-check.py: apostrophe
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/51301
To unsubscribe, visit https://gerrit.ovirt.org/settings
Ger
Tal Nisan has posted comments on this change.
Change subject: schema: Fix Typos
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/51302
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-Mes
Tal Nisan has posted comments on this change.
Change subject: compat.py: Fixed typo "libary"->"library"
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/51303
To unsubscribe, visit https://gerrit.ovirt.
Tal Nisan has posted comments on this change.
Change subject: zombiereaper: Fix typo "happend" -> "happened"
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/51305
To unsubscribe, visit https://gerrit.o
Tal Nisan has posted comments on this change.
Change subject: sigutils: Fix typo "the the" -> "the"
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/51304
To unsubscribe, visit https://gerrit.ovirt.org/
Tal Nisan has posted comments on this change.
Change subject: dump_volume_chains.py: Spelling in comment
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/51306
To unsubscribe, visit https://gerrit.ovirt
Tal Nisan has posted comments on this change.
Change subject: utils.py: Fix typo "placeholer" -> "placeholder"
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/51307
To unsubscribe, visit https://gerrit
Tal Nisan has posted comments on this change.
Change subject: rwlock_test.py: Fix typo "shold" -> "should"
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/51310
To unsubscribe, visit https://gerrit.ovi
Tal Nisan has posted comments on this change.
Change subject: momTests.py: Fix typo "paramters" -> "parameters"
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/51309
To unsubscribe, visit https://gerri
Tal Nisan has posted comments on this change.
Change subject: betterAsyncore.py: Fix typo "enought"->"enough"
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/51308
To unsubscribe, visit https://gerrit.
Tal Nisan has posted comments on this change.
Change subject: sslTests.py: Fix typos
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/51311
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerri
Tal Nisan has posted comments on this change.
Change subject: verify.py: Fix typo "attribets" -> "attributes"
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/51312
To unsubscribe, visit https://gerrit.
Tal Nisan has posted comments on this change.
Change subject: Alignment scans will not run in direct mode
..
Patch Set 7: Verified+1
--
To view, visit https://gerrit.ovirt.org/40402
To unsubscribe, visit https://gerrit.ovirt.o
Tal Nisan has uploaded a new change for review.
Change subject: Return correct scan alignment result through jsonrpc
..
Return correct scan alignment result through jsonrpc
Change-Id: If9ace1a9596f13225e493eda090d69a82d7c2bc1
Si
Tal Nisan has posted comments on this change.
Change subject: Return correct scan alignment result through jsonrpc
..
Patch Set 2:
(5 comments)
https://gerrit.ovirt.org/#/c/51607/2//COMMIT_MSG
Commit Message:
Line 3: AuthorDa
Tal Nisan has posted comments on this change.
Change subject: Return correct scan alignment result through jsonrpc
..
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/51607/3/lib/api/vdsmapi-schema.json
File lib/api/vdsm
Tal Nisan has posted comments on this change.
Change subject: Return correct scan alignment result through jsonrpc
..
Patch Set 8: Verified+1
--
To view, visit https://gerrit.ovirt.org/51607
To unsubscribe, visit https://gerri
Tal Nisan has uploaded a new change for review.
Change subject: Return correct scan alignment result through jsonrpc
..
Return correct scan alignment result through jsonrpc
Since jsonrpc was introduced in oVirt 3.5 the scan alig
Tal Nisan has posted comments on this change.
Change subject: Alignment scans will not run in direct mode
..
Patch Set 10: Verified+1
--
To view, visit https://gerrit.ovirt.org/40402
To unsubscribe, visit https://gerrit.ovirt.
1 - 100 of 120 matches
Mail list logo