Change in vdsm[master]: Change waitForMigrationDestinationPrepare function waiting.
Michal Skrivanek has posted comments on this change. Change subject: Change waitForMigrationDestinationPrepare function waiting. .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/6396 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I017980ee6da676af654b0dd225928830818ebbd3 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Change waitForMigrationDestinationPrepare function waiting.
Dan Kenigsberg has submitted this change and it was merged. Change subject: Change waitForMigrationDestinationPrepare function waiting. .. Change waitForMigrationDestinationPrepare function waiting. The change is to avoid timeouts during migration of several VMs at once. The new implementation doesn't start the timer until the VM starts it creation (e.g. acquired the _ongoingCreations lock). Change-Id: I017980ee6da676af654b0dd225928830818ebbd3 Signed-off-by: Gal Hammer gham...@redhat.com --- M vdsm/libvirtvm.py M vdsm/vm.py 2 files changed, 6 insertions(+), 0 deletions(-) Approvals: Gal Hammer: Verified Dan Kenigsberg: Looks good to me, approved Michal Skrivanek: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/6396 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I017980ee6da676af654b0dd225928830818ebbd3 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Change waitForMigrationDestinationPrepare function waiting.
Michal Skrivanek has posted comments on this change.
Change subject: Change waitForMigrationDestinationPrepare function waiting.
..
Patch Set 1: (1 inline comment)
File vdsm/libvirtvm.py
Line 2429:
Line 2430: def waitForMigrationDestinationPrepare(self):
Line 2431: Wait until paths are prepared for migration destination
Line 2432: # Wait for the VM to start its creation. There is no reason
to start
Line 2433: # the timed waiting for path prepreation before the work has
started.
preparation
Line 2434: self.log.debug('migration destination: waiting for VM
creation')
Line 2435: self._vmCreationEvent.wait()
Line 2436: prepareTimeout = self._loadCorrectedTimeout(
Line 2437: config.getint('vars',
'migration_listener_timeout'),
--
To view, visit http://gerrit.ovirt.org/6396
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I017980ee6da676af654b0dd225928830818ebbd3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Gal Hammer gham...@redhat.com
Gerrit-Reviewer: Barak Azulay bazu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Gal Hammer gham...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Change waitForMigrationDestinationPrepare function waiting.
Gal Hammer has posted comments on this change. Change subject: Change waitForMigrationDestinationPrepare function waiting. .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/6396 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I017980ee6da676af654b0dd225928830818ebbd3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Change waitForMigrationDestinationPrepare function waiting.
Gal Hammer has posted comments on this change. Change subject: Change waitForMigrationDestinationPrepare function waiting. .. Patch Set 1: No score -- To view, visit http://gerrit.ovirt.org/6396 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I017980ee6da676af654b0dd225928830818ebbd3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Change waitForMigrationDestinationPrepare function waiting.
Peter V. Saveliev has posted comments on this change. Change subject: Change waitForMigrationDestinationPrepare function waiting. .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/6396 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I017980ee6da676af654b0dd225928830818ebbd3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Change waitForMigrationDestinationPrepare function waiting.
Dan Kenigsberg has posted comments on this change. Change subject: Change waitForMigrationDestinationPrepare function waiting. .. Patch Set 1: Looks good to me, but someone else must approve as with anything that is relating to migration, this requires real-world verification. -- To view, visit http://gerrit.ovirt.org/6396 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I017980ee6da676af654b0dd225928830818ebbd3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Change waitForMigrationDestinationPrepare function waiting.
Gal Hammer has uploaded a new change for review. Change subject: Change waitForMigrationDestinationPrepare function waiting. .. Change waitForMigrationDestinationPrepare function waiting. The change is to avoid timeouts during migration of several VMs at once. The new implementation doesn't start the timer until the VM starts it creation (e.g. acquired the _ongoingCreations lock). Change-Id: I017980ee6da676af654b0dd225928830818ebbd3 Signed-off-by: Gal Hammer gham...@redhat.com --- M vdsm/libvirtvm.py M vdsm/vm.py 2 files changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/96/6396/1 -- To view, visit http://gerrit.ovirt.org/6396 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I017980ee6da676af654b0dd225928830818ebbd3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer gham...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
