Change in vdsm[master]: Define the StorageDomain.reduce API

2016-09-21 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: Define the StorageDomain.reduce API
..


Patch Set 9:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62853
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5e41b9fa2df4ffef1f3cbb9fbfc57022ffedd9a
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Define the StorageDomain.reduce API

2016-09-21 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: Define the StorageDomain.reduce API
..


Patch Set 8:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62853
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5e41b9fa2df4ffef1f3cbb9fbfc57022ffedd9a
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Define the StorageDomain.reduce API

2016-09-21 Thread laravot 
Liron Aravot has posted comments on this change.

Change subject: Define the StorageDomain.reduce API
..


Patch Set 7:

(2 comments)

https://gerrit.ovirt.org/#/c/62853/7/vdsm/API.py
File vdsm/API.py:

Line 1078: def extend(self, storagepoolID, devlist, force=False):
Line 1079: return self._irs.extendStorageDomain(self._UUID, 
storagepoolID,
Line 1080:  devlist, force)
Line 1081: 
Line 1082: def reduce(self, jobID, guid):
> Please use the same name in all layers (jobID or jobUUID or job_id).
the names are different across the layers for all the verbs as it seems - i 
added this one to match the current pattern.
Line 1083: return self._irs.reduceStorageDomain(jobID, self._UUID, guid)
Line 1084: 
Line 1085: def resizePV(self, storagepoolID, guid):
Line 1086: return self._irs.resizePV(self._UUID, storagepoolID, guid)


https://gerrit.ovirt.org/#/c/62853/7/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:

Line 747: """
Line 748: Reduce a block-based Storage Domain by removing a device from 
it.
Line 749: 
Line 750: :param UUID: The UUID of the job.
Line 751: :type UUID: UUID
> UUID -> jobUUID
Done
Line 752: :param sdUUID: The UUID of the storage domain that owns the 
PV.
Line 753: :type sdUUID: UUID
Line 754: :param guid: A block device GUID
Line 755: :type guid: str


-- 
To view, visit https://gerrit.ovirt.org/62853
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5e41b9fa2df4ffef1f3cbb9fbfc57022ffedd9a
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Define the StorageDomain.reduce API

2016-09-15 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: Define the StorageDomain.reduce API
..


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/62853/3/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml:

Line 8216: -   description: A UUID to be used for tracking the job progress
Line 8217: name: jobID
Line 8218: type: *UUID
Line 8219: 
Line 8220: -   description: The UUID of the Storage Domain
> Why isn't the SD UUID the first param? (I see in most cases it is, that's a
New storage apis are always running in a job, and accept job_id generated by 
engine as the first argument. See for example SDM.copy_data.

Old apis running asynchronously return a task uuid. If communication between 
engine and vdsm brake before engine got a reply, it does not have any way to 
detect the task created in vdsm.

New apis also use complex argument(s) so we don't have to pass around so many 
arguments via the different layers, and we can validate the input automatically 
using properties, see vdsm/storage/sdm/api/copy_data.py.
Line 8221: name: storagedomainID
Line 8222: type: *UUID
Line 8223: 
Line 8224: -   description: A block device GUID


-- 
To view, visit https://gerrit.ovirt.org/62853
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5e41b9fa2df4ffef1f3cbb9fbfc57022ffedd9a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Define the StorageDomain.reduce API

2016-09-15 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: Define the StorageDomain.reduce API
..


Patch Set 7:

(3 comments)

https://gerrit.ovirt.org/#/c/62853/7/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml:

Line 8228: type: *UUID
Line 8229: 
Line 8230: -   description: A block device GUID
Line 8231: name: guid
Line 8232: type: string
I would like to have new style api similar to copy_data.

This is also more correct as this operation is not really performed on the 
storage domain object, but passed to irs anyway, and run in a job.
Line 8233: 
Line 8234: StorageDomain.resizePV:
Line 8235: added: '3.6'
Line 8236: description: Resize PV will cause the PV to use the entire size 
of the


https://gerrit.ovirt.org/#/c/62853/7/vdsm/API.py
File vdsm/API.py:

Line 1078: def extend(self, storagepoolID, devlist, force=False):
Line 1079: return self._irs.extendStorageDomain(self._UUID, 
storagepoolID,
Line 1080:  devlist, force)
Line 1081: 
Line 1082: def reduce(self, jobID, guid):
Please use the same name in all layers (jobID or jobUUID or job_id).
Line 1083: return self._irs.reduceStorageDomain(jobID, self._UUID, guid)
Line 1084: 
Line 1085: def resizePV(self, storagepoolID, guid):
Line 1086: return self._irs.resizePV(self._UUID, storagepoolID, guid)


https://gerrit.ovirt.org/#/c/62853/7/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:

Line 747: """
Line 748: Reduce a block-based Storage Domain by removing a device from 
it.
Line 749: 
Line 750: :param UUID: The UUID of the job.
Line 751: :type UUID: UUID
UUID -> jobUUID
Line 752: :param sdUUID: The UUID of the storage domain that owns the 
PV.
Line 753: :type sdUUID: UUID
Line 754: :param guid: A block device GUID
Line 755: :type guid: str


-- 
To view, visit https://gerrit.ovirt.org/62853
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5e41b9fa2df4ffef1f3cbb9fbfc57022ffedd9a
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Define the StorageDomain.reduce API

2016-09-05 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: Define the StorageDomain.reduce API
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62853
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5e41b9fa2df4ffef1f3cbb9fbfc57022ffedd9a
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Define the StorageDomain.reduce API

2016-09-04 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: Define the StorageDomain.reduce API
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62853
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5e41b9fa2df4ffef1f3cbb9fbfc57022ffedd9a
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Define the StorageDomain.reduce API

2016-09-04 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: Define the StorageDomain.reduce API
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62853
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5e41b9fa2df4ffef1f3cbb9fbfc57022ffedd9a
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Define the StorageDomain.reduce API

2016-08-30 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: Define the StorageDomain.reduce API
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62853
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5e41b9fa2df4ffef1f3cbb9fbfc57022ffedd9a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Define the StorageDomain.reduce API

2016-08-29 Thread ykaul 
Yaniv Kaul has posted comments on this change.

Change subject: Define the StorageDomain.reduce API
..


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/62853/3/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml:

Line 8216: -   description: A UUID to be used for tracking the job progress
Line 8217: name: jobID
Line 8218: type: *UUID
Line 8219: 
Line 8220: -   description: The UUID of the Storage Domain
Why isn't the SD UUID the first param? (I see in most cases it is, that's all).
Line 8221: name: storagedomainID
Line 8222: type: *UUID
Line 8223: 
Line 8224: -   description: A block device GUID


-- 
To view, visit https://gerrit.ovirt.org/62853
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5e41b9fa2df4ffef1f3cbb9fbfc57022ffedd9a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Define the StorageDomain.reduce API

2016-08-28 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: Define the StorageDomain.reduce API
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62853
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5e41b9fa2df4ffef1f3cbb9fbfc57022ffedd9a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Define the StorageDomain.reduce API

2016-08-28 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: Define the StorageDomain.reduce API
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62853
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5e41b9fa2df4ffef1f3cbb9fbfc57022ffedd9a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Define the StorageDomain.reduce API

2016-08-25 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: Define the StorageDomain.reduce API
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62853
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5e41b9fa2df4ffef1f3cbb9fbfc57022ffedd9a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org