Change in vdsm[master]: Enabled selinux boolean virt_use_glusterd for glusterd

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: Enabled selinux boolean virt_use_glusterd for glusterd
..


Patch Set 3: Code-Review+1 Verified+1

copying scores after nit fix

-- 
To view, visit https://gerrit.ovirt.org/81088
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia92a0c43ba2b149597a2321328ca1506f4dddf12
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Gobinda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Denis Chapligin 
Gerrit-Reviewer: Gobinda 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Enabled selinux boolean virt_use_glusterd for glusterd

[Code Review]

From Yaniv Bronhaim :

Yaniv Bronhaim has posted comments on this change.

Change subject: Enabled selinux boolean virt_use_glusterd for glusterd
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/81088
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia92a0c43ba2b149597a2321328ca1506f4dddf12
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Gobinda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Denis Chapligin 
Gerrit-Reviewer: Gobinda 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Enabled selinux boolean virt_use_glusterd for glusterd

[Code Review]

From Yaniv Bronhaim :

Yaniv Bronhaim has posted comments on this change.

Change subject: Enabled selinux boolean virt_use_glusterd for glusterd
..


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/81088/1//COMMIT_MSG
Commit Message:

Line 6: 
Line 7: Enabled selinux boolean virt_use_glusterd for glusterd
Line 8: 
Line 9: bug-url: https://bugzilla.redhat.com/show_bug.cgi?id=1458257
Line 10: 
redundant empty line, and please use capital letter for Bug-Url: ..
Line 11: Change-Id: Ia92a0c43ba2b149597a2321328ca1506f4dddf12


-- 
To view, visit https://gerrit.ovirt.org/81088
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia92a0c43ba2b149597a2321328ca1506f4dddf12
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Gobinda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Denis Chapligin 
Gerrit-Reviewer: Gobinda 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Enabled selinux boolean virt_use_glusterd for glusterd

[Code Review]

From Yaniv Bronhaim :

Yaniv Bronhaim has posted comments on this change.

Change subject: Enabled selinux boolean virt_use_glusterd for glusterd
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/81088/1/lib/vdsm/tool/configurators/sebool.py
File lib/vdsm/tool/configurators/sebool.py:

Line 1: # Copyright 2012 Red Hat, Inc.
please change to 2012-2017
Line 2: #
Line 3: # This program is free software; you can redistribute it and/or modify
Line 4: # it under the terms of the GNU General Public License as published by
Line 5: # the Free Software Foundation; either version 2 of the License, or


-- 
To view, visit https://gerrit.ovirt.org/81088
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia92a0c43ba2b149597a2321328ca1506f4dddf12
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Gobinda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Denis Chapligin 
Gerrit-Reviewer: Gobinda 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org