Change in vdsm[master]: RPC client: Add methods to subscribe, unsubscribe and notify
From Yaniv Bronhaim: Yaniv Bronhaim has posted comments on this change. Change subject: RPC client: Add methods to subscribe, unsubscribe and notify .. Patch Set 46: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/78657 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie5b1e2eace452bf663c34c721bbe3ff9fcabb095 Gerrit-PatchSet: 46 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Andrej Krejcir Gerrit-Reviewer: Andrej Krejcir Gerrit-Reviewer: Denis Chaplygin Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Phillip Bailey Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Roman Mohr Gerrit-Reviewer: Yanir Quinn Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: RPC client: Add methods to subscribe, unsubscribe and notify
From Yaniv Bronhaim: Yaniv Bronhaim has posted comments on this change. Change subject: RPC client: Add methods to subscribe, unsubscribe and notify .. Patch Set 21: I like the tests, but it sounds odd that we don't have client_test module already ... so I grabbed for it and saw some tests in stompTests - worth to put all client tests under your new test module Thanks! -- To view, visit https://gerrit.ovirt.org/78657 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie5b1e2eace452bf663c34c721bbe3ff9fcabb095 Gerrit-PatchSet: 21 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Andrej Krejcir Gerrit-Reviewer: Andrej Krejcir Gerrit-Reviewer: Denis Chaplygin Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Phillip Bailey Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Roman Mohr Gerrit-Reviewer: Yanir Quinn Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: RPC client: Add methods to subscribe, unsubscribe and notify
From Yaniv Bronhaim: Yaniv Bronhaim has posted comments on this change. Change subject: RPC client: Add methods to subscribe, unsubscribe and notify .. Patch Set 21: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/78657 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie5b1e2eace452bf663c34c721bbe3ff9fcabb095 Gerrit-PatchSet: 21 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Andrej Krejcir Gerrit-Reviewer: Andrej Krejcir Gerrit-Reviewer: Denis Chaplygin Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Phillip Bailey Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Roman Mohr Gerrit-Reviewer: Yanir Quinn Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: RPC client: Add methods to subscribe, unsubscribe and notify
From Yaniv Bronhaim: Yaniv Bronhaim has posted comments on this change. Change subject: RPC client: Add methods to subscribe, unsubscribe and notify .. Patch Set 21: (1 comment) https://gerrit.ovirt.org/#/c/78657/21/lib/vdsm/client.py File lib/vdsm/client.py: Line 214 Line 215 Line 216 Line 217 Line 218 why do you remove that? -- To view, visit https://gerrit.ovirt.org/78657 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie5b1e2eace452bf663c34c721bbe3ff9fcabb095 Gerrit-PatchSet: 21 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Andrej Krejcir Gerrit-Reviewer: Andrej Krejcir Gerrit-Reviewer: Denis Chaplygin Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Phillip Bailey Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Roman Mohr Gerrit-Reviewer: Yanir Quinn Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org