Change in vdsm[master]: cmdutils: add env to exec_cmd()'s args
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79694 ) Change subject: cmdutils: add env to exec_cmd()'s args .. cmdutils: add env to exec_cmd()'s args Expose Popen's env argument throught exec_cmd(). The newly-introduced argument is going to be used by hooks.py in the following patch. Change-Id: I109c50c4dd85347e12e8a9a11963b0cded685536 Signed-off-by: Dan Kenigsberg --- M lib/vdsm/common/cmdutils.py M tests/common/cmdutils_test.py 2 files changed, 12 insertions(+), 2 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, approved Nir Soffer: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Dan Kenigsberg: Verified Francesco Romani: Looks good to me, but someone else must approve Edward Haas: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/79694 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I109c50c4dd85347e12e8a9a11963b0cded685536 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: cmdutils: add env to exec_cmd()'s args
From Dan Kenigsberg :
Dan Kenigsberg has posted comments on this change.
Change subject: cmdutils: add env to exec_cmd()'s args
..
Patch Set 10:
(1 comment)
https://gerrit.ovirt.org/#/c/79694/10/tests/common/cmdutils_test.py
File tests/common/cmdutils_test.py:
Line 147: self.assertEqual(out, b'')
Line 148:
Line 149: def test_exec_cmd_with_env(self):
Line 150: rc, out, err = cmdutils.exec_cmd(
Line 151: ('sh', '-c', 'echo $XXX'), env={'XXX': 'hello'})
> printenv XXX would be little nicer.
but more obscure - I did not know of it.
Line 152: self.assertEqual(rc, 0)
--
To view, visit https://gerrit.ovirt.org/79694
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I109c50c4dd85347e12e8a9a11963b0cded685536
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Edward Haas
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: cmdutils: add env to exec_cmd()'s args
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: cmdutils: add env to exec_cmd()'s args .. Patch Set 10: Verified+1 OST passes http://jenkins.ovirt.org/view/oVirt%20system%20tests/job/ovirt-system-tests_manual/899/ -- To view, visit https://gerrit.ovirt.org/79694 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I109c50c4dd85347e12e8a9a11963b0cded685536 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: cmdutils: add env to exec_cmd()'s args
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: cmdutils: add env to exec_cmd()'s args .. Patch Set 8: Verified+1 -- To view, visit https://gerrit.ovirt.org/79694 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I109c50c4dd85347e12e8a9a11963b0cded685536 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: cmdutils: add env to exec_cmd()'s args
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: cmdutils: add env to exec_cmd()'s args .. Patch Set 6: Verified+1 -- To view, visit https://gerrit.ovirt.org/79694 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I109c50c4dd85347e12e8a9a11963b0cded685536 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
