gerrit-hooks has posted comments on this change.
Change subject: core: Expose API for qemuimg commit
..
Patch Set 13:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Nir Soffer has submitted this change and it was merged.
Change subject: core: Expose API for qemuimg commit
..
core: Expose API for qemuimg commit
Change-Id: If7a13be40541fb268541bd8614a642263b96b487
Signed-off-by: Ala Hino
Nir Soffer has posted comments on this change.
Change subject: core: Expose API for qemuimg commit
..
Patch Set 12: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/64222
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: core: Expose API for qemuimg commit
..
Patch Set 12: Code-Review+2
(2 comments)
https://gerrit.ovirt.org/#/c/64222/12/lib/vdsm/qemuimg.py
File
Ala Hino has posted comments on this change.
Change subject: core: Expose API for qemuimg commit
..
Patch Set 12: Verified+1
--
To view, visit https://gerrit.ovirt.org/64222
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: core: Expose API for qemuimg commit
..
Patch Set 12: Code-Review+1 Continuous-Integration+1
Thanks Ala, excellent work!
Network tests failing again.
Waiting for
gerrit-hooks has posted comments on this change.
Change subject: core: Expose API for qemuimg commit
..
Patch Set 12:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Ala Hino has posted comments on this change.
Change subject: core: Expose API for qemuimg commit
..
Patch Set 11:
(15 comments)
https://gerrit.ovirt.org/#/c/64222/11/tests/qemuimg_test.py
File tests/qemuimg_test.py:
Line
Nir Soffer has posted comments on this change.
Change subject: core: Expose API for qemuimg commit
..
Patch Set 11:
(15 comments)
https://gerrit.ovirt.org/#/c/64222/11/tests/qemuimg_test.py
File tests/qemuimg_test.py:
Line
gerrit-hooks has posted comments on this change.
Change subject: core: Expose API for qemuimg commit
..
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Ala Hino has posted comments on this change.
Change subject: core: Expose API for qemuimg commit
..
Patch Set 9:
(6 comments)
https://gerrit.ovirt.org/#/c/64222/9/tests/qemuimg_test.py
File tests/qemuimg_test.py:
Line 380:
gerrit-hooks has posted comments on this change.
Change subject: core: Expose API for qemuimg commit
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Nir Soffer has posted comments on this change.
Change subject: core: Expose API for qemuimg commit
..
Patch Set 9:
(1 comment)
https://gerrit.ovirt.org/#/c/64222/9/tests/qemuimg_test.py
File tests/qemuimg_test.py:
Line 380:
Nir Soffer has posted comments on this change.
Change subject: core: Expose API for qemuimg commit
..
Patch Set 9:
(5 comments)
https://gerrit.ovirt.org/#/c/64222/9/tests/qemuimg_test.py
File tests/qemuimg_test.py:
Line 391:
gerrit-hooks has posted comments on this change.
Change subject: core: Expose API for qemuimg commit
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Ala Hino has posted comments on this change.
Change subject: core: Expose API for qemuimg commit
..
Patch Set 8:
(12 comments)
https://gerrit.ovirt.org/#/c/64222/8/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:
Line 193:
Nir Soffer has posted comments on this change.
Change subject: core: Expose API for qemuimg commit
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/64222/8/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:
Line 193:
Nir Soffer has posted comments on this change.
Change subject: core: Expose API for qemuimg commit
..
Patch Set 8:
(11 comments)
Tests are nice, but we are reinventing storagetestlib.write_qemu_chain and
gerrit-hooks has posted comments on this change.
Change subject: core: Expose API for qemuimg commit
..
Patch Set 8:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is a
gerrit-hooks has posted comments on this change.
Change subject: core: Expose API for qemuimg commit
..
Patch Set 7:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is a
Ala Hino has posted comments on this change.
Change subject: core: Expose API for qemuimg commit
..
Patch Set 6:
(8 comments)
https://gerrit.ovirt.org/#/c/64222/6/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:
Line 186:
Line
Nir Soffer has posted comments on this change.
Change subject: core: Expose API for qemuimg commit
..
Patch Set 6:
(3 comments)
https://gerrit.ovirt.org/#/c/64222/6/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:
Line 186:
Nir Soffer has posted comments on this change.
Change subject: core: Expose API for qemuimg commit
..
Patch Set 6:
(5 comments)
Partial review.
https://gerrit.ovirt.org/#/c/64222/6/tests/qemuimg_test.py
File
gerrit-hooks has posted comments on this change.
Change subject: core: Expose API for qemuimg commit
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Ala Hino has posted comments on this change.
Change subject: core: Expose API for qemuimg commit
..
Patch Set 5:
(7 comments)
Nir, note that I created a single test that covers all use cases. I am hoping
that I addressed all
gerrit-hooks has posted comments on this change.
Change subject: core: Expose API for qemuimg commit
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
26 matches
Mail list logo
