Change in vdsm[master]: devices: add is_hostdevice attribute
gerrit-hooks has posted comments on this change. Change subject: devices: add is_hostdevice attribute .. Patch Set 10: * #62063::Update tracker: OK * #1356161::Update tracker: OK * Set MODIFIED::bug 1356161#1356161IGNORE, not all related patches are closed, check 60640 -- To view, visit https://gerrit.ovirt.org/62063 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icd5c42b371d9bf0eafd99e8ad880f3f97b444e75 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: devices: add is_hostdevice attribute
Dan Kenigsberg has submitted this change and it was merged. Change subject: devices: add is_hostdevice attribute .. devices: add is_hostdevice attribute is_hostdevice attribute is currently used to determine whether given device is so called host device, or in other words if it refers to physical device. At the moment, only devices HOSTDEV and NETWORK may be host devices, but moving the attribute to interface level allows us to greatly simplify host NUMA scheduling. Change-Id: Icd5c42b371d9bf0eafd99e8ad880f3f97b444e75 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1356161 Signed-off-by: Martin Polednik Reviewed-on: https://gerrit.ovirt.org/62063 Reviewed-by: Francesco Romani Continuous-Integration: Jenkins CI --- M vdsm/virt/vmdevices/core.py 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Francesco Romani: Looks good to me, approved Martin Polednik: Verified -- To view, visit https://gerrit.ovirt.org/62063 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icd5c42b371d9bf0eafd99e8ad880f3f97b444e75 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: devices: add is_hostdevice attribute
Martin Polednik has posted comments on this change. Change subject: devices: add is_hostdevice attribute .. Patch Set 9: Verified+1 -- To view, visit https://gerrit.ovirt.org/62063 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icd5c42b371d9bf0eafd99e8ad880f3f97b444e75 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: devices: add is_hostdevice attribute
gerrit-hooks has posted comments on this change. Change subject: devices: add is_hostdevice attribute .. Patch Set 9: * #1356161::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1356161::OK, public bug * Check Product::#1356161::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/62063 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icd5c42b371d9bf0eafd99e8ad880f3f97b444e75 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: devices: add is_hostdevice attribute
gerrit-hooks has posted comments on this change. Change subject: devices: add is_hostdevice attribute .. Patch Set 8: * #1356161::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1356161::OK, public bug * Check Product::#1356161::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/62063 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icd5c42b371d9bf0eafd99e8ad880f3f97b444e75 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: devices: add is_hostdevice attribute
Francesco Romani has posted comments on this change. Change subject: devices: add is_hostdevice attribute .. Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/62063 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icd5c42b371d9bf0eafd99e8ad880f3f97b444e75 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: devices: add is_hostdevice attribute
gerrit-hooks has posted comments on this change. Change subject: devices: add is_hostdevice attribute .. Patch Set 7: * #1356161::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1356161::OK, public bug * Check Product::#1356161::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/62063 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icd5c42b371d9bf0eafd99e8ad880f3f97b444e75 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: devices: add is_hostdevice attribute
gerrit-hooks has posted comments on this change. Change subject: devices: add is_hostdevice attribute .. Patch Set 6: * #1356161::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1356161::OK, public bug * Check Product::#1356161::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/62063 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icd5c42b371d9bf0eafd99e8ad880f3f97b444e75 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: devices: add is_hostdevice attribute
gerrit-hooks has posted comments on this change. Change subject: devices: add is_hostdevice attribute .. Patch Set 5: * #1356161::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1356161::OK, public bug * Check Product::#1356161::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/62063 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icd5c42b371d9bf0eafd99e8ad880f3f97b444e75 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: devices: add is_hostdevice attribute
Francesco Romani has posted comments on this change. Change subject: devices: add is_hostdevice attribute .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/62063 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icd5c42b371d9bf0eafd99e8ad880f3f97b444e75 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: devices: add is_hostdevice attribute
gerrit-hooks has posted comments on this change. Change subject: devices: add is_hostdevice attribute .. Patch Set 4: * #1356161::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1356161::OK, public bug * Check Product::#1356161::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/62063 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icd5c42b371d9bf0eafd99e8ad880f3f97b444e75 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: devices: add is_hostdevice attribute
gerrit-hooks has posted comments on this change. Change subject: devices: add is_hostdevice attribute .. Patch Set 3: * #1356161::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1356161::OK, public bug * Check Product::#1356161::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/62063 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icd5c42b371d9bf0eafd99e8ad880f3f97b444e75 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: devices: add is_hostdevice attribute
Jenkins CI has posted comments on this change. Change subject: devices: add is_hostdevice attribute .. Patch Set 2: Continuous-Integration-1 Propagate review hook: Continuous Integration value inherited from patch 1 -- To view, visit https://gerrit.ovirt.org/62063 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icd5c42b371d9bf0eafd99e8ad880f3f97b444e75 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: devices: add is_hostdevice attribute
gerrit-hooks has posted comments on this change. Change subject: devices: add is_hostdevice attribute .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/62063 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icd5c42b371d9bf0eafd99e8ad880f3f97b444e75 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: devices: add is_hostdevice attribute
gerrit-hooks has posted comments on this change. Change subject: devices: add is_hostdevice attribute .. Patch Set 2: * #1356161::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1356161::OK, public bug * Check Product::#1356161::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/62063 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icd5c42b371d9bf0eafd99e8ad880f3f97b444e75 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: devices: add is_hostdevice attribute
Martin Polednik has uploaded a new change for review. Change subject: devices: add is_hostdevice attribute .. devices: add is_hostdevice attribute is_hostdevice attribute is currently used to determine whether given device is so called host device, or in other words if it refers to physical device. At the moment, only devices HOSTDEV and NETWORK may be host devices, but moving the attribute to interface level allows us to greatly simplify host NUMA scheduling. Change-Id: Icd5c42b371d9bf0eafd99e8ad880f3f97b444e75 Signed-off-by: Martin Polednik --- M vdsm/virt/vmdevices/core.py 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/63/62063/1 diff --git a/vdsm/virt/vmdevices/core.py b/vdsm/virt/vmdevices/core.py index 1508b9d..90b8cd8 100644 --- a/vdsm/virt/vmdevices/core.py +++ b/vdsm/virt/vmdevices/core.py @@ -36,7 +36,8 @@ class Base(vmxml.Device): __slots__ = ('deviceType', 'device', 'alias', 'specParams', 'deviceId', - 'conf', 'log', '_deviceXML', 'type', 'custom') + 'conf', 'log', '_deviceXML', 'type', 'custom', + 'is_hostdevice') def __init__(self, conf, log, **kwargs): self.conf = conf @@ -50,6 +51,7 @@ self.log.debug('Ignoring param (%s, %s) in %s', attr, value, self.__class__.__name__) self._deviceXML = None +self.is_hostdevice = False def __str__(self): attrs = [':'.join((a, str(getattr(self, a, None for a in dir(self) -- To view, visit https://gerrit.ovirt.org/62063 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Icd5c42b371d9bf0eafd99e8ad880f3f97b444e75 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org