gerrit-hooks has posted comments on this change.
Change subject: jobs: Fix abort semantics
..
Patch Set 7:
* Update Tracker::IGNORE, no bug url/s found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Nir Soffer has submitted this change and it was merged.
Change subject: jobs: Fix abort semantics
..
jobs: Fix abort semantics
Prior to this commit jobs.abort was treated as an synchronous operation
and if it returned
Adam Litke has posted comments on this change.
Change subject: jobs: Fix abort semantics
..
Patch Set 6: Verified+1
Verified with unit tests.
--
To view, visit https://gerrit.ovirt.org/65102
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: jobs: Fix abort semantics
..
Patch Set 6: Code-Review+2
Lets make some progress.
--
To view, visit https://gerrit.ovirt.org/65102
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: jobs: Fix abort semantics
..
Patch Set 6:
* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch: master
* Check Public
Adam Litke has posted comments on this change.
Change subject: jobs: Fix abort semantics
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/65102/5/lib/vdsm/jobs.py
File lib/vdsm/jobs.py:
Line 237: """
Line
Nir Soffer has posted comments on this change.
Change subject: jobs: Fix abort semantics
..
Patch Set 5: Code-Review+1
(1 comment)
Francesco, would take another look?
https://gerrit.ovirt.org/#/c/65102/5/lib/vdsm/jobs.py
gerrit-hooks has posted comments on this change.
Change subject: jobs: Fix abort semantics
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
Adam Litke has posted comments on this change.
Change subject: jobs: Fix abort semantics
..
Patch Set 4:
(6 comments)
https://gerrit.ovirt.org/#/c/65102/4/lib/vdsm/jobs.py
File lib/vdsm/jobs.py:
Line 146
Line 147
Line 148
Adam Litke has posted comments on this change.
Change subject: jobs: Fix abort semantics
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/65102/4/lib/vdsm/jobs.py
File lib/vdsm/jobs.py:
Line 162: finally:
Francesco Romani has posted comments on this change.
Change subject: jobs: Fix abort semantics
..
Patch Set 4:
designwise ACK from me.
--
To view, visit https://gerrit.ovirt.org/65102
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: jobs: Fix abort semantics
..
Patch Set 4:
(2 comments)
initial review. Looks nice, but I need to doublecheck the state machine.
Nir Soffer has posted comments on this change.
Change subject: jobs: Fix abort semantics
..
Patch Set 4: Code-Review+1
(5 comments)
https://gerrit.ovirt.org/#/c/65102/4/lib/vdsm/jobs.py
File lib/vdsm/jobs.py:
Line 146
Line
gerrit-hooks has posted comments on this change.
Change subject: jobs: Fix abort semantics
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
Adam Litke has posted comments on this change.
Change subject: jobs: Fix abort semantics
..
Patch Set 3:
(7 comments)
https://gerrit.ovirt.org/#/c/65102/3/lib/vdsm/jobs.py
File lib/vdsm/jobs.py:
Line 168
Line 169
Line 170
Nir Soffer has posted comments on this change.
Change subject: jobs: Fix abort semantics
..
Patch Set 3: Code-Review+1
(7 comments)
Nice and simple!
Please check the comments.
gerrit-hooks has posted comments on this change.
Change subject: jobs: Fix abort semantics
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
Nir Soffer has posted comments on this change.
Change subject: jobs: Fix abort semantics
..
Patch Set 2: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/65102/2/lib/vdsm/jobs.py
File lib/vdsm/jobs.py:
Line 129:
Line
gerrit-hooks has posted comments on this change.
Change subject: jobs: Fix abort semantics
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
Nir Soffer has posted comments on this change.
Change subject: jobs: Fix abort semantics
..
Patch Set 1: Code-Review-1
(8 comments)
https://gerrit.ovirt.org/#/c/65102/1/lib/vdsm/jobs.py
File lib/vdsm/jobs.py:
Line 146
Line
Adam Litke has uploaded a new change for review.
Change subject: jobs: Fix abort semantics
..
jobs: Fix abort semantics
Prior to this commit jobs.abort was treated as an synchronous operation
and if it returned successfully the
gerrit-hooks has posted comments on this change.
Change subject: jobs: Fix abort semantics
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
22 matches
Mail list logo