gerrit-hooks has posted comments on this change.
Change subject: jobs: Guard against racy state changes
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit ht
Nir Soffer has posted comments on this change.
Change subject: jobs: Guard against racy state changes
..
Patch Set 7: Verified+1
Was verified before last changes, which was test fix, and tests pass now.
--
To view, visit http
Nir Soffer has submitted this change and it was merged.
Change subject: jobs: Guard against racy state changes
..
jobs: Guard against racy state changes
When performing test and set operations with the job status we must use
a
Nir Soffer has posted comments on this change.
Change subject: jobs: Guard against racy state changes
..
Patch Set 7: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/63712
To unsubscribe, visit https://gerrit.ovirt.or
Adam Litke has posted comments on this change.
Change subject: jobs: Guard against racy state changes
..
Patch Set 7:
Resolved failing test_abort_running_job() test by adding another event so that
we actually wait for the thre
gerrit-hooks has posted comments on this change.
Change subject: jobs: Guard against racy state changes
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matche
Nir Soffer has posted comments on this change.
Change subject: jobs: Guard against racy state changes
..
Patch Set 6: Code-Review-1
Please check this failing test:
13:17:35 =
gerrit-hooks has posted comments on this change.
Change subject: jobs: Guard against racy state changes
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matche
Nir Soffer has posted comments on this change.
Change subject: jobs: Guard against racy state changes
..
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/63712
To unsubscribe, visit https://gerrit.ovirt.or
Piotr Kliczewski has posted comments on this change.
Change subject: jobs: Guard against racy state changes
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/63712
To unsubscribe, visit https://gerrit.ov
Nir Soffer has posted comments on this change.
Change subject: jobs: Guard against racy state changes
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/63712/5/lib/vdsm/jobs.py
File lib/vdsm/jobs.py:
Line 162
Line 163
Nir Soffer has posted comments on this change.
Change subject: jobs: Guard against racy state changes
..
Patch Set 5:
(3 comments)
https://gerrit.ovirt.org/#/c/63712/5/tests/jobsTests.py
File tests/jobsTests.py:
Line 77: clas
Nir Soffer has posted comments on this change.
Change subject: jobs: Guard against racy state changes
..
Patch Set 5: Code-Review+1
(1 comment)
I think this is good enough for merging, we can improve locking to avoid
holding
Nir Soffer has posted comments on this change.
Change subject: jobs: Guard against racy state changes
..
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/63712/4/lib/vdsm/jobs.py
File lib/vdsm/jobs.py:
Line 130:
Adam Litke has posted comments on this change.
Change subject: jobs: Guard against racy state changes
..
Patch Set 5: Verified+1
--
To view, visit https://gerrit.ovirt.org/63712
To unsubscribe, visit https://gerrit.ovirt.org/s
gerrit-hooks has posted comments on this change.
Change subject: jobs: Guard against racy state changes
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matche
gerrit-hooks has posted comments on this change.
Change subject: jobs: Guard against racy state changes
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matche
Adam Litke has posted comments on this change.
Change subject: jobs: Guard against racy state changes
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/63712/2/lib/vdsm/jobs.py
File lib/vdsm/jobs.py:
Line 37: RUNNI
Adam Litke has posted comments on this change.
Change subject: jobs: Guard against racy state changes
..
Patch Set 3: Verified+1
Functional tests and copy_data verb
--
To view, visit https://gerrit.ovirt.org/63712
To unsubscr
gerrit-hooks has posted comments on this change.
Change subject: jobs: Guard against racy state changes
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matche
Nir Soffer has posted comments on this change.
Change subject: jobs: Guard against racy state changes
..
Patch Set 2:
(2 comments)
Partial review
https://gerrit.ovirt.org/#/c/63712/1/lib/vdsm/jobs.py
File lib/vdsm/jobs.py:
L
gerrit-hooks has posted comments on this change.
Change subject: jobs: Guard against racy state changes
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matche
Adam Litke has posted comments on this change.
Change subject: jobs: Guard against racy state changes
..
Patch Set 1:
(7 comments)
https://gerrit.ovirt.org/#/c/63712/1/lib/vdsm/jobs.py
File lib/vdsm/jobs.py:
Line 154
Line 155
Piotr Kliczewski has posted comments on this change.
Change subject: jobs: Guard against racy state changes
..
Patch Set 1: Code-Review-1
(3 comments)
https://gerrit.ovirt.org/#/c/63712/1/lib/vdsm/jobs.py
File lib/vdsm/jobs.py
Nir Soffer has posted comments on this change.
Change subject: jobs: Guard against racy state changes
..
Patch Set 1: Code-Review-1
--
To view, visit https://gerrit.ovirt.org/63712
To unsubscribe, visit https://gerrit.ovirt.or
Nir Soffer has posted comments on this change.
Change subject: jobs: Guard against racy state changes
..
Patch Set 1:
(5 comments)
https://gerrit.ovirt.org/#/c/63712/1/lib/vdsm/jobs.py
File lib/vdsm/jobs.py:
Line 154
Line 155
gerrit-hooks has posted comments on this change.
Change subject: jobs: Guard against racy state changes
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matche
Adam Litke has uploaded a new change for review.
Change subject: jobs: Guard against racy state changes
..
jobs: Guard against racy state changes
When performing test and set operations with the job status we must use
a lock to
28 matches
Mail list logo