Change in vdsm[master]: jsonrpc: revert Host.getVMList command result change

2016-09-16 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: jsonrpc: revert Host.getVMList command result change
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/63761
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5ed615acfce50d07aa52af740e4963677c6de7cc
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: jsonrpc: revert Host.getVMList command result change

2016-09-16 Thread danken 
Dan Kenigsberg has submitted this change and it was merged.

Change subject: jsonrpc: revert Host.getVMList command result change
..


jsonrpc: revert Host.getVMList command result change

patch https://gerrit.ovirt.org/#/c/63408/ changes the result
representation of Host.getVMList and Host.getFullVMList but it
can cause inconsistency of these commands, therefore the change
is removed

Change-Id: I5ed615acfce50d07aa52af740e4963677c6de7cc
Signed-off-by: Irit Goihman 
Reviewed-on: https://gerrit.ovirt.org/63761
Continuous-Integration: Jenkins CI
Reviewed-by: Nir Soffer 
Reviewed-by: Piotr Kliczewski 
---
M lib/vdsm/rpc/Bridge.py
1 file changed, 2 insertions(+), 12 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, approved
  Nir Soffer: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Irit Goihman: Verified



-- 
To view, visit https://gerrit.ovirt.org/63761
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5ed615acfce50d07aa52af740e4963677c6de7cc
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: jsonrpc: revert Host.getVMList command result change

2016-09-16 Thread piotr . kliczewski 
Piotr Kliczewski has posted comments on this change.

Change subject: jsonrpc: revert Host.getVMList command result change
..


Patch Set 1: Code-Review+2

As we agreed

-- 
To view, visit https://gerrit.ovirt.org/63761
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5ed615acfce50d07aa52af740e4963677c6de7cc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jsonrpc: revert Host.getVMList command result change

2016-09-15 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: jsonrpc: revert Host.getVMList command result change
..


Patch Set 1:

Ping

-- 
To view, visit https://gerrit.ovirt.org/63761
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5ed615acfce50d07aa52af740e4963677c6de7cc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jsonrpc: revert Host.getVMList command result change

2016-09-14 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: jsonrpc: revert Host.getVMList command result change
..


Patch Set 1: Code-Review+1

Waiting for Piotr/Dan ack.

-- 
To view, visit https://gerrit.ovirt.org/63761
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5ed615acfce50d07aa52af740e4963677c6de7cc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jsonrpc: revert Host.getVMList command result change

2016-09-14 Thread igoihman 
Irit Goihman has posted comments on this change.

Change subject: jsonrpc: revert Host.getVMList command result change
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/63761
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5ed615acfce50d07aa52af740e4963677c6de7cc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jsonrpc: revert Host.getVMList command result change

2016-09-14 Thread igoihman 
Irit Goihman has uploaded a new change for review.

Change subject: jsonrpc: revert Host.getVMList command result change
..

jsonrpc: revert Host.getVMList command result change

patch https://gerrit.ovirt.org/#/c/63408/ changes the result
representation of Host.getVMList and Host.getFullVMList but it
can cause inconsistency of these commands, therefore the change
is removed

Change-Id: I5ed615acfce50d07aa52af740e4963677c6de7cc
Signed-off-by: Irit Goihman 
---
M lib/vdsm/rpc/Bridge.py
1 file changed, 2 insertions(+), 12 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/61/63761/1

diff --git a/lib/vdsm/rpc/Bridge.py b/lib/vdsm/rpc/Bridge.py
index f264e8d..bd180e0 100644
--- a/lib/vdsm/rpc/Bridge.py
+++ b/lib/vdsm/rpc/Bridge.py
@@ -326,14 +326,6 @@
 return {'path': ret['path']}
 
 
-def remove_status_from_ret(ret):
-"""
-seprate status from the actual result
-"""
-del ret['status']
-return ret
-
-
 ##
 # Possible ways to override a command:
 # - Supply a custom call function if the function name doesn't map directly to
@@ -359,10 +351,8 @@
 'Host_getStorageDomains': {'ret': 'domlist'},
 'Host_getStorageRepoStats': {'ret': Host_getStorageRepoStats_Ret},
 'Host_hostdevListByCaps': {'ret': 'deviceList'},
-'Host_getVMList': {'call': Host_getVMList_Call,
-   'ret': remove_status_from_ret},
-'Host_getVMFullList': {'call': Host_getVMFullList_Call,
-   'ret': remove_status_from_ret},
+'Host_getVMList': {'call': Host_getVMList_Call, 'ret': 'vmList'},
+'Host_getVMFullList': {'call': Host_getVMFullList_Call, 'ret': 'vmList'},
 'Host_getAllVmStats': {'ret': 'statsList'},
 'Host_setupNetworks': {'ret': 'status'},
 'Host_setKsmTune': {'ret': 'status'},


-- 
To view, visit https://gerrit.ovirt.org/63761
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5ed615acfce50d07aa52af740e4963677c6de7cc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jsonrpc: revert Host.getVMList command result change

2016-09-14 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: jsonrpc: revert Host.getVMList command result change
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63761
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5ed615acfce50d07aa52af740e4963677c6de7cc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org