Change in vdsm[master]: lib: dmidecode: suppress bogus pylint warning

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has submitted this change and it was merged.

Change subject: lib: dmidecode: suppress bogus pylint warning
..


lib: dmidecode: suppress bogus pylint warning

We got a pylint complain about dmidecodeUtil:

E: 44,22: Module 'dmidecode' has no 'system' member (no-member)

This is likely caused by this star-import as the very
beginning of dmidecode.py:

  from dmidecodemod import *

(dmidecode.py doesn't define system() and gets it from dmidecodemod.so)

Thus, at runtime we have this method, but no static analysis tool
can detect it.
This patch suppress the unhelpful pylint warning.

Change-Id: I2d6aaa0d25e79fbe2dac851a62bcde36e8f7cf62
Signed-off-by: Francesco Romani 
---
M lib/vdsm/dmidecodeUtil.py
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Irit Goihman: Looks good to me, but someone else must approve
  Edward Haas: Verified; Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/76977
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2d6aaa0d25e79fbe2dac851a62bcde36e8f7cf62
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: lib: dmidecode: suppress bogus pylint warning

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: lib: dmidecode: suppress bogus pylint warning
..


Patch Set 1:

I hate it, don't understand it, but let us take it in.

-- 
To view, visit https://gerrit.ovirt.org/76977
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d6aaa0d25e79fbe2dac851a62bcde36e8f7cf62
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: lib: dmidecode: suppress bogus pylint warning

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: lib: dmidecode: suppress bogus pylint warning
..


Patch Set 1:

but how can it pass check-patch even without this?

-- 
To view, visit https://gerrit.ovirt.org/76977
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d6aaa0d25e79fbe2dac851a62bcde36e8f7cf62
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org