Change in vdsm[master]: log: Nicer logging format

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: log: Nicer logging format
..


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/64113/1/static/etc/vdsm/logger.conf.in
File static/etc/vdsm/logger.conf.in:

Line 85: [formatter_none]
Line 86: format: %(message)s
Line 87: 
Line 88: [formatter_long]
Line 89: format: %(asctime)s %(levelname)-7s [%(name)s] (%(threadName)s) 
%(message)s
please add the module:lineno, it helps me a lot.
Line 90: 
Line 91: [formatter_sysform]
Line 92: format= vdsm %(name)s %(levelname)s %(message)s


-- 
To view, visit https://gerrit.ovirt.org/64113
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I640c3c83db3b5818a08b4984d5358b1e27bf0ef3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: log: Nicer logging format

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: log: Nicer logging format
..


Patch Set 1:

Do we know whether anyone already parses our log to collect information about 
what is going on?

-- 
To view, visit https://gerrit.ovirt.org/64113
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I640c3c83db3b5818a08b4984d5358b1e27bf0ef3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: log: Nicer logging format

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: log: Nicer logging format
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/64113
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I640c3c83db3b5818a08b4984d5358b1e27bf0ef3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: log: Nicer logging format

[fromani]

Francesco Romani has posted comments on this change.

Change subject: log: Nicer logging format
..


Patch Set 1:

I for myself support this direction. This format is much much nicer and easier 
to work with.
The idea to have a log parser helper is also very nice.

-- 
To view, visit https://gerrit.ovirt.org/64113
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I640c3c83db3b5818a08b4984d5358b1e27bf0ef3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: log: Nicer logging format

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: log: Nicer logging format
..


Patch Set 1:

Maybe we need to have a library for parsing vdsm logs. We already have this 
code in some tools (e.g contrib/db). This will make it easy for people, they 
can use the current vdsm log parser and do not worry.

We cannot help people parsing logs with grep/awk etc. The only option to 
support this is to never change anything and keep the current horrible format.

I'll update logdb and other tools that depend on the logs if we have agreement 
to go in this direction.

-- 
To view, visit https://gerrit.ovirt.org/64113
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I640c3c83db3b5818a08b4984d5358b1e27bf0ef3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: log: Nicer logging format

[fromani]

Francesco Romani has posted comments on this change.

Change subject: log: Nicer logging format
..


Patch Set 1: Code-Review+1

I like this. We tried to change our log format in the past, without much luck. 
Let's try again.
There is a high chance this will break scripts/tools from GSS/QE/users, 
however, perhaps better advertise this ad give the users plenty of time to 
upgrade.

-- 
To view, visit https://gerrit.ovirt.org/64113
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I640c3c83db3b5818a08b4984d5358b1e27bf0ef3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: log: Nicer logging format

[automation]

gerrit-hooks has posted comments on this change.

Change subject: log: Nicer logging format
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64113
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I640c3c83db3b5818a08b4984d5358b1e27bf0ef3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: log: Nicer logging format

[nsoffer]

Nir Soffer has uploaded a new change for review.

Change subject: log: Nicer logging format
..

log: Nicer logging format

Use nicer and more standard logging format, similar to engine log
format. Having similar logging formats should make it easier to debug
and support.

Here is an example log using the new format:

2016-09-19 00:02:25,291 INFO[vds] (MainThread) (PID: 10281) I am the actual 
vdsm 4.18.999-578.git61bfe00.el7 voodoo6.tlv.redhat.com (3.10.0-489.el7.x86_64)
2016-09-19 00:02:25,291 INFO[vds] (MainThread) VDSM will run with cpu 
affinity: frozenset([1])
2016-09-19 00:02:25,379 INFO[storage.check] (MainThread) Starting check 
service
2016-09-19 00:02:25,384 INFO[storage.Dispatcher] (MainThread) Starting 
StorageDispatcher...
2016-09-19 00:02:25,385 INFO[storage.asyncevent] (check/loop) Starting 

2016-09-19 00:02:25,482 INFO[dispatcher] (MainThread) Run and protect: 
registerDomainStateChangeCallback(callbackFunc=)
2016-09-19 00:02:25,482 INFO[dispatcher] (MainThread) Run and protect: 
registerDomainStateChangeCallback, Return response: None
2016-09-19 00:02:25,485 INFO[MOM] (MainThread) Preparing MOM interface
2016-09-19 00:02:25,486 INFO[MOM] (MainThread) Using named unix socket 
/var/run/vdsm/mom-vdsm.sock
2016-09-19 00:02:25,487 INFO[root] (MainThread) Unregistering all secrets
2016-09-19 00:02:25,491 INFO[vds] (MainThread) Setting channels' timeout to 
30 seconds.
2016-09-19 00:02:25,493 INFO[vds.MultiProtocolAcceptor] (MainThread) 
Listening at :::54321
2016-09-19 00:02:25,526 INFO[vds] (clientIFinit) recovery: completed in 0s
2016-09-19 00:02:25,560 WARNING [storage.Multipath] (hsm/init) Map 
'360014052c81462a280847e8a6e3af8cd' has no slaves
2016-09-19 00:02:25,560 WARNING [storage.Multipath] (hsm/init) Map 
'36001405292bb96f19064f81b884fa63f' has no slaves
2016-09-19 00:02:27,115 INFO[vds] (BindingXMLRPC) XMLRPC server running
2016-09-19 00:02:27,122 INFO[health] (MainThread) Starting health monitor 
(interval=60)
2016-09-19 00:02:40,256 INFO[ProtocolDetector.AcceptorImpl] (Reactor 
thread) Accepting connection from ::1:42888
2016-09-19 00:02:40,270 INFO[ProtocolDetector.Detector] (Reactor thread) 
Detected protocol xml from ::1:42888
2016-09-19 00:02:40,270 INFO[vds.XMLRPCServer] (BindingXMLRPC) Starting 
request handler for ::1:42888
2016-09-19 00:02:40,271 INFO[vds.XMLRPCServer] (Thread-12) Request handler 
for ::1:42888 started
2016-09-19 00:02:40,272 INFO[throttled] (Thread-12) Current getAllVmStats: 
{}
2016-09-19 00:02:40,272 INFO[vds] (Thread-12) RPC call getAllVmStats 
finished (code=0) in 0.00 seconds

Unfinished: require updating all the tools parsing vdsm log.

Change-Id: I640c3c83db3b5818a08b4984d5358b1e27bf0ef3
Signed-off-by: Nir Soffer 
---
M static/etc/vdsm/logger.conf.in
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/13/64113/1

diff --git a/static/etc/vdsm/logger.conf.in b/static/etc/vdsm/logger.conf.in
index 34137ff..820fcb4 100644
--- a/static/etc/vdsm/logger.conf.in
+++ b/static/etc/vdsm/logger.conf.in
@@ -86,7 +86,7 @@
 format: %(message)s
 
 [formatter_long]
-format: 
%(threadName)s::%(levelname)s::%(asctime)s::%(module)s::%(lineno)d::%(name)s::(%(funcName)s)
 %(message)s
+format: %(asctime)s %(levelname)-7s [%(name)s] (%(threadName)s) %(message)s
 
 [formatter_sysform]
 format= vdsm %(name)s %(levelname)s %(message)s


-- 
To view, visit https://gerrit.ovirt.org/64113
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I640c3c83db3b5818a08b4984d5358b1e27bf0ef3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org