Change in vdsm[master]: ssl: ssl_accept blocks after reboot

2014-10-01 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: ssl: ssl_accept blocks after reboot
..


Patch Set 1:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11748/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12692/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12537/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/33611
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I759436b5bfb6c2334d253d12806258cbe1c3720f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com
Gerrit-Reviewer: Martin Peřina mper...@redhat.com
Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: ssl: ssl_accept blocks after reboot

2014-10-01 Thread danken
Dan Kenigsberg has posted comments on this change.

Change subject: ssl: ssl_accept blocks after reboot
..


Patch Set 1: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/33611/1//COMMIT_MSG
Commit Message:

Line 9: When rebooting host most of the times ssl_accept blocks when there is
Line 10: new connection estabilished just after socket is opened. Setting 
timeout
Line 11: on socket seems to help but when testing I noticed sometimes there is
Line 12: still connection blocked on ssl_accept.
Line 13: 
And more importantly, without this timeout, it is SO easy to DoS us.

Please add a test that verifies that opening a plaintext TCP connection to an 
SSL server does not block us, and backport as far as you can.
Line 14: 
Line 15: Change-Id: I759436b5bfb6c2334d253d12806258cbe1c3720f


-- 
To view, visit http://gerrit.ovirt.org/33611
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I759436b5bfb6c2334d253d12806258cbe1c3720f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Martin Peřina mper...@redhat.com
Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: ssl: ssl_accept blocks after reboot

2014-10-01 Thread mperina
Martin Peřina has posted comments on this change.

Change subject: ssl: ssl_accept blocks after reboot
..


Patch Set 1: Verified+1

Verified, that it fixes engine - host connection issues after host was fenced 
when using JSONRPC (more than 10 tests executed without error).

Verified, that it doesn't introduce any error in the above scenario when using 
XMLRPC (6 tests executed without errror)

-- 
To view, visit http://gerrit.ovirt.org/33611
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I759436b5bfb6c2334d253d12806258cbe1c3720f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Martin Peřina mper...@redhat.com
Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: ssl: ssl_accept blocks after reboot

2014-10-01 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: ssl: ssl_accept blocks after reboot
..


Patch Set 2:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11760/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12704/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12549/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/33611
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I759436b5bfb6c2334d253d12806258cbe1c3720f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Martin Peřina mper...@redhat.com
Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com
Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: ssl: ssl_accept blocks after reboot

2014-10-01 Thread danken
Dan Kenigsberg has posted comments on this change.

Change subject: ssl: ssl_accept blocks after reboot
..


Patch Set 2: Code-Review-1

(2 comments)

http://gerrit.ovirt.org/#/c/33611/2/tests/sslTests.py
File tests/sslTests.py:

Line 109: 
Line 110: class SocketTests(TestCaseBase):
Line 111: 
Line 112: def test_block_socket(self):
Line 113: # this test make sure that we won't block during
I don't understand how this test works :-(

You start a server, open a TCP connection to it, but you don't check that the 
server is still responsive.

Would this test really fail on master branch (before your fix)?

I think that you should:
* start a server
* open a DoS connection to it
* open a legitimate client to the server
* if the client is not served within 10 seconds, fail the test.
Line 114: # accept. It will hang the build if accept blocks
Line 115: server = TestServer()
Line 116: server.start()
Line 117: try:


Line 119: sock.settimeout(1)
Line 120: sock.connect((HOST, server.port))
Line 121: finally:
Line 122: server.stop()
Line 123: sock.close()
puritan: at this point, sock may have not been defined. better use

  with closing(socket.socket(socket.AF_INET, socket.SOCK_STREAM)) as sock:
Line 124: 
Line 125: 
Line 126: class VerifyingTransportTests(TestCaseBase):
Line 127: 


-- 
To view, visit http://gerrit.ovirt.org/33611
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I759436b5bfb6c2334d253d12806258cbe1c3720f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Martin Peřina mper...@redhat.com
Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com
Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: ssl: ssl_accept blocks after reboot

2014-10-01 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: ssl: ssl_accept blocks after reboot
..


Patch Set 3:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11762/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12706/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12551/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/33611
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I759436b5bfb6c2334d253d12806258cbe1c3720f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Martin Peřina mper...@redhat.com
Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com
Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: ssl: ssl_accept blocks after reboot

2014-10-01 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: ssl: ssl_accept blocks after reboot
..


Patch Set 4:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11763/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12707/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12552/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/33611
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I759436b5bfb6c2334d253d12806258cbe1c3720f
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Martin Peřina mper...@redhat.com
Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com
Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: ssl: ssl_accept blocks after reboot

2014-10-01 Thread danken
Dan Kenigsberg has posted comments on this change.

Change subject: ssl: ssl_accept blocks after reboot
..


Patch Set 4: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/33611/4/tests/sslTests.py
File tests/sslTests.py:

Line 114: server.server.socket.accept_timeout = 1
Line 115: timeout = server.server.socket.accept_timeout + 1
Line 116: server.start()
Line 117: try:
Line 118: client_socket = socket.socket(socket.AF_INET, 
socket.SOCK_STREAM)
nit picking again: please use

 with closing(socket.socket(socket.AF_INET, socket.SOCK_STREAM)) as 
client_socket

and drop the close() on finally. client_socket may not be defined there.
Line 119: client_socket.settimeout(timeout)
Line 120: client_socket.connect((HOST, server.port))
Line 121: # Wait for data that will never arrive.
Line 122: # This will return successfuly if the other side closes 
the


-- 
To view, visit http://gerrit.ovirt.org/33611
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I759436b5bfb6c2334d253d12806258cbe1c3720f
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Martin Peřina mper...@redhat.com
Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com
Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: ssl: ssl_accept blocks after reboot

2014-10-01 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: ssl: ssl_accept blocks after reboot
..


Patch Set 5:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11764/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12708/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12553/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/33611
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I759436b5bfb6c2334d253d12806258cbe1c3720f
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Martin Peřina mper...@redhat.com
Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com
Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: ssl: ssl_accept blocks after reboot

2014-10-01 Thread danken
Dan Kenigsberg has posted comments on this change.

Change subject: ssl: ssl_accept blocks after reboot
..


Patch Set 5: Code-Review+2

-- 
To view, visit http://gerrit.ovirt.org/33611
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I759436b5bfb6c2334d253d12806258cbe1c3720f
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Martin Peřina mper...@redhat.com
Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com
Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: ssl: ssl_accept blocks after reboot

2014-10-01 Thread danken
Dan Kenigsberg has submitted this change and it was merged.

Change subject: ssl: ssl_accept blocks after reboot
..


ssl: ssl_accept blocks after reboot

When rebooting host most of the times ssl_accept blocks when there is
new connection established just after socket is opened. Setting timeout
on socket seems to help but when testing I noticed sometimes there is
still connection blocked on ssl_accept.

Change-Id: I759436b5bfb6c2334d253d12806258cbe1c3720f
Signed-off-by: pkliczewski piotr.kliczew...@gmail.com
Signed-off-by: Saggi Mizrahi smizr...@redhat.com
Reviewed-on: http://gerrit.ovirt.org/33611
Reviewed-by: Dan Kenigsberg dan...@redhat.com
---
M lib/vdsm/sslutils.py
M tests/sslTests.py
2 files changed, 29 insertions(+), 2 deletions(-)

Approvals:
  Piotr Kliczewski: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/33611
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I759436b5bfb6c2334d253d12806258cbe1c3720f
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Martin Peřina mper...@redhat.com
Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com
Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: ssl: ssl_accept blocks after reboot

2014-10-01 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: ssl: ssl_accept blocks after reboot
..


Patch Set 6:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged_test_debug/250/ : 
SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5883/ : 
SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4043/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/53/ : 
SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/49/ : 
SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/55/ : 
SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/29/ : 
SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/33611
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I759436b5bfb6c2334d253d12806258cbe1c3720f
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Martin Peřina mper...@redhat.com
Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com
Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches