Change in vdsm[master]: storage: Refactor workarounds.detect_format

2016-09-23 Thread automation
gerrit-hooks has posted comments on this change. Change subject: storage: Refactor workarounds.detect_format .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view,

Change in vdsm[master]: storage: Refactor workarounds.detect_format

2016-09-23 Thread nsoffer
Nir Soffer has submitted this change and it was merged. Change subject: storage: Refactor workarounds.detect_format .. storage: Refactor workarounds.detect_format The function workarounds.detect_format accepts two volumes,

Change in vdsm[master]: storage: Refactor workarounds.detect_format

2016-09-23 Thread alitke
Adam Litke has posted comments on this change. Change subject: storage: Refactor workarounds.detect_format .. Patch Set 4: Verified+1 Verified by the following steps: - Create 1G thin disk on block sd - Move disk to file sd -

Change in vdsm[master]: storage: Refactor workarounds.detect_format

2016-09-22 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: storage: Refactor workarounds.detect_format .. Patch Set 4: Continuous-Integration+1 Networks tests continue to fail -- To view, visit

Change in vdsm[master]: storage: Refactor workarounds.detect_format

2016-09-22 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: storage: Refactor workarounds.detect_format .. Patch Set 4: I rebase this on master, the tests should pass now. -- To view, visit https://gerrit.ovirt.org/64230

Change in vdsm[master]: storage: Refactor workarounds.detect_format

2016-09-22 Thread automation
gerrit-hooks has posted comments on this change. Change subject: storage: Refactor workarounds.detect_format .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: storage: Refactor workarounds.detect_format

2016-09-22 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: storage: Refactor workarounds.detect_format .. Patch Set 3: Code-Review+2 This needs verification running the old code in image.py. -- To view, visit

Change in vdsm[master]: storage: Refactor workarounds.detect_format

2016-09-22 Thread automation
gerrit-hooks has posted comments on this change. Change subject: storage: Refactor workarounds.detect_format .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: storage: Refactor workarounds.detect_format

2016-09-22 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: storage: Refactor workarounds.detect_format .. Patch Set 2: Code-Review+2 Seems that this is the best way. -- To view, visit https://gerrit.ovirt.org/64230 To

Change in vdsm[master]: storage: Refactor workarounds.detect_format

2016-09-22 Thread automation
gerrit-hooks has posted comments on this change. Change subject: storage: Refactor workarounds.detect_format .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: storage: Refactor workarounds.detect_format

2016-09-22 Thread alitke
Adam Litke has restored this change. Change subject: storage: Refactor workarounds.detect_format .. Restored -- To view, visit https://gerrit.ovirt.org/64230 To unsubscribe, visit https://gerrit.ovirt.org/settings

Change in vdsm[master]: storage: Refactor workarounds.detect_format

2016-09-21 Thread automation
gerrit-hooks has posted comments on this change. Change subject: storage: Refactor workarounds.detect_format .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/64230 To

Change in vdsm[master]: storage: Refactor workarounds.detect_format

2016-09-21 Thread alitke
Adam Litke has abandoned this change. Change subject: storage: Refactor workarounds.detect_format .. Abandoned Not needed. -- To view, visit https://gerrit.ovirt.org/64230 To unsubscribe, visit

Change in vdsm[master]: storage: Refactor workarounds.detect_format

2016-09-21 Thread alitke
Adam Litke has posted comments on this change. Change subject: storage: Refactor workarounds.detect_format .. Patch Set 1: (7 comments) https://gerrit.ovirt.org/#/c/64230/1/tests/storage_workarounds_test.py File

Change in vdsm[master]: storage: Refactor workarounds.detect_format

2016-09-20 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: storage: Refactor workarounds.detect_format .. Patch Set 1: (4 comments) https://gerrit.ovirt.org/#/c/64230/1/vdsm/storage/image.py File vdsm/storage/image.py:

Change in vdsm[master]: storage: Refactor workarounds.detect_format

2016-09-20 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: storage: Refactor workarounds.detect_format .. Patch Set 1: Code-Review-1 (3 comments) https://gerrit.ovirt.org/#/c/64230/1/tests/storage_workarounds_test.py File

Change in vdsm[master]: storage: Refactor workarounds.detect_format

2016-09-20 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: storage: Refactor workarounds.detect_format .. Patch Set 1: Nice, look much better then the original code, and the complicated tests are simple now. -- To view,

Change in vdsm[master]: storage: Refactor workarounds.detect_format

2016-09-20 Thread alitke
Adam Litke has uploaded a new change for review. Change subject: storage: Refactor workarounds.detect_format .. storage: Refactor workarounds.detect_format The function workarounds.detect_format accepts two volumes, checks for

Change in vdsm[master]: storage: Refactor workarounds.detect_format

2016-09-20 Thread automation
gerrit-hooks has posted comments on this change. Change subject: storage: Refactor workarounds.detect_format .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header