Change in vdsm[ovirt-4.0]: stomp: use socket pending

[fromani]

Francesco Romani has submitted this change and it was merged.

Change subject: stomp: use socket pending
..


stomp: use socket pending

Dispatcher pending method is deprecated and we want to use socket
pending method instead.


Bug-Url: https://bugzilla.redhat.com/133
Change-Id: I7cf0e2bfccd10bc825514677f054c3850100a713
Signed-off-by: Piotr Kliczewski 
Reviewed-on: https://gerrit.ovirt.org/61816
Continuous-Integration: Jenkins CI
Reviewed-by: Irit Goihman 
Reviewed-by: Yaniv Bronhaim 
Reviewed-by: Dan Kenigsberg 
(cherry picked from commit 274ff7fa7ccd3db14e336cdae068aa99ee7ac06e)
Reviewed-on: https://gerrit.ovirt.org/63482
Reviewed-by: Simone Tiraboschi 
Reviewed-by: Francesco Romani 
---
M lib/yajsonrpc/stomp.py
M tests/stompAsyncDispatcherTests.py
2 files changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Piotr Kliczewski: Verified
  Simone Tiraboschi: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Irit Goihman: Looks good to me, but someone else must approve
  Francesco Romani: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/63482
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7cf0e2bfccd10bc825514677f054c3850100a713
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: stomp: use socket pending

[automation]

gerrit-hooks has posted comments on this change.

Change subject: stomp: use socket pending
..


Patch Set 4:

* update_tracker: OK
* Set MODIFIED::bug 133#133OK

-- 
To view, visit https://gerrit.ovirt.org/63482
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7cf0e2bfccd10bc825514677f054c3850100a713
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: stomp: use socket pending

[fromani]

Francesco Romani has posted comments on this change.

Change subject: stomp: use socket pending
..


Patch Set 3: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/63482
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7cf0e2bfccd10bc825514677f054c3850100a713
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: stomp: use socket pending

[automation]

gerrit-hooks has posted comments on this change.

Change subject: stomp: use socket pending
..


Patch Set 3:

* #133::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#133::OK, public bug
* Check Product::#133::OK, Correct classification oVirt
* Check TM::#133::ERROR, wrong target milestone for stable branch, --- 
should match ^.*4.0.*
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/63482
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7cf0e2bfccd10bc825514677f054c3850100a713
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: stomp: use socket pending

[automation]

gerrit-hooks has posted comments on this change.

Change subject: stomp: use socket pending
..


Patch Set 3: -Verified

* #133::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#133::OK, public bug
* Check Product::#133::OK, Correct classification oVirt
* Check TM::#133::ERROR, wrong target milestone for stable branch, --- 
should match ^.*4.0.*
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/63482
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7cf0e2bfccd10bc825514677f054c3850100a713
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: stomp: use socket pending

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: stomp: use socket pending
..


Patch Set 3:

Rerun-Hooks: all

-- 
To view, visit https://gerrit.ovirt.org/63482
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7cf0e2bfccd10bc825514677f054c3850100a713
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: stomp: use socket pending

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: stomp: use socket pending
..


Patch Set 2:

We do not have a BZ for this, existing one should be OK.

-- 
To view, visit https://gerrit.ovirt.org/63482
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7cf0e2bfccd10bc825514677f054c3850100a713
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: stomp: use socket pending

[fromani]

Francesco Romani has posted comments on this change.

Change subject: stomp: use socket pending
..


Patch Set 2: Code-Review+1

can we have any bug for reference? We can piggyback on existing one.

-- 
To view, visit https://gerrit.ovirt.org/63482
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7cf0e2bfccd10bc825514677f054c3850100a713
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: stomp: use socket pending

[automation]

gerrit-hooks has posted comments on this change.

Change subject: stomp: use socket pending
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found

* Check Bug-Url::ERROR, At least one bug-url is required for the stable branch
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/63482
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7cf0e2bfccd10bc825514677f054c3850100a713
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: stomp: use socket pending

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: stomp: use socket pending
..


Patch Set 1: Verified+1

with this approach warning is not generated.

-- 
To view, visit https://gerrit.ovirt.org/63482
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7cf0e2bfccd10bc825514677f054c3850100a713
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: stomp: use socket pending

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: stomp: use socket pending
..


Patch Set 1:

Build failure not related to this change. Networking tests are still failing

-- 
To view, visit https://gerrit.ovirt.org/63482
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7cf0e2bfccd10bc825514677f054c3850100a713
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: stomp: use socket pending

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: stomp: use socket pending
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/63482
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7cf0e2bfccd10bc825514677f054c3850100a713
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: stomp: use socket pending

[stirabos]

Simone Tiraboschi has posted comments on this change.

Change subject: stomp: use socket pending
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/63482
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7cf0e2bfccd10bc825514677f054c3850100a713
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: stomp: use socket pending

[piotr . kliczewski]

Piotr Kliczewski has uploaded a new change for review.

Change subject: stomp: use socket pending
..

stomp: use socket pending

Dispatcher pending method is deprecated and we want to use socket
pending method instead.


Change-Id: I7cf0e2bfccd10bc825514677f054c3850100a713
Signed-off-by: Piotr Kliczewski 
Reviewed-on: https://gerrit.ovirt.org/61816
Continuous-Integration: Jenkins CI
Reviewed-by: Irit Goihman 
Reviewed-by: Yaniv Bronhaim 
Reviewed-by: Dan Kenigsberg 
(cherry picked from commit 274ff7fa7ccd3db14e336cdae068aa99ee7ac06e)
---
M lib/yajsonrpc/stomp.py
M tests/stompAsyncDispatcherTests.py
2 files changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/82/63482/1

diff --git a/lib/yajsonrpc/stomp.py b/lib/yajsonrpc/stomp.py
index 44049f5..41ac70f 100644
--- a/lib/yajsonrpc/stomp.py
+++ b/lib/yajsonrpc/stomp.py
@@ -349,7 +349,7 @@
 
 def handle_read(self, dispatcher):
 parser = self._parser
-pending = getattr(dispatcher, 'pending', lambda: 0)
+pending = getattr(dispatcher.socket, 'pending', lambda: 0)
 todo = self._bufferSize
 
 while todo:
diff --git a/tests/stompAsyncDispatcherTests.py 
b/tests/stompAsyncDispatcherTests.py
index 7b4a956..3458357 100644
--- a/tests/stompAsyncDispatcherTests.py
+++ b/tests/stompAsyncDispatcherTests.py
@@ -61,6 +61,8 @@
 
 class TestDispatcher(object):
 
+socket = None
+
 def __init__(self, data):
 self._data = data
 


-- 
To view, visit https://gerrit.ovirt.org/63482
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7cf0e2bfccd10bc825514677f054c3850100a713
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Piotr Kliczewski 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: stomp: use socket pending

[automation]

gerrit-hooks has posted comments on this change.

Change subject: stomp: use socket pending
..


Patch Set 1: Verified-1

* Update tracker: IGNORE, no Bug-Url found

* Check Bug-Url::ERROR, At least one bug-url is required for the stable branch
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/63482
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7cf0e2bfccd10bc825514677f054c3850100a713
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org