Change in vdsm[ovirt-4.0.5]: Fix return value names for VM.ioTune calls

2016-10-12 Thread automation
gerrit-hooks has posted comments on this change.

Change subject: Fix return value names for VM.ioTune calls
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::bug 1373832#1373832OK

-- 
To view, visit https://gerrit.ovirt.org/65377
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4eaac318db3d76743b1ff83f47268d0fc1c2dad7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0.5
Gerrit-Owner: Andrej Krejcir 
Gerrit-Reviewer: Andrej Krejcir 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org


Change in vdsm[ovirt-4.0.5]: Fix return value names for VM.ioTune calls

2016-10-12 Thread fromani
Francesco Romani has posted comments on this change.

Change subject: Fix return value names for VM.ioTune calls
..


Patch Set 1:

Run 'make check' manually. Unrelated, known test failures.

-- 
To view, visit https://gerrit.ovirt.org/65377
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4eaac318db3d76743b1ff83f47268d0fc1c2dad7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0.5
Gerrit-Owner: Andrej Krejcir 
Gerrit-Reviewer: Andrej Krejcir 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org


Change in vdsm[ovirt-4.0.5]: Fix return value names for VM.ioTune calls

2016-10-12 Thread fromani
Francesco Romani has submitted this change and it was merged.

Change subject: Fix return value names for VM.ioTune calls
..


Fix return value names for VM.ioTune calls

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1373832
Change-Id: I4eaac318db3d76743b1ff83f47268d0fc1c2dad7
Signed-off-by: Andrej Krejcir 
Reviewed-on: https://gerrit.ovirt.org/60513
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani 
Reviewed-on: https://gerrit.ovirt.org/63478
Reviewed-by: Piotr Kliczewski 
Reviewed-on: https://gerrit.ovirt.org/65377
Continuous-Integration: Francesco Romani 
---
M tests/vmTests.py
M vdsm/virt/vm.py
2 files changed, 4 insertions(+), 4 deletions(-)

Approvals:
  Francesco Romani: Looks good to me, approved; Passed CI tests
  Andrej Krejcir: Verified



-- 
To view, visit https://gerrit.ovirt.org/65377
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4eaac318db3d76743b1ff83f47268d0fc1c2dad7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0.5
Gerrit-Owner: Andrej Krejcir 
Gerrit-Reviewer: Andrej Krejcir 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org


Change in vdsm[ovirt-4.0.5]: Fix return value names for VM.ioTune calls

2016-10-12 Thread fromani
Francesco Romani has posted comments on this change.

Change subject: Fix return value names for VM.ioTune calls
..


Patch Set 1: Continuous-Integration+1

-- 
To view, visit https://gerrit.ovirt.org/65377
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4eaac318db3d76743b1ff83f47268d0fc1c2dad7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0.5
Gerrit-Owner: Andrej Krejcir 
Gerrit-Reviewer: Andrej Krejcir 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org


Change in vdsm[ovirt-4.0.5]: Fix return value names for VM.ioTune calls

2016-10-12 Thread fromani
Francesco Romani has posted comments on this change.

Change subject: Fix return value names for VM.ioTune calls
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/65377
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4eaac318db3d76743b1ff83f47268d0fc1c2dad7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0.5
Gerrit-Owner: Andrej Krejcir 
Gerrit-Reviewer: Andrej Krejcir 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org


Change in vdsm[ovirt-4.0.5]: Fix return value names for VM.ioTune calls

2016-10-12 Thread akrejcir
Andrej Krejcir has posted comments on this change.

Change subject: Fix return value names for VM.ioTune calls
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/65377
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4eaac318db3d76743b1ff83f47268d0fc1c2dad7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0.5
Gerrit-Owner: Andrej Krejcir 
Gerrit-Reviewer: Andrej Krejcir 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org


Change in vdsm[ovirt-4.0.5]: Fix return value names for VM.ioTune calls

2016-10-12 Thread akrejcir
Hello Piotr Kliczewski, Francesco Romani,

I'd like you to do a code review.  Please visit

https://gerrit.ovirt.org/65377

to review the following change.

Change subject: Fix return value names for VM.ioTune calls
..

Fix return value names for VM.ioTune calls

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1373832
Change-Id: I4eaac318db3d76743b1ff83f47268d0fc1c2dad7
Signed-off-by: Andrej Krejcir 
Reviewed-on: https://gerrit.ovirt.org/60513
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani 
Reviewed-on: https://gerrit.ovirt.org/63478
Reviewed-by: Piotr Kliczewski 
---
M tests/vmTests.py
M vdsm/virt/vm.py
2 files changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/77/65377/1

diff --git a/tests/vmTests.py b/tests/vmTests.py
index 6d38f46..7965317 100644
--- a/tests/vmTests.py
+++ b/tests/vmTests.py
@@ -864,7 +864,7 @@
  u'totalBytes': 
  }}
 ]
-self.assertEqual(tunables['ioTunePolicy'], expected)
+self.assertEqual(tunables['ioTunePolicyList'], expected)
 
 def testSetIoTune(self):
 
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index a896f58..bfe61f0 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -2738,12 +2738,12 @@
 qos = self._getVmPolicy()
 ioTuneList = qos.getElementsByTagName("ioTune")
 if not ioTuneList or not ioTuneList[0].hasChildNodes():
-return response.success(ioTunePolicy=[])
+return response.success(ioTunePolicyList=[])
 
 for device in ioTuneList[0].getElementsByTagName("device"):
 tunables.append(io_tune_dom_to_values(device))
 
-return response.success(ioTunePolicy=tunables)
+return response.success(ioTunePolicyList=tunables)
 
 def getIoTune(self):
 resultList = []
@@ -2776,7 +2776,7 @@
 else:
 return response.error('updateIoTuneErr', e.message)
 
-return response.success(ioTune=resultList)
+return response.success(ioTuneList=resultList)
 
 def setIoTune(self, tunables):
 for io_tune_change in tunables:


-- 
To view, visit https://gerrit.ovirt.org/65377
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4eaac318db3d76743b1ff83f47268d0fc1c2dad7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0.5
Gerrit-Owner: Andrej Krejcir 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Piotr Kliczewski 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org


Change in vdsm[ovirt-4.0.5]: Fix return value names for VM.ioTune calls

2016-10-12 Thread automation
gerrit-hooks has posted comments on this change.

Change subject: Fix return value names for VM.ioTune calls
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::OK
* Check Public Bug::#1373832::OK, public bug
* Check Product::IGNORE, no bug url/s found
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65377
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4eaac318db3d76743b1ff83f47268d0fc1c2dad7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0.5
Gerrit-Owner: Andrej Krejcir 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org