svn commit: r290921 - /jakarta/velocity/core/trunk/project.properties

2005-09-22 Thread henning
Author: henning Date: Thu Sep 22 02:42:18 2005 New Revision: 290921 URL: http://svn.apache.org/viewcvs?rev=290921view=rev Log: add eol-style == native Modified: jakarta/velocity/core/trunk/project.properties (contents, props changed) Modified: jakarta/velocity/core/trunk

svn commit: r290924 - in /jakarta/velocity/core/trunk/src: java/org/apache/velocity/test/ test/org/apache/velocity/test/

2005-09-22 Thread henning
Author: henning Date: Thu Sep 22 03:00:53 2005 New Revision: 290924 URL: http://svn.apache.org/viewcvs?rev=290924view=rev Log: Move the org.apache.velocity.test package out of the main velocity jar and into the src/test tree. These unit tests are only useful at compile time because they depend

svn commit: r290927 - in /jakarta/velocity/core/trunk: ./ src/test/org/apache/velocity/test/ test/texen-classpath/ test/texen-classpath/jar-contents/ test/texen/

2005-09-22 Thread henning
Author: henning Date: Thu Sep 22 03:38:53 2005 New Revision: 290927 URL: http://svn.apache.org/viewcvs?rev=290927view=rev Log: Update test directory references for maven driven unit tests. Modified: jakarta/velocity/core/trunk/project.properties jakarta/velocity/core/trunk/src/test/org

svn commit: r290929 - in /jakarta/velocity/core/trunk: ./ src/test/org/apache/velocity/test/ src/test/org/apache/velocity/util/

2005-09-22 Thread henning
Author: henning Date: Thu Sep 22 03:58:08 2005 New Revision: 290929 URL: http://svn.apache.org/viewcvs?rev=290929view=rev Log: Rename test cases to xxxTestCase so that all test cases can be identified by **/*TestCase.java Added: jakarta/velocity/core/trunk/src/test/org/apache/velocity

svn commit: r290932 - in /jakarta/velocity/core/trunk: ./ src/test/org/apache/velocity/test/

2005-09-22 Thread henning
Author: henning Date: Thu Sep 22 05:08:44 2005 New Revision: 290932 URL: http://svn.apache.org/viewcvs?rev=290932view=rev Log: All unit tests pass again when running under maven. Modified: jakarta/velocity/core/trunk/maven.xml jakarta/velocity/core/trunk/project.properties jakarta

svn commit: r290939 - in /jakarta/velocity/core/trunk: ./ build/ build/lib/ test/texen-classpath/ test/texen-classpath/jar-contents/ test/texen/

2005-09-22 Thread henning
Author: henning Date: Thu Sep 22 06:19:56 2005 New Revision: 290939 URL: http://svn.apache.org/viewcvs?rev=290939view=rev Log: Fix up unit tests to work again using ant. Added: jakarta/velocity/core/trunk/build/lib/junit-3.8.1.jar (with props) jakarta/velocity/core/trunk/test/texen

svn commit: r290984 - /jakarta/velocity/core/trunk/project.xml

2005-09-22 Thread henning
Author: henning Date: Thu Sep 22 10:06:25 2005 New Revision: 290984 URL: http://svn.apache.org/viewcvs?rev=290984view=rev Log: we actually _can_ run TemplateTestCase now... Modified: jakarta/velocity/core/trunk/project.xml Modified: jakarta/velocity/core/trunk/project.xml URL: http

svn commit: r290985 - in /jakarta/velocity/core/trunk/build: build.xml testcases.xml

2005-09-22 Thread henning
Author: henning Date: Thu Sep 22 10:07:07 2005 New Revision: 290985 URL: http://svn.apache.org/viewcvs?rev=290985view=rev Log: Make sure all unit tests still execute under ant. Remove duplicated tests from testcase.xml, running only the test cases that need special consideration like special

svn commit: r291402 - /jakarta/velocity/core/trunk/src/java/org/apache/velocity/runtime/parser/node/PropertyExecutor.java

2005-09-25 Thread henning
Author: henning Date: Sun Sep 25 06:08:51 2005 New Revision: 291402 URL: http://svn.apache.org/viewcvs?rev=291402view=rev Log: - Silence a JSDK 5.0 compile warning. - Minor code cleanup (add braces to if(), remove trailing blanks) Modified: jakarta/velocity/core/trunk/src/java/org/apache

svn commit: r291407 - in /jakarta/velocity/core/trunk/build: build.xml testcases.xml

2005-09-25 Thread henning
Author: henning Date: Sun Sep 25 06:52:41 2005 New Revision: 291407 URL: http://svn.apache.org/viewcvs?rev=291407view=rev Log: Run the test cases relative to the base dir of Velocity. This makes the test work under Windows again (Tested with XP, ant 1.6.5, JDK 1.5.0_05). Factor out

svn commit: r291409 - /jakarta/velocity/core/trunk/build/build.xml

2005-09-25 Thread henning
Author: henning Date: Sun Sep 25 06:57:44 2005 New Revision: 291409 URL: http://svn.apache.org/viewcvs?rev=291409view=rev Log: overeager search'n'replace... Modified: jakarta/velocity/core/trunk/build/build.xml Modified: jakarta/velocity/core/trunk/build/build.xml URL: http

svn commit: r291410 - /jakarta/velocity/core/trunk/build/build.xml

2005-09-25 Thread henning
Author: henning Date: Sun Sep 25 07:01:49 2005 New Revision: 291410 URL: http://svn.apache.org/viewcvs?rev=291410view=rev Log: as we are running from the tree root, we don't need the sysproperty any longer. Modified: jakarta/velocity/core/trunk/build/build.xml Modified: jakarta/velocity

svn commit: r291412 - in /jakarta/velocity/core/trunk/test: texen-classpath/jar-contents/service-ant.props texen-classpath/test.jar texen/service-ant.props

2005-09-25 Thread henning
Author: henning Date: Sun Sep 25 07:02:24 2005 New Revision: 291412 URL: http://svn.apache.org/viewcvs?rev=291412view=rev Log: remove the service-ant kludge again. as the ant-driven tests are also run from the tree root, these are no longer needed. Removed: jakarta/velocity/core/trunk/test

svn commit: r291413 - /jakarta/velocity/core/trunk/src/test/org/apache/velocity/test/BuiltInEventHandlerTestCase.java

2005-09-25 Thread henning
Author: henning Date: Sun Sep 25 07:03:20 2005 New Revision: 291413 URL: http://svn.apache.org/viewcvs?rev=291413view=rev Log: Test results should end up in target/test, not in the source tree. Modified: jakarta/velocity/core/trunk/src/test/org/apache/velocity/test

svn commit: r291585 [3/3] - in /jakarta/velocity/core/trunk: ./ build/ build/xsl/ examples/ examples/anakia/ examples/anakia/build/ examples/anakia/xdocs/ examples/anakia/xdocs/about/ examples/anakia/

2005-09-26 Thread henning
Propchange: jakarta/velocity/core/trunk/xdocs/translations/user-guide_fr.xml -- --- svn:keywords (original) +++ svn:keywords Mon Sep 26 01:56:23 2005 @@ -1 +1 @@ -Author Date Id Revision +Id Author Date Revision

svn commit: r291674 - /jakarta/velocity/core/trunk/src/test/org/apache/velocity/test/misc/Test.java

2005-09-26 Thread henning
Author: henning Date: Mon Sep 26 09:57:38 2005 New Revision: 291674 URL: http://svn.apache.org/viewcvs?rev=291674view=rev Log: Old test stub, has been replaced by junit driven unit tests. Removed: jakarta/velocity/core/trunk/src/test/org/apache/velocity/test/misc/Test.java

svn commit: r291676 - /jakarta/velocity/core/trunk/src/java/org/apache/velocity/app/event/implement/IncludeRelativePath.java

2005-09-26 Thread henning
Author: henning Date: Mon Sep 26 10:03:49 2005 New Revision: 291676 URL: http://svn.apache.org/viewcvs?rev=291676view=rev Log: Does not need to be RuntimeAware because the object passed in is not used. Modified: jakarta/velocity/core/trunk/src/java/org/apache/velocity/app/event/implement

svn commit: r291677 - in /jakarta/velocity/core/trunk/src/java/org/apache/velocity: ./ io/ runtime/configuration/ runtime/directive/ runtime/log/ runtime/parser/node/ util/ util/introspection/

2005-09-26 Thread henning
Author: henning Date: Mon Sep 26 10:04:21 2005 New Revision: 291677 URL: http://svn.apache.org/viewcvs?rev=291677view=rev Log: Remove a number of unused variables, private unused methods and assignments. Modified: jakarta/velocity/core/trunk/src/java/org/apache/velocity/Template.java

svn commit: r291681 - in /jakarta/velocity/core/trunk/src/test/org/apache/velocity/test: ./ eventhandler/ view/

2005-09-26 Thread henning
Author: henning Date: Mon Sep 26 10:16:59 2005 New Revision: 291681 URL: http://svn.apache.org/viewcvs?rev=291681view=rev Log: Remove a few unused variables, clean up unused imports Modified: jakarta/velocity/core/trunk/src/test/org/apache/velocity/test/AnakiaTestCase.java jakarta

svn commit: r291682 - in /jakarta/velocity/core/trunk/src/java/org/apache/velocity: runtime/parser/node/ servlet/ util/ util/introspection/

2005-09-26 Thread henning
Author: henning Date: Mon Sep 26 10:17:23 2005 New Revision: 291682 URL: http://svn.apache.org/viewcvs?rev=291682view=rev Log: Remove unused imports Modified: jakarta/velocity/core/trunk/src/java/org/apache/velocity/runtime/parser/node/ASTIdentifier.java jakarta/velocity/core/trunk

svn commit: r291683 - in /jakarta/velocity/core/trunk/src: java/org/apache/velocity/ java/org/apache/velocity/anakia/ java/org/apache/velocity/context/ java/org/apache/velocity/exception/ java/org/apache/velocity/runtime/directive/ java/org/apache/velo...

2005-09-26 Thread henning
Author: henning Date: Mon Sep 26 10:25:44 2005 New Revision: 291683 URL: http://svn.apache.org/viewcvs?rev=291683view=rev Log: Add a bunch of SerialVersionUID declarations to serializable classes. Modified: jakarta/velocity/core/trunk/src/java/org/apache/velocity/VelocityContext.java

svn commit: r291684 - /jakarta/velocity/core/trunk/src/java/org/apache/velocity/texen/ant/TexenTask.java

2005-09-26 Thread henning
Author: henning Date: Mon Sep 26 10:30:37 2005 New Revision: 291684 URL: http://svn.apache.org/viewcvs?rev=291684view=rev Log: Access static fields statically Modified: jakarta/velocity/core/trunk/src/java/org/apache/velocity/texen/ant/TexenTask.java Modified: jakarta/velocity/core/trunk

svn commit: r291685 - /jakarta/velocity/core/trunk/src/test/org/apache/velocity/test/IntrospectorTestCase.java

2005-09-26 Thread henning
Author: henning Date: Mon Sep 26 10:31:01 2005 New Revision: 291685 URL: http://svn.apache.org/viewcvs?rev=291685view=rev Log: add a comment about a non-referenced method being used for the introspector test Modified: jakarta/velocity/core/trunk/src/test/org/apache/velocity/test

svn commit: r291687 - in /jakarta/velocity/core/trunk: src/java/org/apache/velocity/ src/java/org/apache/velocity/app/ src/java/org/apache/velocity/runtime/configuration/ src/test/org/apache/velocity/test/ xdocs/docs/

2005-09-26 Thread henning
Author: henning Date: Mon Sep 26 10:37:14 2005 New Revision: 291687 URL: http://svn.apache.org/viewcvs?rev=291687view=rev Log: Remove the configuration package and the Configuration class. This was scheduled to be done in 1.3 or 1.4. Now we do it. :-) Removed: jakarta/velocity/core/trunk

svn commit: r291691 - /jakarta/velocity/core/trunk/src/java/org/apache/velocity/runtime/directive/Macro.java

2005-09-26 Thread henning
Author: henning Date: Mon Sep 26 10:46:29 2005 New Revision: 291691 URL: http://svn.apache.org/viewcvs?rev=291691view=rev Log: discard return value, never read anyway Modified: jakarta/velocity/core/trunk/src/java/org/apache/velocity/runtime/directive/Macro.java Modified: jakarta

svn commit: r291695 - in /jakarta/velocity/core/trunk: build/build.xml src/java/org/apache/velocity/runtime/resource/ResourceCacheImpl.java

2005-09-26 Thread henning
Author: henning Date: Mon Sep 26 10:56:01 2005 New Revision: 291695 URL: http://svn.apache.org/viewcvs?rev=291695view=rev Log: - LRUMap moved into map subpackage by collections 3.0 - Actually think long and hard what classes from the collections jar are needed. Just include these. Before we

svn commit: r291862 - /jakarta/velocity/core/trunk/src/java/org/apache/velocity/runtime/VelocimacroFactory.java

2005-09-27 Thread henning
Author: henning Date: Tue Sep 27 01:54:33 2005 New Revision: 291862 URL: http://svn.apache.org/viewcvs?rev=291862view=rev Log: If we have getter/setters, let's use them. Modified: jakarta/velocity/core/trunk/src/java/org/apache/velocity/runtime/VelocimacroFactory.java Modified: jakarta

svn commit: r291868 - in /jakarta/velocity/core/trunk/src/java/org/apache/velocity/runtime: VelocimacroFactory.java directive/Macro.java

2005-09-27 Thread henning
Author: henning Date: Tue Sep 27 02:13:18 2005 New Revision: 291868 URL: http://svn.apache.org/viewcvs?rev=291868view=rev Log: factor out common Macro printout routine. Add some javadocs. Modified: jakarta/velocity/core/trunk/src/java/org/apache/velocity/runtime/VelocimacroFactory.java

svn commit: r291876 - /jakarta/velocity/core/trunk/src/java/org/apache/velocity/app/FieldMethodizer.java

2005-09-27 Thread henning
Author: henning Date: Tue Sep 27 02:38:36 2005 New Revision: 291876 URL: http://svn.apache.org/viewcvs?rev=291876view=rev Log: Removed FindBugs report (Exception was too broad, replaced with IllegalAccessException), cleaned up error messages. I was wondering if there should be a standard way

svn commit: r291877 - /jakarta/velocity/core/trunk/src/java/org/apache/velocity/context/AbstractContext.java

2005-09-27 Thread henning
Author: henning Date: Tue Sep 27 02:43:52 2005 New Revision: 291877 URL: http://svn.apache.org/viewcvs?rev=291877view=rev Log: Serializable is already implemented in superclass (found by findbugs) Modified: jakarta/velocity/core/trunk/src/java/org/apache/velocity/context

svn commit: r291879 - in /jakarta/velocity/core/trunk/src/java/org/apache/velocity: io/VelocityWriter.java runtime/RuntimeSingleton.java

2005-09-27 Thread henning
Author: henning Date: Tue Sep 27 02:51:12 2005 New Revision: 291879 URL: http://svn.apache.org/viewcvs?rev=291879view=rev Log: remove unused methods (found by Findbugs) Modified: jakarta/velocity/core/trunk/src/java/org/apache/velocity/io/VelocityWriter.java jakarta/velocity/core

svn commit: r291888 - /jakarta/velocity/core/trunk/src/java/org/apache/velocity/util/StringUtils.java

2005-09-27 Thread henning
Author: henning Date: Tue Sep 27 03:10:05 2005 New Revision: 291888 URL: http://svn.apache.org/viewcvs?rev=291888view=rev Log: remove potential did not close stream issue. Found by findbugs Modified: jakarta/velocity/core/trunk/src/java/org/apache/velocity/util/StringUtils.java Modified

svn commit: r291889 - /jakarta/velocity/core/trunk/src/java/org/apache/velocity/runtime/RuntimeInstance.java

2005-09-27 Thread henning
Author: henning Date: Tue Sep 27 03:10:18 2005 New Revision: 291889 URL: http://svn.apache.org/viewcvs?rev=291889view=rev Log: add a comment about findbugs issue. Modified: jakarta/velocity/core/trunk/src/java/org/apache/velocity/runtime/RuntimeInstance.java Modified: jakarta/velocity

svn commit: r291890 - /jakarta/velocity/core/trunk/src/java/org/apache/velocity/convert/WebMacro.java

2005-09-27 Thread henning
Author: henning Date: Tue Sep 27 03:10:50 2005 New Revision: 291890 URL: http://svn.apache.org/viewcvs?rev=291890view=rev Log: Remove some findbugs issues, including a number of System.exit() calls. Modified: jakarta/velocity/core/trunk/src/java/org/apache/velocity/convert/WebMacro.java

svn commit: r291900 - /jakarta/velocity/core/trunk/src/java/org/apache/velocity/convert/WebMacro.java

2005-09-27 Thread henning
Author: henning Date: Tue Sep 27 03:58:18 2005 New Revision: 291900 URL: http://svn.apache.org/viewcvs?rev=291900view=rev Log: Remove another dead local storage issue found by Findbugs Modified: jakarta/velocity/core/trunk/src/java/org/apache/velocity/convert/WebMacro.java Modified

svn commit: r291901 - /jakarta/velocity/core/trunk/src/java/org/apache/velocity/texen/Generator.java

2005-09-27 Thread henning
Author: henning Date: Tue Sep 27 03:58:41 2005 New Revision: 291901 URL: http://svn.apache.org/viewcvs?rev=291901view=rev Log: Make sure that all streams are closed at all times (again, found by Findbugs) Modified: jakarta/velocity/core/trunk/src/java/org/apache/velocity/texen

svn commit: r291902 - /jakarta/velocity/core/trunk/src/java/org/apache/velocity/anakia/AnakiaTask.java

2005-09-27 Thread henning
Author: henning Date: Tue Sep 27 03:59:16 2005 New Revision: 291902 URL: http://svn.apache.org/viewcvs?rev=291902view=rev Log: remove an unnecessary null test and make sure that all streams are always closed (Findbugs) Modified: jakarta/velocity/core/trunk/src/java/org/apache/velocity

svn commit: r291905 - /jakarta/velocity/core/trunk/src/java/org/apache/velocity/servlet/VelocityServlet.java

2005-09-27 Thread henning
Author: henning Date: Tue Sep 27 04:01:36 2005 New Revision: 291905 URL: http://svn.apache.org/viewcvs?rev=291905view=rev Log: Closing output streams seems to be tricky business. Another problem found by findbugs. Also reference the static fields in the class by using the VelocityServlet

svn commit: r292943 - /jakarta/velocity/core/trunk/project.xml

2005-10-01 Thread henning
Author: henning Date: Sat Oct 1 03:10:22 2005 New Revision: 292943 URL: http://svn.apache.org/viewcvs?rev=292943view=rev Log: add yours truly to the list of developers Modified: jakarta/velocity/core/trunk/project.xml Modified: jakarta/velocity/core/trunk/project.xml URL: http

svn commit: r292947 - /jakarta/velocity/core/trunk/src/java/org/apache/velocity/app/event/implement/PrintExceptions.java

2005-10-01 Thread henning
Author: henning Date: Sat Oct 1 03:58:33 2005 New Revision: 292947 URL: http://svn.apache.org/viewcvs?rev=292947view=rev Log: Make sure that the output stream always gets close. Has the side effect, that getStackTrace will always return the right stack trace as the IOException can only be thrown

svn commit: r292948 - in /jakarta/velocity/core/trunk/src/java/org/apache/velocity: runtime/directive/Macro.java texen/util/PropertiesUtil.java

2005-10-01 Thread henning
Author: henning Date: Sat Oct 1 03:59:35 2005 New Revision: 292948 URL: http://svn.apache.org/viewcvs?rev=292948view=rev Log: Remove redundant local stores (both found by FindBugs) Modified: jakarta/velocity/core/trunk/src/java/org/apache/velocity/runtime/directive/Macro.java jakarta

svn commit: r292953 - /jakarta/velocity/core/trunk/src/java/org/apache/velocity/app/event/implement/PrintExceptions.java

2005-10-01 Thread henning
Author: henning Date: Sat Oct 1 04:09:37 2005 New Revision: 292953 URL: http://svn.apache.org/viewcvs?rev=292953view=rev Log: We can actually do even a bit better by turning the PrintWriter/StringWriter combo around. Funny how hard it is to get that small piece of code really right... Modified

svn commit: r292955 - /jakarta/velocity/core/trunk/src/java/org/apache/velocity/runtime/parser/node/NodeUtils.java

2005-10-01 Thread henning
Author: henning Date: Sat Oct 1 04:16:17 2005 New Revision: 292955 URL: http://svn.apache.org/viewcvs?rev=292955view=rev Log: Removing a String concatenation in a loop, thus improving a possible StringBuffer.append(StringBuffer) situation. Defuse and comment it. (String concat found by Findbugs

svn commit: r292957 - in /jakarta/velocity/core/trunk/src/java/org/apache/velocity: runtime/resource/loader/ texen/ant/ texen/util/

2005-10-01 Thread henning
Author: henning Date: Sat Oct 1 04:28:17 2005 New Revision: 292957 URL: http://svn.apache.org/viewcvs?rev=292957view=rev Log: Check a number of generic catch Exception instances found by Findbugs and replace them either with more specialized Exceptions or document which Exceptions are caught

svn commit: r292958 - /jakarta/velocity/core/trunk/src/java/org/apache/velocity/runtime/directive/VMProxyArg.java

2005-10-01 Thread henning
Author: henning Date: Sat Oct 1 04:39:27 2005 New Revision: 292958 URL: http://svn.apache.org/viewcvs?rev=292958view=rev Log: - make a constant really static - remove a String(String) C'tor. Strings are immutable so the assignment is really ok. (Both found by Findbugs) Modified

svn commit: r292962 - /jakarta/velocity/core/trunk/src/java/org/apache/velocity/runtime/log/AvalonLogChute.java

2005-10-01 Thread henning
Author: henning Date: Sat Oct 1 04:50:24 2005 New Revision: 292962 URL: http://svn.apache.org/viewcvs?rev=292962view=rev Log: Same code used for two branches (found by findbugs) Modified: jakarta/velocity/core/trunk/src/java/org/apache/velocity/runtime/log/AvalonLogChute.java Modified

svn commit: r292963 - /jakarta/velocity/core/trunk/src/java/org/apache/velocity/runtime/log/LogManager.java

2005-10-01 Thread henning
Author: henning Date: Sat Oct 1 05:00:13 2005 New Revision: 292963 URL: http://svn.apache.org/viewcvs?rev=292963view=rev Log: Removed a possible NPE when rsvc.getProperty might decide to return neither a String nor a List. Modified: jakarta/velocity/core/trunk/src/java/org/apache/velocity

svn commit: r292964 - /jakarta/velocity/core/trunk/src/java/org/apache/velocity/runtime/log/LogManager.java

2005-10-01 Thread henning
Author: henning Date: Sat Oct 1 05:10:59 2005 New Revision: 292964 URL: http://svn.apache.org/viewcvs?rev=292964view=rev Log: make sure that a non LogSystem/non LogChute object passed into the LogManager is not just silently ignored but logged at warn level (might even be error). Modified

svn commit: r292967 - /jakarta/velocity/core/trunk/src/java/org/apache/velocity/runtime/log/Log.java

2005-10-01 Thread henning
Author: henning Date: Sat Oct 1 05:19:19 2005 New Revision: 292967 URL: http://svn.apache.org/viewcvs?rev=292967view=rev Log: more eol fixup Modified: jakarta/velocity/core/trunk/src/java/org/apache/velocity/runtime/log/Log.java (contents, props changed) Modified: jakarta/velocity

svn commit: r292968 - /jakarta/velocity/core/trunk/src/java/org/apache/velocity/runtime/log/LogChuteSystem.java

2005-10-01 Thread henning
Author: henning Date: Sat Oct 1 05:19:40 2005 New Revision: 292968 URL: http://svn.apache.org/viewcvs?rev=292968view=rev Log: More EOL fixup Modified: jakarta/velocity/core/trunk/src/java/org/apache/velocity/runtime/log/LogChuteSystem.java (contents, props changed) Modified: jakarta

svn commit: r292969 - /jakarta/velocity/core/trunk/src/java/org/apache/velocity/runtime/log/RuntimeLoggerLog.java

2005-10-01 Thread henning
Author: henning Date: Sat Oct 1 05:20:09 2005 New Revision: 292969 URL: http://svn.apache.org/viewcvs?rev=292969view=rev Log: even _more_ eol fixup... Modified: jakarta/velocity/core/trunk/src/java/org/apache/velocity/runtime/log/RuntimeLoggerLog.java (contents, props changed

svn commit: r292971 - in /jakarta/velocity/core/trunk/src/java/org/apache/velocity/app: event/implement/IncludeRelativePath.java tools/VelocityFormatter.java

2005-10-01 Thread henning
Author: henning Date: Sat Oct 1 05:35:24 2005 New Revision: 292971 URL: http://svn.apache.org/viewcvs?rev=292971view=rev Log: Remove unread fields (found by findbugs) Modified: jakarta/velocity/core/trunk/src/java/org/apache/velocity/app/event/implement/IncludeRelativePath.java

svn commit: r292972 - /jakarta/velocity/core/trunk/src/java/org/apache/velocity/app/event/EventCartridge.java

2005-10-01 Thread henning
Author: henning Date: Sat Oct 1 05:36:19 2005 New Revision: 292972 URL: http://svn.apache.org/viewcvs?rev=292972view=rev Log: Make variable names start with lowercase letters. All variables are private, so this is a non user visible change. Modified: jakarta/velocity/core/trunk/src/java

svn commit: r292973 - in /jakarta/velocity/core/trunk/src/java/org/apache/velocity: app/event/implement/IncludeNotFound.java runtime/parser/node/ASTDirective.java runtime/parser/node/ASTSetDirective.java runtime/resource/loader/FileResourceLoader.java

2005-10-01 Thread henning
Author: henning Date: Sat Oct 1 05:37:24 2005 New Revision: 292973 URL: http://svn.apache.org/viewcvs?rev=292973view=rev Log: Don't leave fields uninitialized (found by findbugs) Modified: jakarta/velocity/core/trunk/src/java/org/apache/velocity/app/event/implement/IncludeNotFound.java

svn commit: r292974 - in /jakarta/velocity/core/trunk/src/java/org/apache/velocity: anakia/Escape.java runtime/parser/node/MathUtils.java

2005-10-01 Thread henning
Author: henning Date: Sat Oct 1 05:38:30 2005 New Revision: 292974 URL: http://svn.apache.org/viewcvs?rev=292974view=rev Log: Make constant definitions final. Modified: jakarta/velocity/core/trunk/src/java/org/apache/velocity/anakia/Escape.java jakarta/velocity/core/trunk/src/java/org

svn commit: r292975 - /jakarta/velocity/core/trunk/src/java/org/apache/velocity/runtime/VelocimacroFactory.java

2005-10-01 Thread henning
Author: henning Date: Sat Oct 1 05:40:06 2005 New Revision: 292975 URL: http://svn.apache.org/viewcvs?rev=292975view=rev Log: fixup incomplete field synchronization. Also make inner class static (does not need 'this'). Modified: jakarta/velocity/core/trunk/src/java/org/apache/velocity

svn commit: r292976 - in /jakarta/velocity/core/trunk/src/java/org/apache/velocity: runtime/directive/Foreach.java util/introspection/UberspectImpl.java

2005-10-01 Thread henning
Author: henning Date: Sat Oct 1 05:40:39 2005 New Revision: 292976 URL: http://svn.apache.org/viewcvs?rev=292976view=rev Log: make inner classes static Modified: jakarta/velocity/core/trunk/src/java/org/apache/velocity/runtime/directive/Foreach.java jakarta/velocity/core/trunk/src

svn commit: r292977 - /jakarta/velocity/core/trunk/src/java/org/apache/velocity/util/introspection/Introspector.java

2005-10-01 Thread henning
Author: henning Date: Sat Oct 1 05:46:32 2005 New Revision: 292977 URL: http://svn.apache.org/viewcvs?rev=292977view=rev Log: Yet another concat string in loop occurence, found by findbugs Modified: jakarta/velocity/core/trunk/src/java/org/apache/velocity/util/introspection

svn commit: r292978 - /jakarta/velocity/core/trunk/src/java/org/apache/velocity/util/introspection/UberspectImpl.java

2005-10-01 Thread henning
Author: henning Date: Sat Oct 1 05:59:31 2005 New Revision: 292978 URL: http://svn.apache.org/viewcvs?rev=292978view=rev Log: static Introspector object? Now that scares me. And makes me wonder if ever anyone has tried to run two different VelocityEngine instances with different Introspectors

svn commit: r292979 - /jakarta/velocity/core/trunk/src/java/org/apache/velocity/texen/ant/TexenTask.java

2005-10-01 Thread henning
Author: henning Date: Sat Oct 1 06:00:40 2005 New Revision: 292979 URL: http://svn.apache.org/viewcvs?rev=292979view=rev Log: Defuse potential NPE. (findbugs) Modified: jakarta/velocity/core/trunk/src/java/org/apache/velocity/texen/ant/TexenTask.java Modified: jakarta/velocity/core/trunk

svn commit: r292980 - /jakarta/velocity/core/trunk/src/java/org/apache/velocity/runtime/parser/node/ASTMethod.java

2005-10-01 Thread henning
Author: henning Date: Sat Oct 1 06:11:39 2005 New Revision: 292980 URL: http://svn.apache.org/viewcvs?rev=292980view=rev Log: Remove String(String) C'tor. Can anyone tell me whether this whole code segment is actually correct? Because a method returning 'null' and not having a void return type

svn commit: r292981 - /jakarta/velocity/core/trunk/src/java/org/apache/velocity/runtime/resource/loader/JarResourceLoader.java

2005-10-01 Thread henning
Author: henning Date: Sat Oct 1 06:14:31 2005 New Revision: 292981 URL: http://svn.apache.org/viewcvs?rev=292981view=rev Log: Remove possible NPE for error path Modified: jakarta/velocity/core/trunk/src/java/org/apache/velocity/runtime/resource/loader/JarResourceLoader.java Modified

svn commit: r293611 - /jakarta/velocity/core/trunk/xdocs/committers.xml

2005-10-04 Thread henning
Author: henning Date: Tue Oct 4 07:47:23 2005 New Revision: 293611 URL: http://svn.apache.org/viewcvs?rev=293611view=rev Log: that's actually a good idea. :-) Also test out whether anakia is able to parse UTF-8 input if encoding is set to UTF-8. :-) Modified: jakarta/velocity/core/trunk

svn commit: r307295 - /jakarta/velocity/core/trunk/examples/logger_example/LoggerExample.java

2005-10-08 Thread henning
Author: henning Date: Sat Oct 8 07:24:52 2005 New Revision: 307295 URL: http://svn.apache.org/viewcvs?rev=307295view=rev Log: search'n'replace error... :-) Modified: jakarta/velocity/core/trunk/examples/logger_example/LoggerExample.java Modified: jakarta/velocity/core/trunk/examples

svn commit: r307296 - /jakarta/velocity/core/trunk/examples/event_example/EventExample.java

2005-10-08 Thread henning
Author: henning Date: Sat Oct 8 07:28:28 2005 New Revision: 307296 URL: http://svn.apache.org/viewcvs?rev=307296view=rev Log: No longer uses LogSystem but uses LogChute Modified: jakarta/velocity/core/trunk/examples/event_example/EventExample.java Modified: jakarta/velocity/core/trunk

svn commit: r307297 - in /jakarta/velocity/core/trunk/examples: anakia/ app_example1/ app_example2/ context_example/ event_example/ logger_example/ xmlapp_example/

2005-10-08 Thread henning
Author: henning Date: Sat Oct 8 07:29:44 2005 New Revision: 307297 URL: http://svn.apache.org/viewcvs?rev=307297view=rev Log: Ignore files generated when compiling the examples Modified: jakarta/velocity/core/trunk/examples/anakia/ (props changed) jakarta/velocity/core/trunk/examples

svn commit: r307298 - in /jakarta/velocity/core/trunk/build/lib: oro-2.0.8.jar oro.jar

2005-10-08 Thread henning
Author: henning Date: Sat Oct 8 07:43:20 2005 New Revision: 307298 URL: http://svn.apache.org/viewcvs?rev=307298view=rev Log: Bring oro up to current version, removing the unversioned jar. Added: jakarta/velocity/core/trunk/build/lib/oro-2.0.8.jar (with props) Removed: jakarta

svn commit: r307381 - in /jakarta/velocity/core/trunk/src/java/org/apache/velocity/runtime/parser/node: ASTIdentifier.java ASTMethod.java

2005-10-09 Thread henning
Author: henning Date: Sun Oct 9 02:58:23 2005 New Revision: 307381 URL: http://svn.apache.org/viewcvs?rev=307381view=rev Log: remove double call to ite.getTargetException(), remove redundant java.lang qualifier Modified: jakarta/velocity/core/trunk/src/java/org/apache/velocity/runtime

svn commit: r307382 - in /jakarta/velocity/core/trunk/src/java/org/apache/velocity: app/VelocityEngine.java runtime/RuntimeInstance.java runtime/RuntimeSingleton.java

2005-10-09 Thread henning
Author: henning Date: Sun Oct 9 03:21:30 2005 New Revision: 307382 URL: http://svn.apache.org/viewcvs?rev=307382view=rev Log: Remove a number of using deprecated method method calls. Modified: jakarta/velocity/core/trunk/src/java/org/apache/velocity/app/VelocityEngine.java jakarta

svn commit: r307402 - /jakarta/velocity/core/trunk/test/absolute/absolute.vm

2005-10-09 Thread henning
Author: henning Date: Sun Oct 9 04:30:18 2005 New Revision: 307402 URL: http://svn.apache.org/viewcvs?rev=307402view=rev Log: svn:eol-style Modified: jakarta/velocity/core/trunk/test/absolute/absolute.vm (contents, props changed) Modified: jakarta/velocity/core/trunk/test/absolute

svn commit: r307404 - /jakarta/velocity/core/trunk/build/build.properties

2005-10-09 Thread henning
Author: henning Date: Sun Oct 9 04:45:41 2005 New Revision: 307404 URL: http://svn.apache.org/viewcvs?rev=307404view=rev Log: The various common properties in a separate file Added: jakarta/velocity/core/trunk/build/build.properties (with props) Added: jakarta/velocity/core/trunk/build

svn commit: r307406 - /jakarta/velocity/core/trunk/examples/context_example/DBContextTest.java

2005-10-09 Thread henning
Author: henning Date: Sun Oct 9 05:14:16 2005 New Revision: 307406 URL: http://svn.apache.org/viewcvs?rev=307406view=rev Log: Remove deprecated Runtime References, replace them with RuntimeSingleton Modified: jakarta/velocity/core/trunk/examples/context_example/DBContextTest.java Modified

svn commit: r307408 - /jakarta/velocity/core/trunk/examples/app_example2/Example2.java

2005-10-09 Thread henning
Author: henning Date: Sun Oct 9 05:15:30 2005 New Revision: 307408 URL: http://svn.apache.org/viewcvs?rev=307408view=rev Log: Remove deprecated method usage Modified: jakarta/velocity/core/trunk/examples/app_example2/Example2.java Modified: jakarta/velocity/core/trunk/examples/app_example2

svn commit: r307414 - in /jakarta/velocity/core/trunk/examples/logger_example: Log4jCategoryExample.java Log4jLoggerExample.java

2005-10-09 Thread henning
Author: henning Date: Sun Oct 9 05:30:17 2005 New Revision: 307414 URL: http://svn.apache.org/viewcvs?rev=307414view=rev Log: Category is deprecated since about forever. Move the example to use a Logger, renaming it in the process... Added: jakarta/velocity/core/trunk/examples

svn commit: r307415 - /jakarta/velocity/core/trunk/examples/logger_example/README.txt

2005-10-09 Thread henning
Author: henning Date: Sun Oct 9 05:31:37 2005 New Revision: 307415 URL: http://svn.apache.org/viewcvs?rev=307415view=rev Log: update docs Modified: jakarta/velocity/core/trunk/examples/logger_example/README.txt Modified: jakarta/velocity/core/trunk/examples/logger_example/README.txt URL

svn commit: r312491 - /jakarta/velocity/core/trunk/build/testcases.xml

2005-10-09 Thread henning
Author: henning Date: Sun Oct 9 11:52:57 2005 New Revision: 312491 URL: http://svn.apache.org/viewcvs?rev=312491view=rev Log: cleaned up class path definitions. Remove ant 1.3 workarounds. Modified: jakarta/velocity/core/trunk/build/testcases.xml Modified: jakarta/velocity/core/trunk

svn commit: r312493 - in /jakarta/velocity/core/trunk: ./ build/build.properties build/build.xml

2005-10-09 Thread henning
Author: henning Date: Sun Oct 9 12:39:12 2005 New Revision: 312493 URL: http://svn.apache.org/viewcvs?rev=312493view=rev Log: Reworked the Velocity ant build system. Run ant -projecthelp to get an overview of all the available targets. Only two jar targets: jar and jar-dep with warnings about

svn commit: r329216 - /jakarta/velocity/core/trunk/build/build.xml

2005-10-28 Thread henning
Author: henning Date: Fri Oct 28 07:38:01 2005 New Revision: 329216 URL: http://svn.apache.org/viewcvs?rev=329216view=rev Log: JDK 1.3.1 chokes if the encoding is not set and the system defaults to UTF-8. Modified: jakarta/velocity/core/trunk/build/build.xml Modified: jakarta/velocity/core

svn commit: r329218 - in /jakarta/velocity/core/trunk/build: build.properties build.xml download.xml lib/ testcases.xml

2005-10-28 Thread henning
Author: henning Date: Fri Oct 28 08:00:37 2005 New Revision: 329218 URL: http://svn.apache.org/viewcvs?rev=329218view=rev Log: Remove libraries from Subversion. The ant build now fetches all needed libraries directly from the central repository at www.ibiblio.org. You need this only if you

svn commit: r329430 - in /jakarta/velocity/core/trunk: build/build.properties build/build.xml src/java/org/apache/velocity/runtime/parser/Parser.jjt src/parser/ src/parser/Parser.jjt

2005-10-29 Thread henning
Author: henning Date: Sat Oct 29 09:18:23 2005 New Revision: 329430 URL: http://svn.apache.org/viewcvs?rev=329430view=rev Log: Move Parser source out of the build tree. The intermediate Parser.jj file still stays in the java source tree, because it is generated right there by the JTree task

svn commit: r329434 - in /jakarta/velocity/core/trunk/src/java/org/apache/velocity/runtime: parser/node/ParserVisitor.java visitor/BaseVisitor.java visitor/NodeViewMode.java

2005-10-29 Thread henning
Author: henning Date: Sat Oct 29 09:26:32 2005 New Revision: 329434 URL: http://svn.apache.org/viewcvs?rev=329434view=rev Log: Add missing methods in the ParserVisitor for the current JavaCC/JTree generated parser. Modified: jakarta/velocity/core/trunk/src/java/org/apache/velocity/runtime

svn commit: r329445 - in /jakarta/velocity/core/trunk: build/ src/java/org/apache/velocity/runtime/directive/ src/java/org/apache/velocity/runtime/parser/ src/java/org/apache/velocity/runtime/parser/n

2005-10-29 Thread henning
Author: henning Date: Sat Oct 29 10:00:14 2005 New Revision: 329445 URL: http://svn.apache.org/viewcvs?rev=329445view=rev Log: Split the current node.Node into a velocity-specific node.Node which extends the (almost generic) Node. This currently looks ugly because both interfaces are called Node

svn commit: r329446 - in /jakarta/velocity/core/trunk: build/ src/java/org/apache/velocity/runtime/parser/ src/java/org/apache/velocity/runtime/parser/node/ src/java/org/apache/velocity/runtime/visito

2005-10-29 Thread henning
Author: henning Date: Sat Oct 29 10:07:04 2005 New Revision: 329446 URL: http://svn.apache.org/viewcvs?rev=329446view=rev Log: Move ParserVisitor back into the parser directory. Now all the auto-generated files are again in a single directory. Added: jakarta/velocity/core/trunk/src/java

svn commit: r329448 - in /jakarta/velocity/core/trunk/src/java/org/apache/velocity/runtime/parser: ParserVisitor.java Token.java

2005-10-29 Thread henning
Author: henning Date: Sat Oct 29 10:11:09 2005 New Revision: 329448 URL: http://svn.apache.org/viewcvs?rev=329448view=rev Log: Minor changes in visibility due to rebuilding the Parser with JavaCC 3.x Modified: jakarta/velocity/core/trunk/src/java/org/apache/velocity/runtime/parser

svn commit: r329450 - /jakarta/velocity/core/trunk/src/java/org/apache/velocity/runtime/parser/ParserVisitor.java

2005-10-29 Thread henning
Author: henning Date: Sat Oct 29 10:17:31 2005 New Revision: 329450 URL: http://svn.apache.org/viewcvs?rev=329450view=rev Log: undo last change. Got the wrong file. :-( Modified: jakarta/velocity/core/trunk/src/java/org/apache/velocity/runtime/parser/ParserVisitor.java Modified: jakarta

svn commit: r329451 - /jakarta/velocity/core/trunk/src/java/org/apache/velocity/runtime/parser/TokenMgrError.java

2005-10-29 Thread henning
Author: henning Date: Sat Oct 29 10:18:10 2005 New Revision: 329451 URL: http://svn.apache.org/viewcvs?rev=329451view=rev Log: JavaCC 3.0 changes visibility of the LexicalError method Modified: jakarta/velocity/core/trunk/src/java/org/apache/velocity/runtime/parser/TokenMgrError.java

svn commit: r329456 - in /jakarta/velocity/core/trunk/src/java/org/apache/velocity: exception/ParseErrorException.java runtime/parser/ParseException.java runtime/parser/TemplateParseException.java

2005-10-29 Thread henning
Author: henning Date: Sat Oct 29 10:52:49 2005 New Revision: 329456 URL: http://svn.apache.org/viewcvs?rev=329456view=rev Log: - Remove template specific code from ParseException, reverting it to the auto-generated state. - Put template specific code into Subclassed Exception

svn commit: r329459 - in /jakarta/velocity/core/trunk/src: java/org/apache/velocity/runtime/parser/Parser.java java/org/apache/velocity/runtime/parser/Parser.jj parser/Parser.jjt

2005-10-29 Thread henning
Author: henning Date: Sat Oct 29 11:01:49 2005 New Revision: 329459 URL: http://svn.apache.org/viewcvs?rev=329459view=rev Log: rebuild parser using TemplateParseException and JavaCC 3.2 Modified: jakarta/velocity/core/trunk/src/java/org/apache/velocity/runtime/parser/Parser.java

svn commit: r329469 - in /jakarta/velocity/core/trunk/src: java/org/apache/velocity/exception/ java/org/apache/velocity/runtime/directive/ java/org/apache/velocity/runtime/parser/ parser/

2005-10-29 Thread henning
Author: henning Date: Sat Oct 29 12:11:10 2005 New Revision: 329469 URL: http://svn.apache.org/viewcvs?rev=329469view=rev Log: MacroParseException is some sort of relative to TemplateParseException. Find a common Interface (ExtendedParseException) which allows the ParseErrorException to deal

svn commit: r329471 - /jakarta/velocity/core/trunk/src/java/org/apache/velocity/exception/ParseErrorException.java

2005-10-29 Thread henning
Author: henning Date: Sat Oct 29 12:13:48 2005 New Revision: 329471 URL: http://svn.apache.org/viewcvs?rev=329471view=rev Log: Add some sanity check for looking into ParseException to avoid NPE. Modified: jakarta/velocity/core/trunk/src/java/org/apache/velocity/exception

svn commit: r329564 - /jakarta/velocity/core/trunk/src/java/org/apache/velocity/exception/ExtendedParseException.java

2005-10-30 Thread henning
Author: henning Date: Sun Oct 30 05:40:23 2005 New Revision: 329564 URL: http://svn.apache.org/viewcvs?rev=329564view=rev Log: Forgot to add the interface implemented by TemplateParseException and MacroParseException Added: jakarta/velocity/core/trunk/src/java/org/apache/velocity

svn commit: r329577 - in /jakarta/velocity/core/trunk/src/java/org/apache/velocity/runtime: directive/MacroParseException.java parser/TemplateParseException.java

2005-10-30 Thread henning
Author: henning Date: Sun Oct 30 06:53:35 2005 New Revision: 329577 URL: http://svn.apache.org/viewcvs?rev=329577view=rev Log: Update getMessage() method, removing the ugly string concats, replacing them with StringBuffer. add line, column, template information in any case if it is available

svn commit: r329578 - /jakarta/velocity/core/trunk/src/test/org/apache/velocity/test/ParseExceptionTestCase.java

2005-10-30 Thread henning
Author: henning Date: Sun Oct 30 06:54:06 2005 New Revision: 329578 URL: http://svn.apache.org/viewcvs?rev=329578view=rev Log: add tests for the macro exception case checking whether macro def and invocation correctly generate line and column information. Modified: jakarta/velocity/core

svn commit: r329582 - in /jakarta/velocity/core/trunk: build/build.properties build/download.xml project.xml src/java/org/apache/velocity/runtime/compiler/

2005-10-30 Thread henning
Author: henning Date: Sun Oct 30 07:37:44 2005 New Revision: 329582 URL: http://svn.apache.org/viewcvs?rev=329582view=rev Log: The Velocity compiler never went anywhere and dropping it out allows us to remove the bcel dependency that is used nowhere else. Removed: jakarta/velocity/core

svn commit: r329583 - in /jakarta/velocity/core/trunk/xdocs: dependencies.xml stylesheets/project.xml

2005-10-30 Thread henning
Author: henning Date: Sun Oct 30 07:57:47 2005 New Revision: 329583 URL: http://svn.apache.org/viewcvs?rev=329583view=rev Log: Add some docs about Velocity dependencies Added: jakarta/velocity/core/trunk/xdocs/dependencies.xml (with props) Modified: jakarta/velocity/core/trunk/xdocs

svn commit: r329588 - /jakarta/velocity/core/trunk/WHY_TWO_JARS.txt

2005-10-30 Thread henning
Author: henning Date: Sun Oct 30 08:34:30 2005 New Revision: 329588 URL: http://svn.apache.org/viewcvs?rev=329588view=rev Log: update docs about the two jars. Modified: jakarta/velocity/core/trunk/WHY_TWO_JARS.txt Modified: jakarta/velocity/core/trunk/WHY_TWO_JARS.txt URL: http

svn commit: r329589 - in /jakarta/velocity/core/trunk/whiteboard/henning: ./ jdk14/ jdk14/EscapeReference.java jdk14/README

2005-10-30 Thread henning
Author: henning Date: Sun Oct 30 08:38:57 2005 New Revision: 329589 URL: http://svn.apache.org/viewcvs?rev=329589view=rev Log: Add some notes about JDK 1.4 Escape reference so that will not get lost (hmm, maybe I should put that into JIRA?) Added: jakarta/velocity/core/trunk/whiteboard

svn commit: r329600 - /jakarta/velocity/dvsl/trunk/src/java/org/apache/tools/dvsl/directive/MatchDirective.java

2005-10-30 Thread henning
Author: henning Date: Sun Oct 30 10:49:26 2005 New Revision: 329600 URL: http://svn.apache.org/viewcvs?rev=329600view=rev Log: Sigh. Make gump happy and compile dvsl with both old (1.3, 1.4) and new (1.5-dev) Velocity core. Modified: jakarta/velocity/dvsl/trunk/src/java/org/apache/tools

svn commit: r329617 - in /jakarta/velocity/core/trunk/xdocs: dependencies.xml jar-dependencies.xml stylesheets/project.xml

2005-10-30 Thread henning
Author: henning Date: Sun Oct 30 11:57:47 2005 New Revision: 329617 URL: http://svn.apache.org/viewcvs?rev=329617view=rev Log: dependencies was a dumb name, because it clashes with the autogenerated file from the maven site. Added: jakarta/velocity/core/trunk/xdocs/jar-dependencies.xml

svn commit: r329634 - in /jakarta/velocity/core/trunk: project.xml xdocs/images/jakarta.png

2005-10-30 Thread henning
Author: henning Date: Sun Oct 30 12:41:03 2005 New Revision: 329634 URL: http://svn.apache.org/viewcvs?rev=329634view=rev Log: add jakarta logo, update maven site logos Added: jakarta/velocity/core/trunk/xdocs/images/jakarta.png (with props) Modified: jakarta/velocity/core/trunk

  1   2   3   4   5   6   >