[jira] Commented: (VELTOOLS-68) VelocityViewServlet has hard coded ServletLogger

2006-11-04 Thread Henning Schmiedehausen (JIRA)
[ 
http://issues.apache.org/jira/browse/VELTOOLS-68?page=comments#action_12447135 
] 

Henning Schmiedehausen commented on VELTOOLS-68:


Ah yes, I forgot about backwards compatibility again. So your point with 
LogSystem is surely valid. 

About the priority: Well as the current is Avalon, Log4j, JDK, I'd probably say 
that making it configurable for the user and adding a default of ServletLogging 
(which should always be available in a servlet environment... :-) ) might be 
fine.



 VelocityViewServlet has hard coded ServletLogger
 

 Key: VELTOOLS-68
 URL: http://issues.apache.org/jira/browse/VELTOOLS-68
 Project: VelocityTools
  Issue Type: Bug
  Components: VelocityView
Affects Versions: 1.3
Reporter: Henning Schmiedehausen
Priority: Minor

 VelocityViewServlet configures the Velocity engine to use the ServletLogger 
 (~line 323). Integration of the servlet into applications that use other 
 logging systems (e.g. log4j / commons-logging) is very hard because of that.
 - VVS should honor the logging setttings in velocity.properties (e.g. for 
 explicit jdk logging)
 - It should add the ServletLogger to the log engine search path and only use 
 it if no other logger was found (log4j / avalon etc.)
 - The ServletLogger class implements the deprecated LogSystem. VelocityTools 
 should provide a LogChute implementation of the SrevletLogger.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Commented: (VELTOOLS-68) VelocityViewServlet has hard coded ServletLogger

2006-11-03 Thread Nathan Bubna (JIRA)
[ 
http://issues.apache.org/jira/browse/VELTOOLS-68?page=comments#action_12447009 
] 

Nathan Bubna commented on VELTOOLS-68:
--

Integration w/commons-logging used to be trivial until Tomcat decided to use 
c-l as a full logging provider instead of a wrapper. :(

Adding the ServletLogger to the search path sounds good, however, there is the 
question of where in the priority it should be.  i don't necessarily think it 
should be the last option.

i do have LogChute implementations for VelocityTools on the wiki 
(http://wiki.apache.org/jakarta-velocity/VelocityTools), but i've held off 
adding them to Veltools 1.3-dev because i want to be free to release 1.3 before 
Velocity 1.5 comes out.  If we get Vel 1.5 out before i roll Veltools 1.3, then 
i'll add the LogChutes in.

 VelocityViewServlet has hard coded ServletLogger
 

 Key: VELTOOLS-68
 URL: http://issues.apache.org/jira/browse/VELTOOLS-68
 Project: VelocityTools
  Issue Type: Bug
  Components: VelocityView
Affects Versions: 1.3
Reporter: Henning Schmiedehausen
Priority: Minor

 VelocityViewServlet configures the Velocity engine to use the ServletLogger 
 (~line 323). Integration of the servlet into applications that use other 
 logging systems (e.g. log4j / commons-logging) is very hard because of that.
 - VVS should honor the logging setttings in velocity.properties (e.g. for 
 explicit jdk logging)
 - It should add the ServletLogger to the log engine search path and only use 
 it if no other logger was found (log4j / avalon etc.)
 - The ServletLogger class implements the deprecated LogSystem. VelocityTools 
 should provide a LogChute implementation of the SrevletLogger.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]