[viff-devel] Broken build!

2009-10-09 Thread Martin Geisler
Hi everybody,

The build is broken:

  http://buildbot.viff.dk/waterfall

Janus, you added this code to benchmark.py:

  def update_args(runtime, options):
  args = {}
  if options.args != :
  for arg in options.args.split(','):
  id, value = arg.split('=')
  args[id] = long(value)
  runtime.setArgs(args)
  return runtime

What is that supposed to do? We don't have a setArgs method anywhere,
and we don't use the Java-like CamelCase coding style anyway. You're not
trying to parse the command line, right? (we have optparse for that)

-- 
Martin Geisler

VIFF (Virtual Ideal Functionality Framework) brings easy and efficient
SMPC (Secure Multiparty Computation) to Python. See: http://viff.dk/.
___
viff-devel mailing list (http://viff.dk/)
viff-devel@viff.dk
http://lists.viff.dk/listinfo.cgi/viff-devel-viff.dk


Re: [viff-devel] Broken build!

2009-10-09 Thread Janus Dam Nielsen

Hi everybody,


The build is broken:


That is unfortunate, thanks for notifying. I will fix it as soon as  
possible.



Janus, you added this code to benchmark.py:

 def update_args(runtime, options):
 args = {}
 if options.args != :
 for arg in options.args.split(','):
 id, value = arg.split('=')
 args[id] = long(value)
 runtime.setArgs(args)
 return runtime

Yes I did.


What is that supposed to do?
It is supposed to be a way for providing arguments for runtimes, which  
are unique for a given runtime.



We don't have a setArgs method anywhere,
If you use the --args commandline argument then it is your  
responsibility that the runtime you use has a proper setArgs method.



and we don't use the Java-like CamelCase coding style anyway.

Right, I will change that, as soon as possible.

You're not trying to parse the command line, right? (we have  
optparse for that)
I believe that the commandline arguments should be general to all  
runtimes.




Janus Dam Nielsen

Research and Innovationspecialist, PhD.
CENTRE FOR IT-SECURITY

THE ALEXANDRA INSTITUTE LTD.

T +45 42 22 93 56
E janus.niel...@alexandra.dk
W alexandra.dk


___
viff-devel mailing list (http://viff.dk/)
viff-devel@viff.dk
http://lists.viff.dk/listinfo.cgi/viff-devel-viff.dk