Hi,

2011/10/2 Robert Norris <rw_nor...@hotmail.com>:
>
>
>> if ( ! vw->open_dia )
>> {
>> + /* A toggle to decide if we have to open a new window or not */
>> + GtkWidget *toggle = gtk_check_button_new_with_label (_("Open file in a new 
>> window"));
>> + gtk_toggle_button_set_active (GTK_TOGGLE_BUTTON (toggle), TRUE);
>> + gtk_widget_show (toggle);
>> +
>
> It would be better if this could be defaulted to FALSE when one hasn't opened 
> anything yet.
>
> eg:
> gtk_toggle_button_set_active (GTK_TOGGLE_BUTTON (toggle), vw->filename != 
> NULL);
>
> Otherwise one starts viking (get a window), then go to open file - select a 
> file -> get *another* window, unless you remember to uncheck the toggle.

You're rigth: as this patch removed "Append" menu entry and so solved
the possible inconsistency, we can restore the feature removed by the
previous patch.


-- 
Guilhem BONNEFILLE
-=- JID: gu...@im.apinc.org MSN: guilhem_bonnefi...@hotmail.com
-=- mailto:guilhem.bonnefi...@gmail.com
-=- http://nathguil.free.fr/

------------------------------------------------------------------------------
All of the data generated in your IT infrastructure is seriously valuable.
Why? It contains a definitive record of application performance, security
threats, fraudulent activity, and more. Splunk takes this data and makes
sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-d2dcopy2
_______________________________________________
Viking-devel mailing list
Viking-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/viking-devel
Viking home page: http://viking.sf.net/

Reply via email to