Re: Patch 7.0.048

2006-08-16 Thread Alexey I. Froloff
* Alexey I. Froloff raorn@ [060816 12:23]: A patch for the documentation is missing, this is required to see what the intention of shellescape() is. OK, I'll update patch. Attached, fixed, documented, tested. In whatever order ;-) P.S. I don't have cproto and can't make proto... --

Re: Patch 7.0.048

2006-08-16 Thread Christ van Willegen
Alexey, + :call system(chmod +x -- . escapeshell(expand(%))) That should have been: + :call system(chmod +x -- . shellescape(expand(%))) Regards, Christ van Willegen

Re: Patch 7.0.048

2006-08-16 Thread Christ van Willegen
* Christ van Willegen cvwillegen@ [060816 13:33]: That should have been: + :call system(chmod +x -- . shellescape(expand(%))) Oops! Thanks. -- Regards, Sir Raorn. -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.5 (GNU/Linux)

Re: Patch 7.0.048

2006-08-16 Thread Bram Moolenaar
Alexey I. Froloff wrote: * A.J.Mechelynck antoine.mechelynck@ [060816 04:31]: IIRC, in Windows percent signs should be doubled (which requires the same kind of fancy-footwork as Vim's \ or ^V in the case of recursion), except in the names of environment %STRINGS% to be resolved by the

Re: Patch 7.0.048

2006-08-16 Thread Alexey I. Froloff
* Bram Moolenaar Bram@ [060816 15:57]: Are these characters allowed anyway? Well, it's not our problem. shellescape() is used to safely pass arbitrary string to shell command as one argument. It's not necessary to be a file name - it just needs to be expanded by shell to same string. P.S. Now

Re: Patch 7.0.048

2006-08-15 Thread Alexey I. Froloff
* Bram Moolenaar Bram@ [060808 22:52]: ! call system(a:cmd . ' . nmt . ') This patch is evil (:-E~~~). Better add shellescape() function to Vim and properly escape argument. Patch attached. I'm not sure if I handle WIN/UNIX defines properly, also I don't know how to shell-escape string on

Re: Patch 7.0.048

2006-08-15 Thread Bram Moolenaar
Alexey I. Froloff wrote: * Bram Moolenaar Bram@ [060808 22:52]: ! call system(a:cmd . ' . nmt . ') This patch is evil (:-E~~~). Better add shellescape() function to Vim and properly escape argument. Well, at least it's a lot better than what it was. I know it wasn't perfect. Patch

Re: Patch 7.0.048

2006-08-15 Thread A.J.Mechelynck
Bram Moolenaar wrote: Alexey I. Froloff wrote: * Bram Moolenaar Bram@ [060808 22:52]: ! call system(a:cmd . ' . nmt . ') This patch is evil (:-E~~~). Better add shellescape() function to Vim and properly escape argument. Well, at least it's a lot better than what it was. I know it

Re: Patch 7.0.048

2006-08-08 Thread James Vega
On Tue, Aug 08, 2006 at 08:48:31PM +0200, Bram Moolenaar wrote: --- 127,135 let nmt = s:tempname(nm) if rename(nm, nmt) == 0 if exists(b:gzip_comp_arg) ! call system(a:cmd . . b:gzip_comp_arg . ' . nmt . ') else ! call system(a:cmd . ' . nmt . ')

Re: Patch 7.0.048

2006-08-08 Thread Bram Moolenaar
James Vega wrote: On Tue, Aug 08, 2006 at 08:48:31PM +0200, Bram Moolenaar wrote: --- 127,135 let nmt =3D s:tempname(nm) if rename(nm, nmt) =3D=3D 0 if exists(b:gzip_comp_arg) ! call system(a:cmd . . b:gzip_comp_arg . ' . nmt . ') else !