[patch] remove unused save-cursor statement in matchparen plugin

2016-02-15 Fir de Conversatie Christian Brabandt
Bram, I assume, this line was added by accident. It is not used and I think it can be removed (also indentation is wrong). It might be, that I caused this from a previous patch, so let's just remove it for now. diff --git a/runtime/plugin/matchparen.vim b/runtime/plugin/matchparen.vim ---

python3 crash on mingw

2016-02-15 Fir de Conversatie mattn
Hi. in if_python3.c --- #ifdef PYTHON3_HOME # ifdef DYNAMIC_PYTHON3 if (mch_getenv((char_u *)"PYTHONHOME") == NULL) # endif Py_SetPythonHome(PYTHON3_HOME); #endif --- PYTHON3_HOME should be wchar_t*. diff --git

Re: Patch 7.4.1324

2016-02-15 Fir de Conversatie mattn
This is trival fixes. https://gist.github.com/mattn/baec9ece5749d2d90368 -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this

Re: want to update the runtime files

2016-02-15 Fir de Conversatie h_east
Hi Bram, 2016-2-16(Tue) 5:22:29 UTC+9 Bram Moolenaar: > Hirohito Higashi wrote: > > > Hi Bram and list, > > > > Thank you for growing our Vim. Great. > > > > BTW, I would want to update the runtime files. > > It a fourteen patches ahead that changed the built-in function name > > you have

Crash with channel

2016-02-15 Fir de Conversatie Yukihiro Nakadaira
Steps to reproduce: :" 1 :echo ch_open("noserver") :" 2 :let c = ch_open("noserver") :let d = c There is no NULL check for fail channel. And two typos in message. diff --git a/src/channel.c b/src/channel.c index d5d7ffb..003c933 100644 --- a/src/channel.c +++ b/src/channel.c @@

Re: [vim] Windows compilation broken after 7.4.1324 (#635)

2016-02-15 Fir de Conversatie Andrei Olsen
On Monday, February 15, 2016 at 11:24:47 PM UTC+1, Michael Giuffrida wrote: > When building on windows with 7.4.1327: > os_win32.c(5074) : error C2065: 'saAttr' : undeclared identifier > os_win32.c(5077) : error C2065: 'ifd' : undeclared identifier > os_win32.c(5079) : error C2065: 'ofd' :

Patch 7.4.1328

2016-02-15 Fir de Conversatie Bram Moolenaar
Patch 7.4.1328 Problem:Can't compile with +job but without +channel. (John Marriott) Solution: Add more #ifdefs. Files: src/os_unix.c *** ../vim-7.4.1327/src/os_unix.c 2016-02-14 23:02:29.838701624 +0100 --- src/os_unix.c 2016-02-15 23:07:47.652297287 +0100

Re: Patch 7.4.1318

2016-02-15 Fir de Conversatie Bram Moolenaar
John Marriott wrote: > On 15-Feb-2016 7:09 AM, Bram Moolenaar wrote: > > I wrote: > > > >> Patch 7.4.1318 > >> Problem:Channel with pipes doesn't work in GUI. > >> Solution: Register input handlers for pipes. > >> Files: src/structs.h, src/feature.h, src/channel.c, src/eval.c, > >>

Patch 7.4.1327

2016-02-15 Fir de Conversatie Bram Moolenaar
Patch 7.4.1327 Problem:Channel test doesn't work if Python executable is python.exe. Solution: Find py.exe or python.exe. (Ken Takata) Files: src/testdir/test_channel.vim *** ../vim-7.4.1326/src/testdir/test_channel.vim2016-02-15 21:56:42.725119689 +0100 ---

Re: Patch 7.4.1316

2016-02-15 Fir de Conversatie Bram Moolenaar
Ken Takata wrote: > Hi Bram and mattn, > > 2016/2/15 Mon 18:15:45 UTC+9 mattn wrote: > > test_channel.vim should work with following patch. But > > test_channel.vim have a problem that doesn't work with python > > provided on msys2/mingw64. The patch for this problem will be > > present from

Re: NETBEANS is not required when CHANNEL is defined

2016-02-15 Fir de Conversatie Bram Moolenaar
Tony Mechelynck wrote: > Since, with this new set of conditionals, netbeans is never built > without channel, why not leave winsock32 out of the netbeans block and > make it unconditional in the channel block? Wouldn't that be logically > equivalent but clearer? Good point. -- hundred-and-one

Patch 7.4.1326

2016-02-15 Fir de Conversatie Bram Moolenaar
Patch 7.4.1326 Problem:Build rules are bit too complicated. Solution: Remove -lwsock32 from Netbeans, it's already added for the channel feature that it depends on. (Tony Mechelynck) Files: src/Make_cyg_ming.mak *** ../vim-7.4.1325/src/Make_cyg_ming.mak 2016-02-15

Patch 7.4.1325

2016-02-15 Fir de Conversatie Bram Moolenaar
Patch 7.4.1325 Problem:Channel test fails on difference between Unix and DOS line endings. Solution: Strip off CR. Make assert show difference better. Files: src/eval.c, src/channel.c *** ../vim-7.4.1324/src/eval.c 2016-02-15 20:39:42.581803383 +0100 --- src/eval.c 2016-02-15

Patch 7.4.1324

2016-02-15 Fir de Conversatie Bram Moolenaar
Patch 7.4.1324 Problem:Channels with pipes don't work on MS-Windows. Solution: Add pipe I/O support. (Yasuhiro Matsumoto) Files: src/channel.c, src/os_win32.c, src/proto/channel.pro, src/structs.h, src/vim.h, src/testdir/test_channel.vim *** ../vim-7.4.1323/src/channel.c

Re: Patch 7.4.1316

2016-02-15 Fir de Conversatie Bram Moolenaar
Yasuhiro Matsumoto wrote: > Below is a patch to enable job_getchannel on Windows. > > https://gist.github.com/mattn/7669319349f19a1773b6 > > test_channel.vim should work with following patch. But > test_channel.vim have a problem that doesn't work with python provided > on msys2/mingw64. The

Re: Patch 7.4.1322

2016-02-15 Fir de Conversatie Christian J. Robinson
On Mon, 15 Feb 2016, Bram Moolenaar wrote: Christian J. Robinson wrote: On Mon, 15 Feb 2016, Bram Moolenaar wrote: Patch 7.4.1322 Problem:Crash when unletting the variable that holds the channel in a callback function. (Christian Robinson) Solution: Increase the reference

Re: want to update the runtime files

2016-02-15 Fir de Conversatie Bram Moolenaar
Hirohito Higashi wrote: > Hi Bram and list, > > Thank you for growing our Vim. Great. > > BTW, I would want to update the runtime files. > It a fourteen patches ahead that changed the built-in function name > you have released. Yes, will do it soon. -- hundred-and-one symptoms of being an

Re: Patch 7.4.1322

2016-02-15 Fir de Conversatie Bram Moolenaar
Christian J. Robinson wrote: > On Mon, 15 Feb 2016, Bram Moolenaar wrote: > > > Patch 7.4.1322 > > Problem:Crash when unletting the variable that holds the channel in a > >callback function. (Christian Robinson) > > Solution: Increase the reference count while invoking the

Patch 7.4.1322

2016-02-15 Fir de Conversatie Bram Moolenaar
Patch 7.4.1322 Problem:Crash when unletting the variable that holds the channel in a callback function. (Christian Robinson) Solution: Increase the reference count while invoking the callback. Files: src/eval.c, src/channel.c, src/proto/eval.pro,

Re: Crash: unlet on channel descriptor variable within callback

2016-02-15 Fir de Conversatie Bram Moolenaar
Christian J. Robinson wrote: > I don't know if this is related to the crash bug I reported a while > ago because ch_open() didn't return its own variable type at that > time. Nevertheless, it was difficult to find the specific sequence > that would reliably cause a crash without extraneous

Re: Patch 7.4.1318

2016-02-15 Fir de Conversatie John Marriott
On 15-Feb-2016 7:09 AM, Bram Moolenaar wrote: I wrote: Patch 7.4.1318 Problem:Channel with pipes doesn't work in GUI. Solution: Register input handlers for pipes. Files: src/structs.h, src/feature.h, src/channel.c, src/eval.c, src/os_unix.c, src/os_win32.c,

Re: [bug] Compiling vim.exe fails

2016-02-15 Fir de Conversatie Mike Williams
On 15/02/2016 12:09, Bram Moolenaar wrote: Mike Williams wrote: Come on guys, if you're fixing code dependent on pp defines, check with them both defined and undefined that everything still builds and links. It appears Appveyor only builds one specific setup. It would be useful to run a few

Re: [bug] Compiling vim.exe fails

2016-02-15 Fir de Conversatie Bram Moolenaar
Christian Brabandt wrote: > On Mo, 15 Feb 2016, Bram Moolenaar wrote: > > > > Mike Williams wrote: > > > > > On 15/02/2016 08:10, Axel Bender wrote: > > > > Compiling vim.exe (Windows 7 64-bit, MinGW 64-bit) fails with: > > > > > > > > gcc -c -Iproto -DWIN32 -DWINVER=0x0500

Re: Patch 7.4.1316

2016-02-15 Fir de Conversatie Ken Takata
Hi Bram and mattn, 2016/2/15 Mon 18:15:45 UTC+9 mattn wrote: > test_channel.vim should work with following patch. But test_channel.vim have > a problem that doesn't work with python provided on msys2/mingw64. The patch > for this problem will be present from Ken Takata in later. I have

Re: [bug] Compiling vim.exe fails

2016-02-15 Fir de Conversatie Christian Brabandt
Hi Bram! On Mo, 15 Feb 2016, Bram Moolenaar wrote: > > Mike Williams wrote: > > > On 15/02/2016 08:10, Axel Bender wrote: > > > Compiling vim.exe (Windows 7 64-bit, MinGW 64-bit) fails with: > > > > > > gcc -c -Iproto -DWIN32 -DWINVER=0x0500 -D_WIN32_WINNT=0x0500 > > > -DHAVE_PATHDEF

Re: Patch 7.4.870

2016-02-15 Fir de Conversatie Shohei Uzuki
Aha, I see. I was confused a little bit. Thanks, Hirohito and Bram. 2016年2月15日(月) 21:09 Bram Moolenaar : > > Hirohito Higashi wrote: > > > 2016-2-15(Mon) 13:25:58 UTC+9 watiko: > > > Hi, Bram. > > > > > > There is a related issue: > > > > No. > > Reported issue also occurred

Re: Patch 7.4.1316

2016-02-15 Fir de Conversatie mattn
updated. please take a look. -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google

Re: [bug] Compiling vim.exe fails

2016-02-15 Fir de Conversatie Bram Moolenaar
Mike Williams wrote: > On 15/02/2016 08:10, Axel Bender wrote: > > Compiling vim.exe (Windows 7 64-bit, MinGW 64-bit) fails with: > > > > gcc -c -Iproto -DWIN32 -DWINVER=0x0500 -D_WIN32_WINNT=0x0500 -DHAVE_PATHDEF > > -DFEAT_BIG -DMS_WIN64 -DHAVE_GETTEXT -DHAVE_LOCALE_H -DDYNAMIC_GETTEXT > >

Re: Patch 7.4.870

2016-02-15 Fir de Conversatie Bram Moolenaar
Hirohito Higashi wrote: > 2016-2-15(Mon) 13:25:58 UTC+9 watiko: > > Hi, Bram. > > > > There is a related issue: > > No. > Reported issue also occurred in Vim 7.4.869. > This patch doesn't matter. > > > > > ```sh > > vim -u NONE -i NONE -c 'nnoremap x getchar()' > > ``` > > > > Then type

Re: Patch 7.4.1316

2016-02-15 Fir de Conversatie mattn
Sorry noisy. I found a problem that vim become hang with ch_readraw(). https://msdn.microsoft.com/en-us/library/aa365141(VS.85).aspx I'll update my patch to use PeekNamedPipe(). -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you

Patch 7.4.1321

2016-02-15 Fir de Conversatie Bram Moolenaar
Patch 7.4.1321 Problem:Compiler complains about missing statement. Solution: Add an empty statement. (Andrei Olsen) Files: src/os_win32.c *** ../vim-7.4.1320/src/os_win32.c 2016-02-14 23:02:29.838701624 +0100 --- src/os_win32.c 2016-02-15 12:41:49.275472328 +0100

Re: NETBEANS is not required when CHANNEL is defined

2016-02-15 Fir de Conversatie Tony Mechelynck
Since, with this new set of conditionals, netbeans is never built without channel, why not leave winsock32 out of the netbeans block and make it unconditional in the channel block? Wouldn't that be logically equivalent but clearer? Best regards, Tony. On Sun, Feb 14, 2016 at 11:11 PM, Bram

Re: [Patch] GTK3 GUI

2016-02-15 Fir de Conversatie Kazunobu Kuriyama
2016-02-15 18:28 GMT+09:00 SungHyun Nam : > Hello, > > First of all, many thanks for your effort. > I followed your every patch. > Thank you. That really encourages me. > > And I used 'gtk3-v7.4.1317' this whole day with NO PROBLEM. > To me, it seems gtk3-v7.4.1317 is same

Re: Patch 7.4.1316

2016-02-15 Fir de Conversatie mattn
On Monday, February 15, 2016 at 6:42:22 PM UTC+9, mattn wrote: > Seems to be many compilation warnings. Will fix in later. Updated -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit

Re: Diff to silence noise from VS tools

2016-02-15 Fir de Conversatie Mike Williams
On 10/02/2016 22:16, Bram Moolenaar wrote: Kenny Wong wrote: After applying patch 7.4.1240, I cannot build using Visual Studio 2005 because its rc.exe version does not support the /nologo option, e.g. C:\>"C:\Program Files (x86)\Microsoft Visual Studio 8\VC\bin\rc.exe" /nologo fatal error

Re: Patch 7.4.1316

2016-02-15 Fir de Conversatie mattn
Seems to be many compilation warnings. Will fix in later. -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are

Re: [Patch] GTK3 GUI

2016-02-15 Fir de Conversatie SungHyun Nam
Hello, First of all, many thanks for your effort. I followed your every patch. And I used 'gtk3-v7.4.1317' this whole day with NO PROBLEM. To me, it seems gtk3-v7.4.1317 is same as gtk2 version (or maybe even better (*1*)). Now, I tested gtk3-v7.4.1320. It seems it almost work fine. Maybe one

Re: [bug] Compiling vim.exe fails

2016-02-15 Fir de Conversatie Mike Williams
On 15/02/2016 08:10, Axel Bender wrote: Compiling vim.exe (Windows 7 64-bit, MinGW 64-bit) fails with: gcc -c -Iproto -DWIN32 -DWINVER=0x0500 -D_WIN32_WINNT=0x0500 -DHAVE_PATHDEF -DFEAT_BIG -DMS_WIN64 -DHAVE_GETTEXT -DHAVE_LOCALE_H -DDYNAMIC_GETTEXT -DFEAT_OLE -DFEAT_CSCOPE -DFEAT_MBYTE -DFEA

[bug] Compiling vim.exe fails

2016-02-15 Fir de Conversatie Axel Bender
Compiling vim.exe (Windows 7 64-bit, MinGW 64-bit) fails with: gcc -c -Iproto -DWIN32 -DWINVER=0x0500 -D_WIN32_WINNT=0x0500 -DHAVE_PATHDEF -DFEAT_BIG -DMS_WIN64 -DHAVE_GETTEXT -DHAVE_LOCALE_H -DDYNAMIC_GETTEXT -DFEAT_OLE -DFEAT_CSCOPE -DFEAT_MBYTE -DFEA T_MBYTE_IME -DDYNAMIC_IME -DDYNAMIC_ICONV

[bug] Binding fails when setting the Perl path in make_ming.mak

2016-02-15 Fir de Conversatie Axel Bender
Binding gvim.exe (Windows 7 64-bit, MinGW 64-bit) fails when setting the Perl path in make_ming.mak instead fo make_cyg_ming.mak. -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit

Re: [Patch] GTK3 GUI

2016-02-15 Fir de Conversatie Kazunobu Kuriyama
Thank you for the comment. To me, the cursor draw issue is another side of the redraw issue; one issue is tried to be fixed, another manifests then :) To fix those two issues simultaneously and make the code portable, I wrote another patch in such a way that no assumption was made on what had