[patch] Allow environment var completion with "unlet"

2018-05-30 Fir de Conversatie Jason Franklin
Patch 8.0.1832 made ":unlet" work on environment variables. No change was made to allow completion to work like with: :unlet $ This patch makes completion work as expected. A test is included to ensure that ":unlet" completion works properly. -- Jason Franklin -- -

Re: [patch] Fix bug with "CTRL-W " quickfix window command

2018-05-30 Fir de Conversatie Jason Franklin
subscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. >From 8ddb5e6b03fe59c9e9d819ee0856e9d91e881e3a Mon Sep 17 00:00:00 2001 From: Jason Franklin Date: Wed, 30 May 2018 08:

Re: [patch] Fix bug with "CTRL-W " quickfix window command

2018-05-29 Fir de Conversatie Jason Franklin
Yegappan, Attached is the updated patch. To confirm, I... * merged qf_view_result() and qf_view_result_split() * used vim_snprintf(); I believe I used it properly * I used the X... functions to merge the test code Let me know what you think! -- Jason Franklin -- -- You received this

Re: [patch] Fix bug with "CTRL-W " quickfix window command

2018-05-29 Fir de Conversatie Jason Franklin
Hey Yegappan, I can certainly make these changes. It shouldn't be too difficult... I'm still learning best practices in the context of the Vim project. Just a moment. -- Jason -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are

Re: [patch] Fix bug with "CTRL-W " quickfix window command

2018-05-29 Fir de Conversatie Jason Franklin
Note that more can be done to fix up this command, but I didn't want to do too much in one patch. -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- Y

[patch] Fix bug with "CTRL-W " quickfix window command

2018-05-29 Fir de Conversatie Jason Franklin
to vim_dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. >From 1591f6a25c962ed58adad2211304a53da7170dbe Mon Sep 17 00:00:00 2001 From: Jason Franklin Date: Tue, 29 May 2018 10:40:45 -0400 Subject: [PATCH] Fix bug with "CTRL-W " quickfix window comm

Re: PuTTy connection to RHEL 6.9 mouse not usable on Vim 8.1.0022 startup

2018-05-24 Fir de Conversatie Jason Franklin
Another note: git bisect shows that the problem started somewhere around 8.0.1309, but I can't be sure becuase I can't build vim on this system for several commits in that range (the build errors out). -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply

PuTTy connection to RHEL 6.9 mouse not usable on Vim 8.1.0022 startup

2018-05-24 Fir de Conversatie Jason Franklin
8.1 (2018 May 17, compiled May 24 2018 09:52:50) Included patches: 1-22 Compiled by Jason Franklin Huge version without GUI. Features included (+) or not (-): +acl +cmdline_compl -ebcdic-hangul_input -lua +mouse_xterm -python

Re: Question: Any reason why ":file" is disallowed in the cmdline window?

2018-05-23 Fir de Conversatie Jason Franklin
Good tips. Thank you! I indeed use older versions of Vim without `getwininfo()` on disparate machines. So, keeping this function is necessary at the moment. -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For mo

Re: Question: Any reason why ":file" is disallowed in the cmdline window?

2018-05-23 Fir de Conversatie Jason Franklin
The first instance makes sense. After all, no one would want to change the file name in the command line window. The second instance means that I can't run :file in the ftplugin for the "qf" file type. I was previously doing this in my own "ftplugin/qf.vim" script to get the type of list I was

Re: Question: Any reason why ":file" is disallowed in the cmdline window?

2018-05-23 Fir de Conversatie Jason Franklin
To replicate with the cmdline window: vim -u NONE q: :file To replicate with the quickfix window: vim -u NONE :autocmd FileType qf file :copen In both of these cases, ":file" fails. This is more what I was talking about. -- -- You received this message from the "vim_dev" mailli

Re: Question: Any reason why ":file" is disallowed in the cmdline window?

2018-05-23 Fir de Conversatie Jason Franklin
Just a follow up on what I've learned here. I don't think that the ":file" command makes much sense in the cmdline window. However, I don't think it should be disallowed when curbuf_lock is set. Since these restrictions go together, not much can be done. Still, this is more of a decision about w

Re: Question: Any reason why ":file" is disallowed in the cmdline window?

2018-05-23 Fir de Conversatie Jason Franklin
Just a follow up on what I've learned here. I don't think that the ":file" command makes much sense in the cmdline window. However, I don't think it should be disallowed when curbuf_lock is set. Since these restrictions go together, not much can be done. Still, this is more of a decision abou

Re: [PATCH] Add code and tests to fix the sentence text object

2018-05-23 Fir de Conversatie Jason Franklin
Hey Bram, and anyone else interested. Just a friendly ping concerning this issue. Like Andy, I feel pretty strongly that this patch is worth merging. I noted in my original post that the code for sentence text objects could use a more general refactoring later down the line. However, I think th

Question: Any reason why ":file" is disallowed in the cmdline window?

2018-05-21 Fir de Conversatie Jason Franklin
In the command index table, the ":file" command doesn't have the CMDWIN flag. This means it can't be called in the cmdline window. Should this be the case? I know that ":file" has variations that let you change the name of the current buffer, but it doesn't switch buffers that I can tell. One of

Re: [PATCH] Add code and tests to fix the sentence text object

2018-05-21 Fir de Conversatie Jason Franklin
This conversation is fun, btw. :) -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google

Re: [PATCH] Add code and tests to fix the sentence text object

2018-05-21 Fir de Conversatie Jason Franklin
Thanks for the support, Andy. Just a thought: I don't know that checking for a capital letter would work. Proper nouns will always get in the way. -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more informa

Re: [PATCH] Add code and tests to fix the sentence text object

2018-05-21 Fir de Conversatie Jason Franklin
Well, British style is more specific than American style. The rule under British style is that punctuation should go inside the quotes if it "belongs" to the quoted text (e.g., with our technical writing). The only exception, unfortunately, is the one we're talking about! Closing punctuation ('.

Re: [PATCH] Add code and tests to fix the sentence text object

2018-05-21 Fir de Conversatie Jason Franklin
Well, according to the most widely accepted conventions in English grammar, quotes always come after the period, exclamation point, or question mark. So, the following: This is a "sentence." This is a sentence. would be considered two correct and completely separate sentences. The documentat

Re: [PATCH] Add code and tests to fix the sentence text object

2018-05-21 Fir de Conversatie Jason Franklin
I looked at this patch again today, and I realized I used "normal" in some of the tests instead of "normal!" with the '!' modifier. The latter is probably preferred. Just wanted to make a note of that. -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your re

Re: Bug report: 'scrollbind' breaks when using mouse in xterm window

2018-05-20 Fir de Conversatie Jason Franklin
Thanks Marius! > Both places should probably be updated to also mention the mouse wheel. I see now that my initial idea was mistaken. However, I noted in an email directly to Bram that gvim on Microsoft Windows does not obey this behavior. That is, both windows are scrolled regardless of which w

Bug report: 'scrollbind' breaks when using mouse in xterm window

2018-05-19 Fir de Conversatie Jason Franklin
Reproduce as follows (I used Gnome Terminal): vim -u NONE :set mouse=a :e [name of long file] :vsp :windo set scrollbind Now, use the mouse wheel to try and scroll in both windows. The window with cursor focus will scroll both windows properly, but not the other window, thus breaking the 'scroll

[PATCH] Add code and tests to fix the sentence text object

2018-05-19 Fir de Conversatie Jason Franklin
--- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. >From

Bugfix: Patch to prevent ":stopinsert" from disturbing message output

2018-05-18 Fir de Conversatie Jason Franklin
subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. >From a4c10e42d533785c85382497f4ce757b36ee573f Mon Se

Re: Advice for debugging Vim

2018-05-16 Fir de Conversatie Jason Franklin
Thanks, guys! This is really great stuff. The tips I gathered are here: 1. Use "VIMRUNTIME=../runtime .vim" to run the fresh Vim binary. 2. I can run "./configure" directly to override default build options (allows me to NOT change the makefile). 3. The "Makefile" can also be edited directly to

Advice for debugging Vim

2018-05-15 Fir de Conversatie Jason Franklin
Does anyone have any advice for running Vim with a debugger? 1. What debugger is preferred? GDB or something else? Specific commands to run would be useful here. 2. How do I build Vim with debugging information in the binary? 3. How can I go about debugging Vim on Windows? Thanks, Jason

Re: Patch to have ":close" attempt to respect 'wfw' and 'wfh' settings (bug fix)

2018-05-04 Fir de Conversatie Jason Franklin
27; settings. I didn't want to include this because I didn't want to be redundant. The patch will fix either case! I'm one of the maintainers of the NERDTree, and this was originally discovered by one of our users: https://github.com/scrooloose/nerdtree/issues/644 He'

Patch to have ":close" attempt to respect 'wfw' and 'wfh' settings (bug fix)

2018-05-04 Fir de Conversatie Jason Franklin
receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. example.vim Description: Binary data >From 9002f09dc8f89ba67d8b45e8ec3c5cb7b78dcecb Mon Sep 17 00:00:00 2001 From: Jason Franklin Date: Fri, 4 May 20

Re: Questions about new-style Vim tests

2018-05-03 Fir de Conversatie Jason Franklin
> > The test can start a new Vim instance and run the test. > Could you give me an example of this syntax? It looks like it won't be necessary for my case given your first answer. However, I would like to see an example of this type of test. Thanks! -- -- You received this message from t

Questions about new-style Vim tests

2018-05-03 Fir de Conversatie Jason Franklin
I'm writing two new tests for a patch that fixes a bug with the ":close" command. There is already a file for testing the various commands that close a buffer/window (see "src/testdir/test_winbuf_close.vim"). My questions are: Should new tests always be placed in their own file to isolate thei

Re: [vim/vim] Fix win_remove() so that it does not break f_gettabvar() (#2170)

2017-09-29 Fir de Conversatie Jason Franklin
Sorry, I didn't realize you had already taken care of that. Thanks, Bram! -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message

Re: [vim/vim] Fix win_remove() so that it does not break f_gettabvar() (#2170)

2017-09-29 Fir de Conversatie Jason Franklin
I appreciate it Bram! > Thanks for the verbose explanation. I hope not too verbose. :/ I was just being thorough since the bug left me quite confused at first! > Another way to fix it is to use "firstwin" in f_gettabvar() when "tp" is > "curtab". curtab->tp_firstwin is not guaranteed to be val

Re: [patch] allow setting of w:quickfix_title via setqflist()/setloclist() functions

2017-07-17 Fir de Conversatie Jason Franklin
tions Georgia Southern University P.O. Box 8088 Statesboro, GA 30460 912.478.5639 On Mon, Jul 17, 2017 at 1:19 PM, Christian Brabandt wrote: > > On Mo, 17 Jul 2017, Jason Franklin wrote: > > On Monday, July 17, 2017 at 12:29:44 PM UTC-4, yega...@gmail.com > > wrote: > >

Re: [patch] allow setting of w:quickfix_title via setqflist()/setloclist() functions

2017-07-17 Fir de Conversatie Jason Franklin
On Monday, July 17, 2017 at 12:29:44 PM UTC-4, yega...@gmail.com wrote: > Hi, > > On Mon, Jul 17, 2017 at 8:20 AM, Jason Franklin > wrote: > > On Monday, July 17, 2017 at 10:52:17 AM UTC-4, yega...@gmail.com wrote: > >> Hi, > >> > >> On Mon, Jul 17

Re: [patch] allow setting of w:quickfix_title via setqflist()/setloclist() functions

2017-07-17 Fir de Conversatie Jason Franklin
On Monday, July 17, 2017 at 10:52:17 AM UTC-4, yega...@gmail.com wrote: > Hi, > > On Mon, Jul 17, 2017 at 6:04 AM, Jason Franklin > wrote: > > On Sunday, May 10, 2015 at 4:16:29 AM UTC-4, Bram Moolenaar wrote: > >> Daniel Hahler wrote: > >> > >> >

Re: [patch] allow setting of w:quickfix_title via setqflist()/setloclist() functions

2017-07-17 Fir de Conversatie Jason Franklin
On Sunday, May 10, 2015 at 4:16:29 AM UTC-4, Bram Moolenaar wrote: > Daniel Hahler wrote: > > > @Bram, > > > > what do you think about the patch? > > > > I have not checked if it still applies (I have it in my local branch), but > > came across it being missing a few times recently. > > > > It

<    1   2