Re: [Patch] Re: 'backupcopy' and Windows Vista symbolic links

2012-09-24 Fir de Conversatie Ken Takata
Hi, 2012/08/25 Sat 12:41:45 UTC+9 Ken Takata: Then I found your post and tried David's patch. It seems that the patch works well but I found a little problem. This is an updated patch. https://gist.github.com/3436380 The differences from David's patch are: 1. Fix memory leakage in

Re: [Patch] Re: 'backupcopy' and Windows Vista symbolic links

2012-08-22 Fir de Conversatie Ian Halliday
What ever happened to this patch? I just ran into this problem for a second time in the last year, having forgotten how to fix it since last time, had to look everything up again. A fix in the main branch would be great to have. Ian -- You received this message from the vim_dev maillist. Do

Re: [Patch] Re: 'backupcopy' and Windows Vista symbolic links

2012-03-29 Fir de Conversatie Ben Fritz
On Thursday, March 29, 2012 12:52:49 AM UTC-5, David Pope wrote: Thanks, any help is appreciated.  I have updated the patch with some further fixes (it broke a common pattern for calling mch_getperms to check for file existence).  The latest patch is available in my fork at github:

Re: [Patch] Re: 'backupcopy' and Windows Vista symbolic links

2012-03-29 Fir de Conversatie David Pope
On Thu, Mar 29, 2012 at 10:30 AM, Ben Fritz fritzophre...@gmail.com wrote: That's not github, by the way :-) oops :) It can be nice to pull from a real repository, but some people (me included) would prefer to put experimental patches into a patch queue with mq. I like this option better

Re: [Patch] Re: 'backupcopy' and Windows Vista symbolic links

2012-03-28 Fir de Conversatie David Pope
On Mon, Mar 26, 2012 at 11:00 AM, Benjamin Fritz fritzophre...@gmail.comwrote: I'd like to test, but currently the only computers I use are stuck on Windows XP and I'm not able to. The machine I was using at the time I originally encountered the issue was a dual-boot Windows Vista/Ubuntu

Re: [Patch] Re: 'backupcopy' and Windows Vista symbolic links

2012-03-26 Fir de Conversatie Benjamin Fritz
On Fri, Mar 23, 2012 at 11:35 PM, David Pope d.e.p...@gmail.com wrote: Is there any feedback on this patch, or on the way the fix was presented?  As I said earlier, I'm new to vim development so I'm all ears.  :)  Is there someone I need to direct this patch toward, e.g. someone who deals

Re: [Patch] Re: 'backupcopy' and Windows Vista symbolic links

2012-03-23 Fir de Conversatie David Pope
Hello Bram, Benjamin, and all, On Wed, Mar 21, 2012 at 2:27 AM, David Pope d.e.p...@gmail.com wrote: A patch definitely helps. And a way to reproduce the problem. Reproduction is easy. 1. Create a symbolic link on Windows. (e.g. mklink link_path target_path) 2. open the file in Vim 3.

[Patch] Re: 'backupcopy' and Windows Vista symbolic links

2012-03-21 Fir de Conversatie David Pope
On Thu, Mar 15, 2012 at 5:02 PM, Benjamin Fritz fritzophre...@gmail.comwrote: On Thu, Mar 15, 2012 at 2:28 PM, Bram Moolenaar b...@moolenaar.net wrote: David Pope wrote: On Wednesday, July 20, 2011 3:54:09 PM UTC-4, Craig Barkhouse wrote: The mch_is_linked() function in os_win32.c