Re: Question about :find completion support in Vim 7.3b

2010-08-08 Fir de Conversatie Bram Moolenaar
James Vega wrote: > On Thu, Aug 05, 2010 at 09:56:29PM +0200, Bram Moolenaar wrote: > > Nazri Ramliy wrote: > > > test73.in should now run successfully on both unix and windows. > > > > Thank you very much for fixing the problems and enhancing the test. > > > > I'll include this and check that

Re: Question about :find completion support in Vim 7.3b

2010-08-07 Fir de Conversatie James Vega
On Thu, Aug 05, 2010 at 09:56:29PM +0200, Bram Moolenaar wrote: > Nazri Ramliy wrote: > > test73.in should now run successfully on both unix and windows. > > Thank you very much for fixing the problems and enhancing the test. > > I'll include this and check that it works for me. > The Xfind direc

Re: Question about :find completion support in Vim 7.3b

2010-08-06 Fir de Conversatie Nazri Ramliy
On Thu, Aug 5, 2010 at 12:25 AM, Ajit Thakkar wrote: > Nazri, for the future, you may want to try and add path completion for :cd > > Ajit Here's a toy patch if you would like to try it out. Thanks for the suggestion. I've never used 'cdpath' before. The implementation reuses the same mechanism

Re: Question about :find completion support in Vim 7.3b

2010-08-05 Fir de Conversatie Bram Moolenaar
Nazri Ramliy wrote: > On Thu, Aug 5, 2010 at 4:11 AM, Bram Moolenaar wrote: > >> > I noticed another problem: with 'path' set to "./**" and in an empty > >> > buffer :find completion crashes. =A0I fixed it. > >> > >> Thanks. I'll add this check to the test script. > > I've updated the test to

Re: Question about :find completion support in Vim 7.3b

2010-08-05 Fir de Conversatie Nazri Ramliy
On Thu, Aug 5, 2010 at 4:11 AM, Bram Moolenaar wrote: >> > I noticed another problem: with 'path' set to "./**" and in an empty >> > buffer :find completion crashes. =A0I fixed it. >> >> Thanks. I'll add this check to the test script. I've updated the test to check for this and a few more condit

Re: Question about :find completion support in Vim 7.3b

2010-08-04 Fir de Conversatie Bram Moolenaar
Nazri Ramliy wrote: > On Wed, Aug 4, 2010 at 7:20 PM, Bram Moolenaar wrote: > > If the arguments are the same the returned values should be the same. > > You will need to use a debugger to find out what really happens. > > I did. The problem is due to the static nature of "recursive" in > gen_

Re: Question about :find completion support in Vim 7.3b

2010-08-04 Fir de Conversatie Ajit Thakkar
On Wed, Aug 4, 2010 at 12:46 PM, Bram Moolenaar wrote: > > Nazri Ramliy wrote: > >> On Wed, Aug 4, 2010 at 7:20 PM, Bram Moolenaar wrote: >> > If the arguments are the same the returned values should be the same. >> > You will need to use a debugger to find out what really happens. >> >> I did.  

Re: Question about :find completion support in Vim 7.3b

2010-08-04 Fir de Conversatie Bram Moolenaar
Nazri Ramliy wrote: > On Wed, Aug 4, 2010 at 7:20 PM, Bram Moolenaar wrote: > > If the arguments are the same the returned values should be the same. > > You will need to use a debugger to find out what really happens. > > I did. The problem is due to the static nature of "recursive" in > gen_

Re: Question about :find completion support in Vim 7.3b

2010-08-04 Fir de Conversatie Nazri Ramliy
On Wed, Aug 4, 2010 at 7:20 PM, Bram Moolenaar wrote: > If the arguments are the same the returned values should be the same. > You will need to use a debugger to find out what really happens. I did. The problem is due to the static nature of "recursive" in gen_expand_wildcards(). Please see my

Re: Question about :find completion support in Vim 7.3b

2010-08-04 Fir de Conversatie Bram Moolenaar
Nazri Ramliy wrote: > On Wed, Aug 4, 2010 at 4:39 AM, Bram Moolenaar wrote: > >> Attached is the fix on top of Revision: 7d1044b27e. > > > > Thanks and sorry, I suppose I caused this problem. > > That is minuscule compared to all the problems that I have caused with > all this find-completion

Re: Question about :find completion support in Vim 7.3b

2010-08-04 Fir de Conversatie Nazri Ramliy
On Wed, Aug 4, 2010 at 4:47 PM, Nazri Ramliy wrote: > On Wed, Aug 4, 2010 at 1:16 PM, Nazri Ramliy wrote: >> which call expand_in_path(), which in turns call globpath(), fails with >> the exact same argument "c:/src/vim/**", "misc*" and 0 for path, file and >> expand_options, respectively. >> >>

Re: Question about :find completion support in Vim 7.3b

2010-08-04 Fir de Conversatie Nazri Ramliy
On Wed, Aug 4, 2010 at 1:16 PM, Nazri Ramliy wrote: > which call expand_in_path(), which in turns call globpath(), fails with > the exact same argument "c:/src/vim/**", "misc*" and 0 for path, file and > expand_options, respectively. > > Help! I think I found the solution. "recursive" should be r

Re: Question about :find completion support in Vim 7.3b

2010-08-03 Fir de Conversatie Nazri Ramliy
On Wed, Aug 4, 2010 at 4:39 AM, Bram Moolenaar wrote: >> Attached is the fix on top of Revision: 7d1044b27e. > > Thanks and sorry, I suppose I caused this problem. That is minuscule compared to all the problems that I have caused with all this find-completion stuff :) Prove (this will show that

Re: Question about :find completion support in Vim 7.3b

2010-08-03 Fir de Conversatie Bram Moolenaar
Nazri Ramliy wrote: > On Tue, Aug 3, 2010 at 8:07 AM, Nazri Ramliy wrote: > > On Tue, Aug 3, 2010 at 7:51 AM, Ajit Thakkar wrote: > >> Revision: 7d1044b27e > >> > >> On WinXP, attempting find completion leads to a crash. > >> > >> gvim -N -u NONE a.tex > >> :find > >> Vim crashes > >> > >> Th

Re: Question about :find completion support in Vim 7.3b

2010-08-03 Fir de Conversatie Thomas Liebezeit
Am 03.08.2010 02:33, schrieb Nazri Ramliy: On Tue, Aug 3, 2010 at 8:07 AM, Nazri Ramliy wrote: On Tue, Aug 3, 2010 at 7:51 AM, Ajit Thakkar wrote: Revision: 7d1044b27e On WinXP, attempting find completion leads to a crash. gvim -N -u NONE a.tex :find Vim crashes The same happens with :fin

Re: Question about :find completion support in Vim 7.3b

2010-08-02 Fir de Conversatie Nazri Ramliy
On Tue, Aug 3, 2010 at 8:07 AM, Nazri Ramliy wrote: > On Tue, Aug 3, 2010 at 7:51 AM, Ajit Thakkar wrote: >> Revision:  7d1044b27e >> >> On WinXP, attempting find completion leads to a crash. >> >> gvim -N -u NONE a.tex >> :find >> Vim crashes >> >> The same happens with >> :find a >> >> Ajit >

Re: Question about :find completion support in Vim 7.3b

2010-08-02 Fir de Conversatie Nazri Ramliy
On Tue, Aug 3, 2010 at 7:51 AM, Ajit Thakkar wrote: > Revision:  7d1044b27e > > On WinXP, attempting find completion leads to a crash. > > gvim -N -u NONE a.tex > :find > Vim crashes > > The same happens with > :find a > > Ajit Thanks for testing it. I'll investigate the crash. nazri. -- You

Re: Question about :find completion support in Vim 7.3b

2010-08-02 Fir de Conversatie Ajit Thakkar
On Mon, Aug 2, 2010 at 5:10 PM, Bram Moolenaar wrote: > > Nazri Ramliy wrote: > >> >> On Mon, Aug 2, 2010 at 8:49 AM, Nazri Ramliy wrote: >> > On Thu, Jul 29, 2010 at 4:39 AM, Bram Moolenaar wrote: >> >> I have included the recent patches, but not the one that resets >> >> "recursive" in gen_exp

Re: Question about :find completion support in Vim 7.3b

2010-08-02 Fir de Conversatie Bram Moolenaar
Nazri Ramliy wrote: > > On Mon, Aug 2, 2010 at 8:49 AM, Nazri Ramliy wrote: > > On Thu, Jul 29, 2010 at 4:39 AM, Bram Moolenaar wrote: > >> I have included the recent patches, but not the one that resets > >> "recursive" in gen_expand_wildcards(). That is probably causing that > >> crash. > >

Re: Question about :find completion support in Vim 7.3b

2010-08-02 Fir de Conversatie Bram Moolenaar
Nazri Ramliy wrote: > On Thu, Jul 29, 2010 at 4:39 AM, Bram Moolenaar wrote: > > I have included the recent patches, but not the one that resets > > "recursive" in gen_expand_wildcards(). That is probably causing that > > crash. > > I noticed that mch_expandpath() is defined on both unix and w

Re: Question about :find completion support in Vim 7.3b

2010-08-02 Fir de Conversatie Nazri Ramliy
On Mon, Aug 2, 2010 at 8:49 AM, Nazri Ramliy wrote: > On Thu, Jul 29, 2010 at 4:39 AM, Bram Moolenaar wrote: >> I have included the recent patches, but not the one that resets >> "recursive" in gen_expand_wildcards(). That is probably causing that >> crash. > > I noticed that mch_expandpath() is

Re: Question about :find completion support in Vim 7.3b

2010-08-01 Fir de Conversatie Nazri Ramliy
On Thu, Jul 29, 2010 at 4:39 AM, Bram Moolenaar wrote: > I have included the recent patches, but not the one that resets > "recursive" in gen_expand_wildcards().  That is probably causing that > crash. I noticed that mch_expandpath() is defined on both unix and windows as unix_expandpath() and do

Re: Question about :find completion support in Vim 7.3b

2010-07-28 Fir de Conversatie Bram Moolenaar
Nazri Ramliy wrote: > On Wed, Jul 28, 2010 at 8:53 AM, Nazri Ramliy wrote: > > On Wed, Jul 28, 2010 at 2:44 AM, Nazri Ramliy wrote: > >> When I set 'path' to something like "c:\src\**" the completion doesn't > >> work: > >> > >>:find > >> > >> has no effect. > > > > When the patch is appl

Re: Question about :find completion support in Vim 7.3b

2010-07-28 Fir de Conversatie Nazri Ramliy
On Wed, Jul 28, 2010 at 8:53 AM, Nazri Ramliy wrote: > On Wed, Jul 28, 2010 at 2:44 AM, Nazri Ramliy wrote: >> When I set 'path' to something like "c:\src\**" the completion doesn't work: >> >>    :find >> >> has no effect. > > When the patch is applied on top of my patches sent in [1], vim (on

Re: Question about :find completion support in Vim 7.3b

2010-07-27 Fir de Conversatie Nazri Ramliy
On Wed, Jul 28, 2010 at 2:44 AM, Nazri Ramliy wrote: > When I set 'path' to something like "c:\src\**" the completion doesn't work: > >    :find > > has no effect. When the patch is applied on top of my patches sent in [1], vim (on Windows) crashes. I'll investigate this later. nazri. [1] htt

Re: Question about :find completion support in Vim 7.3b

2010-07-27 Fir de Conversatie Nazri Ramliy
On Tue, Jul 27, 2010 at 10:55 AM, Ajit Thakkar wrote: > On Mon, Jul 26, 2010 at 9:16 PM, Nazri Ramliy wrote: >> On Tue, Jul 27, 2010 at 6:01 AM, Yegappan Lakshmanan >> wrote: >> >>> When I press after typing ":find ", I expected that the filenames from >>> the current directory will be complete

Re: Question about :find completion support in Vim 7.3b

2010-07-26 Fir de Conversatie Ajit Thakkar
On Mon, Jul 26, 2010 at 9:16 PM, Nazri Ramliy wrote: > On Tue, Jul 27, 2010 at 6:01 AM, Yegappan Lakshmanan > wrote: > >> When I press after typing ":find ", I expected that the filenames from >> the current directory will be completed. But none of the filenames are >> displayed. If I try to com

Re: Question about :find completion support in Vim 7.3b

2010-07-26 Fir de Conversatie Yegappan Lakshmanan
Hi, On Mon, Jul 26, 2010 at 5:16 PM, Nazri Ramliy wrote: > On Tue, Jul 27, 2010 at 6:01 AM, Yegappan Lakshmanan > wrote: >> Hi, >> >> I am trying the new completion support for the ":find" command in Vim7.3b >> on MS-Windows (XP). The 'path' option is set to the default value (".,,"). > > Thanks

Re: Question about :find completion support in Vim 7.3b

2010-07-26 Fir de Conversatie Nazri Ramliy
On Tue, Jul 27, 2010 at 6:01 AM, Yegappan Lakshmanan wrote: > Hi, > > I am trying the new completion support for the ":find" command in Vim7.3b > on MS-Windows (XP). The 'path' option is set to the default value (".,,"). Thanks for trying out the ":find" completion feature on MS-Windows. > When

Question about :find completion support in Vim 7.3b

2010-07-26 Fir de Conversatie Yegappan Lakshmanan
Hi, I am trying the new completion support for the ":find" command in Vim7.3b on MS-Windows (XP). The 'path' option is set to the default value (".,,"). When I press after typing ":find ", I expected that the filenames from the current directory will be completed. But none of the filenames are d