RE: bad default shellxquote in Widows

2008-11-11 Fir de Conversatie Craig Barkhouse
Tony wrote: To avoid passing a path with spaces in it, use the short form of the path, such as %:p:8 (this works only on Windows -- on Unix you can just backslash-escape the spaces). This will convert the path so that Program Files becomes PROGRA~1, My Documents MYDOCU~1 and, I think, Copy

Re: bad default shellxquote in Widows

2008-11-11 Fir de Conversatie Ben Fritz
I found another case where my proposed new default values break things. I had an implementation of a MyDiff function to use with diffexpr, that added the first and last quote as part of its internal logic. I.e., it was doing the job of my suggested shellxquote internally. Naturally, adding a

Re: bad default shellxquote in Widows

2008-11-10 Fir de Conversatie Ben Fritz
On Nov 8, 7:24 am, Bram Moolenaar [EMAIL PROTECTED] wrote: I think this should only be done for cmd.exe, not for command.com.  So the check should not be 'shell' not matching sh but 'shell' matching cmd. That's probably a good idea, for now at least. I have no idea how command.com works.

Re: bad default shellxquote in Widows

2008-11-08 Fir de Conversatie Bram Moolenaar
Ben Fritz wrote: On Nov 6, 11:20 pm, Tony Mechelynck [EMAIL PROTECTED] wrote: To avoid passing a path with spaces in it, use the short form of the path, such as %:p:8 (this works only on Windows -- on Unix you can just backslash-escape the spaces). This will convert the path so that

Re: bad default shellxquote in Widows

2008-11-07 Fir de Conversatie Ben Fritz
On Nov 6, 11:20 pm, Tony Mechelynck [EMAIL PROTECTED] wrote: To avoid passing a path with spaces in it, use the short form of the path, such as %:p:8 (this works only on Windows -- on Unix you can just backslash-escape the spaces). This will convert the path so that Program Files becomes

Re: bad default shellxquote in Widows

2008-11-06 Fir de Conversatie Ben Fritz
On Nov 4, 3:08 pm, Bram Moolenaar [EMAIL PROTECTED] wrote: I had some trouble reproducing the problem. When both 'shellquote' and 'shellxquote' are emtpy and 'shell' is cmd.exe, this works fine: :echo system('e:/mksnt/echo.exe foo bar') I finally figured out a way to break it:

Re: bad default shellxquote in Widows

2008-11-06 Fir de Conversatie David Fishburn
On Thu, Nov 6, 2008 at 12:58 PM, Ben Fritz [EMAIL PROTECTED] wrote: On Nov 4, 3:08 pm, Bram Moolenaar [EMAIL PROTECTED] wrote: ... Plugins are another question though. For testing, I placed my proposed values of shellxquote and shellcmdflag in my vimrc, and immediately broke the TagList

Re: bad default shellxquote in Widows

2008-11-06 Fir de Conversatie Bram Moolenaar
Ben Fritz wrote: [...] Now the question is what will break if we change the default for 'shellxquote'. I'm not sure about that. I doubt that changing the default would break anything built into Vim, but I suppose that remains to be seen. Changing the default would certainly add a

Re: bad default shellxquote in Widows

2008-11-06 Fir de Conversatie Tony Mechelynck
On 06/11/08 18:58, Ben Fritz wrote: [...] In my testing, I had set g:mlint_path_to_mlint to something in my Program Files directory (hence the need for a double quote) and s:filename contained Copy of startup.m (also, a need for the double quote). There may be a much better way to

Re: bad default shellxquote in Widows

2008-11-04 Fir de Conversatie Bram Moolenaar
Benjamin Fritz wrote: I've been playing around with a plugin (http://www.vim.org/scripts/script.php?script_id=2378), trying to specify a path to the _command_ that is passed to system(). Since this command may have spaces in it, it needs to be wrapped in quotes. However, if it is wrapped

bad default shellxquote in Widows

2008-10-13 Fir de Conversatie Benjamin Fritz
I've been playing around with a plugin (http://www.vim.org/scripts/script.php?script_id=2378), trying to specify a path to the _command_ that is passed to system(). Since this command may have spaces in it, it needs to be wrapped in quotes. However, if it is wrapped in quotes, the default