Re: Patch 8.1.0474

2018-10-15 Fir de Conversatie Ken Takata
Hi, 2018/10/16 Tue 8:10:20 UTC+9 Tony Mechelynck wrote: > On Mon, Oct 15, 2018 at 8:11 PM Bram Moolenaar wrote: > > Ken Takata wrote: > > > Is it better to remove -I. from CFLAGS in Make_mvc.mak and add it only > > > where > > > needed like Make_cyg_ming.mak? > > > > I think it doesn't hurt.

Re: Patch 8.1.0474

2018-10-15 Fir de Conversatie Tony Mechelynck
On Mon, Oct 15, 2018 at 8:11 PM Bram Moolenaar wrote: > Ken Takata wrote: > > Is it better to remove -I. from CFLAGS in Make_mvc.mak and add it only where > > needed like Make_cyg_ming.mak? > > I think it doesn't hurt. Perhaps it's also needed for the xdiff files? On Linux, at least (where

Re: Suggested follow-on to patches 474 and 478 (if_perl)

2018-10-15 Fir de Conversatie Ken Takata
Hi, 2018/10/16 Tue 7:05:57 UTC+9 Michael Soyka wrote: > Since patch 474 places if_perl.c in "auto", the following patch is > suggested.  I can't test the Visual C changes but it looks like it > should work. > > > diff --git a/src/Make_cyg_ming.mak b/src/Make_cyg_ming.mak > index

Suggested follow-on to patches 474 and 478 (if_perl)

2018-10-15 Fir de Conversatie Michael Soyka
Since patch 474 places if_perl.c in "auto", the following patch is suggested.  I can't test the Visual C changes but it looks like it should work. diff --git a/src/Make_cyg_ming.mak b/src/Make_cyg_ming.mak index e213b803d..05725e988 100644 --- a/src/Make_cyg_ming.mak +++

Re: [vim/vim] matchparen causes changes in syntax highlighting (#3543)

2018-10-15 Fir de Conversatie Bram Moolenaar
Hirohito Higashi wrote: > A following patch would fix this issue. > > ```patch > diff --git a/runtime/plugin/matchparen.vim b/runtime/plugin/matchparen.vim > index 65b9fe57b..a79e36d90 100644 > --- a/runtime/plugin/matchparen.vim > +++ b/runtime/plugin/matchparen.vim > @@ -192,6 +192,7 @@

Patch 8.1.0479

2018-10-15 Fir de Conversatie Bram Moolenaar
Patch 8.1.0479 Problem:Failure when setting 'varsofttabstop' to end in a comma. (Ralf Schandl) Solution: Reject value with trailing command. Add test for invalid values (closes #3544) Files: src/testdir/test_vartabs.vim, src/option.c ***

Re: [patch] Check for accessibility of directory in term_start() cwd option

2018-10-15 Fir de Conversatie Jason Franklin
Updated patch is attached. 1. mch_isdir() is added back 2. test is extended to make sure that term_start() fails with a file for cwd value Thanks, Jason -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For

Re: [patch] Check for accessibility of directory in term_start() cwd option

2018-10-15 Fir de Conversatie Jason Franklin
I had the same thought! Currently extending the test for your review. Thanks! Jason -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received

Re: [patch] Check for accessibility of directory in term_start() cwd option

2018-10-15 Fir de Conversatie Bram Moolenaar
Jason Franklin wrote: > Currently, the "term_start()" function will give an error when > a non-existent directory is passed to its "cwd" option. The call will not > fail, however, when the directory exists but is not accessible by the > current user. It would be nice to be able to recover

Re: [patch] Fix indents

2018-10-15 Fir de Conversatie Bram Moolenaar
Ken Takata wrote: > This is a small patch to fix some indents: > > --- a/src/os_win32.c > +++ b/src/os_win32.c > @@ -7691,9 +7691,9 @@ mch_setenv(char *var, char *value, int x > #endif > { > _putenv((char *)envbuf); > -# ifdef libintl_putenv > +#ifdef libintl_putenv >

Re: [vim/vim] Access to free memory with quickfix commands (#3538)

2018-10-15 Fir de Conversatie Bram Moolenaar
Yegappan wrote: > > > On Sat, Oct 13, 2018 at 7:58 AM Yegappan Lakshmanan > > > w= > > > rote: > > > > > > > > On Sat, Oct 13, 2018 at 1:11 AM Dominique Pell=C3=A9 > > > > wrote: > > > > > > > > > > Here is another use of free memory also found by afl-fuzz > > > > > which may be related to

Re: [patch] Check for accessibility of directory in term_start() cwd option

2018-10-15 Fir de Conversatie Jason Franklin
I just realized that the call to "mch_isdir()" is necessary. I'm not sure why I thought I could delete it. I'll send an updated patch in just a moment. -- Jason -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to.

[patch] Check for accessibility of directory in term_start() cwd option

2018-10-15 Fir de Conversatie Jason Franklin
Currently, the "term_start()" function will give an error when a non-existent directory is passed to its "cwd" option. The call will not fail, however, when the directory exists but is not accessible by the current user. It would be nice to be able to recover from this error. This patch uses

Patch 8.1.0478

2018-10-15 Fir de Conversatie Bram Moolenaar
Patch 8.1.0478 Problem:Cannot build with perl using MinGW. Solution: Add -I. (Ken takata, Cesar Romani) Files: src/Make_cyg_ming.mak *** ../vim-8.1.0477/src/Make_cyg_ming.mak 2018-10-14 16:25:04.904583951 +0200 --- src/Make_cyg_ming.mak 2018-10-15 20:08:10.194056013

Re: Patch 8.1.0474

2018-10-15 Fir de Conversatie Bram Moolenaar
Ken Takata wrote: > 2018/10/15 Mon 8:29:46 UTC+9 Ken Takata wrote: > > Hi all, > > > > 2018/10/15 Mon 7:53:19 UTC+9 Cesar wrote: > > > On 14/10/2018 02:48 p.m., Bram Moolenaar wrote: > > > > > > > > Cesar Romani wrote: > > > >> > > > >> Compiling on Windows 7 with MinGW, I get: > > > >> >

Re: [vim/vim] Access to free memory with quickfix commands (#3538)

2018-10-15 Fir de Conversatie Yegappan Lakshmanan
Hi Dominique, On Mon, Oct 15, 2018 at 4:42 AM Dominique Pellé wrote: > > Yegappan wrote: >> >> The attached patch fixes these crashes. >> > > Thanks. I tried your patch and it fixes the 2 cases I reported in this ticket. > Thanks for confirming the fixes. > > However, I have a bunch of cases

Re: [vim/vim] Access to free memory with quickfix commands (#3538)

2018-10-15 Fir de Conversatie Yegappan Lakshmanan
Hi Bram, On Sun, Oct 14, 2018 at 12:48 PM Bram Moolenaar wrote: > > Yegappan wrote: > > > On Sat, Oct 13, 2018 at 7:58 AM Yegappan Lakshmanan w= > > rote: > > > > > > On Sat, Oct 13, 2018 at 1:11 AM Dominique Pell=C3=A9 > > > wrote: > > > > > > > > Here is another use of free memory also found