Re: build error since today (invalid UTF-8)
Hi, 2019/6/7 Fri 12:05:15 UTC+9 Ken Takata wrote: > Hi, > > 2019/6/7 Fri 5:51:02 UTC+9 Bram Moolenaar wrote: > > > I see someone else posted earlier about the same issue. > > > But those suggestions and also latest git rev do not resolve issue for me. > > > > The problem appears to be a broken version of msgfmt. > > We can't fix that in Vim. And it appears to be a real problem, thus > > ignoring it also doesn't appear to be a good idea. > > > > Is this a build error or an error for "make install"? > > This is an error for "make". > > How about checking the version of broken msgfmt? > It seems that v0.19.7 is broken. > > --- a/src/configure.ac > +++ b/src/configure.ac > @@ -4302,8 +4302,13 @@ if test "$enable_nls" = "yes"; then >AC_MSG_CHECKING([if msgfmt supports --desktop]) >MSGFMT_DESKTOP= >if "$MSGFMT" --help | grep -e '--desktop' >/dev/null; then > - AC_MSG_RESULT([yes]) > - MSGFMT_DESKTOP="gvim.desktop vim.desktop" > + if "$MSGFMT" --version | grep '0.19.7$' >/dev/null; then > + dnl GNU gettext 0.19.7's --desktop is broken. > + AC_MSG_RESULT([no]) > + else > + AC_MSG_RESULT([yes]) > + MSGFMT_DESKTOP="gvim.desktop vim.desktop" > + fi >else > AC_MSG_RESULT([no]) >fi Or, should we also mark gettext v0.19 to v0.19.6 as broken? If so: --- a/src/configure.ac +++ b/src/configure.ac @@ -4302,8 +4302,13 @@ if test "$enable_nls" = "yes"; then AC_MSG_CHECKING([if msgfmt supports --desktop]) MSGFMT_DESKTOP= if "$MSGFMT" --help | grep -e '--desktop' >/dev/null; then - AC_MSG_RESULT([yes]) - MSGFMT_DESKTOP="gvim.desktop vim.desktop" + if "$MSGFMT" --version | grep '0.19$\|0.19.[[1-7]]$' >/dev/null; then + dnl GNU gettext 0.19.7's --desktop is broken. + AC_MSG_RESULT([broken]) + else + AC_MSG_RESULT([yes]) + MSGFMT_DESKTOP="gvim.desktop vim.desktop" + fi else AC_MSG_RESULT([no]) fi Regards, Ken Takata -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/2364c29e-58a9-4330-913f-1bd23e1a747f%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: build error since today (invalid UTF-8)
On Do, 06 Jun 2019, Bram Moolenaar wrote: > > > I see someone else posted earlier about the same issue. > > But those suggestions and also latest git rev do not resolve issue for me. > > The problem appears to be a broken version of msgfmt. > We can't fix that in Vim. And it appears to be a real problem, thus > ignoring it also doesn't appear to be a good idea. > > Is this a build error or an error for "make install"? It is a build error Best, Christian -- Schfleck, Knut: Verkünder der befleckten Empfängnis -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/20190607054457.GS23877%40256bit.org. For more options, visit https://groups.google.com/d/optout.
Re: build error since today (invalid UTF-8)
On Do, 06 Jun 2019, M Kelly wrote: > Hi, > > I see someone else posted earlier about the same issue. > But those suggestions and also latest git rev do not resolve issue for me. Yeah, it looks like Ubuntus msgfmt is seriously broken. Open a bug report at their issue tracker please. For the time being, you can either install an updated msgfmt from here: https://launchpad.net/~ricotz/+archive/ubuntu/toolchain or simply ignore the error and apply a local patch, like this one: https://groups.google.com/d/msg/vim_dev/yYGCsJJPlA0/oPYsDxBRAgAJ Best, Christian -- "Arden von Deversham", Shakespeares Jugendarbeit. Es ist der ganze rein-treue Ernst des Auffassens und Wiedergebens, ohne Spur von Rücksicht auf den Effekt, vollkommen dramatisch, ganz untheatralisch. -- Goethe, Maximen und Reflektionen, Nr. 495 -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/20190607054433.GR23877%40256bit.org. For more options, visit https://groups.google.com/d/optout.
Re: How about sound?
Since others have posted code, here's mine. In gui_gtk_x11.c: At file scope: #ifdef CANBERRA # include static ca_context *canberra = 0; #endif In gui_mch_beep: #ifdef CANBERRA int ca_error; if (!canberra) // static, initialize on first use ca_context_create (); ca_error = ca_context_play (canberra, 0, CA_PROP_EVENT_ID, "bell", CA_PROP_EVENT_DESCRIPTION, "vim beep", CA_PROP_CANBERRA_CACHE_CONTROL, "volatile", NULL); if (ca_error) fprintf(stderr, "%d error, %s\n", ca_error, ca_strerror(ca_error)); #else ... But also, in misc1.c, in vim_beep: #ifdef CANBERRA // john I use a 100 ms beep, which plays asynchronously anyway // so let's use 50 instead of 500 if (!did_init || ELAPSED_FUNC(start_tv) > 50) #else if (!did_init || ELAPSED_FUNC(start_tv) > 500) #endif Because libcanberra plays the sound in another thread, or something like that, it doesn't block, and it handles playing multiple sounds. My keyboard repeat rate is 50 Hz, and if I hold down the escape key I get 10 sounds a second, because the sound is 100 ms (thanks to audacity). Having a very fast (that is, a short attack stage) sound saves me a good fraction of second every time. Thinking while typing, please excuse me... The sound themes typically available for the xdg desktop standard have sounds that are one or 2 seconds long, and usually start slowly. For me that wouldn't suit vim. I'd like a general scheme where a different sound could be set for at least each auto command event. Maybe via an ex command, say "play". F.ex. one could make vim like a smartphone with key sounds on with InsertCharPre. But I'd like other events, too, with fine-grained control possible for errors and every circumstance where vim presently issues a beep. Python can play sounds, so I suppose I could make a call to python in auto commands. Maybe all we need is an event for the bell, and for errors, maybe passing or setting up some context via v:event. (It was a struggle for me to get all the packages I needed to get my python to use GSound; documentation I found was not quite up to date. ) So, my conclusion is that there could be an event for all the circumstances where vim presently may beep, and the relevant item at :h 'belloff' could be set in v:event. If an error has occurred then v:errmsg gives information. Then some heroic plugin author can put together the python bits and pieces with an appropriate sound theme. The large majority who want nothing to do with sound can continue in their silence, or maybe flash their RGB, or send a command to an odour generator ;). Regards, John Little -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/06c490a5-53be-444c-8b9b-9edc033a7629%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: build error since today (invalid UTF-8)
Hi, 2019/6/7 Fri 5:51:02 UTC+9 Bram Moolenaar wrote: > > I see someone else posted earlier about the same issue. > > But those suggestions and also latest git rev do not resolve issue for me. > > The problem appears to be a broken version of msgfmt. > We can't fix that in Vim. And it appears to be a real problem, thus > ignoring it also doesn't appear to be a good idea. > > Is this a build error or an error for "make install"? This is an error for "make". How about checking the version of broken msgfmt? It seems that v0.19.7 is broken. --- a/src/configure.ac +++ b/src/configure.ac @@ -4302,8 +4302,13 @@ if test "$enable_nls" = "yes"; then AC_MSG_CHECKING([if msgfmt supports --desktop]) MSGFMT_DESKTOP= if "$MSGFMT" --help | grep -e '--desktop' >/dev/null; then - AC_MSG_RESULT([yes]) - MSGFMT_DESKTOP="gvim.desktop vim.desktop" + if "$MSGFMT" --version | grep '0.19.7$' >/dev/null; then + dnl GNU gettext 0.19.7's --desktop is broken. + AC_MSG_RESULT([no]) + else + AC_MSG_RESULT([yes]) + MSGFMT_DESKTOP="gvim.desktop vim.desktop" + fi else AC_MSG_RESULT([no]) fi Regards, Ken Takata -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/ec7adb40-c0b6-438b-8564-8efb6c2735f2%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: build error since today (invalid UTF-8)
> I see someone else posted earlier about the same issue. > But those suggestions and also latest git rev do not resolve issue for me. The problem appears to be a broken version of msgfmt. We can't fix that in Vim. And it appears to be a real problem, thus ignoring it also doesn't appear to be a good idea. Is this a build error or an error for "make install"? -- hundred-and-one symptoms of being an internet addict: 106. When told to "go to your room" you inform your parents that you can't...because you were kicked out and banned. /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net \\\ ///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org/// \\\help me help AIDS victims -- http://ICCF-Holland.org/// -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/201906062050.x56KooAc028722%40masaka.moolenaar.net. For more options, visit https://groups.google.com/d/optout.
Patch 8.1.1486
Patch 8.1.1486 Problem:A listener change is merged even when it adds a line. (Paul Jolly) Solution: Do not merge a change that adds or removes a line. (closes #4490) Files: src/change.c, src/testdir/test_listener.vim *** ../vim-8.1.1485/src/change.c2019-06-01 13:28:30.269829512 +0200 --- src/change.c2019-06-06 19:58:19.326775932 +0200 *** *** 186,191 --- 186,192 || (prev_lnume >= lnum && xtra != 0)) { if (li->li_next == NULL && lnum == prev_lnum + && xtra == 0 && col + 1 == (colnr_T)dict_get_number( li->li_tv.vval.v_dict, (char_u *)"col")) { *** ../vim-8.1.1485/src/testdir/test_listener.vim 2019-05-24 21:39:23.893950022 +0200 --- src/testdir/test_listener.vim 2019-06-06 20:04:46.320364378 +0200 *** *** 28,36 set undolevels& " start new undo block call append(2, 'two two') undo redraw ! " the two changes get merged ! call assert_equal([{'lnum': 3, 'end': 4, 'col': 1, 'added': 0}], s:list) 1 " Two listeners, both get called. Also check column. --- 28,37 set undolevels& " start new undo block call append(2, 'two two') undo + call assert_equal([{'lnum': 3, 'end': 3, 'col': 1, 'added': 1}], s:list) redraw ! " the two changes are not merged ! call assert_equal([{'lnum': 3, 'end': 4, 'col': 1, 'added': -1}], s:list) 1 " Two listeners, both get called. Also check column. *** *** 65,79 call assert_equal([{'lnum': 3, 'end': 3, 'col': 1, 'added': 1}, \ {'lnum': 1, 'end': 2, 'col': 1, 'added': 0}], s:list) ! " an insert just above a previous change that was the last one gets merged call setline(1, ['one one', 'two']) call listener_flush() let s:list = [] call setline(2, 'something') call append(1, 'two two') ! call assert_equal([], s:list) call listener_flush() ! call assert_equal([{'lnum': 2, 'end': 3, 'col': 1, 'added': 1}], s:list) " an insert above a previous change causes a flush call setline(1, ['one one', 'two']) --- 66,81 call assert_equal([{'lnum': 3, 'end': 3, 'col': 1, 'added': 1}, \ {'lnum': 1, 'end': 2, 'col': 1, 'added': 0}], s:list) ! " an insert just above a previous change that was the last one does not get ! " merged call setline(1, ['one one', 'two']) call listener_flush() let s:list = [] call setline(2, 'something') call append(1, 'two two') ! call assert_equal([{'lnum': 2, 'end': 3, 'col': 1, 'added': 0}], s:list) call listener_flush() ! call assert_equal([{'lnum': 2, 'end': 2, 'col': 1, 'added': 1}], s:list) " an insert above a previous change causes a flush call setline(1, ['one one', 'two']) *** *** 86,98 call assert_equal([{'lnum': 1, 'end': 1, 'col': 1, 'added': 1}], s:list) call assert_equal('two two', s:text) ! " a delete at a previous change that was the last one gets merged call setline(1, ['one one', 'two']) call listener_flush() let s:list = [] call setline(2, 'something') 2del ! call assert_equal([], s:list) call listener_flush() call assert_equal([{'lnum': 2, 'end': 3, 'col': 1, 'added': -1}], s:list) --- 88,100 call assert_equal([{'lnum': 1, 'end': 1, 'col': 1, 'added': 1}], s:list) call assert_equal('two two', s:text) ! " a delete at a previous change that was the last one does not get merged call setline(1, ['one one', 'two']) call listener_flush() let s:list = [] call setline(2, 'something') 2del ! call assert_equal([{'lnum': 2, 'end': 3, 'col': 1, 'added': 0}], s:list) call listener_flush() call assert_equal([{'lnum': 2, 'end': 3, 'col': 1, 'added': -1}], s:list) *** ../vim-8.1.1485/src/version.c 2019-06-06 19:03:14.388227807 +0200 --- src/version.c 2019-06-06 22:50:01.509039136 +0200 *** *** 769,770 --- 769,772 { /* Add new patch number below this line */ + /**/ + 1486, /**/ -- hundred-and-one symptoms of being an internet addict: 107. When using your phone you forget that you don't have to use your keyboard. /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net \\\ ///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org/// \\\help me help AIDS victims -- http://ICCF-Holland.org/// -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to
Re: [patch] doc fixes
Dominique wrote: > Attached are minor doc fixes for vim-8.1.1485. Thanks! -- hundred-and-one symptoms of being an internet addict: 105. When someone asks you for your address, you tell them your URL. /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net \\\ ///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org/// \\\help me help AIDS victims -- http://ICCF-Holland.org/// -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/201906062050.x56Kop8r028747%40masaka.moolenaar.net. For more options, visit https://groups.google.com/d/optout.
Re: Patch 8.1.1478
Christian wrote: > On Do, 06 Jun 2019, Bram Moolenaar wrote: > > export VIMRUNTIME; ../vim -f -u unix.vim -U NONE --noplugin > > --not-a-term -S summarize.vim messages essages" [New File] > > Error detected while processing > > /home/travis/build/vim/vim/src/testdir/summariz > > : > > line 33: > > E10: \ should be followed by /, ? or & > > line 34: > > E10: \ should be followed by /, ? or & > > line 35: > > E10: \ should be followed by /, ? or & > > line 36: > > E10: \ should be followed by /, ? or & > > line 37: > > E10: \ should be followed by /, ? or & > > line 38: > > E10: \ should be followed by /, ? or & > > line 39: > > E10: \ should be followed by /, ? or & > > line 58: > > E484: Can't open file test.log > > Test results: > > ALL DONE > > Hm, the first part should have been skipped by the if 1. > > I suppose the real error is the last one, there was no test.log output > file, hm, perhaps sil! :r would have worked. Note sure. The tiny vim is > often tricky to make work. But since you fixed it now in the Makefile, I > guess I don't have to worry about it ;) The problem was that with 'compatible' set the line continuation doesn't work. But yes, it had to be fixed in the Makefile, since without +eval reading test.log would fail. -- hundred-and-one symptoms of being an internet addict: 103. When you find yourself in the "Computer" section of Barnes & Noble enjoying yourself. /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net \\\ ///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org/// \\\help me help AIDS victims -- http://ICCF-Holland.org/// -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/201906062050.x56KopZ4028728%40masaka.moolenaar.net. For more options, visit https://groups.google.com/d/optout.
[patch] doc fixes
Hi Attached are minor doc fixes for vim-8.1.1485. Regards Dominique -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/CAON-T_hdhodcGYUaDFt-jJjhgQKxfvwxkm3QUgTT31YRpCO71w%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout. diff --git a/runtime/doc/eval.txt b/runtime/doc/eval.txt index 0b44e58e2..3a9e868c0 100644 --- a/runtime/doc/eval.txt +++ b/runtime/doc/eval.txt @@ -7343,7 +7343,7 @@ prop_remove({props} [, {lnum} [, {lnum-end}]]) not just the first one A property matches when either "id" or "type" matches. If buffer "bufnr" does not exist you get an error message. - If buffer 'bufnr" is not loaded then nothing happens. + If buffer "bufnr" is not loaded then nothing happens. Returns the number of properties that were removed. diff --git a/runtime/doc/popup.txt b/runtime/doc/popup.txt index ceb93875d..a3fa38778 100644 --- a/runtime/doc/popup.txt +++ b/runtime/doc/popup.txt @@ -496,7 +496,7 @@ Vim provides standard filters |popup_filter_menu()| and Note that "x" is the normal way to close a popup. You may want to use Esc, but since many keys start with an Esc character, there may be a delay before -Vim recognizes the Esc key. If you do use Esc, it is reecommended to set the +Vim recognizes the Esc key. If you do use Esc, it is recommended to set the 'ttimeoutlen' option to 100 and set 'timeout' and/or 'ttimeout'.
Re: build error since today (invalid UTF-8)
Hi, I see someone else posted earlier about the same issue. But those suggestions and also latest git rev do not resolve issue for me. -m -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/e6ab3364-4955-4907-a5e2-bcc33a848c8d%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: build error since today (invalid UTF-8)
git rev is latest master since a few minutes ago: * 2019-06-06 773a97c25 (HEAD -> master, origin/master, origin/HEAD) Update runtime files - Add typescript syntax and indent. (Bram Moolenaar) -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/8bc0fb56-58be-4948-9bb3-14c80e85bb97%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
build error since today (invalid UTF-8)
Hi, I typically build daily and its been fine until today - msgfmt --desktop -d . --template gvim.desktop.in -o tmp_gvim.desktop rm -f LINGUAS if command -v desktop-file-validate; then desktop-file-validate tmp_gvim.desktop; fi /usr/bin/desktop-file-validate tmp_gvim.desktop: warning: file contains lines that are not UTF-8 encoded. There is no guarantee the validator will correctly work. [Invalid UTF-8] tmp_gvim.desktop: error: value "\xe0\xac\xaa\xe0\xac\xbe\xe0\xac\xa0\xe0\xad\x8d\xe0\xac\xaf \xe0\xac\xab\xe0\xac\xbe\xe0\xac\x87\xe0\xac\xb2\xe0\xac\x97\xe0\xad\x81\xe0\xac\xa1\xe0\xac\xbc\xe0\xac\xbf\xe0\xac\x95\xe0\xad\x81 \xe0\xac\xb8\xe0\xac\xae\xe0\xad\x8d\xe0\xac\xaa\xe0\xac\xbe\xe0\xac\xa6\xe0\xac\xa8 \xe0\xac\x95\xe0\xac\xb0\xe0\xac\xa8\xe0\xad\x8d\xe0\xac\xa4\xe0\xad" for locale string key "Comment[or]" in group "Desktop Entry" contains y characters, locale string values should be encoded in UTF-8 I'm on linux 4.15.0-51-generic gcc --version gcc (Ubuntu 5.4.0-6ubuntu1~16.04.11) 5.4.0 20160609 msgfmt (GNU gettext-tools) 0.19.7 GDM_LANG=en_US LANG=en_US.UTF-8 LANGUAGE=en_US Any ideas ? thx, -m -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/d85ac218-ad36-43a7-a2ed-f2c2f13bef8e%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Using popup windows instead of balloons
> What part of balloons? If you mean 'balloonexpr', it only returns plain > text. Perhaps you mean the functionality to detect the mouse pointer is > hovering over text for some time? Well, we could add 'balloonpopup', > which would open a popup window with anything it likes and return the > window ID. That window would then be closed when the mouse moves. I think what you propose 'balloonpopup' is exactly what I'm looking for, thank you. Essentially I'd like to leverage the fact that gopls (the LSP server used by govim) can return a richer markdown version of hover information. Being able to display a popup window instead of a balloon will (via text properties etc) allow me to do just that. One other thing to mention: I think we would want a cursor movement to dismiss such a popup, in addition to a mouse move. Similarly, I think we will need one of the options to popup_create to allow for 'moved' property to also include mouse movement. Reason being, I'd like the user to be able to trigger exactly the same hover information via a mapping, displaying the popup at the cursor position (not the mouse position). Just as described above, a mouse movement or cursor movement should dismiss such a popup. Thanks -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/CACoUkn64r9E2aAvSpB2YyA8760A4wGLTxrzMcnmgQ%3DF7zYXXVA%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
Re: Patch 8.1.1468
On 06/06/2019 18:22, Christian Brabandt wrote: > > On Do, 06 Jun 2019, Mike Williams wrote: > >> The desktop file still seems valid apart from encoding errors. Is there >> a problem if the makefile ignored the error and continued? Or have a > > The problem is, we might not notice failures :( You still get the error reported, but yes I see your point. Fine for local development, not for CI where you want it to pick up errors. >> build option to allow ignoring errors generating desktop files? Just a >> wild thought. > > I think for fixing your local environment, the best is to commit a local > patch like below, that should just ignore the error. Granted, that would > install a probably invalid desktop file, but that happened before as > well (and it seemed nobody noticed since the desktop files are generated > from the po files directly (8.1.1147)). > > Well, at least Debian and Ubuntu do not offer official packages newer > than 8.1.0875, in case of Debian this is probably due to the buster > freeze). U16.04 is 7.4.1689. The level of pain may depend on how many people build recent versions of VIM or provide a PPA for others. > That patch could be stashed on top, or just kept around in your local > repository, shouldn't really matter. > > diff --git a/src/po/Makefile b/src/po/Makefile > index 8c7066b64..dcf88ab19 100644 > --- a/src/po/Makefile > +++ b/src/po/Makefile > @@ -169,14 +169,14 @@ vim.desktop: vim.desktop.in $(POFILES) > @echo $(LANGUAGES) | tr " " "\n" |sed -e '/\./d' | sort > LINGUAS > $(MSGFMT) --desktop -d . --template vim.desktop.in -o tmp_vim.desktop > rm -f LINGUAS > - if command -v desktop-file-validate; then desktop-file-validate > tmp_vim.desktop; fi > + -if command -v desktop-file-validate; then desktop-file-validate > tmp_vim.desktop; fi > mv tmp_vim.desktop vim.desktop > > gvim.desktop: gvim.desktop.in $(POFILES) > @echo $(LANGUAGES) | tr " " "\n" |sed -e '/\./d' | sort > LINGUAS > $(MSGFMT) --desktop -d . --template gvim.desktop.in -o > tmp_gvim.desktop > rm -f LINGUAS > - if command -v desktop-file-validate; then desktop-file-validate > tmp_gvim.desktop; fi > + -if command -v desktop-file-validate; then desktop-file-validate > tmp_gvim.desktop; fi > mv tmp_gvim.desktop gvim.desktop > > update-po: $(LANGUAGES) I still run off an hg repo so a simple mq patch will quickly do what I need. Thanks for all the help. TTFN Mike -- If you throw a cat out of a car window... is it kitty litter?? -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/542f88eb-4264-2415-b723-af0326dd7556%40globalgraphics.com. For more options, visit https://groups.google.com/d/optout.
Re: Patch 8.1.1468
On Do, 06 Jun 2019, Mike Williams wrote: > The desktop file still seems valid apart from encoding errors. Is there > a problem if the makefile ignored the error and continued? Or have a The problem is, we might not notice failures :( > build option to allow ignoring errors generating desktop files? Just a > wild thought. I think for fixing your local environment, the best is to commit a local patch like below, that should just ignore the error. Granted, that would install a probably invalid desktop file, but that happened before as well (and it seemed nobody noticed since the desktop files are generated from the po files directly (8.1.1147)). Well, at least Debian and Ubuntu do not offer official packages newer than 8.1.0875, in case of Debian this is probably due to the buster freeze). That patch could be stashed on top, or just kept around in your local repository, shouldn't really matter. diff --git a/src/po/Makefile b/src/po/Makefile index 8c7066b64..dcf88ab19 100644 --- a/src/po/Makefile +++ b/src/po/Makefile @@ -169,14 +169,14 @@ vim.desktop: vim.desktop.in $(POFILES) @echo $(LANGUAGES) | tr " " "\n" |sed -e '/\./d' | sort > LINGUAS $(MSGFMT) --desktop -d . --template vim.desktop.in -o tmp_vim.desktop rm -f LINGUAS - if command -v desktop-file-validate; then desktop-file-validate tmp_vim.desktop; fi + -if command -v desktop-file-validate; then desktop-file-validate tmp_vim.desktop; fi mv tmp_vim.desktop vim.desktop gvim.desktop: gvim.desktop.in $(POFILES) @echo $(LANGUAGES) | tr " " "\n" |sed -e '/\./d' | sort > LINGUAS $(MSGFMT) --desktop -d . --template gvim.desktop.in -o tmp_gvim.desktop rm -f LINGUAS - if command -v desktop-file-validate; then desktop-file-validate tmp_gvim.desktop; fi + -if command -v desktop-file-validate; then desktop-file-validate tmp_gvim.desktop; fi mv tmp_gvim.desktop gvim.desktop update-po: $(LANGUAGES) Best, Christian -- Eine Frau heiratet einen Mann in der Erwartung, daß er sich ändert, aber er ändert sich nicht. Ein Mann heiratet eine Frau in der Erwartung, daß sie sich nicht ändert - doch sie tut es. -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/2019060617.GP23877%40256bit.org. For more options, visit https://groups.google.com/d/optout.
Re: can't pull
On Thu, Jun 6, 2019 at 12:04 PM Christian Brabandt wrote: > On Do, 06 Jun 2019, tooth pik wrote: > > > this morning i get a > > > > Updating 32e197701..75ee544f9 > > error: Your local changes to the following files would be overwritten by > > merge: > > src/testdir/test_clientserver.vim > > Please commit your changes or stash them before you merge. > > Aborting > > > > when i try to git pull > > Did you change test_clientserver.vim? Then git stash it away and pull > again and do git stash pop afterwards. Or do you not care? Then git > reset --hard before doing git pull i have a vague recollection of trying to turn logging on to see why my tests all failed -- no joy -- but i put it back the way it was but maybe git is checking time stamps anyway git reset --hard did the trick for me -- thx christian > Best, > Christian > -- > Nicht die einzelnen Anreden, sondern die zufälligen Äußerungen der > Eltern und die absichtlose Fortsetzung und Offenbarung eines > Charakters wirken so unglaublich auf die Kinder, denen durch ihre > Verehrung alles so fest anfliegt. > -- Jean Paul > > -- > -- > You received this message from the "vim_dev" maillist. > Do not top-post! Type your reply below the text you are replying to. > For more information, visit http://www.vim.org/maillist.php > > --- > You received this message because you are subscribed to the Google Groups > "vim_dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to vim_dev+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/vim_dev/20190606170420.GO23877%40256bit.org. > For more options, visit https://groups.google.com/d/optout. -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/CALfSX1yUTrkdgn1pDtkPAO3-ya08kP7bKiNWz-5zwhOWZ%3D_CBw%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
Re: How about sound?
On Thu, Jun 06, 2019 at 02:07:46PM +0200, Bram Moolenaar wrote: > I tried a little example: > > > #include > #include > int main () { > ca_context * hello; > ca_context_create (); > ca_context_play (hello, 0, > CA_PROP_EVENT_ID, "phone-incoming-call", > CA_PROP_EVENT_DESCRIPTION, "hello world", > NULL); > sleep(2); > return 0; > } > > gcc -o sound -D_REENTRANT -lcanberra sound.c > /usr/bin/ld: /tmp/ccArSjRM.o: in function `main': > sound.c:(.text+0x1f): undefined reference to `ca_context_create' > /usr/bin/ld: sound.c:(.text+0x57): undefined reference to `ca_context_play' > collect2: error: ld returned 1 exit status > > Somehow linking doesn't work, must be missing something... This works: gcc -o sound -D_REENTRANT sound.c -lcanberra (At some point back in 2011 Ubuntu changed the linker defaults to use --as-needed, which means the linker tries to drop unneeded libraries if it doesn't see any object files using symbols from that library before it encounters the name of the library. I don't really understand this; but it caused everyone's build scripts to fail at the time, and the fix was to move all the libraries to the end of the compiler command line. It's documented in https://wiki.ubuntu.com/NattyNarwhal/ToolchainTransition#Indirect_Linking_for_Shared_Libraries but I don't understand a word on that page. I hope it's the right page.) Marius Gedminas -- Perl is hard for most people to write. They write PERL or Pearl. -- Abigail -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/20190606170546.b6y6ajnlocplfnsj%40platonas. For more options, visit https://groups.google.com/d/optout. signature.asc Description: PGP signature
Re: can't pull
On Do, 06 Jun 2019, tooth pik wrote: > this morning i get a > > Updating 32e197701..75ee544f9 > error: Your local changes to the following files would be overwritten by > merge: > src/testdir/test_clientserver.vim > Please commit your changes or stash them before you merge. > Aborting > > when i try to git pull Did you change test_clientserver.vim? Then git stash it away and pull again and do git stash pop afterwards. Or do you not care? Then git reset --hard before doing git pull Best, Christian -- Nicht die einzelnen Anreden, sondern die zufälligen Äußerungen der Eltern und die absichtlose Fortsetzung und Offenbarung eines Charakters wirken so unglaublich auf die Kinder, denen durch ihre Verehrung alles so fest anfliegt. -- Jean Paul -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/20190606170420.GO23877%40256bit.org. For more options, visit https://groups.google.com/d/optout.
Re: Using popup windows instead of balloons
Paul Jolly wrote: > As a follow up to a thread I just started ("Using text properties to > show rendered documents" - > https://groups.google.com/forum/#!topic/vim_dev/Armm3XaIleo) I'd like > to ask whether folks would be supportive of using popup windows > instead of balloons (or at least having this as an option). > > Reason being, this gives us far greater flexibility in terms of > what/how we show when the mouse hovers over something. > > Any thoughts? What part of balloons? If you mean 'balloonexpr', it only returns plain text. Perhaps you mean the functionality to detect the mouse pointer is hovering over text for some time? Well, we could add 'balloonpopup', which would open a popup window with anything it likes and return the window ID. That window would then be closed when the mouse moves. -- Contrary to popular belief, Unix is user friendly. It just happens to be selective about who it makes friends with. -- Dave Parnas /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net \\\ ///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org/// \\\help me help AIDS victims -- http://ICCF-Holland.org/// -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/201906061703.x56H3WRa008001%40masaka.moolenaar.net. For more options, visit https://groups.google.com/d/optout.
Patch 8.1.1485
Patch 8.1.1485 Problem:Double free when garbage_collect() is used in autocommand. Solution: Have garbage collection also set the copyID in funccal_stack. Files: src/eval.c, src/userfunc.c *** ../vim-8.1.1484/src/eval.c 2019-06-06 18:05:19.238273419 +0200 --- src/eval.c 2019-06-06 18:42:56.488165150 +0200 *** *** 430,441 vim_free(SCRIPT_SV(i)); ga_clear(_scripts); - // functions need to be freed before gargabe collecting, otherwise local - // variables might be freed twice. - free_all_functions(); - // unreferenced lists and dicts (void)garbage_collect(FALSE); } #endif --- 430,440 vim_free(SCRIPT_SV(i)); ga_clear(_scripts); // unreferenced lists and dicts (void)garbage_collect(FALSE); + + // functions not garbage collected + free_all_functions(); } #endif *** ../vim-8.1.1484/src/userfunc.c 2019-06-01 13:28:30.269829512 +0200 --- src/userfunc.c 2019-06-06 18:57:47.970625188 +0200 *** *** 4030,4040 int set_ref_in_call_stack(int copyID) { ! int abort = FALSE; ! funccall_T*fc; for (fc = current_funccal; fc != NULL; fc = fc->caller) abort = abort || set_ref_in_funccal(fc, copyID); return abort; } --- 4030,4047 int set_ref_in_call_stack(int copyID) { ! int abort = FALSE; ! funccall_T*fc; ! funccal_entry_T *entry; for (fc = current_funccal; fc != NULL; fc = fc->caller) abort = abort || set_ref_in_funccal(fc, copyID); + + // Also go through the funccal_stack. + for (entry = funccal_stack; entry != NULL; entry = entry->next) + for (fc = entry->top_funccal; fc != NULL; fc = fc->caller) + abort = abort || set_ref_in_funccal(fc, copyID); + return abort; } *** ../vim-8.1.1484/src/version.c 2019-06-06 18:05:19.238273419 +0200 --- src/version.c 2019-06-06 18:59:31.333985583 +0200 *** *** 769,770 --- 769,772 { /* Add new patch number below this line */ + /**/ + 1485, /**/ -- To be rich is not the end, but only a change of worries. /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net \\\ ///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org/// \\\help me help AIDS victims -- http://ICCF-Holland.org/// -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/201906061703.x56H3WJ6008008%40masaka.moolenaar.net. For more options, visit https://groups.google.com/d/optout.
can't pull
this morning i get a Updating 32e197701..75ee544f9 error: Your local changes to the following files would be overwritten by merge: src/testdir/test_clientserver.vim Please commit your changes or stash them before you merge. Aborting when i try to git pull -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/CALfSX1xpiO%2BwHTjbO3PV5Z2C-eq%2BnuDhcWvvBFu3Up%3DF9QZxbQ%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
Re: Patch 8.1.1468
On 06/06/2019 16:48, Christian Brabandt wrote: > > On Do, 06 Jun 2019, Mike Williams wrote: > >> 16.04 is a Ubuntu LTS and supported for another 18 months or so. It >> would be nice to think they would want to updated for such an obvious >> bug on release widely used, but who knows. > > Just for the fun of it, I have been trying to see what commit caused it. > I think, this commit fixed it: > http://git.savannah.gnu.org/cgit/gettext.git/commit/?id=68ab0dafa99f1941b3ebb47b7cf969381e7310f4 > > Going further I could successfully apply that patch against Ubuntus > 16.04 LTS version and rebuild the complete package. That seems to have > fixed the problem on my local xenial (16.04LTS) box. So perhaps you can > convince them to rebuild with that patch applied on top. On a straight read of the patch that seems a surprising fix, but I'll happily take your word for it. >> This is for a work machine so modifying toolchains via a PPA is not >> possible. I can work around the problem now that I know what it is. > > Understood. I have been wondering if it would be doable to detect this > problem somewhere and then skip this step. Not sure how to do this and > if it would be worth the trouble. The desktop file still seems valid apart from encoding errors. Is there a problem if the makefile ignored the error and continued? Or have a build option to allow ignoring errors generating desktop files? Just a wild thought. TTFN Mike -- Everyone I know lives on a fold on a map! -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/44cc19bd-fdb6-d39c-d083-2cd65fccfdbc%40globalgraphics.com. For more options, visit https://groups.google.com/d/optout.
Patch 8.1.1484
Patch 8.1.1484 Problem:Some tests are slow. Solution: Add timing to the test messages. Fix double free when quitting in VimLeavePre autocmd. Files: src/testdir/runtest.vim, src/eval.c *** ../vim-8.1.1483/src/testdir/runtest.vim 2019-06-06 13:37:56.967789508 +0200 --- src/testdir/runtest.vim 2019-06-06 17:39:17.999764119 +0200 *** *** 42,47 --- 42,51 cquit endif + if has('reltime') + let s:start_time = reltime() + endif + " Common with all tests on all systems. source setup.vim *** *** 99,104 --- 103,111 func RunTheTest(test) echo 'Executing ' . a:test + if has('reltime') + let func_start = reltime() + endif " Avoid stopping at the "hit enter" prompt set nomore *** *** 126,132 endtry endif ! call add(s:messages, 'Executing ' . a:test) let s:done += 1 if a:test =~ 'Test_nocatch_' --- 133,143 endtry endif ! let message = 'Executed ' . a:test ! if has('reltime') ! let message ..= ' in ' .. reltimestr(reltime(func_start)) .. ' seconds' ! endif ! call add(s:messages, message) let s:done += 1 if a:test =~ 'Test_nocatch_' *** *** 232,237 --- 243,251 else let message = 'Executed ' . s:done . (s:done > 1 ? ' tests' : ' test') endif + if has('reltime') + let message ..= ' in ' .. reltimestr(reltime(s:start_time)) .. ' seconds' + endif echo message call add(s:messages, message) if s:fail > 0 *** ../vim-8.1.1483/src/eval.c 2019-06-01 13:28:30.273829492 +0200 --- src/eval.c 2019-06-06 17:57:24.701211822 +0200 *** *** 430,440 vim_free(SCRIPT_SV(i)); ga_clear(_scripts); ! /* unreferenced lists and dicts */ ! (void)garbage_collect(FALSE); ! ! /* functions */ free_all_functions(); } #endif --- 430,441 vim_free(SCRIPT_SV(i)); ga_clear(_scripts); ! // functions need to be freed before gargabe collecting, otherwise local ! // variables might be freed twice. free_all_functions(); + + // unreferenced lists and dicts + (void)garbage_collect(FALSE); } #endif *** ../vim-8.1.1483/src/version.c 2019-06-06 16:12:05.927134625 +0200 --- src/version.c 2019-06-06 16:26:07.558637258 +0200 *** *** 769,770 --- 769,772 { /* Add new patch number below this line */ + /**/ + 1484, /**/ -- hundred-and-one symptoms of being an internet addict: 101. U can read htis w/o ny porblm and cant figur eout Y its evn listd. /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net \\\ ///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org/// \\\help me help AIDS victims -- http://ICCF-Holland.org/// -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/201906061605.x56G5jLM027835%40masaka.moolenaar.net. For more options, visit https://groups.google.com/d/optout.
Re: Patch 8.1.1468
On Do, 06 Jun 2019, Mike Williams wrote: > 16.04 is a Ubuntu LTS and supported for another 18 months or so. It > would be nice to think they would want to updated for such an obvious > bug on release widely used, but who knows. Just for the fun of it, I have been trying to see what commit caused it. I think, this commit fixed it: http://git.savannah.gnu.org/cgit/gettext.git/commit/?id=68ab0dafa99f1941b3ebb47b7cf969381e7310f4 Going further I could successfully apply that patch against Ubuntus 16.04 LTS version and rebuild the complete package. That seems to have fixed the problem on my local xenial (16.04LTS) box. So perhaps you can convince them to rebuild with that patch applied on top. > This is for a work machine so modifying toolchains via a PPA is not > possible. I can work around the problem now that I know what it is. Understood. I have been wondering if it would be doable to detect this problem somewhere and then skip this step. Not sure how to do this and if it would be worth the trouble. Best, Christian -- Sobald der Glaube an die Allmacht physischer Gewalt das Leben einer Nation beherrscht, emanzipiert sich diese Kraft, wird zum Selbstzweck und wird mächtiger als jene Männer, die sie als Werkzeug benützen wollen. -- Albert Einstein -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/20190606154825.GN23877%40256bit.org. For more options, visit https://groups.google.com/d/optout.
Using popup windows instead of balloons
Hi all, As a follow up to a thread I just started ("Using text properties to show rendered documents" - https://groups.google.com/forum/#!topic/vim_dev/Armm3XaIleo) I'd like to ask whether folks would be supportive of using popup windows instead of balloons (or at least having this as an option). Reason being, this gives us far greater flexibility in terms of what/how we show when the mouse hovers over something. Any thoughts? Many thanks, Paul -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/CACoUkn5ig6mHk5mKiX1TLJ723GCL5V010A3cYU9JH-yw0YVwXw%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
Re: Patch 8.1.1468
On 06/06/2019 15:47, Christian Brabandt wrote: > > On Do, 06 Jun 2019, Mike Williams wrote: > >> It looks like the last byte of the last character has been dropped in >> processing. The .in file has the UTF-8 sequence 0xe0 0xad 0x81 0x0a for >> the last character and the newline, but the tmp file has 0xe0 0xad 0x0a >> which is an invalid UTF-8 sequence. Removing the line from both the .in >> files allows make to run to completion with no errors. >> >> This looks like a bug in msgfmt which should not be emitting invalid >> UTF-8 sequences. In the meantime this will break all builds on U16.04. :( > > Indeed. Try reporting a bug to ubuntu, though I doubt they will upload a > new (fixed) version. In the meantime, you might want to use this package > here: > https://launchpad.net/~ricotz/+archive/ubuntu/toolchain > > We are using this on our Travis build script as well. 16.04 is a Ubuntu LTS and supported for another 18 months or so. It would be nice to think they would want to updated for such an obvious bug on release widely used, but who knows. This is for a work machine so modifying toolchains via a PPA is not possible. I can work around the problem now that I know what it is. TTFN Mike -- The wind of change blows straight into the face of time. -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/7085e9a9-72a3-a0aa-8a99-011230d75b10%40globalgraphics.com. For more options, visit https://groups.google.com/d/optout.
Using text properties to show rendered documents
Hi all, I'm somewhat/extremely behind on the text properties work, which looks very exciting. In the context of govim (https://github.com/myitcv/govim), I'm considering using text properties as a way of showing a simple rendering of markdown/HTML within a Vim window (popup to be precise). Rendering the document with text properties from the parsed markdown/HTML should be relatively doable, but before I start down this path, does anyone have any thoughts on this approach vs others? Many thanks, Paul -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/CACoUkn7pjUhHGz-aKDJyXDVN1vO66fMDdUweZCpB-2gPvYBAVg%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
Re: Patch 8.1.1468
On Do, 06 Jun 2019, Mike Williams wrote: > It looks like the last byte of the last character has been dropped in > processing. The .in file has the UTF-8 sequence 0xe0 0xad 0x81 0x0a for > the last character and the newline, but the tmp file has 0xe0 0xad 0x0a > which is an invalid UTF-8 sequence. Removing the line from both the .in > files allows make to run to completion with no errors. > > This looks like a bug in msgfmt which should not be emitting invalid > UTF-8 sequences. In the meantime this will break all builds on U16.04. :( Indeed. Try reporting a bug to ubuntu, though I doubt they will upload a new (fixed) version. In the meantime, you might want to use this package here: https://launchpad.net/~ricotz/+archive/ubuntu/toolchain We are using this on our Travis build script as well. Best, Christian -- Wie man sein Kind nicht nennen sollte: Bud Ismus -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/20190606144713.GM23877%40256bit.org. For more options, visit https://groups.google.com/d/optout.
Patch 8.1.1483
Patch 8.1.1483 Problem:Skipped tests are not properly listed. Solution: Throw a "Skipped" exception instead of using ":finish" or ":return". Files: src/testdir/test_breakindent.vim, src/testdir/test_cdo.vim, src/testdir/test_channel.vim, src/testdir/test_clientserver.vim, src/testdir/test_balloon.vim, src/testdir/test_conceal.vim, src/testdir/test_debugger.vim, src/testdir/test_diffmode.vim, src/testdir/test_fold.vim, src/testdir/test_highlight.vim, src/testdir/test_popup.vim, src/testdir/test_popupwin.vim, src/testdir/test_search.vim, src/testdir/test_startup.vim, src/testdir/test_startup_utf8.vim, src/testdir/test_syntax.vim, src/testdir/test_tabpage.vim, src/testdir/test_termencoding.vim, src/testdir/test_terminal.vim, src/testdir/test_textprop.vim, src/testdir/test_timers.vim *** ../vim-8.1.1482/src/testdir/test_breakindent.vim2018-06-23 19:22:45.614486258 +0200 --- src/testdir/test_breakindent.vim2019-06-06 15:49:20.303809623 +0200 *** *** 5,11 " It helps to change the tabstop setting and force a redraw (e.g. see " Test_breakindent08()) if !exists('+breakindent') ! finish endif source view_util.vim --- 5,11 " It helps to change the tabstop setting and force a redraw (e.g. see " Test_breakindent08()) if !exists('+breakindent') ! throw 'Skipped: breakindent option not supported' endif source view_util.vim *** ../vim-8.1.1482/src/testdir/test_cdo.vim2016-01-01 14:24:29.0 +0100 --- src/testdir/test_cdo.vim2019-06-06 15:50:04.719517911 +0200 *** *** 1,7 " Tests for the :cdo, :cfdo, :ldo and :lfdo commands if !has('quickfix') ! finish endif " Create the files used by the tests --- 1,7 " Tests for the :cdo, :cfdo, :ldo and :lfdo commands if !has('quickfix') ! throw 'Skipped: quickfix feature missing' endif " Create the files used by the tests *** ../vim-8.1.1482/src/testdir/test_channel.vim2019-03-04 12:09:43.901396026 +0100 --- src/testdir/test_channel.vim2019-06-06 15:51:06.355113672 +0200 *** *** 1,7 " Test for channel functions. if !has('channel') ! finish endif source shared.vim --- 1,7 " Test for channel functions. if !has('channel') ! throw 'Skipped: channel feature missing' endif source shared.vim *** *** 9,15 let s:python = PythonProg() if s:python == '' " Can't run this test without Python. ! finish endif " Uncomment the next line to see what happens. Output is in --- 9,15 let s:python = PythonProg() if s:python == '' " Can't run this test without Python. ! throw 'Skipped: Python command missing' endif " Uncomment the next line to see what happens. Output is in *** ../vim-8.1.1482/src/testdir/test_clientserver.vim 2018-04-28 21:12:37.0 +0200 --- src/testdir/test_clientserver.vim 2019-06-06 15:51:32.518942263 +0200 *** *** 1,7 " Tests for the +clientserver feature. if !has('job') || !has('clientserver') ! finish endif source shared.vim --- 1,7 " Tests for the +clientserver feature. if !has('job') || !has('clientserver') ! throw 'Skipped: job and/or clientserver feature missing' endif source shared.vim *** ../vim-8.1.1482/src/testdir/test_balloon.vim2019-06-06 13:37:56.967789508 +0200 --- src/testdir/test_balloon.vim2019-06-06 15:52:55.598398666 +0200 *** *** 9,15 source screendump.vim if !CanRunVimInTerminal() ! throw 'Skipped: cannot run Vim in a terminal window' endif let s:common_script =<< [CODE] --- 9,15 source screendump.vim if !CanRunVimInTerminal() ! throw 'Skipped: cannot make screendumps' endif let s:common_script =<< [CODE] *** ../vim-8.1.1482/src/testdir/test_conceal.vim2019-05-20 22:12:30.720442793 +0200 --- src/testdir/test_conceal.vim2019-06-06 15:52:38.786508603 +0200 *** *** 2,13 " Also see test88.in (should be converted to a test function here). if !has('conceal') ! finish endif source screendump.vim if !CanRunVimInTerminal() ! finish endif func Test_conceal_two_windows() --- 2,13 " Also see test88.in (should be converted to a test function here). if !has('conceal') ! throw 'Skipped: conceal feature missing' endif source screendump.vim if !CanRunVimInTerminal() ! throw 'Skipped: cannot make screendumps' endif func Test_conceal_two_windows() *** ../vim-8.1.1482/src/testdir/test_debugger.vim 2019-06-03 23:07:21.828486877 +0200 --- src/testdir/test_debugger.vim 2019-06-06 15:53:56.434001190 +0200 *** *** 22,28 " Debugger tests func Test_Debugger() if !CanRunVimInTerminal() ! return endif " Create a Vim script with some
Patch 8.1.1482
Patch 8.1.1482 Problem:No test for wincol() depending on the 'number' option. Solution: Add a couple of tests. (Christian Brabandt, closes #4500) Files: src/testdir/test_gui.vim *** ../vim-8.1.1481/src/testdir/test_gui.vim2019-03-28 22:04:53.290665042 +0100 --- src/testdir/test_gui.vim2019-06-06 15:36:18.041054603 +0200 *** *** 694,705 --- 694,715 call setline(11, repeat('x', 150)) redraw call assert_equal(1, wincol()) + set number + redraw + call assert_equal(5, wincol()) + set nonumber + redraw call assert_equal(1, col('.')) " scroll to character 11, cursor is moved call test_scrollbar('hor', 10, 0) redraw call assert_equal(1, wincol()) + set number + redraw + call assert_equal(5, wincol()) + set nonumber + redraw call assert_equal(11, col('.')) set guioptions& *** ../vim-8.1.1481/src/version.c 2019-06-06 15:19:28.247404537 +0200 --- src/version.c 2019-06-06 15:36:04.193150549 +0200 *** *** 769,770 --- 769,772 { /* Add new patch number below this line */ + /**/ + 1482, /**/ -- hundred-and-one symptoms of being an internet addict: 99. The hum of a cooling fan and the click of keys is comforting to you. /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net \\\ ///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org/// \\\help me help AIDS victims -- http://ICCF-Holland.org/// -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/201906061340.x56Dehig021070%40masaka.moolenaar.net. For more options, visit https://groups.google.com/d/optout.
Re: Patch 8.1.1468
On 06/06/2019 12:16, Christian Brabandt wrote: > > On Do, 06 Jun 2019, Mike Williams wrote: > >> Hi >> >> On 05/06/2019 20:25, Bram Moolenaar wrote: >>> >>> Patch 8.1.1468 >>> Problem:The generated desktop files may be invalid. >>> Solution: Check validity with desktop-file-validate. (Christian Brabandt, >>> Will Thompson, closes #4480) >>> Files: src/po/Makefile >>> >> >> A clean build and install is now reporting the following warnings and >> errors: >> >> msgfmt --desktop -d . --template gvim.desktop.in -o tmp_gvim.desktop >> rm -f LINGUAS >> if command -v desktop-file-validate; then desktop-file-validate >> tmp_gvim.desktop; fi >> /usr/bin/desktop-file-validate > >> tmp_gvim.desktop: warning: file contains lines that are not UTF-8 >> encoded. There is no guarantee the validator will correctly work. > > I have no clue where that comes from. This may be related to the later UTF-8 warning. >> tmp_gvim.desktop: error: file contains multiple keys named >> "GenericName[eo]" in group "Desktop Entry" >> tmp_gvim.desktop: error: file contains multiple keys named "Comment[eo]" >> in group "Desktop Entry" > > That is expected and fixed by > https://github.com/vim/vim/commit/61da1bfa6c6b19dd670671a318ce9f9e2acc784c Confirmed. >> [Invalid UTF-8] tmp_gvim.desktop: error: value >> "\xe0\xac\xaa\xe0\xac\xbe\xe0\xac\xa0\xe0\xad\x8d\xe0\xac\xaf >> \xe0\xac\xab\xe0\xac\xbe\xe0\xac\x87\xe0\xac\xb2\xe0\xac\x97\xe0\xad\x81\xe0\xac\xa1\xe0\xac\xbc\xe0\xac\xbf\xe0\xac\x95\xe0\xad\x81 >> \xe0\xac\xb8\xe0\xac\xae\xe0\xad\x8d\xe0\xac\xaa\xe0\xac\xbe\xe0\xac\xa6\xe0\xac\xa8 >> \xe0\xac\x95\xe0\xac\xb0\xe0\xac\xa8\xe0\xad\x8d\xe0\xac\xa4\xe0\xad" >> for locale string key "Comment[or]" in group "Desktop Entry" contains >> invalid UTF-8 characters, locale string values should be encoded in UTF-8 > > I don't see that. I suspect either msgfmt cannot correctly handle the > template (gvim.desktop.in) file or desktop-file-validate does > incorrectly detect it as non UTF-8 > > BTW, is your locale set correctly? I believe so. All settings are en_GB.UTF-8 > For the records, in my debian dev box, I am using: > gettext: >Installed: 0.19.8.1-9 >Candidate: 0.19.8.1-9 >Version table: > *** 0.19.8.1-9 500 > 500 http://ftp.de.debian.org/debian buster/main amd64 Packages > 100 /var/lib/dpkg/status > 0 140901 chrisbra@debian ~/code/vim-src/src/po (git)-[desktop-file-utils]- % > apt-cache policy desktop-file-utils > desktop-file-utils: >Installed: 0.23-4 >Candidate: 0.23-4 >Version table: > *** 0.23-4 500 > 500 http://ftp.de.debian.org/debian buster/main amd64 Packages > 100 /var/lib/dpkg/status ~/repos/vim $ apt list gettext desktop-file-utils Listing... Done desktop-file-utils/xenial-updates,now 0.22-1ubuntu5.2 i386 [installed] gettext/xenial-updates,xenial-security,now 0.19.7-2ubuntu3.1 i386 [installed] So slightly behind your versions. >> This is on Ubuntu 16.04 Is this a problem with the VIM po source or >> lack or installed tooling? > > I am not sure yet. What does the raw generated utf-8 file tmp_gvim.desktop > look like? It looks like the last byte of the last character has been dropped in processing. The .in file has the UTF-8 sequence 0xe0 0xad 0x81 0x0a for the last character and the newline, but the tmp file has 0xe0 0xad 0x0a which is an invalid UTF-8 sequence. Removing the line from both the .in files allows make to run to completion with no errors. This looks like a bug in msgfmt which should not be emitting invalid UTF-8 sequences. In the meantime this will break all builds on U16.04. :( TTFN Mike -- If you're not making waves, you're not rowing the boat. -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/d39ef65a-5ed1-0c28-a901-a1e2e5464586%40globalgraphics.com. For more options, visit https://groups.google.com/d/optout.
Patch 8.1.1481
Patch 8.1.1481 Problem:Length for two-digit rgb termresponse is off by one. Solution: Adjust the length. (closes #4494) Files: src/term.c *** ../vim-8.1.1480/src/term.c 2019-06-05 22:57:00.932848350 +0200 --- src/term.c 2019-06-06 15:15:31.928819121 +0200 *** *** 4990,4996 int is_4digit = i - j >= 21 && tp[j + 11] == '/' && tp[j + 16] == '/'; ! if (i - j >= 14 && STRNCMP(tp + j + 3, "rgb:", 4) == 0 && (is_4digit || (tp[j + 9] == '/' && tp[i + 12 == '/']))) { --- 4990,4996 int is_4digit = i - j >= 21 && tp[j + 11] == '/' && tp[j + 16] == '/'; ! if (i - j >= 15 && STRNCMP(tp + j + 3, "rgb:", 4) == 0 && (is_4digit || (tp[j + 9] == '/' && tp[i + 12 == '/']))) { *** ../vim-8.1.1480/src/version.c 2019-06-06 15:13:16.597604260 +0200 --- src/version.c 2019-06-06 15:19:19.547457394 +0200 *** *** 769,770 --- 769,772 { /* Add new patch number below this line */ + /**/ + 1481, /**/ -- hundred-and-one symptoms of being an internet addict: 98. The Alta Vista administrators ask you what sites are missing in their index files. /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net \\\ ///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org/// \\\help me help AIDS victims -- http://ICCF-Holland.org/// -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/201906061319.x56DJmb2014614%40masaka.moolenaar.net. For more options, visit https://groups.google.com/d/optout.
Patch 8.1.1480
Patch 8.1.1480 Problem:Desktop file check doesn't run on CI. Solution: Install the desktip-file-utils packages. (Christian Brabandt, closes #4498) Files: .travis.yml *** ../vim-8.1.1479/.travis.yml 2019-05-11 14:34:09.326200119 +0200 --- .travis.yml 2019-06-06 15:11:00.614367690 +0200 *** *** 86,91 --- 86,92 - tcl-dev - cscope - libgtk2.0-dev + - desktop-file-utils homebrew: packages: - lua *** ../vim-8.1.1479/src/version.c 2019-06-06 14:37:59.886604048 +0200 --- src/version.c 2019-06-06 15:11:54.562068307 +0200 *** *** 769,770 --- 769,772 { /* Add new patch number below this line */ + /**/ + 1480, /**/ -- hundred-and-one symptoms of being an internet addict: 97. Your mother tells you to remember something, and you look for a File/Save command. /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net \\\ ///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org/// \\\help me help AIDS victims -- http://ICCF-Holland.org/// -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/201906061313.x56DDaSV008602%40masaka.moolenaar.net. For more options, visit https://groups.google.com/d/optout.
Re: Patch 8.1.1478
Christian wrote: > On Do, 06 Jun 2019, Bram Moolenaar wrote: > > > Patch 8.1.1478 > > Problem:Still an error when running tests with the tiny version. > > Solution: Do not try reading test.log > > Files: src/testdir/Makefile, src/testdir/summarize.vim > > I did not see any failures with the tiny version those and neither did > Travis: > https://travis-ci.org/vim/vim/builds/54386 > https://travis-ci.org/vim/vim/builds/542233477 > > And Appveyor hasn't even come to that patch yet (currently testing patch > 8.1.1473). What error did you see? This only shows when you don't redirect output (that's why it was commented out): export VIMRUNTIME; ../vim -f -u unix.vim -U NONE --noplugin --not-a-term -S summarize.vim messages essages" [New File] Error detected while processing /home/travis/build/vim/vim/src/testdir/summariz : line 33: E10: \ should be followed by /, ? or & line 34: E10: \ should be followed by /, ? or & line 35: E10: \ should be followed by /, ? or & line 36: E10: \ should be followed by /, ? or & line 37: E10: \ should be followed by /, ? or & line 38: E10: \ should be followed by /, ? or & line 39: E10: \ should be followed by /, ? or & line 58: E484: Can't open file test.log Test results: ALL DONE -- hundred-and-one symptoms of being an internet addict: 95. Only communication in your household is through email. /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net \\\ ///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org/// \\\help me help AIDS victims -- http://ICCF-Holland.org/// -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/201906061313.x56DDa50008590%40masaka.moolenaar.net. For more options, visit https://groups.google.com/d/optout.
Patch 8.1.1479
Patch 8.1.1479 Problem:Change included for debugging only. Solution: Restore the REDIR_TEST_TO_NULL line. Files: src/testdir/Makefile *** ../vim-8.1.1478/src/testdir/Makefile2019-06-06 14:28:50.629869185 +0200 --- src/testdir/Makefile2019-06-06 14:34:35.455882856 +0200 *** *** 12,18 # Comment out this line to see the verbose output of tests. # # Catches SwapExists to avoid hanging at the ATTENTION prompt. ! # REDIR_TEST_TO_NULL = --cmd 'au SwapExists * let v:swapchoice = "e"' > /dev/null # Uncomment this line to use valgrind for memory leaks and extra warnings. # The output goes into a file "valgrind.testN" --- 12,18 # Comment out this line to see the verbose output of tests. # # Catches SwapExists to avoid hanging at the ATTENTION prompt. ! REDIR_TEST_TO_NULL = --cmd 'au SwapExists * let v:swapchoice = "e"' > /dev/null # Uncomment this line to use valgrind for memory leaks and extra warnings. # The output goes into a file "valgrind.testN" *** ../vim-8.1.1478/src/version.c 2019-06-06 14:28:50.633869164 +0200 --- src/version.c 2019-06-06 14:37:46.870687022 +0200 *** *** 769,770 --- 769,772 { /* Add new patch number below this line */ + /**/ + 1479, /**/ -- hundred-and-one symptoms of being an internet addict: 94. Now admit it... How many of you have made "modem noises" into the phone just to see if it was possible? :-) /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net \\\ ///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org/// \\\help me help AIDS victims -- http://ICCF-Holland.org/// -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/201906061238.x56CcKY7032645%40masaka.moolenaar.net. For more options, visit https://groups.google.com/d/optout.
Re: Patch 8.1.1476
Christian wrote: > On Do, 06 Jun 2019, Bram Moolenaar wrote: > > > Patch 8.1.1476 > > Problem:No statistics displayed after running tests. > > Solution: Summarize the test results. (Christian Brabandt, closes #4391) > > Also make it possible to report a skipped file. > > Files: src/Makefile, src/testdir/Makefile, > > src/testdir/summarize.vim, > > src/testdir/runtest.vim, src/testdir/test_arabic.vim, > > src/testdir/test_autochdir.vim, src/testdir/test_balloon.vim > > Thanks! Did some more tweaking, Travis showed more errors than what I got with local testing. We can also throw more "skipped" exceptions in various places, now that the are listed together it's more useful. > > *** ../vim-8.1.1475/src/testdir/Makefile2019-02-21 21:50:42.603751312 > > +0100 > > --- src/testdir/Makefile2019-06-06 12:56:44.810633118 +0200 > > *** > > *** 12,18 > > # Comment out this line to see the verbose output of tests. > > # > > # Catches SwapExists to avoid hanging at the ATTENTION prompt. > > ! REDIR_TEST_TO_NULL = --cmd 'au SwapExists * let v:swapchoice = "e"' > > > /dev/null > > > > # Uncomment this line to use valgrind for memory leaks and extra warnings. > > # The output goes into a file "valgrind.testN" > > --- 12,18 > > # Comment out this line to see the verbose output of tests. > > # > > # Catches SwapExists to avoid hanging at the ATTENTION prompt. > > ! # REDIR_TEST_TO_NULL = --cmd 'au SwapExists * let v:swapchoice = "e"' > > > /dev/null > > That looks wrong. I think it is not necessary to comment it out. Forgot to remove this from the patch, I'll send out a patch. -- hundred-and-one symptoms of being an internet addict: 93. New mail alarm on your palmtop annoys other churchgoers. /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net \\\ ///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org/// \\\help me help AIDS victims -- http://ICCF-Holland.org/// -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/201906061238.x56CcK8j032657%40masaka.moolenaar.net. For more options, visit https://groups.google.com/d/optout.
Re: Patch 8.1.1478
On Do, 06 Jun 2019, Bram Moolenaar wrote: > Patch 8.1.1478 > Problem:Still an error when running tests with the tiny version. > Solution: Do not try reading test.log > Files:src/testdir/Makefile, src/testdir/summarize.vim I did not see any failures with the tiny version those and neither did Travis: https://travis-ci.org/vim/vim/builds/54386 https://travis-ci.org/vim/vim/builds/542233477 And Appveyor hasn't even come to that patch yet (currently testing patch 8.1.1473). What error did you see? Best, Christian -- Wenn Frauen sich schön anziehen, sind sie wahrscheinlich der Ansicht, die Männer hielten sie unbekleidet für genauso reizvoll. -- Christian Dior -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/20190606123341.GL23877%40256bit.org. For more options, visit https://groups.google.com/d/optout.
Patch 8.1.1478
Patch 8.1.1478 Problem:Still an error when running tests with the tiny version. Solution: Do not try reading test.log Files: src/testdir/Makefile, src/testdir/summarize.vim *** ../vim-8.1.1477/src/testdir/Makefile2019-06-06 13:37:56.967789508 +0200 --- src/testdir/Makefile2019-06-06 14:27:30.830283175 +0200 *** *** 49,54 --- 49,59 benchmark: $(SCRIPTS_BENCH) report: + # without the +eval feature test_result.log is a copy of test.log + @/bin/sh -c "if test -f test.log; \ + then cp test.log test_result.log; \ + else echo No failures reported > test_result.log; \ + fi" $(RUN_VIMTEST) $(NO_INITS) -S summarize.vim messages $(REDIR_TEST_TO_NULL) @echo @echo 'Test results:' *** ../vim-8.1.1477/src/testdir/summarize.vim 2019-06-06 14:08:47.486391198 +0200 --- src/testdir/summarize.vim 2019-06-06 14:26:49.566573530 +0200 *** *** 50,61 catch " Catch-all finally call writefile(output, 'test_result.log') " overwrites an existing file - q! endtry endif - " This is executed without the eval feature - %d - r test.log - w test_result.log q! --- 50,56 *** ../vim-8.1.1477/src/version.c 2019-06-06 14:08:47.490391171 +0200 --- src/version.c 2019-06-06 14:26:04.654896242 +0200 *** *** 769,770 --- 769,772 { /* Add new patch number below this line */ + /**/ + 1478, /**/ -- hundred-and-one symptoms of being an internet addict: 92. It takes you two hours to check all 14 of your mailboxes. /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net \\\ ///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org/// \\\help me help AIDS victims -- http://ICCF-Holland.org/// -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/201906061229.x56CT76d030779%40masaka.moolenaar.net. For more options, visit https://groups.google.com/d/optout.
Patch 8.1.1477
Patch 8.1.1477 Problem:Test summary fails in the tiny version. Solution: set 'nocompatible'. Files: Filelist, src/testdir/summarize.vim *** ../vim-8.1.1476/Filelist2019-05-25 19:51:03.768408497 +0200 --- Filelist2019-06-06 13:38:48.383437887 +0200 *** *** 118,123 --- 118,124 src/testdir/lsan-suppress.txt \ src/testdir/sautest/autoload/*.vim \ src/testdir/runtest.vim \ + src/testdir/summarize.vim \ src/testdir/shared.vim \ src/testdir/screendump.vim \ src/testdir/view_util.vim \ *** ../vim-8.1.1476/src/testdir/summarize.vim 2019-06-06 13:37:56.967789508 +0200 --- src/testdir/summarize.vim 2019-06-06 14:01:14.053739953 +0200 *** *** 1,3 --- 1,4 + set nocp if 1 " This is executed with the eval feature set nocp *** ../vim-8.1.1476/src/version.c 2019-06-06 13:37:56.971789479 +0200 --- src/version.c 2019-06-06 14:02:21.225237799 +0200 *** *** 769,770 --- 769,772 { /* Add new patch number below this line */ + /**/ + 1477, /**/ -- >From "know your smileys": :-*A big kiss! /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net \\\ ///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org/// \\\help me help AIDS victims -- http://ICCF-Holland.org/// -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/201906061209.x56C9Fb1023906%40masaka.moolenaar.net. For more options, visit https://groups.google.com/d/optout.
Re: How about sound?
Marius Gedminas wrote: > On Thu, Jun 06, 2019 at 11:59:34AM +0200, Bram Moolenaar wrote: > > It appears libcanberra is widely available. My system also has the -dev > > package installed (I didn't do that, perhaps because of a gtk > > dependency). I could not find something for autoconf though. But I > > expect it to be simple. > > On my system libcanberra-dev ships a pkg-config file, so it should be > simple to hook it up to autoconf. > > $ pkg-config --libs libcanberra > -lcanberra > > $ pkg-config --cflags libcanberra > -D_REENTRANT > > (I've never used autoconf so I'm afraid I cannot offer a patch.) I tried a little example: #include #include int main () { ca_context * hello; ca_context_create (); ca_context_play (hello, 0, CA_PROP_EVENT_ID, "phone-incoming-call", CA_PROP_EVENT_DESCRIPTION, "hello world", NULL); sleep(2); return 0; } gcc -o sound -D_REENTRANT -lcanberra sound.c /usr/bin/ld: /tmp/ccArSjRM.o: in function `main': sound.c:(.text+0x1f): undefined reference to `ca_context_create' /usr/bin/ld: sound.c:(.text+0x57): undefined reference to `ca_context_play' collect2: error: ld returned 1 exit status Somehow linking doesn't work, must be missing something... -- Common sense is what tells you that the world is flat. /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net \\\ ///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org/// \\\help me help AIDS victims -- http://ICCF-Holland.org/// -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/201906061207.x56C7kG6023479%40masaka.moolenaar.net. For more options, visit https://groups.google.com/d/optout.
Re: Patch 8.1.1476
Hi Bram, On Do, 06 Jun 2019, Bram Moolenaar wrote: > Patch 8.1.1476 > Problem:No statistics displayed after running tests. > Solution: Summarize the test results. (Christian Brabandt, closes #4391) > Also make it possible to report a skipped file. > Files:src/Makefile, src/testdir/Makefile, > src/testdir/summarize.vim, > src/testdir/runtest.vim, src/testdir/test_arabic.vim, > src/testdir/test_autochdir.vim, src/testdir/test_balloon.vim Thanks! > *** ../vim-8.1.1475/src/testdir/Makefile 2019-02-21 21:50:42.603751312 > +0100 > --- src/testdir/Makefile 2019-06-06 12:56:44.810633118 +0200 > *** > *** 12,18 > # Comment out this line to see the verbose output of tests. > # > # Catches SwapExists to avoid hanging at the ATTENTION prompt. > ! REDIR_TEST_TO_NULL = --cmd 'au SwapExists * let v:swapchoice = "e"' > > /dev/null > > # Uncomment this line to use valgrind for memory leaks and extra warnings. > # The output goes into a file "valgrind.testN" > --- 12,18 > # Comment out this line to see the verbose output of tests. > # > # Catches SwapExists to avoid hanging at the ATTENTION prompt. > ! # REDIR_TEST_TO_NULL = --cmd 'au SwapExists * let v:swapchoice = "e"' > > /dev/null That looks wrong. I think it is not necessary to comment it out. Mit freundlichen Grüßen Christian -- Wer die Menschen kennt, liebt die Tiere. Und wer die Tiere kennt - liebt die Pflanzen. -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/20190606114608.GK23877%40256bit.org. For more options, visit https://groups.google.com/d/optout.
Patch 8.1.1476
Patch 8.1.1476 Problem:No statistics displayed after running tests. Solution: Summarize the test results. (Christian Brabandt, closes #4391) Also make it possible to report a skipped file. Files: src/Makefile, src/testdir/Makefile, src/testdir/summarize.vim, src/testdir/runtest.vim, src/testdir/test_arabic.vim, src/testdir/test_autochdir.vim, src/testdir/test_balloon.vim *** ../vim-8.1.1475/src/Makefile2019-05-31 20:02:47.567231180 +0200 --- src/Makefile2019-06-06 13:12:56.701571974 +0200 *** *** 2117,2123 # TESTING # # Execute the test scripts and the unittests. ! test check: scripttests unittests test_libvterm # Execute the test scripts. Run these after compiling Vim, before installing. # This doesn't depend on $(VIMTARGET), because that won't work when configure --- 2118,2125 # TESTING # # Execute the test scripts and the unittests. ! # Do the scripttests first, so that the summary shows last. ! test check: unittests test_libvterm scripttests # Execute the test scripts. Run these after compiling Vim, before installing. # This doesn't depend on $(VIMTARGET), because that won't work when configure *** ../vim-8.1.1475/src/testdir/Makefile2019-02-21 21:50:42.603751312 +0100 --- src/testdir/Makefile2019-06-06 12:56:44.810633118 +0200 *** *** 12,18 # Comment out this line to see the verbose output of tests. # # Catches SwapExists to avoid hanging at the ATTENTION prompt. ! REDIR_TEST_TO_NULL = --cmd 'au SwapExists * let v:swapchoice = "e"' > /dev/null # Uncomment this line to use valgrind for memory leaks and extra warnings. # The output goes into a file "valgrind.testN" --- 12,18 # Comment out this line to see the verbose output of tests. # # Catches SwapExists to avoid hanging at the ATTENTION prompt. ! # REDIR_TEST_TO_NULL = --cmd 'au SwapExists * let v:swapchoice = "e"' > /dev/null # Uncomment this line to use valgrind for memory leaks and extra warnings. # The output goes into a file "valgrind.testN" *** *** 49,58 benchmark: $(SCRIPTS_BENCH) report: @echo @echo 'Test results:' @/bin/sh -c "if test -f test.log; \ ! then cat test.log; echo TEST FAILURE; exit 1; \ else echo ALL DONE; \ fi" --- 49,60 benchmark: $(SCRIPTS_BENCH) report: + $(RUN_VIMTEST) $(NO_INITS) -S summarize.vim messages $(REDIR_TEST_TO_NULL) @echo @echo 'Test results:' + @cat test_result.log @/bin/sh -c "if test -f test.log; \ ! then echo TEST FAILURE; exit 1; \ else echo ALL DONE; \ fi" *** *** 77,83 RUN_VIM = VIMRUNTIME=$(SCRIPTSOURCE); export VIMRUNTIME; $(VALGRIND) $(VIMPROG) -f $(GUI_FLAG) -u unix.vim $(NO_INITS) -s dotest.in clean: ! -rm -rf *.out *.failed *.res *.rej *.orig opt_test.vim test.log messages $(RM_ON_RUN) $(RM_ON_START) valgrind.* test1.out: test1.in -rm -rf $*.failed $(RM_ON_RUN) $(RM_ON_START) wrongtermsize --- 79,88 RUN_VIM = VIMRUNTIME=$(SCRIPTSOURCE); export VIMRUNTIME; $(VALGRIND) $(VIMPROG) -f $(GUI_FLAG) -u unix.vim $(NO_INITS) -s dotest.in clean: ! -rm -rf *.out *.failed *.res *.rej *.orig ! -rm opt_test.vim test.log test_result.log messages ! -rm $(RM_ON_RUN) $(RM_ON_START) ! -rm valgrind.* test1.out: test1.in -rm -rf $*.failed $(RM_ON_RUN) $(RM_ON_START) wrongtermsize *** ../vim-8.1.1475/src/testdir/summarize.vim 2019-06-06 13:36:51.512235762 +0200 --- src/testdir/summarize.vim 2019-06-06 13:10:12.018902480 +0200 *** *** 0 --- 1,60 + if 1 + " This is executed with the eval feature + set nocp + func Count(match, type) + if a:type ==# 'executed' + let g:executed += (a:match+0) + elseif a:type ==# 'failed' + let g:failed = a:match+0 + elseif a:type ==# 'skipped' + let g:skipped += 1 + call extend(g:skipped_output, ["\t".a:match]) + endif + endfunc + + let g:executed = 0 + let g:skipped = 0 + let g:failed = 0 + let g:skipped_output = [] + let g:failed_output = [] + let output = [""] + + try + " This uses the :s command to just fetch and process the output of the + " tests, it doesn't acutally replay anything + %s/^Executed\s\+\zs\d\+\ze\s\+tests/\=Count(submatch(0),'executed')/egn + %s/^SKIPPED \zs.*/\=Count(submatch(0), 'skipped')/egn + %s/^\(\d\+\)\s\+FAILED:/\=Count(submatch(1), 'failed')/egn + + call extend(output, ["Skipped:"]) + call extend(output, skipped_output) + + call extend(output, [ + \ "", + \ "---", + \ printf("Executed: %5d Tests", g:executed), + \ printf(" Skipped: %5d Tests", g:skipped), + \ printf(" %s: %5d Tests", g:failed
Re: Patch 8.1.1468
On Do, 06 Jun 2019, Mike Williams wrote: > Hi > > On 05/06/2019 20:25, Bram Moolenaar wrote: > > > > Patch 8.1.1468 > > Problem:The generated desktop files may be invalid. > > Solution: Check validity with desktop-file-validate. (Christian Brabandt, > > Will Thompson, closes #4480) > > Files: src/po/Makefile > > > > A clean build and install is now reporting the following warnings and > errors: > > msgfmt --desktop -d . --template gvim.desktop.in -o tmp_gvim.desktop > rm -f LINGUAS > if command -v desktop-file-validate; then desktop-file-validate > tmp_gvim.desktop; fi > /usr/bin/desktop-file-validate > tmp_gvim.desktop: warning: file contains lines that are not UTF-8 > encoded. There is no guarantee the validator will correctly work. I have no clue where that comes from. > tmp_gvim.desktop: error: file contains multiple keys named > "GenericName[eo]" in group "Desktop Entry" > tmp_gvim.desktop: error: file contains multiple keys named "Comment[eo]" > in group "Desktop Entry" That is expected and fixed by https://github.com/vim/vim/commit/61da1bfa6c6b19dd670671a318ce9f9e2acc784c > [Invalid UTF-8] tmp_gvim.desktop: error: value > "\xe0\xac\xaa\xe0\xac\xbe\xe0\xac\xa0\xe0\xad\x8d\xe0\xac\xaf > \xe0\xac\xab\xe0\xac\xbe\xe0\xac\x87\xe0\xac\xb2\xe0\xac\x97\xe0\xad\x81\xe0\xac\xa1\xe0\xac\xbc\xe0\xac\xbf\xe0\xac\x95\xe0\xad\x81 > > \xe0\xac\xb8\xe0\xac\xae\xe0\xad\x8d\xe0\xac\xaa\xe0\xac\xbe\xe0\xac\xa6\xe0\xac\xa8 > > \xe0\xac\x95\xe0\xac\xb0\xe0\xac\xa8\xe0\xad\x8d\xe0\xac\xa4\xe0\xad" > for locale string key "Comment[or]" in group "Desktop Entry" contains > invalid UTF-8 characters, locale string values should be encoded in UTF-8 I don't see that. I suspect either msgfmt cannot correctly handle the template (gvim.desktop.in) file or desktop-file-validate does incorrectly detect it as non UTF-8 BTW, is your locale set correctly? For the records, in my debian dev box, I am using: gettext: Installed: 0.19.8.1-9 Candidate: 0.19.8.1-9 Version table: *** 0.19.8.1-9 500 500 http://ftp.de.debian.org/debian buster/main amd64 Packages 100 /var/lib/dpkg/status 0 140901 chrisbra@debian ~/code/vim-src/src/po (git)-[desktop-file-utils]- % apt-cache policy desktop-file-utils desktop-file-utils: Installed: 0.23-4 Candidate: 0.23-4 Version table: *** 0.23-4 500 500 http://ftp.de.debian.org/debian buster/main amd64 Packages 100 /var/lib/dpkg/status > This is on Ubuntu 16.04 Is this a problem with the VIM po source or > lack or installed tooling? I am not sure yet. What does the raw generated utf-8 file tmp_gvim.desktop look like? Mit freundlichen Grüßen Christian -- Für das Wohlbefinden einer Frau sind bewundernde Männerblicke wichtiger als Kalorien und Medikamente. -- Françoise Sagan -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/20190606111641.GJ23877%40256bit.org. For more options, visit https://groups.google.com/d/optout.
Re: How about sound?
On Thu, Jun 06, 2019 at 11:59:34AM +0200, Bram Moolenaar wrote: > It appears libcanberra is widely available. My system also has the -dev > package installed (I didn't do that, perhaps because of a gtk > dependency). I could not find something for autoconf though. But I > expect it to be simple. On my system libcanberra-dev ships a pkg-config file, so it should be simple to hook it up to autoconf. $ pkg-config --libs libcanberra -lcanberra $ pkg-config --cflags libcanberra -D_REENTRANT (I've never used autoconf so I'm afraid I cannot offer a patch.) Marius Gedminas -- Be cheerful. Strive to be happy Oh, and we just set fire to your desktop. -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/20190606110546.mqurow4d4znvg4sa%40platonas. For more options, visit https://groups.google.com/d/optout. signature.asc Description: PGP signature
Patch 8.1.1475
Patch 8.1.1475 Problem:Search string not displayed when 'rightleft' is set. Solution: Clear the right part of the old text. (closes #4488, closes #4489) Files: src/search.c, src/testdir/test_search.vim *** ../vim-8.1.1474/src/search.c2019-05-28 23:08:12.076648654 +0200 --- src/search.c2019-06-06 12:46:44.412241408 +0200 *** *** 1462,1467 --- 1462,1468 if (curwin->w_p_rl && *curwin->w_p_rlc == 's') { char_u *r; + size_t pat_len; r = reverse_text(msgbuf); if (r != NULL) *** *** 1471,1479 // move reversed text to beginning of buffer while (*r != NUL && *r == ' ') r++; ! mch_memmove(msgbuf, r, msgbuf + STRLEN(msgbuf) - r); // overwrite old text ! vim_memset(r, ' ', msgbuf + STRLEN(msgbuf) - r); } } #endif --- 1472,1484 // move reversed text to beginning of buffer while (*r != NUL && *r == ' ') r++; ! pat_len = msgbuf + STRLEN(msgbuf) - r; ! mch_memmove(msgbuf, r, pat_len); // overwrite old text ! if ((size_t)(r - msgbuf) >= pat_len) ! vim_memset(r, ' ', pat_len); ! else ! vim_memset(msgbuf + pat_len, ' ', r - msgbuf); } } #endif *** ../vim-8.1.1474/src/testdir/test_search.vim 2019-04-27 18:00:29.851064563 +0200 --- src/testdir/test_search.vim 2019-06-06 12:44:41.479197393 +0200 *** *** 1289,1291 --- 1289,1313 close! endfunc + + func Test_search_display_pattern() + new + call setline(1, ['foo', 'bar', 'foobar']) + + call cursor(1, 1) + let @/ = 'foo' + let pat = escape(@/, '()*?'. '\s\+') + let g:a = execute(':unsilent :norm! n') + call assert_match(pat, g:a) + + " right-left + if exists("+rightleft") + set rl + call cursor(1, 1) + let @/ = 'foo' + let pat = 'oof/\s\+' + let g:a = execute(':unsilent :norm! n') + call assert_match(pat, g:a) + set norl + endif + endfunc *** ../vim-8.1.1474/src/version.c 2019-06-06 12:36:11.887259331 +0200 --- src/version.c 2019-06-06 12:47:48.562880329 +0200 *** *** 769,770 --- 769,772 { /* Add new patch number below this line */ + /**/ + 1475, /**/ -- >From "know your smileys": <|-) Chinese <|-( Chinese and doesn't like these kind of jokes /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net \\\ ///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org/// \\\help me help AIDS victims -- http://ICCF-Holland.org/// -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/201906061049.x56Anj8Q018037%40masaka.moolenaar.net. For more options, visit https://groups.google.com/d/optout.
Re: Patch 8.1.1468
Hi On 05/06/2019 20:25, Bram Moolenaar wrote: > > Patch 8.1.1468 > Problem:The generated desktop files may be invalid. > Solution: Check validity with desktop-file-validate. (Christian Brabandt, > Will Thompson, closes #4480) > Files:src/po/Makefile > A clean build and install is now reporting the following warnings and errors: msgfmt --desktop -d . --template gvim.desktop.in -o tmp_gvim.desktop rm -f LINGUAS if command -v desktop-file-validate; then desktop-file-validate tmp_gvim.desktop; fi /usr/bin/desktop-file-validate tmp_gvim.desktop: warning: file contains lines that are not UTF-8 encoded. There is no guarantee the validator will correctly work. tmp_gvim.desktop: error: file contains multiple keys named "GenericName[eo]" in group "Desktop Entry" tmp_gvim.desktop: error: file contains multiple keys named "Comment[eo]" in group "Desktop Entry" [Invalid UTF-8] tmp_gvim.desktop: error: value "\xe0\xac\xaa\xe0\xac\xbe\xe0\xac\xa0\xe0\xad\x8d\xe0\xac\xaf \xe0\xac\xab\xe0\xac\xbe\xe0\xac\x87\xe0\xac\xb2\xe0\xac\x97\xe0\xad\x81\xe0\xac\xa1\xe0\xac\xbc\xe0\xac\xbf\xe0\xac\x95\xe0\xad\x81 \xe0\xac\xb8\xe0\xac\xae\xe0\xad\x8d\xe0\xac\xaa\xe0\xac\xbe\xe0\xac\xa6\xe0\xac\xa8 \xe0\xac\x95\xe0\xac\xb0\xe0\xac\xa8\xe0\xad\x8d\xe0\xac\xa4\xe0\xad" for locale string key "Comment[or]" in group "Desktop Entry" contains invalid UTF-8 characters, locale string values should be encoded in UTF-8 Makefile:176: recipe for target 'gvim.desktop' failed make[2]: *** [gvim.desktop] Error 1 make[2]: Leaving directory '/home/mikew/repos/vim/src/po' Makefile:2021: recipe for target 'languages' failed make[1]: *** [languages] Error 2 make[1]: Leaving directory '/home/mikew/repos/vim/src' Makefile:26: recipe for target 'first' failed make: *** [first] Error 2 This is on Ubuntu 16.04 Is this a problem with the VIM po source or lack or installed tooling? TTFN Mike -- Why do they call it the rush hour when nothing moves? -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/6f3a9963-fb0a-b434-da7d-c449ad52011c%40globalgraphics.com. For more options, visit https://groups.google.com/d/optout.
Patch 8.1.1474
Patch 8.1.1474 Problem:'ttybuiltin' is not tested. Solution: At least test that it doesn't break things. Files: src/testdir/test_termcodes.vim *** ../vim-8.1.1473/src/testdir/test_termcodes.vim 2019-06-06 11:59:15.508182794 +0200 --- src/testdir/test_termcodes.vim 2019-06-06 12:33:03.600017459 +0200 *** *** 717,720 --- 717,740 set t_k1= set t_k1& call assert_equal(k1, _k1) + + " use external termcap first + set nottybuiltin + set t_k1= + set t_k1& + " when using external termcap may get something else, but it must not be + " empty, since we would fallback to the builtin one. + call assert_notequal('', _k1) + + if =~ 'xterm' + " use internal termcap first + let term_save = + let = 'builtin_' .. + set t_k1= + set t_k1& + call assert_equal(k1, _k1) + let = term_save + endif + + set ttybuiltin endfunc *** ../vim-8.1.1473/src/version.c 2019-06-06 12:22:38.266535367 +0200 --- src/version.c 2019-06-06 12:35:28.659433382 +0200 *** *** 769,770 --- 769,772 { /* Add new patch number below this line */ + /**/ + 1474, /**/ -- >From "know your smileys": |-(Contact lenses, but has lost them /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net \\\ ///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org/// \\\help me help AIDS victims -- http://ICCF-Holland.org/// -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/201906061036.x56AaU5a015142%40masaka.moolenaar.net. For more options, visit https://groups.google.com/d/optout.
Re: resolve() on Windows breaking change
Hi Ken On 05/06/2019 11:56, Ken Takata wrote: > Hi, > > 2019/6/5 Wed 5:25:13 UTC+9 Mike Williams wrote: >> On 04/06/2019 19:18, Bram Moolenaar wrote: >>> >>> Mike Williams wrote: >>> It looks like the change to Windows for resolve() in 8.1.1417 was a breaking change. I use the NERDtree plugin and any build after than change results in NERDtree reports plain files on Windows as links. See attached image. I guess the question is. is this wrong in VIM or a bad assumption in NERDtree in what resolve() returns? Since it is a breaking change in VIM I thought I would start the ball rolling here. >>> >>> Perhaps NERDtree checks if the returned path is a full path? >>> Assuming you still have the older Vim version, compare the output of >>> resolve() for some simple files, is it different? >> >> It is different. 8.1.1416 does not return a full path for simple files >> while 8.1.1417 onwards does. >> >>> The docs say: >>> On MS-Windows, when {filename} is a shortcut (a .lnk file), >>> returns the path the shortcut points to in a simplified form. >>> When {filename} is a symbolic link or junction point, return >>> the full path to the target. If the target of junction is >>> removed, return {filename}. >>> >>> It says some more about a simplified result. But that wasn't changed. >> >> Based on the above it means that there is no way to tell the difference >> between a simple file and a symbolic link or junction point, getftype() >> does not help on Windows. But perhaps that does not matter. >> >> Spelunking in NERDtree the root cause of the problem is directory >> separators. It seems a bit free in always using '/' when building >> paths. Now that resolve() returns a full path filepath checks based on >> string comparison fails. A local hack^wfix confirms this but NERDtree >> is still able to detect symbolic links so there must some other method >> to distinguish that I am not aware of. >> >> I'll bounce over to GitHub to report this. >> >> TTFN >> >> Mike > > I created a PR for this: https://github.com/vim/vim/pull/4492 Many thanks for this. Bonus points for extending getftype() to work under Windows for consistency with what resolve() returns ;-) TTFN Mike -- If nodding means yes, why doesn't yesding mean no? -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/6330f627-17c8-c9e6-3794-5ab8994cadde%40globalgraphics.com. For more options, visit https://groups.google.com/d/optout.
Re: Patch for fixing an issue with hitest.vim
> On 4 Jun 2019, at 19:10, Bram Moolenaar wrote: > > > > > >> I have tried to contact the author of hitest.vim a few days ago, but > >> didn’t get any answer yet. Anyway, hopefully it’s on this list, too. > >> > >> I get E348 with runtime syntax/hitest.vim when whichwrap is set to a value > >> different from the default. To reproduce: > >> > >> 1. create vimrc-hitest with the following content: > >> > >>set whichwrap=b,~,<,>,[,],h,l > >>hi StatusLine guifg=#64878f guibg=#ff guisp=NONE gui=reverse > >> cterm=reverse > >>hi! link StatusLineTerm StatusLine > >> > >> 2. vim -N -i NONE -u vimrc-hitest > >> > >> 3. runtime syntax/hitest.vim > >> > >> The proposed patch fixes it for me. It also adds ‘silent' to the highlight > >> command to avoid flashing the screen. > > > > Thanks. I still see a flash, caused by this line: > > > > global /links to/ normal mz3ElD0#$p'zdd > > > > Appears for a "links to Something" when "Something" is not defined. > > I'll add a silent! here, but it's not really the right solution. > > I do not see that. Perhaps, I have not encountered such cases. > > > It's also quite slow, there should be a way to make it much faster. > > >From a user point of view, I do not perceive it as too slow, although it may > >be compared to what it does. > > > It also leaves some names at the end, which can be fixed with: > > g/ cleared$/d > > The enclosed patch adds the changes you mention. Thanks. > > -- > > % cat /usr/include/life.h > > void life(void); > > > Noo! Maybe, long life(double fun); > > Is your signature generator really random? It's rotating, thus what fortune ends up where is a matter of luck. I like your response, I'll add it to the list. -- >From "know your smileys": :-| :-| Deja' vu! /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net \\\ ///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org/// \\\help me help AIDS victims -- http://ICCF-Holland.org/// -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/201906061022.x56AMuu9012880%40masaka.moolenaar.net. For more options, visit https://groups.google.com/d/optout.
Patch 8.1.1473
Patch 8.1.1473 Problem:New resolve() implementation causes problem for plugins. Solution: Only resolve a resparse point after checking it is needed. (Ken Takata, closes #4492) Files: src/os_mswin.c, src/testdir/test_functions.vim *** ../vim-8.1.1472/src/os_mswin.c 2019-05-29 20:36:51.502509469 +0200 --- src/os_mswin.c 2019-06-06 12:21:08.278897691 +0200 *** *** 1753,1758 --- 1753,1791 DWORD nFileSystemNameSize); static pfnGetVolumeInformationByHandleW pGetVolumeInformationByHandleW = NULL; + # define is_path_sep(c) ((c) == L'\\' || (c) == L'/') + + static int + is_reparse_point_included(LPCWSTR fname) + { + LPCWSTR p = fname, q; + WCHAR buf[MAX_PATH]; + DWORD attr; + + if (isalpha(p[0]) && p[1] == L':' && is_path_sep(p[2])) + p += 3; + else if (is_path_sep(p[0]) && is_path_sep(p[1])) + p += 2; + + while (*p != L'\0') + { + q = wcspbrk(p, L"\\/"); + if (q == NULL) + p = q = fname + wcslen(fname); + else + p = q + 1; + if (q - fname >= MAX_PATH) + return FALSE; + wcsncpy(buf, fname, q - fname); + buf[q - fname] = L'\0'; + attr = GetFileAttributesW(buf); + if (attr != INVALID_FILE_ATTRIBUTES + && (attr & FILE_ATTRIBUTE_REPARSE_POINT) != 0) + return TRUE; + } + return FALSE; + } + static char_u * resolve_reparse_point(char_u *fname) { *** *** 1787,1792 --- 1820,1831 if (p == NULL) goto fail; + if (!is_reparse_point_included(p)) + { + vim_free(p); + goto fail; + } + h = CreateFileW(p, 0, 0, NULL, OPEN_EXISTING, FILE_FLAG_BACKUP_SEMANTICS, NULL); vim_free(p); *** ../vim-8.1.1472/src/testdir/test_functions.vim 2019-05-29 20:36:51.502509469 +0200 --- src/testdir/test_functions.vim 2019-06-06 12:21:08.278897691 +0200 *** *** 276,281 --- 276,282 " test for symbolic link to a file new Xfile wq + call assert_equal('Xfile', resolve('Xfile')) silent !mklink Xlink Xfile if !v:shell_error call assert_equal(s:normalize_fname(getcwd() . '\Xfile'), s:normalize_fname(resolve('./Xlink'))) *** *** 333,343 --- 334,347 " test for reparse point call mkdir('Xdir') + call assert_equal('Xdir', resolve('Xdir')) silent !mklink /D Xdirlink Xdir if !v:shell_error w Xdir/text.txt + call assert_equal('Xdir/text.txt', resolve('Xdir/text.txt')) call assert_equal(s:normalize_fname(getcwd() . '\Xdir\text.txt'), s:normalize_fname(resolve('Xdirlink\text.txt'))) call assert_equal(s:normalize_fname(getcwd() . '\Xdir'), s:normalize_fname(resolve('Xdirlink'))) + call delete('Xdirlink') else echomsg 'skipped test for reparse point' endif *** ../vim-8.1.1472/src/version.c 2019-06-06 11:59:15.512182778 +0200 --- src/version.c 2019-06-06 12:21:30.774807116 +0200 *** *** 769,770 --- 769,772 { /* Add new patch number below this line */ + /**/ + 1473, /**/ -- >From "know your smileys": C=}>;*{)) Drunk, devilish chef with a toupee in an updraft, a mustache, and a double chin /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net \\\ ///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org/// \\\help me help AIDS victims -- http://ICCF-Holland.org/// -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/201906061022.x56AMuIs012867%40masaka.moolenaar.net. For more options, visit https://groups.google.com/d/optout.
Re: How about sound?
John Little wrote: > On Wednesday, June 5, 2019 at 1:08:03 AM UTC+12, Bram Moolenaar wrote: > > I have been wondering if it would help if Vim could play a sound. > > I'm a fan. More bandwidth from vim to me is always good. But people wanting > to turn off beeps from vim are very vocal, those wanting to turn them on are > not. > > I got used to relying on beeps using vi on dumb terminals for many > years, and using vim with GTK with random DEs getting any kind of beep > with vim proved very hit or miss, and losing the beep after some kind > of upgrade happened a lot. So I learned about libcanberra, and my vim > gives me a 100 ms cowbell. It's only about 15 lines of C. Managing > (choosing, distributing) the sound files would be a far larger task > than the code I imagine. It appears libcanberra is widely available. My system also has the -dev package installed (I didn't do that, perhaps because of a gtk dependency). I could not find something for autoconf though. But I expect it to be simple. > I've no idea about libcanberra on MS Windows. It needs a completely different solution. And again I hope it's a simple thing, since we don't want this to be adding much code to Vim. -- >From "know your smileys": :-EHas major dental problems /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net \\\ ///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org/// \\\help me help AIDS victims -- http://ICCF-Holland.org/// -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/201906060959.x569xYs9008392%40masaka.moolenaar.net. For more options, visit https://groups.google.com/d/optout.
Patch 8.1.1472
Patch 8.1.1472 Problem:Add_termcap_entry() is not tested. Solution: Add a simple test. Files: src/testdir/test_termcodes.vim *** ../vim-8.1.1471/src/testdir/test_termcodes.vim 2019-06-05 22:57:00.932848350 +0200 --- src/testdir/test_termcodes.vim 2019-06-06 11:51:58.289942323 +0200 *** *** 626,632 endfunc " This only checks if the sequence is recognized. - " TODO: check that the values were parsed properly func Test_term_rgb_response() set t_RF=x set t_RB=y --- 626,631 *** *** 712,714 --- 711,720 set t_RV= endfunc + + func Test_get_termcode() + let k1 = _k1 + set t_k1= + set t_k1& + call assert_equal(k1, _k1) + endfunc *** ../vim-8.1.1471/src/version.c 2019-06-05 22:57:00.932848350 +0200 --- src/version.c 2019-06-06 11:56:08.664934796 +0200 *** *** 769,770 --- 769,772 { /* Add new patch number below this line */ + /**/ + 1472, /**/ -- >From "know your smileys": :-| :-| Deja' vu! /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net \\\ ///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org/// \\\help me help AIDS victims -- http://ICCF-Holland.org/// -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/201906060959.x569xYQ2008386%40masaka.moolenaar.net. For more options, visit https://groups.google.com/d/optout.
Re: Patch for fixing an issue with hitest.vim
On 5 Jun 2019, at 16:56, 'Lifepillar' wrote: > > The enclosed patch adds the changes you mention. > > The attached patch uses silent! also on the added command. > > About the slowness: I have made some more tests and when there are many > highlight groups (e.g. those loaded by Vim filetype), the script takes about > three seconds on my machine. > > Life. Thank you, Lifepillar, for fixing this. I could not reproduce the problem as you wrote. This is probably because I'm still working with Vim 8.0. I did not find time yet to try 8.1. Maybe in the next weeks. Then I'll also have a look at the slowness issue. Regards Scutum -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/2bc00d8a-564f-4dca-b51c-4df34a6f31e7%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.