Re: [vim/vim] Feature Request: mode() returns Insert sub-mode (#1397)

Hi, On Mon, Jan 23, 2017 at 9:02 AM, Zhen-Huan (Kenny) Hu wrote: > else if (ins_compl_active()) > > buf[1] = pum_visible() ? 'C' : 'c'; > > Does this 'C' vs. 'c' mean whether a completion was successful? I don't > think pum_visible() alone is able to determine this

Re: [vim/vim] Feature Request: mode() returns Insert sub-mode (#1397)

Hi All, 2017-1-24(Tue) 2:03:05 UTC+9 Zhen-Huan (Kenny) Hu: > else if (ins_compl_active()) > > > > buf[1] = pum_visible() ? 'C' : 'c'; > > > > > > Does this 'C' vs. 'c' mean whether a completion was successful? I don't think > pum_visible() alone is able to determine this accurately since

Re: [vim/vim] Feature Request: mode() returns Insert sub-mode (#1397)

Hi Yegappan, 2017-1-23(Mon) 2:40:48 UTC+9 yega...@gmail.com: > Hi, > > On Fri, Jan 20, 2017 at 12:35 PM, Zhen-Huan (Kenny) Hu > wrote: > > diff --git a/src/evalfunc.c b/src/evalfunc.c > > index 4b6bfaa..1f3164f 100644 > > --- a/src/evalfunc.c > > +++ b/src/evalfunc.c

Re: [vim/vim] Feature Request: mode() returns Insert sub-mode (#1397)

Hi Hirohito, On Fri, Jan 20, 2017 at 4:23 PM, h_east wrote: > Hi Yegappan, > > 2017-1-21(Sat) 4:20:02 UTC+9 yega...@gmail.com: >> Hi Hirohito, >> >> On Fri, Jan 20, 2017 at 7:44 AM, h_east wrote: >> > Hi Bram, Yegappan, Zhen and Vim developers, >> >

Re: [vim/vim] Feature Request: mode() returns Insert sub-mode (#1397)

Hi, On Fri, Jan 20, 2017 at 12:35 PM, Zhen-Huan (Kenny) Hu wrote: > diff --git a/src/evalfunc.c b/src/evalfunc.c > index 4b6bfaa..1f3164f 100644 > --- a/src/evalfunc.c > +++ b/src/evalfunc.c > @@ -7765,10 +7765,16 @@ f_mode(typval_T *argvars, typval_T *rettv) > } >

Re: [vim/vim] Feature Request: mode() returns Insert sub-mode (#1397)

Hi Yegappan, 2017-1-21(Sat) 4:20:02 UTC+9 yega...@gmail.com: > Hi Hirohito, > > On Fri, Jan 20, 2017 at 7:44 AM, h_east wrote: > > Hi Bram, Yegappan, Zhen and Vim developers, > > > > 2017-1-20(Fri) 12:44:50 UTC+9 vim-dev ML: > >> Hi, > >> > >> > >> > >> On Thu, Jan 19,

Re: [vim/vim] Feature Request: mode() returns Insert sub-mode (#1397)

Hi Hirohito, On Fri, Jan 20, 2017 at 7:44 AM, h_east wrote: > Hi Bram, Yegappan, Zhen and Vim developers, > > 2017-1-20(Fri) 12:44:50 UTC+9 vim-dev ML: >> Hi, >> >> >> >> On Thu, Jan 19, 2017 at 3:56 PM, Zhen-Huan (Kenny) Hu >> >> wrote: >> >> >

Re: [vim/vim] Feature Request: mode() returns Insert sub-mode (#1397)

Hi Bram, Yegappan, Zhen and Vim developers, 2017-1-20(Fri) 12:44:50 UTC+9 vim-dev ML: > Hi, > > > > On Thu, Jan 19, 2017 at 3:56 PM, Zhen-Huan (Kenny) Hu > > wrote: > > > #ifdef FEAT_INS_EXPAND > > > if (ctrl_x_mode != 0) > > >buf[0] = 'x'; > > > else > > >

Re: [vim/vim] Feature Request: mode() returns Insert sub-mode (#1397)

Hi, On Thu, Jan 19, 2017 at 3:56 PM, Zhen-Huan (Kenny) Hu wrote: > #ifdef FEAT_INS_EXPAND > if (ctrl_x_mode != 0) >buf[0] = 'x'; > else > #endif > > I tested the code. mode() all returns x as expected when pressing > alone, or combined with , , , , , , , as > well

Re: [vim/vim] Feature Request: mode() returns Insert sub-mode (#1397)

Hi Bram, On Thu, Jan 19, 2017 at 1:43 PM, Bram Moolenaar wrote: > Since it's a sub mode of insert it should be "ix". > The CTRL-X key can be used in Replace mode also. So it is either 'ix' or 'Rx'. - Yegappan -- -- You received this message from the "vim_dev"

Re: [vim/vim] Feature Request: mode() returns Insert sub-mode (#1397)

Hi, On Thu, Jan 19, 2017 at 8:39 AM, Zhen-Huan (Kenny) Hu wrote: > Please make mode() return i_CTRL-X sub mode. Currently there seems to be no > way to determine this. It would be very helpful for writing completion > plugins. > Can you try the attached diff? The