Re: Patch 8.1.0510

2018-11-05 Fir de Conversatie Bram Moolenaar
Tony wrote: > >if (lang == NULL || STRLEN(lang) < 2)/* safety check */ > >return; > ... > >// any C like setting, such as C.UTF-8, becomes "en" > >else if (STRLEN(p_hlg) >= 1 && *p_hlg == 'C') > >{ > >p_hlg[0] = 'e'; > >p_hlg[1] =

Re: Patch 8.1.0510

2018-11-04 Fir de Conversatie Bram Moolenaar
James McCoy wrote: > On Sun, Nov 04, 2018 at 08:09:10PM +0100, Christian Brabandt wrote: > > > > On So, 04 Nov 2018, Bram Moolenaar wrote: > > > > > + else if (STRLEN(p_hlg) >= 1 && *p_hlg == 'C') > > > > James mentioned[¹], that this might be overly eager. > > This isn't doing

Re: Patch 8.1.0510

2018-11-04 Fir de Conversatie Tony Mechelynck
>if (lang == NULL || STRLEN(lang) < 2)/* safety check */ >return; ... >// any C like setting, such as C.UTF-8, becomes "en" >else if (STRLEN(p_hlg) >= 1 && *p_hlg == 'C') >{ >p_hlg[0] = 'e'; >p_hlg[1] = 'n'; >} This sets

Re: Patch 8.1.0510

2018-11-04 Fir de Conversatie Christian Brabandt
On So, 04 Nov 2018, James McCoy wrote: > On Sun, Nov 04, 2018 at 08:09:10PM +0100, Christian Brabandt wrote: > > On So, 04 Nov 2018, Bram Moolenaar wrote: > > > > > + else if (STRLEN(p_hlg) >= 1 && *p_hlg == 'C') > > > > James mentioned[¹], that this might be overly eager. > >

Re: Patch 8.1.0510

2018-11-04 Fir de Conversatie James McCoy
On Sun, Nov 04, 2018 at 08:09:10PM +0100, Christian Brabandt wrote: > > On So, 04 Nov 2018, Bram Moolenaar wrote: > > > + else if (STRLEN(p_hlg) >= 1 && *p_hlg == 'C') > > James mentioned[¹], that this might be overly eager. This isn't doing a case-insensitive comparison, so it _should_

Re: Patch 8.1.0510

2018-11-04 Fir de Conversatie Christian Brabandt
On So, 04 Nov 2018, Bram Moolenaar wrote: > + else if (STRLEN(p_hlg) >= 1 && *p_hlg == 'C') James mentioned[¹], that this might be overly eager. So perhaps this would be better: diff --git a/src/option.c b/src/option.c index efe43aa2b..39bb52f88 100644 --- a/src/option.c +++

Patch 8.1.0510

2018-11-04 Fir de Conversatie Bram Moolenaar
Patch 8.1.0510 Problem:Filter test fails when $LANG is C.UTF-8. Solution: Set 'helplang' to "en" for any C language. (Christian Brabandt, closes #3577) Files: src/option.c *** ../vim-8.1.0509/src/option.c2018-10-25 13:31:33.829906902 +0200 --- sr