subject:"Patch 8.0.1711"

Re: Patch 8.0.1711

2018-04-14 Fir de Conversatie Christian Brabandt


On Sa, 14 Apr 2018, Bram Moolenaar wrote:

> 
> Christian wrote:
> 
> > On Sa, 14 Apr 2018, Bram Moolenaar wrote:
> > 
> > > Patch 8.0.1711
> > > Problem:Term_setsize() is not implemented yet.
> > > Solution:   Implement it.
> > > Files:  src/evalfunc.c, src/terminal.c, src/proto/terminal.pro,
> > 
> > Unless stated in the documentation, it does not give an error message 
> > for the case that the buffer is not a terminal buffer.
> 
> Most term_ functions are forgiving, but calling term_setsize() on a
> non-terminal buffer can only be an error.  I'll add it.

I did not imply that an error message is needed. I just noticed that the 
documentation for patch 8.0.1711 talked about an error, while the actual 
code did not show an error message.

Best,
Christian
-- 
Internet? Das ist doch dieses WWW-Netz?
-- IBM Technischer Support, November 1994

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Patch 8.0.1711

2018-04-14 Fir de Conversatie Bram Moolenaar


Christian wrote:

> On Sa, 14 Apr 2018, Bram Moolenaar wrote:
> 
> > Patch 8.0.1711
> > Problem:Term_setsize() is not implemented yet.
> > Solution:   Implement it.
> > Files:  src/evalfunc.c, src/terminal.c, src/proto/terminal.pro,
> 
> Unless stated in the documentation, it does not give an error message 
> for the case that the buffer is not a terminal buffer.

Most term_ functions are forgiving, but calling term_setsize() on a
non-terminal buffer can only be an error.  I'll add it.

-- 
hundred-and-one symptoms of being an internet addict:
177. You log off of your system because it's time to go to work.

 /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net   \\\
///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\  an exciting new programming language -- http://www.Zimbu.org///
 \\\help me help AIDS victims -- http://ICCF-Holland.org///

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Patch 8.0.1711

2018-04-14 Fir de Conversatie Christian Brabandt


On Sa, 14 Apr 2018, Bram Moolenaar wrote:

> 
> Patch 8.0.1711
> Problem:Term_setsize() is not implemented yet.
> Solution:   Implement it.
> Files:  src/evalfunc.c, src/terminal.c, src/proto/terminal.pro,

Unless stated in the documentation, it does not give an error message 
for the case that the buffer is not a terminal buffer.

Best,
Christian
-- 
Mit Ungeduld bestraft sich zehnfach Ungeduld; man will das Ziel 
heranziehn und entfernt es nur.
-- Goethe, Maximen und Reflektionen, Nr. 802

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Patch 8.0.1711

2018-04-14 Fir de Conversatie Bram Moolenaar


Patch 8.0.1711
Problem:Term_setsize() is not implemented yet.
Solution:   Implement it.
Files:  src/evalfunc.c, src/terminal.c, src/proto/terminal.pro,
src/testdir/test_terminal.vim, runtime/doc/eval.txt


*** ../vim-8.0.1710/src/evalfunc.c  2018-04-14 13:51:51.978588368 +0200
--- src/evalfunc.c  2018-04-14 16:40:16.517362325 +0200
***
*** 876,881 
--- 876,882 
  # endif
  {"term_setkill",  2, 2, f_term_setkill},
  {"term_setrestore",   2, 2, f_term_setrestore},
+ {"term_setsize",  3, 3, f_term_setsize},
  {"term_start",1, 2, f_term_start},
  {"term_wait", 1, 2, f_term_wait},
  #endif
*** ../vim-8.0.1710/src/terminal.c  2018-04-13 22:11:52.740902329 +0200
--- src/terminal.c  2018-04-14 16:58:54.542065201 +0200
***
*** 40,46 
   * TODO:
   * - Win32: Make terminal used for :!cmd in the GUI work better.  Allow for
   *   redirection.  Probably in call to channel_set_pipes().
-  * - implement term_setsize()
   * - add an optional limit for the scrollback size.  When reaching it remove
   *   10% at the start.
   * - Copy text in the vterm to the Vim buffer once in a while, so that
--- 40,45 
***
*** 4603,4608 
--- 4602,4632 
  }
  
  /*
+  * "term_setsize(buf, rows, cols)" function
+  */
+ void
+ f_term_setsize(typval_T *argvars UNUSED, typval_T *rettv UNUSED)
+ {
+ buf_T *buf = term_get_buf(argvars, "term_setsize()");
+ term_T*term;
+ varnumber_T rows, cols;
+ 
+ if (buf == NULL || buf->b_term->tl_vterm == NULL)
+   return;
+ term = buf->b_term;
+ rows = get_tv_number(&argvars[1]);
+ rows = rows <= 0 ? term->tl_rows : rows;
+ cols = get_tv_number(&argvars[2]);
+ cols = cols <= 0 ? term->tl_cols : cols;
+ vterm_set_size(term->tl_vterm, rows, cols);
+ /* handle_resize() will resize the windows */
+ 
+ /* Get and remember the size we ended up with.  Update the pty. */
+ vterm_get_size(term->tl_vterm, &term->tl_rows, &term->tl_cols);
+ term_report_winsize(term, term->tl_rows, term->tl_cols);
+ }
+ 
+ /*
   * "term_getstatus(buf)" function
   */
  void
***
*** 5432,5438 
  }
  
  /*
!  * Request size to terminal.
   */
  static void
  term_report_winsize(term_T *term, int rows, int cols)
--- 5456,5462 
  }
  
  /*
!  * Report the size to the terminal.
   */
  static void
  term_report_winsize(term_T *term, int rows, int cols)
***
*** 5514,5520 
  }
  
  /*
!  * Request size to terminal.
   */
  static void
  term_report_winsize(term_T *term, int rows, int cols)
--- 5538,5544 
  }
  
  /*
!  * Report the size to the terminal.
   */
  static void
  term_report_winsize(term_T *term, int rows, int cols)
*** ../vim-8.0.1710/src/proto/terminal.pro  2018-04-10 15:59:04.295392601 
+0200
--- src/proto/terminal.pro  2018-04-14 16:38:13.742270972 +0200
***
*** 32,50 
  void f_term_dumpdiff(typval_T *argvars, typval_T *rettv);
  void f_term_dumpload(typval_T *argvars, typval_T *rettv);
  void f_term_getaltscreen(typval_T *argvars, typval_T *rettv);
- void f_term_getansicolors(typval_T *argvars, typval_T *rettv);
  void f_term_getattr(typval_T *argvars, typval_T *rettv);
  void f_term_getcursor(typval_T *argvars, typval_T *rettv);
  void f_term_getjob(typval_T *argvars, typval_T *rettv);
  void f_term_getline(typval_T *argvars, typval_T *rettv);
  void f_term_getscrolled(typval_T *argvars, typval_T *rettv);
  void f_term_getsize(typval_T *argvars, typval_T *rettv);
  void f_term_getstatus(typval_T *argvars, typval_T *rettv);
  void f_term_gettitle(typval_T *argvars, typval_T *rettv);
  void f_term_gettty(typval_T *argvars, typval_T *rettv);
  void f_term_list(typval_T *argvars, typval_T *rettv);
  void f_term_scrape(typval_T *argvars, typval_T *rettv);
  void f_term_sendkeys(typval_T *argvars, typval_T *rettv);
  void f_term_setansicolors(typval_T *argvars, typval_T *rettv);
  void f_term_setrestore(typval_T *argvars, typval_T *rettv);
  void f_term_setkill(typval_T *argvars, typval_T *rettv);
--- 32,51 
  void f_term_dumpdiff(typval_T *argvars, typval_T *rettv);
  void f_term_dumpload(typval_T *argvars, typval_T *rettv);
  void f_term_getaltscreen(typval_T *argvars, typval_T *rettv);
  void f_term_getattr(typval_T *argvars, typval_T *rettv);
  void f_term_getcursor(typval_T *argvars, typval_T *rettv);
  void f_term_getjob(typval_T *argvars, typval_T *rettv);
  void f_term_getline(typval_T *argvars, typval_T *rettv);
  void f_term_getscrolled(typval_T *argvars, typval_T *rettv);
  void f_term_getsize(typval_T *argvars, typval_T *rettv);
+ void f_term_setsize(typval_T *argvars, typval_T *rettv);
  void f_term_getstatus(typval_T *argvars, typval_T *rettv);
  void f_term_gettitle(typval_T *argvars, typ

Re: Patch 8.0.1711

Re: Patch 8.0.1711

Re: Patch 8.0.1711

Patch 8.0.1711

4 matches

Site Navigation

Mail list logo

Footer information