Re: [patch] 2 problems about job

2016-10-14 Fir de Conversatie Bram Moolenaar
Yasuhiro Matsumoto wrote: > Sorry, It was wrong. I updated patch > > https://gist.github.com/mattn/d47e7d3bfe5ade4be86062b565a4bfca > > On Wednesday, October 12, 2016 at 11:19:06 PM UTC+9, Bram Moolenaar wrote: > > +strsave_for_argv(char_u *string) > > > > I would call the argument "argv" and

Re: [patch] 2 problems about job

2016-10-14 Fir de Conversatie mattn
Sorry, It was wrong. I updated patch https://gist.github.com/mattn/d47e7d3bfe5ade4be86062b565a4bfca On Wednesday, October 12, 2016 at 11:19:06 PM UTC+9, Bram Moolenaar wrote: > +strsave_for_argv(char_u *string) > > I would call the argument "argv" and the escaped result "argv_escaped". renamed

Re: [patch] 2 problems about job

2016-10-12 Fir de Conversatie Bram Moolenaar
Yasuhiro Matsumoto wrote: > On Wednesday, October 5, 2016 at 9:05:11 PM UTC+9, mattn wrote: > > On Wednesday, October 5, 2016 at 5:49:32 AM UTC+9, Bram Moolenaar wrote: > > > Thanks for diving into this. But I think this needs more testing, since > > > it's quite different from what we have

Re: [patch] 2 problems about job

2016-10-09 Fir de Conversatie Bram Moolenaar
Ozaki Kiichi wrote: > I updated patch. > > I'm wondering: > In channel_close_on_error, when there is netbeans channel, > channel_save writes to PART_OUT, but is this right? to PART_SOCK? That is indeed strange. Netbeans only uses PART_SOCK. I'll change it. No test fails, don't really know

Re: [patch] 2 problems about job

2016-10-08 Fir de Conversatie Ozaki Kiichi
I updated patch. I'm wondering: In channel_close_on_error, when there is netbeans channel, channel_save writes to PART_OUT, but is this right? to PART_SOCK? -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For

Re: [patch] 2 problems about job

2016-10-05 Fir de Conversatie Ozaki Kiichi
> Doing this with reference counting is tricky. It looks like if in > channel_set_pipes() the may_close_part() actually closes an fd, then > ch_to_be_closed is not decremented. Also, when debugging it's hard to > see what happened. I think it would work to have a bitmask: Set the > bit for the

Re: [patch] 2 problems about job

2016-10-05 Fir de Conversatie mattn
On Wednesday, October 5, 2016 at 9:05:11 PM UTC+9, mattn wrote: > On Wednesday, October 5, 2016 at 5:49:32 AM UTC+9, Bram Moolenaar wrote: > > Thanks for diving into this. But I think this needs more testing, since > > it's quite different from what we have before. > > > > I think the "escaping"

Re: [patch] 2 problems about job

2016-10-05 Fir de Conversatie mattn
On Wednesday, October 5, 2016 at 5:49:32 AM UTC+9, Bram Moolenaar wrote: > Thanks for diving into this. But I think this needs more testing, since > it's quite different from what we have before. > > I think the "escaping" value needs to be reset after > for (i = 0; i < escaping; i++) >

Re: [patch] 2 problems about job

2016-10-04 Fir de Conversatie Bram Moolenaar
Yasuhiro Matsumoto wrote: > > > On Monday, October 3, 2016 at 7:49:20 AM UTC+9, Ozaki Kiichi wrote: > > > > > > > > https://gist.github.com/ichizok/6e0c00daf387b32bebcc2972f0cca137 > > > > > > Bram, in this patch, you can see workaround to avoid a bug with escaping > > > double-quote on

Re: [patch] 2 problems about job

2016-10-03 Fir de Conversatie mattn
On Tuesday, October 4, 2016 at 5:29:16 AM UTC+9, Bram Moolenaar wrote: > Yasuhiro Matsumoto wrote: > > > On Monday, October 3, 2016 at 7:49:20 AM UTC+9, Ozaki Kiichi wrote: > > > > > > https://gist.github.com/ichizok/6e0c00daf387b32bebcc2972f0cca137 > > > > Bram, in this patch, you can see

Re: [patch] 2 problems about job

2016-10-03 Fir de Conversatie Bram Moolenaar
Yasuhiro Matsumoto wrote: > On Monday, October 3, 2016 at 7:49:20 AM UTC+9, Ozaki Kiichi wrote: > > > > https://gist.github.com/ichizok/6e0c00daf387b32bebcc2972f0cca137 > > Bram, in this patch, you can see workaround to avoid a bug with escaping > double-quote on Windows. > >

Re: [patch] 2 problems about job

2016-10-03 Fir de Conversatie Bram Moolenaar
Ozaki Kiichi wrote: > There are 2 problems about job-channel callback. > > > 1) callback isn't invoked when last line doesn't terminate by NL. > > [repro steps] > > test.vim > > --- > function! Callback(ch, msg) > echom a:msg > let g:linecount += 1 > endfunction > > let g:linecount = 0

Re: [patch] 2 problems about job

2016-10-02 Fir de Conversatie mattn
On Monday, October 3, 2016 at 7:49:20 AM UTC+9, Ozaki Kiichi wrote: > > https://gist.github.com/ichizok/6e0c00daf387b32bebcc2972f0cca137 Bram, in this patch, you can see workaround to avoid a bug with escaping double-quote on Windows.