Re: Patch 7.4.2332

2016-10-12 Fir de Conversatie Bram Moolenaar
Ozaki Kiichi wrote: > I found still another mistake... > GET_TIMEDIFF() macro has a trailing semicolon. > This is not serious now, but is improper. > > patch: > https://gist.github.com/ichizok/47df234e05f78f84b1abf4e8ca89f270 Thanks. -- ROBIN: The what? ARTHUR: The Holy Hand Grenade of Antio

Re: Patch 7.4.2332

2016-10-11 Fir de Conversatie Ozaki Kiichi
I found still another mistake... GET_TIMEDIFF() macro has a trailing semicolon. This is not serious now, but is improper. patch: https://gist.github.com/ichizok/47df234e05f78f84b1abf4e8ca89f270 -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below t

Re: Patch 7.4.2332

2016-09-10 Fir de Conversatie Bram Moolenaar
Ozaki Kiichi wrote: > 2016年9月10日土曜日 22時59分53秒 UTC+9 Bram Moolenaar: > > Ozaki Kiichi wrote: > > > > > > ! if (++last_timer_id < 0) > > > > ! /* Overflow! Might cause duplicates... */ > > > > ! last_timer_id = 0; > > > > > > Sorry, I realized this is not proper overflow detectio

Re: Patch 7.4.2332

2016-09-10 Fir de Conversatie Ozaki Kiichi
2016年9月10日土曜日 22時59分53秒 UTC+9 Bram Moolenaar: > Ozaki Kiichi wrote: > > > > ! if (++last_timer_id < 0) > > > ! /* Overflow! Might cause duplicates... */ > > > ! last_timer_id = 0; > > > > Sorry, I realized this is not proper overflow detection in standard C. > > We had to che

Re: Patch 7.4.2332

2016-09-10 Fir de Conversatie Bram Moolenaar
Ozaki Kiichi wrote: > > ! if (++last_timer_id < 0) > > ! /* Overflow! Might cause duplicates... */ > > ! last_timer_id = 0; > > Sorry, I realized this is not proper overflow detection in standard C. > We had to check before increment. > > https://gist.github.com/ichizok/d9d220ba44e512a

Re: Patch 7.4.2332

2016-09-10 Fir de Conversatie Ozaki Kiichi
> ! if (++last_timer_id < 0) > ! /* Overflow! Might cause duplicates... */ > ! last_timer_id = 0; Sorry, I realized this is not proper overflow detection in standard C. We had to check before increment. https://gist.github.com/ichizok/d9d220ba44e512a6b26d34c1bfc05711 Thank you. - Oz