Re: Patch 8.0.0873

2017-08-05 Fir de Conversatie Bram Moolenaar

Dominique wrote:

> > Patch 8.0.0873
> > Problem:In a terminal window cannot use CTRL-\ CTRL-N to start Visual
> > mode.
> > Solution:   After CTRL-\ CTRL-N enter Terminal-Normal mode for one command.
> > Files:  src/main.c, src/terminal.c, src/proto/terminal.pro
> 
> This patch is causing a compilation error when
> I configure vim with:
> 
> $ ./configure --with-features=huge --enable-gui=none
> --enable-terminal --enable-python3interp
> $ make
> ...
> normal.c: In function 'nv_mousescroll':
> normal.c:4642:6: error: too few arguments to function 'term_use_loop'
>   if (term_use_loop())
>   ^
> In file included from proto.h:167:0,
>  from vim.h:2119,
>  from normal.c:15:
> proto/terminal.pro:9:5: note: declared here
>  int term_use_loop(int once);
>  ^
> 
> I suppose that it should be fixed like this:
> 
> diff --git a/src/normal.c b/src/normal.c
> index 25ab2d3..88f604d 100644
> --- a/src/normal.c
> +++ b/src/normal.c
> @@ -4639,7 +4639,7 @@ nv_mousescroll(cmdarg_T *cap)
>  if (cap->arg == MSCR_UP || cap->arg == MSCR_DOWN)
>  {
>  # ifdef FEAT_TERMINAL
> -   if (term_use_loop())
> +   if (term_use_loop(FALSE))
> send_keys_to_term(curbuf->b_term, cap->cmdchar, TRUE);
> else
>  # endif

Yes, sorry, I forgot to include that change in the patch.

-- 
Michael: There is no such thing as a dump question.
Bernard: Sure there is.  For example "what is a core dump?"

 /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net   \\\
///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\  an exciting new programming language -- http://www.Zimbu.org///
 \\\help me help AIDS victims -- http://ICCF-Holland.org///

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Patch 8.0.0873

2017-08-05 Fir de Conversatie Dominique Pellé
Bram Moolenaar  wrote:

> Patch 8.0.0873
> Problem:In a terminal window cannot use CTRL-\ CTRL-N to start Visual
> mode.
> Solution:   After CTRL-\ CTRL-N enter Terminal-Normal mode for one command.
> Files:  src/main.c, src/terminal.c, src/proto/terminal.pro

This patch is causing a compilation error when
I configure vim with:

$ ./configure --with-features=huge --enable-gui=none
--enable-terminal --enable-python3interp
$ make
...
normal.c: In function 'nv_mousescroll':
normal.c:4642:6: error: too few arguments to function 'term_use_loop'
  if (term_use_loop())
  ^
In file included from proto.h:167:0,
 from vim.h:2119,
 from normal.c:15:
proto/terminal.pro:9:5: note: declared here
 int term_use_loop(int once);
 ^

I suppose that it should be fixed like this:

diff --git a/src/normal.c b/src/normal.c
index 25ab2d3..88f604d 100644
--- a/src/normal.c
+++ b/src/normal.c
@@ -4639,7 +4639,7 @@ nv_mousescroll(cmdarg_T *cap)
 if (cap->arg == MSCR_UP || cap->arg == MSCR_DOWN)
 {
 # ifdef FEAT_TERMINAL
-   if (term_use_loop())
+   if (term_use_loop(FALSE))
send_keys_to_term(curbuf->b_term, cap->cmdchar, TRUE);
else
 # endif

Dominique

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.